120367 2013-08-27 10:04:00 -0700 No need for generalPasteboard (aside from "global selection mode") 2013-08-27 22:02:06 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 120392 1 darin darin ap commit-queue oldest_to_newest 921574 0 darin 2013-08-27 10:04:00 -0700 No need for generalPasteboard (aside from "global selection mode") 921576 1 209783 darin 2013-08-27 10:06:38 -0700 Created attachment 209783 Patch 921586 2 ap 2013-08-27 10:36:12 -0700 I got confused by your IRC statement that this patch fixes the root cause of bug 113094, so I'd like to chat about how pasteboard works (especially as I'm going to look into drag&drop handling in WKTR soon). 921607 3 209783 buildbot 2013-08-27 11:45:48 -0700 Comment on attachment 209783 Patch Attachment 209783 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1594008 921613 4 209783 ap 2013-08-27 11:59:45 -0700 Comment on attachment 209783 Patch r=me I think that ultimately, using the same class for long-living Pasteboard handles (like those inside Clipboard object) and for these single-shot ones is confusing. We need to keep changeCount updated for Clipboard but don't care about it here. 921686 5 209783 darin 2013-08-27 15:02:03 -0700 Comment on attachment 209783 Patch Windows build failures were unrelated to this patch. 921701 6 209783 commit-queue 2013-08-27 15:24:17 -0700 Comment on attachment 209783 Patch Clearing flags on attachment: 209783 Committed r154712: <http://trac.webkit.org/changeset/154712> 921702 7 commit-queue 2013-08-27 15:24:18 -0700 All reviewed patches have been landed. Closing bug. 209783 2013-08-27 10:06:38 -0700 2013-08-27 15:24:17 -0700 Patch bug-120367-20130827100638.patch text/plain 6054 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTUzYmQxZDZhZDAwNjdl NmQxMjhkOWI1ZTZhZmEwNjg4ZDI5OWE5MC4uOWE3NjQ1NmQwYWU2ZjlhYjlkMTAyYTRiZTUyYTRm NGI4NjA5MTE1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTI3ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBObyBuZWVkIGZvciBnZW5lcmFs UGFzdGVib2FyZCAoYXNpZGUgZnJvbSAiZ2xvYmFsIHNlbGVjdGlvbiBtb2RlIikKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDM2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9FZGl0b3Iu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpwYXN0ZUFzUGxhaW5UZXh0QnlwYXNzaW5n REhUTUwpOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpkaXNwYXRjaENQUEV2ZW50KToKKyAg ICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y3V0KToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6 Y29weSk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OnBhc3RlKToKKyAgICAgICAgKFdlYkNv cmU6OkVkaXRvcjo6cGFzdGVBc1BsYWluVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6 OmNvcHlVUkwpOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpjb3B5SW1hZ2UpOgorICAgICAg ICBVc2UgUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlIHJhdGhlciB0aGFuIHRoZSBz aW5nbGUgZ2VuZXJhbCBwYXN0ZWJvYXJkCisgICAgICAgIGZvciBlZGl0aW5nIG9wZXJhdGlvbnMu CisKIDIwMTMtMDgtMjYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBF ZGl0b3JJbnRlcm5hbENvbW1hbmQgc2hvdWxkIHVzZSBGcmFtZSYgd2hlcmUgcG9zc2libGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvRWRpdG9yLmNwcAppbmRleCBiNjhiOWUyNTVhOTZjMWMzZjA3M2E2ODM0MWE3 ZGQ3MjcxZWMxMTU3Li4yYzY0OWU0MGNmMThmOTJjZDc4ZTg2ODQwNTA0NzY0NDE2ZjUwMmI4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCkBAIC00MTQsNyArNDE0LDcgQEAgdm9pZCBFZGl0 b3I6OnBhc3RlQXNGcmFnbWVudChQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IHBhc3RpbmdG cmFnbWVudCwgYm9vbAogCiB2b2lkIEVkaXRvcjo6cGFzdGVBc1BsYWluVGV4dEJ5cGFzc2luZ0RI VE1MKCkKIHsKLSAgICBwYXN0ZUFzUGxhaW5UZXh0V2l0aFBhc3RlYm9hcmQoUGFzdGVib2FyZDo6 Z2VuZXJhbFBhc3RlYm9hcmQoKSk7CisgICAgcGFzdGVBc1BsYWluVGV4dFdpdGhQYXN0ZWJvYXJk KFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSgpLmdldCgpKTsKIH0KIAogdm9pZCBF ZGl0b3I6OnBhc3RlQXNQbGFpblRleHRXaXRoUGFzdGVib2FyZChQYXN0ZWJvYXJkKiBwYXN0ZWJv YXJkKQpAQCAtNzA2LDcgKzcwNiw3IEBAIGJvb2wgRWRpdG9yOjpkaXNwYXRjaENQUEV2ZW50KGNv bnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBDbGlwYm9hcmRBY2Nlc3NQb2xpCiAgICAgdGFy Z2V0LT5kaXNwYXRjaEV2ZW50KGV2ZW50LCBJR05PUkVfRVhDRVBUSU9OKTsKICAgICBib29sIG5v RGVmYXVsdFByb2Nlc3NpbmcgPSBldmVudC0+ZGVmYXVsdFByZXZlbnRlZCgpOwogICAgIGlmIChu b0RlZmF1bHRQcm9jZXNzaW5nICYmIHBvbGljeSA9PSBDbGlwYm9hcmRXcml0YWJsZSkgewotICAg ICAgICBQYXN0ZWJvYXJkKiBwYXN0ZWJvYXJkID0gUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3RlYm9h cmQoKTsKKyAgICAgICAgT3duUHRyPFBhc3RlYm9hcmQ+IHBhc3RlYm9hcmQgPSBQYXN0ZWJvYXJk OjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKTsKICAgICAgICAgcGFzdGVib2FyZC0+Y2xlYXIoKTsK ICAgICAgICAgcGFzdGVib2FyZC0+d3JpdGVQYXN0ZWJvYXJkKGNsaXBib2FyZC0+cGFzdGVib2Fy ZCgpKTsKICAgICB9CkBAIC0xMDQxLDEwICsxMDQxLDEwIEBAIHZvaWQgRWRpdG9yOjpjdXQoKQog ICAgIGlmIChzaG91bGREZWxldGVSYW5nZShzZWxlY3Rpb24uZ2V0KCkpKSB7CiAgICAgICAgIHVw ZGF0ZU1hcmtlcnNGb3JXb3Jkc0FmZmVjdGVkQnlFZGl0aW5nKHRydWUpOwogICAgICAgICBpZiAo ZW5jbG9zaW5nVGV4dEZvcm1Db250cm9sKG1fZnJhbWUuc2VsZWN0aW9uKCkuc3RhcnQoKSkpIHsK LSAgICAgICAgICAgIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJvYXJkKCktPndyaXRlUGxhaW5U ZXh0KHNlbGVjdGVkVGV4dEZvckNsaXBib2FyZCgpLAorICAgICAgICAgICAgUGFzdGVib2FyZDo6 Y3JlYXRlRm9yQ29weUFuZFBhc3RlKCktPndyaXRlUGxhaW5UZXh0KHNlbGVjdGVkVGV4dEZvckNs aXBib2FyZCgpLAogICAgICAgICAgICAgICAgIGNhblNtYXJ0Q29weU9yRGVsZXRlKCkgPyBQYXN0 ZWJvYXJkOjpDYW5TbWFydFJlcGxhY2UgOiBQYXN0ZWJvYXJkOjpDYW5ub3RTbWFydFJlcGxhY2Up OwogICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJv YXJkKCktPndyaXRlU2VsZWN0aW9uKHNlbGVjdGlvbi5nZXQoKSwgY2FuU21hcnRDb3B5T3JEZWxl dGUoKSwgJm1fZnJhbWUsIEluY2x1ZGVJbWFnZUFsdFRleHRGb3JDbGlwYm9hcmQpOworICAgICAg ICAgICAgUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlKCktPndyaXRlU2VsZWN0aW9u KHNlbGVjdGlvbi5nZXQoKSwgY2FuU21hcnRDb3B5T3JEZWxldGUoKSwgJm1fZnJhbWUsIEluY2x1 ZGVJbWFnZUFsdFRleHRGb3JDbGlwYm9hcmQpOwogICAgICAgICBkaWRXcml0ZVNlbGVjdGlvblRv UGFzdGVib2FyZCgpOwogICAgICAgICBkZWxldGVTZWxlY3Rpb25XaXRoU21hcnREZWxldGUoY2Fu U21hcnRDb3B5T3JEZWxldGUoKSk7CiAgICAgfQpAQCAtMTA2MSwxNCArMTA2MSwxNCBAQCB2b2lk IEVkaXRvcjo6Y29weSgpCiAKICAgICB3aWxsV3JpdGVTZWxlY3Rpb25Ub1Bhc3RlYm9hcmQoc2Vs ZWN0ZWRSYW5nZSgpKTsKICAgICBpZiAoZW5jbG9zaW5nVGV4dEZvcm1Db250cm9sKG1fZnJhbWUu c2VsZWN0aW9uKCkuc3RhcnQoKSkpIHsKLSAgICAgICAgUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3Rl Ym9hcmQoKS0+d3JpdGVQbGFpblRleHQoc2VsZWN0ZWRUZXh0Rm9yQ2xpcGJvYXJkKCksCisgICAg ICAgIFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSgpLT53cml0ZVBsYWluVGV4dChz ZWxlY3RlZFRleHRGb3JDbGlwYm9hcmQoKSwKICAgICAgICAgICAgIGNhblNtYXJ0Q29weU9yRGVs ZXRlKCkgPyBQYXN0ZWJvYXJkOjpDYW5TbWFydFJlcGxhY2UgOiBQYXN0ZWJvYXJkOjpDYW5ub3RT bWFydFJlcGxhY2UpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIERvY3VtZW50KiBkb2N1bWVudCA9 IG1fZnJhbWUuZG9jdW1lbnQoKTsKICAgICAgICAgaWYgKEhUTUxJbWFnZUVsZW1lbnQqIGltYWdl RWxlbWVudCA9IGltYWdlRWxlbWVudEZyb21JbWFnZURvY3VtZW50KGRvY3VtZW50KSkKLSAgICAg ICAgICAgIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJvYXJkKCktPndyaXRlSW1hZ2UoaW1hZ2VF bGVtZW50LCBkb2N1bWVudC0+dXJsKCksIGRvY3VtZW50LT50aXRsZSgpKTsKKyAgICAgICAgICAg IFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSgpLT53cml0ZUltYWdlKGltYWdlRWxl bWVudCwgZG9jdW1lbnQtPnVybCgpLCBkb2N1bWVudC0+dGl0bGUoKSk7CiAgICAgICAgIGVsc2UK LSAgICAgICAgICAgIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJvYXJkKCktPndyaXRlU2VsZWN0 aW9uKHNlbGVjdGVkUmFuZ2UoKS5nZXQoKSwgY2FuU21hcnRDb3B5T3JEZWxldGUoKSwgJm1fZnJh bWUsIEluY2x1ZGVJbWFnZUFsdFRleHRGb3JDbGlwYm9hcmQpOworICAgICAgICAgICAgUGFzdGVi b2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlKCktPndyaXRlU2VsZWN0aW9uKHNlbGVjdGVkUmFu Z2UoKS5nZXQoKSwgY2FuU21hcnRDb3B5T3JEZWxldGUoKSwgJm1fZnJhbWUsIEluY2x1ZGVJbWFn ZUFsdFRleHRGb3JDbGlwYm9hcmQpOwogICAgIH0KIAogICAgIGRpZFdyaXRlU2VsZWN0aW9uVG9Q YXN0ZWJvYXJkKCk7CkBAIC0xMDg1LDkgKzEwODUsOSBAQCB2b2lkIEVkaXRvcjo6cGFzdGUoKQog ICAgIENhY2hlZFJlc291cmNlTG9hZGVyKiBsb2FkZXIgPSBtX2ZyYW1lLmRvY3VtZW50KCktPmNh Y2hlZFJlc291cmNlTG9hZGVyKCk7CiAgICAgUmVzb3VyY2VDYWNoZVZhbGlkYXRpb25TdXBwcmVz c29yIHZhbGlkYXRpb25TdXBwcmVzc29yKGxvYWRlcik7CiAgICAgaWYgKG1fZnJhbWUuc2VsZWN0 aW9uKCkuaXNDb250ZW50UmljaGx5RWRpdGFibGUoKSkKLSAgICAgICAgcGFzdGVXaXRoUGFzdGVi b2FyZChQYXN0ZWJvYXJkOjpnZW5lcmFsUGFzdGVib2FyZCgpLCB0cnVlKTsKKyAgICAgICAgcGFz dGVXaXRoUGFzdGVib2FyZChQYXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKS5nZXQo KSwgdHJ1ZSk7CiAgICAgZWxzZQotICAgICAgICBwYXN0ZUFzUGxhaW5UZXh0V2l0aFBhc3RlYm9h cmQoUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3RlYm9hcmQoKSk7CisgICAgICAgIHBhc3RlQXNQbGFp blRleHRXaXRoUGFzdGVib2FyZChQYXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKS5n ZXQoKSk7CiB9CiAKIHZvaWQgRWRpdG9yOjpwYXN0ZUFzUGxhaW5UZXh0KCkKQEAgLTEwOTcsNyAr MTA5Nyw3IEBAIHZvaWQgRWRpdG9yOjpwYXN0ZUFzUGxhaW5UZXh0KCkKICAgICBpZiAoIWNhblBh c3RlKCkpCiAgICAgICAgIHJldHVybjsKICAgICB1cGRhdGVNYXJrZXJzRm9yV29yZHNBZmZlY3Rl ZEJ5RWRpdGluZyhmYWxzZSk7Ci0gICAgcGFzdGVBc1BsYWluVGV4dFdpdGhQYXN0ZWJvYXJkKFBh c3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJvYXJkKCkpOworICAgIHBhc3RlQXNQbGFpblRleHRXaXRo UGFzdGVib2FyZChQYXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKS5nZXQoKSk7CiB9 CiAKIHZvaWQgRWRpdG9yOjpwZXJmb3JtRGVsZXRlKCkKQEAgLTExMzUsNyArMTEzNSw3IEBAIHZv aWQgRWRpdG9yOjpzaW1wbGlmeU1hcmt1cChOb2RlKiBzdGFydE5vZGUsIE5vZGUqIGVuZE5vZGUp CiAKIHZvaWQgRWRpdG9yOjpjb3B5VVJMKGNvbnN0IEtVUkwmIHVybCwgY29uc3QgU3RyaW5nJiB0 aXRsZSkKIHsKLSAgICBQYXN0ZWJvYXJkOjpnZW5lcmFsUGFzdGVib2FyZCgpLT53cml0ZVVSTCh1 cmwsIHRpdGxlLCAmbV9mcmFtZSk7CisgICAgUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBh c3RlKCktPndyaXRlVVJMKHVybCwgdGl0bGUsICZtX2ZyYW1lKTsKIH0KIAogdm9pZCBFZGl0b3I6 OmNvcHlJbWFnZShjb25zdCBIaXRUZXN0UmVzdWx0JiByZXN1bHQpCkBAIC0xMTQ0LDcgKzExNDQs NyBAQCB2b2lkIEVkaXRvcjo6Y29weUltYWdlKGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkK ICAgICBpZiAodXJsLmlzRW1wdHkoKSkKICAgICAgICAgdXJsID0gcmVzdWx0LmFic29sdXRlSW1h Z2VVUkwoKTsKIAotICAgIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJvYXJkKCktPndyaXRlSW1h Z2UocmVzdWx0LmlubmVyTm9uU2hhcmVkTm9kZSgpLCB1cmwsIHJlc3VsdC5hbHREaXNwbGF5U3Ry aW5nKCkpOworICAgIFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSgpLT53cml0ZUlt YWdlKHJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKSwgdXJsLCByZXN1bHQuYWx0RGlzcGxheVN0 cmluZygpKTsKIH0KIAogYm9vbCBFZGl0b3I6OmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFi bGVkKCkgY29uc3QK