120353 2013-08-27 04:35:43 -0700 [WK2][Soup] Add WebFrameNetworkingContext::webFrameLoaderClient() after r154490 2013-08-27 11:01:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 120186 1 ossy ossy ap beidson commit-queue ossy oldest_to_newest 921440 0 ossy 2013-08-27 04:35:43 -0700 http://trac.webkit.org/changeset/154490 added WebFrameNetworkingContext::webFrameLoaderClient(), but only for Mac implementation. But it is needed by WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp unconditionally for ENABLE_NETWORK_PROCESS builds. So we should add it to Soup implementation too. 921441 1 209745 ossy 2013-08-27 04:38:25 -0700 Created attachment 209745 Patch 921587 2 209745 ap 2013-08-27 10:40:17 -0700 Comment on attachment 209745 Patch Unsure why this code can't be cross-platform (I guess I subconsciously expected it to be). 921590 3 209745 commit-queue 2013-08-27 11:01:43 -0700 Comment on attachment 209745 Patch Clearing flags on attachment: 209745 Committed r154699: <http://trac.webkit.org/changeset/154699> 921591 4 commit-queue 2013-08-27 11:01:47 -0700 All reviewed patches have been landed. Closing bug. 209745 2013-08-27 04:38:25 -0700 2013-08-27 11:01:43 -0700 Patch bug-120353-20130827133823.patch text/plain 3133 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjA2MjhiZTQ5ZDdmYzUw Y2QyNmZkODk2MDBjNTFmNjJhZDVjNDE0MC4uN2ZjNzAwMzVlMjVjMWI2NTk1NGM3ZmVlNzFlOGEw NTA1YTgzZDM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTI3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl1bU291cF0g QWRkIFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OndlYkZyYW1lTG9hZGVyQ2xpZW50KCkgYWZ0 ZXIgcjE1NDQ5MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIwMzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHA6 CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9zb3VwL1dlYkZyYW1lTmV0d29y a2luZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZU5ldHdvcmtpbmdDb250 ZXh0Ojp3ZWJGcmFtZUxvYWRlckNsaWVudCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9zb3VwL1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuaDoKKwogMjAxMy0wOC0yNiAg U2FudG9zaCBNYWh0byAgPHNhbnRvc2gubWFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgRml4aW5n IGNvbXBpbGF0aW9uIHdhcm5pbmcgInVudXNlZCBwYXJhbWV0ZXIiIGluIFdlYlBhZ2VQcm94eS5j cHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv V2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcAppbmRleCAyOTg5YjI2ZGI0NGVl N2JmYjE3ZTJmYjMxYjliZmEwYTVmMDA2MjE1Li40Yjg1YjEwZjI2YjhlYjA3YTMxODQ3NWJlNzNi ODVhZjljZDc0NjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCkBAIC0z NSw2ICszNSw4IEBACiAjaW5jbHVkZSAiV2ViQ29va2llTWFuYWdlci5oIgogI2luY2x1ZGUgIldl YkNvcmVBcmd1bWVudENvZGVycy5oIgogI2luY2x1ZGUgIldlYkVycm9ycy5oIgorI2luY2x1ZGUg IldlYkZyYW1lLmgiCisjaW5jbHVkZSAiV2ViRnJhbWVMb2FkZXJDbGllbnQuaCIKICNpbmNsdWRl ICJXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmgiCiAjaW5jbHVkZSAiV2ViUGFnZS5oIgogI2lu Y2x1ZGUgIldlYlByb2Nlc3MuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvc291cC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvc291cC9XZWJGcmFtZU5ldHdv cmtpbmdDb250ZXh0LmNwcAppbmRleCAzOTNkZjAyYjBiNWY0NDk2ZDk1N2Y3MWZlN2VmOGFiY2Qz MDU1MjQzLi4zYjhhMDM4YTdjOWY5NmVjYWJjOTJjZDg5YjQxYWU2ZWQzMDI4NDIyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L3NvdXAvV2ViRnJh bWVOZXR3b3JraW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9zb3VwL1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuY3BwCkBAIC03Niw1 ICs3NiwxMyBAQCB1aW50NjRfdCBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0Ojppbml0aWF0aW5n UGFnZUlEKCkgY29uc3QKICAgICByZXR1cm4gbV9pbml0aWF0aW5nUGFnZUlEOwogfQogCitXZWJG cmFtZUxvYWRlckNsaWVudCogV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dDo6d2ViRnJhbWVMb2Fk ZXJDbGllbnQoKSBjb25zdAoreworICAgIGlmICghZnJhbWUoKSkKKyAgICAgICAgcmV0dXJuIDA7 CisKKyAgICByZXR1cm4gdG9XZWJGcmFtZUxvYWRlckNsaWVudChmcmFtZSgpLT5sb2FkZXIoKS5j bGllbnQoKSk7Cit9CisKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9zb3VwL1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuaCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvc291cC9XZWJGcmFtZU5ldHdvcmtp bmdDb250ZXh0LmgKaW5kZXggZDc1NWZhOWFkYWQ4OTFjMDIzMzcxNjFkMGY3ODNiOGVlYTFmMGE1 Mi4uMGUwMzU1MjFjYmNkNDgyNDhmZWQ1YTcyNzU1MDVjZWM3ZTMyMjAwZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9zb3VwL1dlYkZyYW1lTmV0 d29ya2luZ0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L3NvdXAvV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dC5oCkBAIC0zMyw2ICszMyw3IEBA CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY2xhc3MgV2ViRnJhbWU7CitjbGFzcyBXZWJGcmFtZUxv YWRlckNsaWVudDsKIAogY2xhc3MgV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dCA6IHB1YmxpYyBX ZWJDb3JlOjpGcmFtZU5ldHdvcmtpbmdDb250ZXh0IHsKIHB1YmxpYzoKQEAgLTQ0LDYgKzQ1LDgg QEAgcHVibGljOgogICAgIHN0YXRpYyB2b2lkIGVuc3VyZVByaXZhdGVCcm93c2luZ1Nlc3Npb24o KTsKICAgICBzdGF0aWMgdm9pZCBkZXN0cm95UHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbigpOwogCisg ICAgV2ViRnJhbWVMb2FkZXJDbGllbnQqIHdlYkZyYW1lTG9hZGVyQ2xpZW50KCkgY29uc3Q7CisK IHByaXZhdGU6CiAgICAgV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dChXZWJGcmFtZSopOwogCg==