120351 2013-08-27 03:06:52 -0700 Add USE(PROTECTION_SPACE_AUTH_CALLBACK) guards to canAuthenticateAgainstProtectionSpace() 2013-08-30 10:49:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 1 ossy ossy andersca commit-queue darin kling koivisto ossy sam oldest_to_newest 921422 0 ossy 2013-08-27 03:06:52 -0700 virtual void NetworkLoaderClient::canAuthenticateAgainstProtectionSpace(NetworkResourceLoader*, const WebCore::ProtectionSpace&) = 0; is implemented by AsynchronousNetworkLoaderClient and SynchronousNetworkLoaderClient. - AsynchronousNetworkLoaderClient implementation uses Messages::WebResourceLoader::CanAuthenticateAgainstProtectionSpace() - SynchronousNetworkLoaderClient implementation uses NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace() Both of them are inside USE(PROTECTION_SPACE_AUTH_CALLBACK), so all functions use them should be inside the same if guard. 921425 1 209739 ossy 2013-08-27 03:08:33 -0700 Created attachment 209739 Patch 923034 2 ossy 2013-08-30 10:02:37 -0700 ping for review, please :) 923069 3 209739 commit-queue 2013-08-30 10:49:51 -0700 Comment on attachment 209739 Patch Clearing flags on attachment: 209739 Committed r154895: <http://trac.webkit.org/changeset/154895> 923070 4 commit-queue 2013-08-30 10:49:53 -0700 All reviewed patches have been landed. Closing bug. 209739 2013-08-27 03:08:33 -0700 2013-08-30 10:49:50 -0700 Patch bug-120351-20130827120831.patch text/plain 6990 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjA2MjhiZTQ5ZDdmYzUw Y2QyNmZkODk2MDBjNTFmNjJhZDVjNDE0MC4uZWJmNjM3ZjQ4NzY2MDcxNDNhNzhhYjg5YzJiMmZh MzNlMTExMDUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTI3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIFVTRShQUk9U RUNUSU9OX1NQQUNFX0FVVEhfQ0FMTEJBQ0spIGd1YXJkcyB0byBjYW5BdXRoZW50aWNhdGVBZ2Fp bnN0UHJvdGVjdGlvblNwYWNlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMDM1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvQXN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNs aWVudC5jcHA6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvQXN5bmNocm9ub3VzTmV0d29ya0xv YWRlckNsaWVudC5oOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkZXJDbGll bnQuaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9TeW5jaHJvbm91c05ldHdvcmtMb2FkZXJD bGllbnQuY3BwOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1N5bmNocm9ub3VzTmV0d29ya0xv YWRlckNsaWVudC5oOgorCiAyMDEzLTA4LTI2ICBTYW50b3NoIE1haHRvICA8c2FudG9zaC5tYUBz YW1zdW5nLmNvbT4KIAogICAgICAgICBGaXhpbmcgY29tcGlsYXRpb24gd2FybmluZyAidW51c2Vk IHBhcmFtZXRlciIgaW4gV2ViUGFnZVByb3h5LmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvQXN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Bc3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xp ZW50LmNwcAppbmRleCBkYjk3NzVlNTgzYTJjMWIyNTUzYzdhZjQxY2U4M2U3MzIwZWMyMDZhLi4x YmFmNWIxOWFiMjAwM2U1NDhkMDNiYzJlNjU4MmIyMmE0M2ViN2E3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Bc3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Bc3luY2hyb25vdXNOZXR3 b3JrTG9hZGVyQ2xpZW50LmNwcApAQCAtNTIsMTIgKzUyLDE0IEBAIHZvaWQgQXN5bmNocm9ub3Vz TmV0d29ya0xvYWRlckNsaWVudDo6d2lsbFNlbmRSZXF1ZXN0KE5ldHdvcmtSZXNvdXJjZUxvYWRl ciogbG9hCiAgICAgbG9hZGVyLT5zZW5kQWJvcnRpbmdPbkZhaWx1cmUoTWVzc2FnZXM6OldlYlJl c291cmNlTG9hZGVyOjpXaWxsU2VuZFJlcXVlc3QocmVxdWVzdCwgcmVkaXJlY3RSZXNwb25zZSks IENvcmVJUEM6OkRpc3BhdGNoTWVzc2FnZUV2ZW5XaGVuV2FpdGluZ0ZvclN5bmNSZXBseSk7CiB9 CiAKKyNpZiBVU0UoUFJPVEVDVElPTl9TUEFDRV9BVVRIX0NBTExCQUNLKQogdm9pZCBBc3luY2hy b25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50OjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlv blNwYWNlKE5ldHdvcmtSZXNvdXJjZUxvYWRlciogbG9hZGVyLCBjb25zdCBQcm90ZWN0aW9uU3Bh Y2UmIHByb3RlY3Rpb25TcGFjZSkKIHsKICAgICAvLyBUaGlzIG1lc3NhZ2UgaXMgRGlzcGF0Y2hN ZXNzYWdlRXZlbldoZW5XYWl0aW5nRm9yU3luY1JlcGx5IHRvIGF2b2lkIGEgc2l0dWF0aW9uIHdo ZXJlIHRoZSBOZXR3b3JrUHJvY2VzcyBpcyBkZWFkbG9ja2VkCiAgICAgLy8gd2FpdGluZyBmb3Ig NiBjb25uZWN0aW9ucyB0byBjb21wbGV0ZSB3aGlsZSB0aGUgV2ViUHJvY2VzcyBpcyB3YWl0aW5n IGZvciBhIDd0aCAoU3luY2hyb25vdXMgWEhSKSB0byBjb21wbGV0ZS4KICAgICBsb2FkZXItPnNl bmRBYm9ydGluZ09uRmFpbHVyZShNZXNzYWdlczo6V2ViUmVzb3VyY2VMb2FkZXI6OkNhbkF1dGhl bnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UocHJvdGVjdGlvblNwYWNlKSwgQ29yZUlQQzo6 RGlzcGF0Y2hNZXNzYWdlRXZlbldoZW5XYWl0aW5nRm9yU3luY1JlcGx5KTsKIH0KKyNlbmRpZgog CiB2b2lkIEFzeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQ6OmRpZFJlY2VpdmVSZXNwb25z ZShOZXR3b3JrUmVzb3VyY2VMb2FkZXIqIGxvYWRlciwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYg cmVzcG9uc2UpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9B c3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9Bc3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmgKaW5kZXggYTQ1NmY5M2I2 NThhMjIxMTgzNTljYjNhMmY2ZTZhNTQzMmYyZTE2Yy4uYzcwMjYyNWY0NjI3YTY0OGY1NDk3Njll NWQ5Njc4ODAwM2QzMGNmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvQXN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQuaApAQCAtNDUs NyArNDUsOSBAQCBwcml2YXRlOgogICAgIEFzeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQo KTsKIAogICAgIHZpcnR1YWwgdm9pZCB3aWxsU2VuZFJlcXVlc3QoTmV0d29ya1Jlc291cmNlTG9h ZGVyKiwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiBuZXdSZXF1ZXN0LCBjb25zdCBXZWJDb3Jl OjpSZXNvdXJjZVJlc3BvbnNlJiByZWRpcmVjdFJlc3BvbnNlKSBPVkVSUklERTsKKyNpZiBVU0Uo UFJPVEVDVElPTl9TUEFDRV9BVVRIX0NBTExCQUNLKQogICAgIHZpcnR1YWwgdm9pZCBjYW5BdXRo ZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKE5ldHdvcmtSZXNvdXJjZUxvYWRlciosIGNv bnN0IFdlYkNvcmU6OlByb3RlY3Rpb25TcGFjZSYpIE9WRVJSSURFOworI2VuZGlmCiAgICAgdmly dHVhbCB2b2lkIGRpZFJlY2VpdmVSZXNwb25zZShOZXR3b3JrUmVzb3VyY2VMb2FkZXIqLCBjb25z dCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lk IGRpZFJlY2VpdmVCdWZmZXIoTmV0d29ya1Jlc291cmNlTG9hZGVyKiwgV2ViQ29yZTo6U2hhcmVk QnVmZmVyKiwgaW50IGVuY29kZWREYXRhTGVuZ3RoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZv aWQgZGlkU2VuZERhdGEoTmV0d29ya1Jlc291cmNlTG9hZGVyKiwgdW5zaWduZWQgbG9uZyBsb25n IGJ5dGVzU2VudCwgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFsQnl0ZXNUb0JlU2VudCkgT1ZFUlJJ REU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9h ZGVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZGVy Q2xpZW50LmgKaW5kZXggMWY0ZGU3MmNiMzg5ZjUyYTEwNDYxMzhmYzI3ZTU3OTU2ZThmMjU5Yi4u ZTZkNmI4ODljYmUzYWM5YjY2NmM4YjA1ZTU5MjcxMjgwYWFkYTNkZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWRlckNsaWVudC5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkZXJDbGllbnQuaApAQCAtNDcs NyArNDcsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+TmV0d29ya0xvYWRlckNsaWVudCgpIHsg fQogCiAgICAgdmlydHVhbCB2b2lkIHdpbGxTZW5kUmVxdWVzdChOZXR3b3JrUmVzb3VyY2VMb2Fk ZXIqLCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIG5ld1JlcXVlc3QsIGNvbnN0IFdlYkNvcmU6 OlJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2UpID0gMDsKKyNpZiBVU0UoUFJPVEVD VElPTl9TUEFDRV9BVVRIX0NBTExCQUNLKQogICAgIHZpcnR1YWwgdm9pZCBjYW5BdXRoZW50aWNh dGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKE5ldHdvcmtSZXNvdXJjZUxvYWRlciosIGNvbnN0IFdl YkNvcmU6OlByb3RlY3Rpb25TcGFjZSYpID0gMDsKKyNlbmRpZgogICAgIHZpcnR1YWwgdm9pZCBk aWRSZWNlaXZlUmVzcG9uc2UoTmV0d29ya1Jlc291cmNlTG9hZGVyKiwgY29uc3QgV2ViQ29yZTo6 UmVzb3VyY2VSZXNwb25zZSYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZUJ1ZmZl cihOZXR3b3JrUmVzb3VyY2VMb2FkZXIqLCBXZWJDb3JlOjpTaGFyZWRCdWZmZXIqLCBpbnQgZW5j b2RlZERhdGFMZW5ndGgpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGlkU2VuZERhdGEoTmV0d29y a1Jlc291cmNlTG9hZGVyKiwgdW5zaWduZWQgbG9uZyBsb25nIGJ5dGVzU2VudCwgdW5zaWduZWQg bG9uZyBsb25nIHRvdGFsQnl0ZXNUb0JlU2VudCkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmNwcCBi L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL1N5bmNocm9ub3VzTmV0d29ya0xvYWRlckNs aWVudC5jcHAKaW5kZXggYWI1OTEzODgzNjUyZGJmYzFiNTQ2OTU5M2Q4N2Y5OWQzMjk3MWJiMS4u YzdmMzBmNDc4ZmI1YTk5OGFlMTU0MDlhZDY5NDYwNTZiNzg3NTAzYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9TeW5jaHJvbm91c05ldHdv cmtMb2FkZXJDbGllbnQuY3BwCkBAIC02Niw2ICs2Niw3IEBAIHZvaWQgU3luY2hyb25vdXNOZXR3 b3JrTG9hZGVyQ2xpZW50Ojp3aWxsU2VuZFJlcXVlc3QoTmV0d29ya1Jlc291cmNlTG9hZGVyKiBs b2FkCiAgICAgbG9hZGVyLT5jb250aW51ZVdpbGxTZW5kUmVxdWVzdChtX2N1cnJlbnRSZXF1ZXN0 KTsKIH0KIAorI2lmIFVTRShQUk9URUNUSU9OX1NQQUNFX0FVVEhfQ0FMTEJBQ0spCiB2b2lkIFN5 bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudDo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3Rl Y3Rpb25TcGFjZShOZXR3b3JrUmVzb3VyY2VMb2FkZXIqIGxvYWRlciwgY29uc3QgUHJvdGVjdGlv blNwYWNlJikKIHsKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFzayB0aGUgV2ViUHJvY2VzcyBs aWtlIHRoZSBhc3luY2hyb25vdXMgY2FzZSBiZWxvdyBkb2VzLgpAQCAtNzMsNiArNzQsNyBAQCB2 b2lkIFN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudDo6Y2FuQXV0aGVudGljYXRlQWdhaW5z dFByb3RlY3Rpb25TcGFjZShOZXR3bwogICAgIC8vIEl0J3MgcG9zc2libGUgdGhhdCB3ZSBjYW4g anVtcCBzdHJhaWdodCB0byB0aGUgVUkgcHJvY2VzcyB0byByZXNvbHZlIHRoaXMuCiAgICAgbG9h ZGVyLT5jb250aW51ZUNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UodHJ1ZSk7 CiB9CisjZW5kaWYKIAogdm9pZCBTeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQ6OmRpZFJl Y2VpdmVSZXNwb25zZShOZXR3b3JrUmVzb3VyY2VMb2FkZXIqLCBjb25zdCBSZXNvdXJjZVJlc3Bv bnNlJiByZXNwb25zZSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL1N5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmgKaW5kZXggY2I4ZWI3 Njg4NjA0YmJhOTI4MzkzZjA3MzIzODcyMzVlNTIwZmM2Ni4uNGM4MjJmZDBlZjdhM2YyZTA3MTYx YTM3ZDc0ZjVlYjdjMGEyMDFlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvU3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50LmgKQEAgLTU2 LDcgKzU2LDkgQEAgcHJpdmF0ZToKICAgICBTeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQo Y29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiBvcmlnaW5hbFJlcXVlc3QsIFBhc3NSZWZQ dHI8TWVzc2FnZXM6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpQZXJmb3JtU3luY2hy b25vdXNMb2FkOjpEZWxheWVkUmVwbHk+KTsKIAogICAgIHZpcnR1YWwgdm9pZCB3aWxsU2VuZFJl cXVlc3QoTmV0d29ya1Jlc291cmNlTG9hZGVyKiwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiBw cm9wb3NlZFJlcXVlc3QsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0 UmVzcG9uc2UpIE9WRVJSSURFOworI2lmIFVTRShQUk9URUNUSU9OX1NQQUNFX0FVVEhfQ0FMTEJB Q0spCiAgICAgdmlydHVhbCB2b2lkIGNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3Bh Y2UoTmV0d29ya1Jlc291cmNlTG9hZGVyKiwgY29uc3QgV2ViQ29yZTo6UHJvdGVjdGlvblNwYWNl JikgT1ZFUlJJREU7CisjZW5kaWYKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNl KE5ldHdvcmtSZXNvdXJjZUxvYWRlciosIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2Um KSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZUJ1ZmZlcihOZXR3b3JrUmVz b3VyY2VMb2FkZXIqLCBXZWJDb3JlOjpTaGFyZWRCdWZmZXIqLCBpbnQgZW5jb2RlZERhdGFMZW5n dGgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBkaWRTZW5kRGF0YShOZXR3b3JrUmVzb3Vy Y2VMb2FkZXIqLCB1bnNpZ25lZCBsb25nIGxvbmcgYnl0ZXNTZW50LCB1bnNpZ25lZCBsb25nIGxv bmcgdG90YWxCeXRlc1RvQmVTZW50KSBPVkVSUklERSB7IH0K