120332 2013-08-26 17:00:46 -0700 Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload 2013-09-05 15:10:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 921231 0 joepeck 2013-08-26 17:00:46 -0700 * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on pretty printed easySlider.min.js that would be hit on reload 3. Reload => console.assert in console when file is auto-pretty printed without execution line handle. 921232 1 webkit-bug-importer 2013-08-26 17:01:19 -0700 <rdar://problem/14840428> 921234 2 209693 joepeck 2013-08-26 17:01:52 -0700 Created attachment 209693 [PATCH] Proposed Fix 921235 3 joepeck 2013-08-26 17:02:30 -0700 This assert doesn't really matter either. By the end of the function, if newExecutionLocation we re-generate the executionLineHandle when setting the new executionLineNumber. 925238 4 209693 commit-queue 2013-09-05 15:10:30 -0700 Comment on attachment 209693 [PATCH] Proposed Fix Clearing flags on attachment: 209693 Committed r155154: <http://trac.webkit.org/changeset/155154> 925239 5 commit-queue 2013-09-05 15:10:32 -0700 All reviewed patches have been landed. Closing bug. 209693 2013-08-26 17:01:52 -0700 2013-09-05 15:10:30 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 1868 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEzYmVlYzQuLjUwNGU4MDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEzLTA4LTI2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IGhhcm1sZXNzIGFzc2VydCwgdHJpZ2dlcmVkIGhpdHRpbmcgYnJlYWtwb2ludCBpbiBhdXRvIHBy ZXR0eXByaW50ZWQgY29kZSBvbiByZWxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMDMzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9UZXh0RWRpdG9yLmpzOgorCisyMDEz LTA4LTI2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogV2Ugc2hvdWxkIHJlZ2VuZXJhdGUgSW5zcGVjdG9yQmFja2VuZENvbW1h bmRzLmpzIGZvciBMZWdhY3kgSW5zcGVjdG9yLmpzb24gdmVyc2lvbnMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDI0MgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXh0RWRpdG9yLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGV4dEVkaXRvci5qcwppbmRleCA3MjgyM2Yx Li4yOWUyMjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1RleHRFZGl0b3IuanMKQEAgLTExODAsNyArMTE4MCw2IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRp dG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgICAgICBp ZiAoIWlzTmFOKHRoaXMuX2V4ZWN1dGlvbkxpbmVOdW1iZXIpKSB7Ci0gICAgICAgICAgICAgICAg ICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuX2V4ZWN1dGlvbkxpbmVIYW5kbGUpOwogICAgICAgICAg ICAgICAgICAgICBjb25zb2xlLmFzc2VydCghaXNOYU4odGhpcy5fZXhlY3V0aW9uQ29sdW1uTnVt YmVyKSk7CiAgICAgICAgICAgICAgICAgICAgIG5ld0V4ZWN1dGlvbkxvY2F0aW9uID0gdGhpcy5f Zm9ybWF0dGVyU291cmNlTWFwLm9yaWdpbmFsVG9Gb3JtYXR0ZWQodGhpcy5fZXhlY3V0aW9uTGlu ZU51bWJlciwgdGhpcy5fZXhlY3V0aW9uQ29sdW1uTnVtYmVyKTsKICAgICAgICAgICAgICAgICB9 CkBAIC0xMjA0LDcgKzEyMDMsNiBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgaWYgKCFpc05hTih0aGlz Ll9leGVjdXRpb25MaW5lTnVtYmVyKSkgewotICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmFz c2VydCh0aGlzLl9leGVjdXRpb25MaW5lSGFuZGxlKTsKICAgICAgICAgICAgICAgICAgICAgY29u c29sZS5hc3NlcnQoIWlzTmFOKHRoaXMuX2V4ZWN1dGlvbkNvbHVtbk51bWJlcikpOwogICAgICAg ICAgICAgICAgICAgICBuZXdFeGVjdXRpb25Mb2NhdGlvbiA9IHRoaXMuX2Zvcm1hdHRlclNvdXJj ZU1hcC5mb3JtYXR0ZWRUb09yaWdpbmFsKHRoaXMuX2V4ZWN1dGlvbkxpbmVOdW1iZXIsIHRoaXMu X2V4ZWN1dGlvbkNvbHVtbk51bWJlcik7CiAgICAgICAgICAgICAgICAgfQo=