120325 2013-08-26 14:46:46 -0700 Editor::spellChecker() should return a reference 2013-08-26 15:17:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 921169 0 sam 2013-08-26 14:46:46 -0700 Editor::spellChecker() should return a reference 921170 1 209679 sam 2013-08-26 14:47:36 -0700 Created attachment 209679 Patch 921174 2 209679 kling 2013-08-26 14:49:25 -0700 Comment on attachment 209679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209679&action=review r=me > Source/WebCore/editing/Editor.h:332 > - SpellChecker* spellChecker() const { return m_spellChecker.get(); } > + SpellChecker& spellChecker() const { return *m_spellChecker.get(); } You should make m_spellChecker a "const OwnPtr" so it can't be assigned to after construction, too. 921175 3 sam 2013-08-26 14:49:27 -0700 Committed r154643: <http://trac.webkit.org/changeset/154643> 921191 4 209679 darin 2013-08-26 15:17:15 -0700 Comment on attachment 209679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209679&action=review >> Source/WebCore/editing/Editor.h:332 >> + SpellChecker& spellChecker() const { return *m_spellChecker.get(); } > > You should make m_spellChecker a "const OwnPtr" so it can't be assigned to after construction, too. No need for get() here. 209679 2013-08-26 14:47:36 -0700 2013-08-26 15:17:15 -0700 Patch bug-120325-20130826144736.patch text/plain 6961 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDY0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA4LTI2ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRWRpdG9yOjpzcGVsbENoZWNrZXIoKSBz aG91bGQgcmV0dXJuIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjAzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkVkaXRvcjo6RWRpdG9yKToKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5oOgorICAgICAgICAo V2ViQ29yZTo6RWRpdG9yOjpzcGVsbENoZWNrZXIpOgorICAgICAgICAqIGVkaXRpbmcvU3BlbGxD aGVja2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNwZWxsQ2hlY2tlcjo6U3BlbGxDaGVja2Vy KToKKyAgICAgICAgKFdlYkNvcmU6OlNwZWxsQ2hlY2tlcjo6Y2xpZW50KToKKyAgICAgICAgKFdl YkNvcmU6OlNwZWxsQ2hlY2tlcjo6aXNBc3luY2hyb25vdXNFbmFibGVkKToKKyAgICAgICAgKFdl YkNvcmU6OlNwZWxsQ2hlY2tlcjo6ZGlkQ2hlY2spOgorICAgICAgICAoV2ViQ29yZTo6U3BlbGxD aGVja2VyOjpkaWRDaGVja1N1Y2NlZWQpOgorICAgICAgICAqIGVkaXRpbmcvU3BlbGxDaGVja2Vy Lmg6CisgICAgICAgICogcGFnZS9FZGl0b3JDbGllbnQuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0lu dGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6Omxhc3RTcGVsbENoZWNr UmVxdWVzdFNlcXVlbmNlKToKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6bGFzdFNwZWxs Q2hlY2tQcm9jZXNzZWRTZXF1ZW5jZSk6CisKIDIwMTMtMDgtMjYgIEJlbSBKb25lcy1CZXkgIDxi am9uZXNiZUBhZG9iZS5jb20+CiAKICAgICAgICAgT3B0aW1pemUgRmxvYXRJbnRlcnZhbFNlYXJj aEFkYXB0ZXI6OmNvbGxlY3RJZk5lZWRlZApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9F ZGl0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNw cAkocmV2aXNpb24gMTU0NjI4KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04OTgsNyArODk4LDcgQEAgRWRpdG9yOjpFZGl0b3IoRnJhbWUm IGZyYW1lKQogICAgIC8vIFRoaXMgaXMgb2ZmIGJ5IGRlZmF1bHQsIHNpbmNlIG1vc3QgZWRpdG9y cyB3YW50IHRoaXMgYmVoYXZpb3IgKHRoaXMgbWF0Y2hlcyBJRSBidXQgbm90IEZGKS4KICAgICAs IG1fc2hvdWxkU3R5bGVXaXRoQ1NTKGZhbHNlKQogICAgICwgbV9raWxsUmluZyhhZG9wdFB0cihu ZXcgS2lsbFJpbmcpKQotICAgICwgbV9zcGVsbENoZWNrZXIoYWRvcHRQdHIobmV3IFNwZWxsQ2hl Y2tlcigmZnJhbWUpKSkKKyAgICAsIG1fc3BlbGxDaGVja2VyKGFkb3B0UHRyKG5ldyBTcGVsbENo ZWNrZXIoZnJhbWUpKSkKICAgICAsIG1fYWx0ZXJuYXRpdmVUZXh0Q29udHJvbGxlcihhZG9wdFB0 cihuZXcgQWx0ZXJuYXRpdmVUZXh0Q29udHJvbGxlcigmZnJhbWUpKSkKICAgICAsIG1fYXJlTWFy a2VkVGV4dE1hdGNoZXNIaWdobGlnaHRlZChmYWxzZSkKICAgICAsIG1fZGVmYXVsdFBhcmFncmFw aFNlcGFyYXRvcihFZGl0b3JQYXJhZ3JhcGhTZXBhcmF0b3JJc0RpdikKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRp dGluZy9FZGl0b3IuaAkocmV2aXNpb24gMTU0NjI4KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9FZGl0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMzI5LDcgKzMyOSw3IEBAIHB1YmxpYzoKICAg ICBWaXNpYmxlU2VsZWN0aW9uIHNlbGVjdGlvbkZvckNvbW1hbmQoRXZlbnQqKTsKIAogICAgIEtp bGxSaW5nKiBraWxsUmluZygpIGNvbnN0IHsgcmV0dXJuIG1fa2lsbFJpbmcuZ2V0KCk7IH0KLSAg ICBTcGVsbENoZWNrZXIqIHNwZWxsQ2hlY2tlcigpIGNvbnN0IHsgcmV0dXJuIG1fc3BlbGxDaGVj a2VyLmdldCgpOyB9CisgICAgU3BlbGxDaGVja2VyJiBzcGVsbENoZWNrZXIoKSBjb25zdCB7IHJl dHVybiAqbV9zcGVsbENoZWNrZXIuZ2V0KCk7IH0KIAogICAgIEVkaXRpbmdCZWhhdmlvciBiZWhh dmlvcigpIGNvbnN0OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1NwZWxsQ2hlY2tl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9TcGVsbENoZWNrZXIu Y3BwCShyZXZpc2lvbiAxNTQ2MjgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1NwZWxsQ2hl Y2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCB2b2lkIFNwZWxsQ2hl Y2tSZXF1ZXN0OjpyZXF1ZXN0ZXJEZXN0cm95CiAgICAgbV9jaGVja2VyID0gMDsKIH0KIAotU3Bl bGxDaGVja2VyOjpTcGVsbENoZWNrZXIoRnJhbWUqIGZyYW1lKQorU3BlbGxDaGVja2VyOjpTcGVs bENoZWNrZXIoRnJhbWUmIGZyYW1lKQogICAgIDogbV9mcmFtZShmcmFtZSkKICAgICAsIG1fbGFz dFJlcXVlc3RTZXF1ZW5jZSgwKQogICAgICwgbV9sYXN0UHJvY2Vzc2VkU2VxdWVuY2UoMCkKQEAg LTEyNCw3ICsxMjQsNyBAQCBTcGVsbENoZWNrZXI6On5TcGVsbENoZWNrZXIoKQogCiBUZXh0Q2hl Y2tlckNsaWVudCogU3BlbGxDaGVja2VyOjpjbGllbnQoKSBjb25zdAogewotICAgIFBhZ2UqIHBh Z2UgPSBtX2ZyYW1lLT5wYWdlKCk7CisgICAgUGFnZSogcGFnZSA9IG1fZnJhbWUucGFnZSgpOwog ICAgIGlmICghcGFnZSkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuIHBhZ2UtPmVkaXRv ckNsaWVudCgpLT50ZXh0Q2hlY2tlcigpOwpAQCAtMTQxLDcgKzE0MSw3IEBAIHZvaWQgU3BlbGxD aGVja2VyOjp0aW1lckZpcmVkVG9Qcm9jZXNzUXUKIAogYm9vbCBTcGVsbENoZWNrZXI6OmlzQXN5 bmNocm9ub3VzRW5hYmxlZCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fZnJhbWUtPnNldHRpbmdz KCkuYXN5bmNocm9ub3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoKTsKKyAgICByZXR1cm4gbV9mcmFt ZS5zZXR0aW5ncygpLmFzeW5jaHJvbm91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCk7CiB9CiAKIGJv b2wgU3BlbGxDaGVja2VyOjpjYW5DaGVja0FzeW5jaHJvbm91c2x5KFJhbmdlKiByYW5nZSkgY29u c3QKQEAgLTIxMiw3ICsyMTIsNyBAQCB2b2lkIFNwZWxsQ2hlY2tlcjo6ZGlkQ2hlY2soaW50IHNl cXVlbmNlCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2ZyYW1lLT5lZGl0b3IoKS5t YXJrQW5kUmVwbGFjZUZvcihtX3Byb2Nlc3NpbmdSZXF1ZXN0LCByZXN1bHRzKTsKKyAgICBtX2Zy YW1lLmVkaXRvcigpLm1hcmtBbmRSZXBsYWNlRm9yKG1fcHJvY2Vzc2luZ1JlcXVlc3QsIHJlc3Vs dHMpOwogCiAgICAgaWYgKG1fbGFzdFByb2Nlc3NlZFNlcXVlbmNlIDwgc2VxdWVuY2UpCiAgICAg ICAgIG1fbGFzdFByb2Nlc3NlZFNlcXVlbmNlID0gc2VxdWVuY2U7CkBAIC0yMzIsNyArMjMyLDcg QEAgdm9pZCBTcGVsbENoZWNrZXI6OmRpZENoZWNrU3VjY2VlZChpbnQgcwogICAgICAgICBpZiAo cmVxdWVzdERhdGEubWFzaygpICYgVGV4dENoZWNraW5nVHlwZUdyYW1tYXIpCiAgICAgICAgICAg ICBtYXJrZXJzIHw9IERvY3VtZW50TWFya2VyOjpHcmFtbWFyOwogICAgICAgICBpZiAobWFya2Vy cykKLSAgICAgICAgICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPm1hcmtlcnMoKS5yZW1vdmVNYXJr ZXJzKG1fcHJvY2Vzc2luZ1JlcXVlc3QtPmNoZWNraW5nUmFuZ2UoKS5nZXQoKSwgbWFya2Vycyk7 CisgICAgICAgICAgICBtX2ZyYW1lLmRvY3VtZW50KCktPm1hcmtlcnMoKS5yZW1vdmVNYXJrZXJz KG1fcHJvY2Vzc2luZ1JlcXVlc3QtPmNoZWNraW5nUmFuZ2UoKS5nZXQoKSwgbWFya2Vycyk7CiAg ICAgfQogICAgIGRpZENoZWNrKHNlcXVlbmNlLCByZXN1bHRzKTsKIH0KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvU3BlbGxDaGVja2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvZWRpdGluZy9TcGVsbENoZWNrZXIuaAkocmV2aXNpb24gMTU0NjI4KQorKysgU291cmNlL1dl YkNvcmUvZWRpdGluZy9TcGVsbENoZWNrZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNzUsNyArNzUs NyBAQCBjbGFzcyBTcGVsbENoZWNrZXIgewogcHVibGljOgogICAgIGZyaWVuZCBjbGFzcyBTcGVs bENoZWNrUmVxdWVzdDsKIAotICAgIGV4cGxpY2l0IFNwZWxsQ2hlY2tlcihGcmFtZSopOworICAg IGV4cGxpY2l0IFNwZWxsQ2hlY2tlcihGcmFtZSYpOwogICAgIH5TcGVsbENoZWNrZXIoKTsKIAog ICAgIGJvb2wgaXNBc3luY2hyb25vdXNFbmFibGVkKCkgY29uc3Q7CkBAIC0xMDUsNyArMTA1LDcg QEAgcHJpdmF0ZToKICAgICB2b2lkIGRpZENoZWNrQ2FuY2VsKGludCBzZXF1ZW5jZSk7CiAgICAg dm9pZCBkaWRDaGVjayhpbnQgc2VxdWVuY2UsIGNvbnN0IFZlY3RvcjxUZXh0Q2hlY2tpbmdSZXN1 bHQ+Jik7CiAKLSAgICBGcmFtZSogbV9mcmFtZTsKKyAgICBGcmFtZSYgbV9mcmFtZTsKICAgICBp bnQgbV9sYXN0UmVxdWVzdFNlcXVlbmNlOwogICAgIGludCBtX2xhc3RQcm9jZXNzZWRTZXF1ZW5j ZTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9FZGl0b3JDbGllbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0VkaXRvckNsaWVudC5oCShyZXZpc2lvbiAxNTQ2Mjgp CisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0VkaXRvckNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBA IC01Myw3ICs1Myw2IEBAIGNsYXNzIEtleWJvYXJkRXZlbnQ7CiBjbGFzcyBOb2RlOwogY2xhc3Mg UmFuZ2U7CiBjbGFzcyBTaGFyZWRCdWZmZXI7Ci1jbGFzcyBTcGVsbENoZWNrZXI7CiBjbGFzcyBT dHlsZVByb3BlcnR5U2V0OwogY2xhc3MgVGV4dENoZWNrZXJDbGllbnQ7CiBjbGFzcyBWaXNpYmxl U2VsZWN0aW9uOwpJbmRleDogU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAkocmV2aXNp b24gMTU0NjI4KQorKysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMjksMTQgKzIyOSw2IEBAIHN0YXRpYyBib29sIG1hcmtlclR5cGVzRnJv bShjb25zdCBTdHJpbmcKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotc3RhdGljIFNwZWxsQ2hlY2tl ciogc3BlbGxjaGVja2VyKERvY3VtZW50KiBkb2N1bWVudCkKLXsKLSAgICBpZiAoIWRvY3VtZW50 IHx8ICFkb2N1bWVudC0+ZnJhbWUoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICByZXR1cm4g ZG9jdW1lbnQtPmZyYW1lKCktPmVkaXRvcigpLnNwZWxsQ2hlY2tlcigpOwotfQotCiBjb25zdCBj aGFyKiBJbnRlcm5hbHM6OmludGVybmFsc0lkID0gImludGVybmFscyI7CiAKIFBhc3NSZWZQdHI8 SW50ZXJuYWxzPiBJbnRlcm5hbHM6OmNyZWF0ZShEb2N1bWVudCogZG9jdW1lbnQpCkBAIC0xMTcy LDI2ICsxMTY0LDIyIEBAIFBhc3NSZWZQdHI8Q2xpZW50UmVjdD4gSW50ZXJuYWxzOjpiZXN0Wm8K IAogaW50IEludGVybmFsczo6bGFzdFNwZWxsQ2hlY2tSZXF1ZXN0U2VxdWVuY2UoRG9jdW1lbnQq IGRvY3VtZW50LCBFeGNlcHRpb25Db2RlJiBlYykKIHsKLSAgICBTcGVsbENoZWNrZXIqIGNoZWNr ZXIgPSBzcGVsbGNoZWNrZXIoZG9jdW1lbnQpOwotCi0gICAgaWYgKCFjaGVja2VyKSB7CisgICAg aWYgKCFkb2N1bWVudCB8fCAhZG9jdW1lbnQtPmZyYW1lKCkpIHsKICAgICAgICAgZWMgPSBJTlZB TElEX0FDQ0VTU19FUlI7CiAgICAgICAgIHJldHVybiAtMTsKICAgICB9CiAKLSAgICByZXR1cm4g Y2hlY2tlci0+bGFzdFJlcXVlc3RTZXF1ZW5jZSgpOworICAgIHJldHVybiBkb2N1bWVudC0+ZnJh bWUoKS0+ZWRpdG9yKCkuc3BlbGxDaGVja2VyKCkubGFzdFJlcXVlc3RTZXF1ZW5jZSgpOwogfQog CiBpbnQgSW50ZXJuYWxzOjpsYXN0U3BlbGxDaGVja1Byb2Nlc3NlZFNlcXVlbmNlKERvY3VtZW50 KiBkb2N1bWVudCwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgU3BlbGxDaGVja2VyKiBjaGVj a2VyID0gc3BlbGxjaGVja2VyKGRvY3VtZW50KTsKLQotICAgIGlmICghY2hlY2tlcikgeworICAg IGlmICghZG9jdW1lbnQgfHwgIWRvY3VtZW50LT5mcmFtZSgpKSB7CiAgICAgICAgIGVjID0gSU5W QUxJRF9BQ0NFU1NfRVJSOwogICAgICAgICByZXR1cm4gLTE7CiAgICAgfQogCi0gICAgcmV0dXJu IGNoZWNrZXItPmxhc3RQcm9jZXNzZWRTZXF1ZW5jZSgpOworICAgIHJldHVybiBkb2N1bWVudC0+ ZnJhbWUoKS0+ZWRpdG9yKCkuc3BlbGxDaGVja2VyKCkubGFzdFByb2Nlc3NlZFNlcXVlbmNlKCk7 CiB9CiAKIFZlY3RvcjxTdHJpbmc+IEludGVybmFsczo6dXNlclByZWZlcnJlZExhbmd1YWdlcygp IGNvbnN0Cg==