120320 2013-08-26 11:22:58 -0700 Page::console() should return a reference 2013-08-26 14:53:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki commit-queue esprehn+autocc glenn kangil.han kling macpherson menard mkwst psolanki oldest_to_newest 921101 0 psolanki 2013-08-26 11:22:58 -0700 Page::m_console is never NULL. 921102 1 209666 psolanki 2013-08-26 11:24:56 -0700 Created attachment 209666 Patch 921177 2 209666 commit-queue 2013-08-26 14:53:36 -0700 Comment on attachment 209666 Patch Clearing flags on attachment: 209666 Committed r154645: <http://trac.webkit.org/changeset/154645> 921178 3 commit-queue 2013-08-26 14:53:38 -0700 All reviewed patches have been landed. Closing bug. 209666 2013-08-26 11:24:56 -0700 2013-08-26 14:53:36 -0700 Patch bug-120320-20130826112456.patch text/plain 6409 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFkZjNiNzE0ODIzN2Nl ODY2ZDQ4YzliMWE3YTU4NmQ5MDE1NzgwMy4uNjJlN2MzNjljNmJjNmZlOTUzMGMyMDI0NzVjNGM0 NmQ1YzNmY2JhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA4LTI2ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBQYWdlOjpjb25zb2xl KCkgc2hvdWxkIHJldHVybiBhIHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUGFnZTo6bV9jb25zb2xlIGlzIG5ldmVyIE5VTEwgc28gY29u c29sZSgpIGNhbiBqdXN0IHJldHVybiBhIHJlZmVyZW5jZS4KKworICAgICAgICAqIGNzcy9DU1NQ YXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpsb2dFcnJvcik6CisgICAg ICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjphZGRD b25zb2xlTWVzc2FnZSk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6YWRkTWVzc2FnZSk6 CisgICAgICAgICogcGFnZS9ET01XaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2lu ZG93OjpwYWdlQ29uc29sZSk6CisgICAgICAgICogcGFnZS9QYWdlLmg6CisgICAgICAgIChXZWJD b3JlOjpQYWdlOjpjb25zb2xlKToKKyAgICAgICAgKiB4bWwvWFNMU3R5bGVTaGVldExpYnhzbHQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6WFNMU3R5bGVTaGVldDo6cGFyc2VTdHJpbmcpOgorICAg ICAgICAqIHhtbC9YU0xUUHJvY2Vzc29yTGlieHNsdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpk b2NMb2FkZXJGdW5jKToKKwogMjAxMy0wOC0yNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWQgZml4LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmNwcAppbmRleCBjYmU3OGY2Mjc3YTVkOGQ1NWM0MmQyMmY0NDMyMjQ5NDk5YTliZmM0Li4z YzU3Y2EzM2U1Y2VkMjAyNDlkMTRlMWZlODQwNWI5M2Q1NTQ4Mzc3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcApAQCAtMTE3MTcsOCArMTE3MTcsOCBAQCBib29sIENTU1BhcnNlcjo6aXNMb2dn aW5nRXJyb3JzKCkKIHZvaWQgQ1NTUGFyc2VyOjpsb2dFcnJvcihjb25zdCBTdHJpbmcmIG1lc3Nh Z2UsIGludCBsaW5lTnVtYmVyKQogewogICAgIC8vIEZJWE1FOiA8aHR0cDovL3dlYmtpdC5vcmcv Yi8xMTQzMTM+IENTUyBQYXJzZXIgQ29uc29sZU1lc3NhZ2UgZXJyb3JzIHNob3VsZCBpbmNsdWRl IGNvbHVtbiBudW1iZXJzCi0gICAgUGFnZUNvbnNvbGUqIGNvbnNvbGUgPSBtX3N0eWxlU2hlZXQt PnNpbmdsZU93bmVyRG9jdW1lbnQoKS0+cGFnZSgpLT5jb25zb2xlKCk7Ci0gICAgY29uc29sZS0+ YWRkTWVzc2FnZShDU1NNZXNzYWdlU291cmNlLCBXYXJuaW5nTWVzc2FnZUxldmVsLCBtZXNzYWdl LCBtX3N0eWxlU2hlZXQtPmJhc2VVUkwoKS5zdHJpbmcoKSwgbGluZU51bWJlciArIDEsIDApOwor ICAgIFBhZ2VDb25zb2xlJiBjb25zb2xlID0gbV9zdHlsZVNoZWV0LT5zaW5nbGVPd25lckRvY3Vt ZW50KCktPnBhZ2UoKS0+Y29uc29sZSgpOworICAgIGNvbnNvbGUuYWRkTWVzc2FnZShDU1NNZXNz YWdlU291cmNlLCBXYXJuaW5nTWVzc2FnZUxldmVsLCBtZXNzYWdlLCBtX3N0eWxlU2hlZXQtPmJh c2VVUkwoKS5zdHJpbmcoKSwgbGluZU51bWJlciArIDEsIDApOwogfQogCiBTdHlsZVJ1bGVLZXlm cmFtZXMqIENTU1BhcnNlcjo6Y3JlYXRlS2V5ZnJhbWVzUnVsZShjb25zdCBTdHJpbmcmIG5hbWUs IFBhc3NPd25QdHI8VmVjdG9yPFJlZlB0cjxTdHlsZUtleWZyYW1lPiA+ID4gcG9wS2V5ZnJhbWVz KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggNTdkZDA0OGJjNmI3MTc3OTJlNjExYTM4MTNk MTZkNjBhYWEzOTc5Yy4uZDdlN2JkZjRkOTNkZGViZTNlYmIxMWZkYjFiNDBkNDI4MmY4MjRkYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC00NzQ5LDcgKzQ3NDksNyBAQCB2b2lkIERvY3Vt ZW50OjphZGRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlIHNvdXJjZSwgTWVzc2FnZUxldmVs IGxldmVsLCBjb25zdAogICAgIH0KIAogICAgIGlmIChQYWdlKiBwYWdlID0gdGhpcy0+cGFnZSgp KQotICAgICAgICBwYWdlLT5jb25zb2xlKCktPmFkZE1lc3NhZ2Uoc291cmNlLCBsZXZlbCwgbWVz c2FnZSwgcmVxdWVzdElkZW50aWZpZXIsIHRoaXMpOworICAgICAgICBwYWdlLT5jb25zb2xlKCku YWRkTWVzc2FnZShzb3VyY2UsIGxldmVsLCBtZXNzYWdlLCByZXF1ZXN0SWRlbnRpZmllciwgdGhp cyk7CiB9CiAKIHZvaWQgRG9jdW1lbnQ6OmFkZE1lc3NhZ2UoTWVzc2FnZVNvdXJjZSBzb3VyY2Us IE1lc3NhZ2VMZXZlbCBsZXZlbCwgY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBjb25zdCBTdHJpbmcm IHNvdXJjZVVSTCwgdW5zaWduZWQgbGluZU51bWJlciwgdW5zaWduZWQgY29sdW1uTnVtYmVyLCBQ YXNzUmVmUHRyPFNjcmlwdENhbGxTdGFjaz4gY2FsbFN0YWNrLCBTY3JpcHRTdGF0ZSogc3RhdGUs IHVuc2lnbmVkIGxvbmcgcmVxdWVzdElkZW50aWZpZXIpCkBAIC00NzYwLDcgKzQ3NjAsNyBAQCB2 b2lkIERvY3VtZW50OjphZGRNZXNzYWdlKE1lc3NhZ2VTb3VyY2Ugc291cmNlLCBNZXNzYWdlTGV2 ZWwgbGV2ZWwsIGNvbnN0IFN0cmluZwogICAgIH0KIAogICAgIGlmIChQYWdlKiBwYWdlID0gdGhp cy0+cGFnZSgpKQotICAgICAgICBwYWdlLT5jb25zb2xlKCktPmFkZE1lc3NhZ2Uoc291cmNlLCBs ZXZlbCwgbWVzc2FnZSwgc291cmNlVVJMLCBsaW5lTnVtYmVyLCBjb2x1bW5OdW1iZXIsIGNhbGxT dGFjaywgc3RhdGUsIHJlcXVlc3RJZGVudGlmaWVyKTsKKyAgICAgICAgcGFnZS0+Y29uc29sZSgp LmFkZE1lc3NhZ2Uoc291cmNlLCBsZXZlbCwgbWVzc2FnZSwgc291cmNlVVJMLCBsaW5lTnVtYmVy LCBjb2x1bW5OdW1iZXIsIGNhbGxTdGFjaywgc3RhdGUsIHJlcXVlc3RJZGVudGlmaWVyKTsKIH0K IAogU2VjdXJpdHlPcmlnaW4qIERvY3VtZW50Ojp0b3BPcmlnaW4oKSBjb25zdApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9ET01XaW5kb3cuY3BwCmluZGV4IGMwMmU3NzVhODM5M2UyMjBhZWY4ZTQ1NGIzMGJlMjFmOGRk ZWM5YTcuLjExM2EwNmZkNDA1YzVhNGRiOTc1Y2YyMmFkYzEyNTA1ZWU3MjNmMmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVdpbmRvdy5jcHAKQEAgLTY5MSw3ICs2OTEsNyBAQCBQYWdlQ29uc29sZSogRE9N V2luZG93OjpwYWdlQ29uc29sZSgpIGNvbnN0CiB7CiAgICAgaWYgKCFpc0N1cnJlbnRseURpc3Bs YXllZEluRnJhbWUoKSkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgcmV0dXJuIG1fZnJhbWUtPnBh Z2UoKSA/IG1fZnJhbWUtPnBhZ2UoKS0+Y29uc29sZSgpIDogMDsKKyAgICByZXR1cm4gbV9mcmFt ZS0+cGFnZSgpID8gJm1fZnJhbWUtPnBhZ2UoKS0+Y29uc29sZSgpIDogMDsKIH0KIAogRE9NQXBw bGljYXRpb25DYWNoZSogRE9NV2luZG93OjphcHBsaWNhdGlvbkNhY2hlKCkgY29uc3QKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Q YWdlLmgKaW5kZXggMmYzNjJkZWQ0OTc2YmRhZTM4ZDYxYjk5Mzc5YWUxZmNjNjE1N2M4MS4uZDQx MDc2OTlmMzFhYjc3NzQ2OGZiYzYzMzA4MDU1NjA4YmQ4ZDQzNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKQEAg LTM5NCw3ICszOTQsNyBAQCBwdWJsaWM6CiAgICAgUGFnZVRocm90dGxlciogcGFnZVRocm90dGxl cigpIHsgcmV0dXJuIG1fcGFnZVRocm90dGxlci5nZXQoKTsgfQogICAgIFBhc3NPd25QdHI8UGFn ZUFjdGl2aXR5QXNzZXJ0aW9uVG9rZW4+IGNyZWF0ZUFjdGl2aXR5VG9rZW4oKTsKIAotICAgIFBh Z2VDb25zb2xlKiBjb25zb2xlKCkgeyByZXR1cm4gbV9jb25zb2xlLmdldCgpOyB9CisgICAgUGFn ZUNvbnNvbGUmIGNvbnNvbGUoKSB7IHJldHVybiAqbV9jb25zb2xlOyB9CiAKICNpZiBFTkFCTEUo SElEREVOX1BBR0VfRE9NX1RJTUVSX1RIUk9UVExJTkcpCiAgICAgdm9pZCBoaWRkZW5QYWdlRE9N VGltZXJUaHJvdHRsaW5nU3RhdGVDaGFuZ2VkKCk7CkBAIC01NDUsNyArNTQ1LDcgQEAgcHJpdmF0 ZToKICAgICBib29sIG1fc2NyaXB0ZWRBbmltYXRpb25zU3VzcGVuZGVkOwogICAgIE93blB0cjxQ YWdlVGhyb3R0bGVyPiBtX3BhZ2VUaHJvdHRsZXI7CiAKLSAgICBPd25QdHI8UGFnZUNvbnNvbGU+ IG1fY29uc29sZTsKKyAgICBjb25zdCBPd25QdHI8UGFnZUNvbnNvbGU+IG1fY29uc29sZTsKIAog ICAgIEhhc2hTZXQ8U3RyaW5nPiBtX3NlZW5QbHVnaW5zOwogICAgIEhhc2hTZXQ8U3RyaW5nPiBt X3NlZW5NZWRpYUVuZ2luZXM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMU3R5 bGVTaGVldExpYnhzbHQuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hTTFN0eWxlU2hlZXRMaWJ4 c2x0LmNwcAppbmRleCA4ZTI0Yjc0MjE2Zjg5YzdiZGM1MWJiNTRiOWZmOTU1MWFjYzE3N2RiLi4w ODdmM2VmNWY4YjFhOGFiN2IzZDFlOGI2MzlmMDhlNGFkNGVlZTUyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS94bWwvWFNMU3R5bGVTaGVldExpYnhzbHQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3htbC9YU0xTdHlsZVNoZWV0TGlieHNsdC5jcHAKQEAgLTE0Nyw3ICsxNDcsNyBAQCBib29s IFhTTFN0eWxlU2hlZXQ6OnBhcnNlU3RyaW5nKGNvbnN0IFN0cmluZyYgc3RyaW5nKQogICAgIFBh Z2VDb25zb2xlKiBjb25zb2xlID0gMDsKICAgICBGcmFtZSogZnJhbWUgPSBvd25lckRvY3VtZW50 KCktPmZyYW1lKCk7CiAgICAgaWYgKGZyYW1lICYmIGZyYW1lLT5wYWdlKCkpCi0gICAgICAgIGNv bnNvbGUgPSBmcmFtZS0+cGFnZSgpLT5jb25zb2xlKCk7CisgICAgICAgIGNvbnNvbGUgPSAmZnJh bWUtPnBhZ2UoKS0+Y29uc29sZSgpOwogCiAgICAgWE1MRG9jdW1lbnRQYXJzZXJTY29wZSBzY29w ZShjYWNoZWRSZXNvdXJjZUxvYWRlcigpLCBYU0xUUHJvY2Vzc29yOjpnZW5lcmljRXJyb3JGdW5j LCBYU0xUUHJvY2Vzc29yOjpwYXJzZUVycm9yRnVuYywgY29uc29sZSk7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yTGlieHNsdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS94bWwvWFNMVFByb2Nlc3NvckxpYnhzbHQuY3BwCmluZGV4IDkyYmM5M2QxNzgxYTQ4MDA5 OTEzNTAzOTlkMmU0MGU5ZTE2ZWY1ZmYuLjY4NjIxYjQyZjBhOTU0ZTkzODI0OWRkN2RhNjBlNDk2 MGQ4YzJhNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yTGli eHNsdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUveG1sL1hTTFRQcm9jZXNzb3JMaWJ4c2x0LmNw cApAQCAtMTQwLDcgKzE0MCw3IEBAIHN0YXRpYyB4bWxEb2NQdHIgZG9jTG9hZGVyRnVuYyhjb25z dCB4bWxDaGFyKiB1cmksCiAgICAgICAgIFBhZ2VDb25zb2xlKiBjb25zb2xlID0gMDsKICAgICAg ICAgRnJhbWUqIGZyYW1lID0gZ2xvYmFsUHJvY2Vzc29yLT54c2xTdHlsZXNoZWV0KCktPm93bmVy RG9jdW1lbnQoKS0+ZnJhbWUoKTsKICAgICAgICAgaWYgKGZyYW1lICYmIGZyYW1lLT5wYWdlKCkp Ci0gICAgICAgICAgICBjb25zb2xlID0gZnJhbWUtPnBhZ2UoKS0+Y29uc29sZSgpOworICAgICAg ICAgICAgY29uc29sZSA9ICZmcmFtZS0+cGFnZSgpLT5jb25zb2xlKCk7CiAgICAgICAgIHhtbFNl dFN0cnVjdHVyZWRFcnJvckZ1bmMoY29uc29sZSwgWFNMVFByb2Nlc3Nvcjo6cGFyc2VFcnJvckZ1 bmMpOwogICAgICAgICB4bWxTZXRHZW5lcmljRXJyb3JGdW5jKGNvbnNvbGUsIFhTTFRQcm9jZXNz b3I6OmdlbmVyaWNFcnJvckZ1bmMpOwogCg==