120299 2013-08-26 04:05:53 -0700 [GTK][WK2] a11y tests unconditionally launching a11y daemons 2013-09-12 04:14:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar webkit-unassigned apinheiro commit-queue jdiggs mario svillar oldest_to_newest 920957 0 svillar 2013-08-26 04:05:53 -0700 I was checking the status of some GTK bots and I noticed that we had >600!!! at-spi2-bus-launcher processes with their corresponding dbus-daemon processes I think the problem is that we unconditionally launch them in _start_accessibility_daemons() in run-gtk-tests 924476 1 210470 mario 2013-09-04 09:30:08 -0700 Created attachment 210470 Patch proposal (In reply to comment #0) > I was checking the status of some GTK bots and I noticed that we had >600!!! at-spi2-bus-launcher processes with their corresponding dbus-daemon processes > > I think the problem is that we unconditionally launch them in _start_accessibility_daemons() in run-gtk-tests Actually, this should not be an issue since we already take care of terminating the process that we start in _tear_down_testing_environment(). The problem was that, as silly as it might sound, we were using the wrong variable name (_ally_bus_launcher) to keep a reference to that process, so later on we were not terminating it properly (as we were expecting _spi_bus_launcher in _tear_down_testing_environment()). 928238 2 210470 commit-queue 2013-09-12 04:14:49 -0700 Comment on attachment 210470 Patch proposal Clearing flags on attachment: 210470 Committed r155606: <http://trac.webkit.org/changeset/155606> 928239 3 commit-queue 2013-09-12 04:14:51 -0700 All reviewed patches have been landed. Closing bug. 210470 2013-09-04 09:30:08 -0700 2013-09-12 04:14:49 -0700 Patch proposal 0001-2013-09-04-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 2310 mario RnJvbSBlZjU5NDZjYzBjNjQ0ZDcyYWVjNWE3M2U2ZDFkY2M1OGRkYzU5NGM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogV2VkLCA0IFNlcCAyMDEzIDE3OjI2OjE4ICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gMjAxMy0wOS0wNCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1 bmcuY29tPgoKICAgICAgICBbR1RLXVtXSzJdIGExMXkgdGVzdHMgdW5jb25kaXRpb25hbGx5IGxh dW5jaGluZyBhMTF5IGRhZW1vbnMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIwMjk5CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK ICAgICAgICBVc2UgdGhlIHJpZ2h0IHZhcmlhYmxlIG5hbWUgdG8gc3RvcmUgYSByZWZlcmVuY2Ug dG8gdGhlIGF0LXNwaTIKICAgICAgICBidXMgbGF1bmNoZXIgcHJvY2Vzcywgc28gd2UgY2FuIGJl IHN1cmUgd2UgYXJlIHRlcm1pbmF0aW5nIGl0IHdoZW4KICAgICAgICBjYWxsaW5nIF90ZWFyX2Rv d25fdGVzdGluZ19lbnZpcm9ubWVudCgpLgoKICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0 czoKICAgICAgICAoVGVzdFJ1bm5lci5fc3RhcnRfYWNjZXNzaWJpbGl0eV9kYWVtb25zKTogVXNl IF9zcGlfYnVzX2xhdW5jaGVyCiAgICAgICAgaW5zdGVhZCBvZiBfYWxseV9idXNfbGF1bmNoZXIu Ci0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysK IFRvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5n ZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNjk0NzUzLi4wOWY4MTVjIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTMtMDktMDQgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNv bT4KKworICAgICAgICBbR1RLXVtXSzJdIGExMXkgdGVzdHMgdW5jb25kaXRpb25hbGx5IGxhdW5j aGluZyBhMTF5IGRhZW1vbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMDI5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVzZSB0aGUgcmlnaHQgdmFyaWFibGUgbmFtZSB0byBzdG9yZSBhIHJlZmVyZW5j ZSB0byB0aGUgYXQtc3BpMgorICAgICAgICBidXMgbGF1bmNoZXIgcHJvY2Vzcywgc28gd2UgY2Fu IGJlIHN1cmUgd2UgYXJlIHRlcm1pbmF0aW5nIGl0IHdoZW4KKyAgICAgICAgY2FsbGluZyBfdGVh cl9kb3duX3Rlc3RpbmdfZW52aXJvbm1lbnQoKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0 ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIuX3N0YXJ0X2FjY2Vzc2liaWxpdHlfZGFlbW9u cyk6IFVzZSBfc3BpX2J1c19sYXVuY2hlcgorICAgICAgICBpbnN0ZWFkIG9mIF9hbGx5X2J1c19s YXVuY2hlci4KKwogMjAxMy0wOS0wMyAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbQVhdW0FUS10gQWRkZWQgc3VwcG9ydCBmb3Igc29ydCBhbmQgaGVs cCBhdHRyaWJ1dGVzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMgYi9U b29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggNjNjZDczZS4uY2Y4NzRiMSAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVu LWd0ay10ZXN0cwpAQCAtMTQ4LDcgKzE0OCw3IEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAgICAgICAg ICAgICByZXR1cm4gRmFsc2UKIAogICAgICAgICB0cnk6Ci0gICAgICAgICAgICBzZWxmLl9hbGx5 X2J1c19sYXVuY2hlciA9IHN1YnByb2Nlc3MuUG9wZW4oW3NwaV9idXNfbGF1bmNoZXJfcGF0aF0s IGVudj1zZWxmLl90ZXN0X2VudikKKyAgICAgICAgICAgIHNlbGYuX3NwaV9idXNfbGF1bmNoZXIg PSBzdWJwcm9jZXNzLlBvcGVuKFtzcGlfYnVzX2xhdW5jaGVyX3BhdGhdLCBlbnY9c2VsZi5fdGVz dF9lbnYpCiAgICAgICAgIGV4Y2VwdDoKICAgICAgICAgICAgIHN5cy5zdGRlcnIud3JpdGUoIkZh aWxlZCB0byBsYXVuY2ggdGhlIGFjY2Vzc2liaWxpdHkgYnVzXG4iKQogICAgICAgICAgICAgc3lz LnN0ZGVyci5mbHVzaCgpCi0tIAoxLjcuMTAuNAoK