120296 2013-08-26 02:56:21 -0700 [GTK] Add support for passing test directories to run-gtk-tests 2013-08-26 03:35:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 920936 0 cgarcia 2013-08-26 02:56:21 -0700 This way you can pass for example the WebKit1 uni tests dir to run only wk1 tests, or pass both wk1 and wk2 test dirs, but not the C API tests, etc. 920937 1 209631 cgarcia 2013-08-26 03:01:41 -0700 Created attachment 209631 Patch 920947 2 209631 pnormand 2013-08-26 03:26:39 -0700 Comment on attachment 209631 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209631&action=review > Tools/ChangeLog:13 > + in the directory are added the list of tests run. are added *to* the list of tests *to* run? 920952 3 cgarcia 2013-08-26 03:35:05 -0700 Committed r154595: <http://trac.webkit.org/changeset/154595> 209631 2013-08-26 03:01:41 -0700 2013-08-26 03:26:39 -0700 Patch tools-run-gtk-tests-dirs.diff text/plain 2733 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNGNh ZjhhLi4xNGRkYTEwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTMtMDgtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBw YXNzaW5nIHRlc3QgZGlyZWN0b3JpZXMgdG8gcnVuLWd0ay10ZXN0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMjk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6 CisgICAgICAgIChUZXN0UnVubmVyLl9nZXRfdGVzdHNfZnJvbV9kaXIpOiBIZWxwZXIgZnVuY3Rp b24gdG8gcmV0dXJuIGFsbAorICAgICAgICB1bml0IHRlc3RzIGZvdW5kIGluIGEgZ2l2ZW4gZGly ZWN0b3J5LgorICAgICAgICAoVGVzdFJ1bm5lci5fZ2V0X3Rlc3RzKTogQ2hlY2sgdGhlIGdpdmVu IHRlc3RzIHBhc3NlZCBpbiB0aGUKKyAgICAgICAgY29tbWFuZCBsaW5lLCBzbyB0aGF0IGlmIGEg ZGlyZWN0b3J5IGlzIGZvdW5kIHRoZSB0ZXN0cyBjb250YWluZWQKKyAgICAgICAgaW4gdGhlIGRp cmVjdG9yeSBhcmUgYWRkZWQgdGhlIGxpc3Qgb2YgdGVzdHMgcnVuLgorCisyMDEzLTA4LTI2ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RL XSBTaWxlbmNlIE1pbmlCcm93c2VyIGNvbXBpbGUgd2FybmluZ3MgZHVlIHRvIHJlY2VudCBHVEsr IGRlcHJlY2F0aW9ucwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIwMjkwCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBi L1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwppbmRleCA4ODNlZDU2Li4xOGI1MjRmIDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9y dW4tZ3RrLXRlc3RzCkBAIC05NywyMSArOTcsMzMgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAg ICAgc2VsZi5fc3BpX3JlZ2lzdHJ5ZCA9IE5vbmUKICAgICAgICAgc2VsZi5fc3BpX2J1c19sYXVu Y2hlciA9IE5vbmUKIAotICAgIGRlZiBfZ2V0X3Rlc3RzKHNlbGYsIHRlc3RzKToKKyAgICBkZWYg X2dldF90ZXN0c19mcm9tX2RpcihzZWxmLCB0ZXN0X2Rpcik6CisgICAgICAgIGlmIG5vdCBvcy5w YXRoLmlzZGlyKHRlc3RfZGlyKToKKyAgICAgICAgICAgIHJldHVybiBbXQorCisgICAgICAgIHRl c3RzID0gW10KKyAgICAgICAgZm9yIHRlc3RfZmlsZSBpbiBvcy5saXN0ZGlyKHRlc3RfZGlyKToK KyAgICAgICAgICAgIGlmIG5vdCB0ZXN0X2ZpbGUubG93ZXIoKS5zdGFydHN3aXRoKCJ0ZXN0Iik6 CisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgICAgIHRlc3RfcGF0aCA9IG9zLnBh dGguam9pbih0ZXN0X2RpciwgdGVzdF9maWxlKQorICAgICAgICAgICAgaWYgb3MucGF0aC5pc2Zp bGUodGVzdF9wYXRoKSBhbmQgb3MuYWNjZXNzKHRlc3RfcGF0aCwgb3MuWF9PSyk6CisgICAgICAg ICAgICAgICAgdGVzdHMuYXBwZW5kKHRlc3RfcGF0aCkKKyAgICAgICAgcmV0dXJuIHRlc3RzCisK KyAgICBkZWYgX2dldF90ZXN0cyhzZWxmLCBpbml0aWFsX3Rlc3RzKToKKyAgICAgICAgdGVzdHMg PSBbXQorICAgICAgICBmb3IgdGVzdCBpbiBpbml0aWFsX3Rlc3RzOgorICAgICAgICAgICAgaWYg b3MucGF0aC5pc2Rpcih0ZXN0KToKKyAgICAgICAgICAgICAgICB0ZXN0cy5leHRlbmQoc2VsZi5f Z2V0X3Rlc3RzX2Zyb21fZGlyKHRlc3QpKQorICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAg ICAgICB0ZXN0cy5hcHBlbmQodGVzdCkKICAgICAgICAgaWYgdGVzdHM6CiAgICAgICAgICAgICBy ZXR1cm4gdGVzdHMKIAogICAgICAgICB0ZXN0cyA9IFtdCiAgICAgICAgIGZvciB0ZXN0X2RpciBp biBzZWxmLlRFU1RfRElSUzoKICAgICAgICAgICAgIGFic29sdXRlX3Rlc3RfZGlyID0gb3MucGF0 aC5qb2luKHNlbGYuX3Byb2dyYW1zX3BhdGgsIHRlc3RfZGlyKQotICAgICAgICAgICAgaWYgbm90 IG9zLnBhdGguaXNkaXIoYWJzb2x1dGVfdGVzdF9kaXIpOgotICAgICAgICAgICAgICAgIGNvbnRp bnVlCi0gICAgICAgICAgICBmb3IgdGVzdF9maWxlIGluIG9zLmxpc3RkaXIoYWJzb2x1dGVfdGVz dF9kaXIpOgotICAgICAgICAgICAgICAgIGlmIG5vdCB0ZXN0X2ZpbGUubG93ZXIoKS5zdGFydHN3 aXRoKCJ0ZXN0Iik6Ci0gICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCi0gICAgICAgICAgICAg ICAgdGVzdF9wYXRoID0gb3MucGF0aC5qb2luKHNlbGYuX3Byb2dyYW1zX3BhdGgsIHRlc3RfZGly LCB0ZXN0X2ZpbGUpCi0gICAgICAgICAgICAgICAgaWYgb3MucGF0aC5pc2ZpbGUodGVzdF9wYXRo KSBhbmQgb3MuYWNjZXNzKHRlc3RfcGF0aCwgb3MuWF9PSyk6Ci0gICAgICAgICAgICAgICAgICAg IHRlc3RzLmFwcGVuZCh0ZXN0X3BhdGgpCisgICAgICAgICAgICB0ZXN0cy5leHRlbmQoc2VsZi5f Z2V0X3Rlc3RzX2Zyb21fZGlyKGFic29sdXRlX3Rlc3RfZGlyKSkKICAgICAgICAgcmV0dXJuIHRl c3RzCiAKICAgICBkZWYgX2xvb2t1cF9hdHNwaTJfYmluYXJ5KHNlbGYsIGZpbGVuYW1lKToK