120294 2013-08-26 02:47:27 -0700 [WK2] Buildfix for non Mac platforms 2013-08-26 15:33:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 1 ossy ossy andersca beidson commit-queue kling ossy sam oldest_to_newest 920933 0 ossy 2013-08-26 02:47:27 -0700 We should check if __MAC_OS_X_VERSION_MIN_REQUIRED macro is defined or not: -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 +#if defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 Patch is coming. 920934 1 209630 ossy 2013-08-26 02:49:08 -0700 Created attachment 209630 Patch 921023 2 209630 andersca 2013-08-26 08:03:32 -0700 Comment on attachment 209630 Patch It's probably better to use PLATFORM(MAC) here. 921065 3 209630 darin 2013-08-26 10:23:10 -0700 Comment on attachment 209630 Patch Please use PLATFORM(MAC) as suggested by Anders. 921176 4 209680 ossy 2013-08-26 14:53:22 -0700 Created attachment 209680 Patch 921197 5 209680 commit-queue 2013-08-26 15:33:35 -0700 Comment on attachment 209680 Patch Clearing flags on attachment: 209680 Committed r154646: <http://trac.webkit.org/changeset/154646> 921198 6 commit-queue 2013-08-26 15:33:37 -0700 All reviewed patches have been landed. Closing bug. 209630 2013-08-26 02:49:08 -0700 2013-08-26 14:53:17 -0700 Patch bug-120294-20130826114906.patch text/plain 2870 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjEyNmUxZTNmZmVhYzUy YTFmMTU0N2UzOTA3ZmQ5NzcyYTI0OTkzMy4uOTljMDAyODU3MmFjZmE3ZGVkMmRjN2JhMzkxMzUz MTMyYTJjNjM3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gQnVpbGRm aXggZm9yIG5vbiBNYWMgcGxhdGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjAyOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91c05ldHdvcmtMb2Fk ZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpBc3luY2hyb25vdXNOZXR3b3JrTG9hZGVy Q2xpZW50OjpkaWRSZWNlaXZlQnVmZmVyKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuaDoKKwogMjAxMy0wOC0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIG1pc3NpbmcgaW5pdGlh bGl6ZXIgZm9yIHBsdWdpbkxvYWRQb2xpY3kgaW4gV0tQYWdlTG9hZGVyQ2xpZW50CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Bc3luY2hyb25vdXNOZXR3b3JrTG9h ZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91 c05ldHdvcmtMb2FkZXJDbGllbnQuY3BwCmluZGV4IDc1ZWVjYTEyNThhNmU2Njc0ODg5NzM0Mzcz ZWQ4M2Q2OGZkNDAyYjkuLmFiMDMwNmQ5ZTVkZjhlNWY5ODc1NGUwYThkYmRkYWQ2NmY4MWIyYTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91c05l dHdvcmtMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L0FzeW5jaHJvbm91c05ldHdvcmtMb2FkZXJDbGllbnQuY3BwCkBAIC02Niw3ICs2Niw3IEBAIHZv aWQgQXN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudDo6ZGlkUmVjZWl2ZVJlc3BvbnNlKE5l dHdvcmtSZXNvdXJjZUxvYWRlcioKIAogdm9pZCBBc3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xp ZW50OjpkaWRSZWNlaXZlQnVmZmVyKE5ldHdvcmtSZXNvdXJjZUxvYWRlciogbG9hZGVyLCBTaGFy ZWRCdWZmZXIqIGJ1ZmZlciwgaW50IGVuY29kZWREYXRhTGVuZ3RoKQogewotI2lmIF9fTUFDX09T X1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5MAorI2lmIGRlZmluZWQoX19NQUNfT1NfWF9W RVJTSU9OX01JTl9SRVFVSVJFRCkgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSAxMDkwCiAgICAgU2hhcmVhYmxlUmVzb3VyY2U6OkhhbmRsZSBzaGFyZWFibGVSZXNvdXJjZUhh bmRsZTsKICAgICBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnRyeUdldFNoYXJlYWJsZUhhbmRsZUZy b21TaGFyZWRCdWZmZXIoc2hhcmVhYmxlUmVzb3VyY2VIYW5kbGUsIGJ1ZmZlcik7CiAgICAgaWYg KCFzaGFyZWFibGVSZXNvdXJjZUhhbmRsZS5pc051bGwoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmggYi9Tb3VyY2Uv V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuaAppbmRleCBmYjlm M2YxMzExMGM1YzFmNTAzNDFlZWJmYTliZjZmZmY3NWM1YmEzLi5kY2Y1YTUxZjIxODhjZDBlNGRj NWYyZjdkNzM5OWFjNTI2YmU5M2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuaApAQCAtMTEyLDcgKzExMiw3IEBAIHB1 YmxpYzoKICAgICAvLyBNZXNzYWdlIGhhbmRsZXJzLgogICAgIHZvaWQgZGlkUmVjZWl2ZU5ldHdv cmtSZXNvdXJjZUxvYWRlck1lc3NhZ2UoQ29yZUlQQzo6Q29ubmVjdGlvbiosIENvcmVJUEM6Ok1l c3NhZ2VEZWNvZGVyJik7CiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwOTAKKyNpZiBkZWZpbmVkKF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQpICYmIF9f TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5MAogICAgIHN0YXRpYyB2b2lkIHRy eUdldFNoYXJlYWJsZUhhbmRsZUZyb21DRlVSTENhY2hlZFJlc3BvbnNlKFNoYXJlYWJsZVJlc291 cmNlOjpIYW5kbGUmLCBDRkNhY2hlZFVSTFJlc3BvbnNlUmVmKTsKICNlbmRpZgogCkBAIC0xMzYs NyArMTM2LDcgQEAgcHVibGljOgogI2VuZGlmCiAgICAgdm9pZCBjb250aW51ZVdpbGxTZW5kUmVx dWVzdChjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIG5ld1JlcXVlc3QpOwogCi0jaWYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCisjaWYgIGRlZmluZWQoX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCkgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMDkwCiAgICAgc3RhdGljIHZvaWQgdHJ5R2V0U2hhcmVhYmxlSGFuZGxlRnJv bVNoYXJlZEJ1ZmZlcihTaGFyZWFibGVSZXNvdXJjZTo6SGFuZGxlJiwgV2ViQ29yZTo6U2hhcmVk QnVmZmVyKik7CiAjZW5kaWYKIAo= 209680 2013-08-26 14:53:22 -0700 2013-08-26 15:33:35 -0700 Patch bug-120294-20130826235324.patch text/plain 2793 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjNlOTFiZjE5YTViMmU1 M2NlYjU1MDZkNzk4OWI4YzUwNDNhZDllNS4uYzI3ZmZhMTViMzkyZGRhNDU3NjJkYTk3YmUyMzMy ZDQyNDM3YTk5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gQnVpbGRm aXggZm9yIG5vbiBNYWMgcGxhdGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjAyOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91c05ldHdvcmtMb2Fk ZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpBc3luY2hyb25vdXNOZXR3b3JrTG9hZGVy Q2xpZW50OjpkaWRSZWNlaXZlQnVmZmVyKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuaDoKKwogMjAxMy0wOC0yNiAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBjYW4tcmVhZC1pbi1kcmFnc3RhcnQtZXZl bnQuaHRtbCBhbmQgY2FuLXJlYWQtaW4tY29weS1hbmQtY3V0LWV2ZW50cy5odG1sIGZhaWwKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0FzeW5jaHJvbm91c05ldHdv cmtMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvQXN5bmNo cm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAKaW5kZXggNzVlZWNhMTI1OGE2ZTY2NzQ4ODk3 MzQzNzNlZDgzZDY4ZmQ0MDJiOS4uZGI5Nzc1ZTU4M2EyYzFiMjU1M2M3YWY0MWNlODNlNzMyMGVj MjA2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvQXN5bmNocm9u b3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvQXN5bmNocm9ub3VzTmV0d29ya0xvYWRlckNsaWVudC5jcHAKQEAgLTY2LDcgKzY2LDcg QEAgdm9pZCBBc3luY2hyb25vdXNOZXR3b3JrTG9hZGVyQ2xpZW50OjpkaWRSZWNlaXZlUmVzcG9u c2UoTmV0d29ya1Jlc291cmNlTG9hZGVyKgogCiB2b2lkIEFzeW5jaHJvbm91c05ldHdvcmtMb2Fk ZXJDbGllbnQ6OmRpZFJlY2VpdmVCdWZmZXIoTmV0d29ya1Jlc291cmNlTG9hZGVyKiBsb2FkZXIs IFNoYXJlZEJ1ZmZlciogYnVmZmVyLCBpbnQgZW5jb2RlZERhdGFMZW5ndGgpCiB7Ci0jaWYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCisjaWYgUExBVEZPUk0oTUFDKSAm JiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwOTAKICAgICBTaGFyZWFibGVS ZXNvdXJjZTo6SGFuZGxlIHNoYXJlYWJsZVJlc291cmNlSGFuZGxlOwogICAgIE5ldHdvcmtSZXNv dXJjZUxvYWRlcjo6dHJ5R2V0U2hhcmVhYmxlSGFuZGxlRnJvbVNoYXJlZEJ1ZmZlcihzaGFyZWFi bGVSZXNvdXJjZUhhbmRsZSwgYnVmZmVyKTsKICAgICBpZiAoIXNoYXJlYWJsZVJlc291cmNlSGFu ZGxlLmlzTnVsbCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L05ldHdvcmtSZXNvdXJjZUxvYWRlci5oCmluZGV4IGZiOWYzZjEzMTEwYzVjMWY1MDM0MWVlYmZh OWJmNmZmZjc1YzViYTMuLjlhZjg0Yjk1NjBhOTZjZjk1ODRkNTZkYmRhNmYzYTZlOWQ3ZTk2YjMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJj ZUxvYWRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNv dXJjZUxvYWRlci5oCkBAIC0xMTIsNyArMTEyLDcgQEAgcHVibGljOgogICAgIC8vIE1lc3NhZ2Ug aGFuZGxlcnMuCiAgICAgdm9pZCBkaWRSZWNlaXZlTmV0d29ya1Jlc291cmNlTG9hZGVyTWVzc2Fn ZShDb3JlSVBDOjpDb25uZWN0aW9uKiwgQ29yZUlQQzo6TWVzc2FnZURlY29kZXImKTsKIAotI2lm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5MAorI2lmIFBMQVRGT1JNKE1B QykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCiAgICAgc3RhdGlj IHZvaWQgdHJ5R2V0U2hhcmVhYmxlSGFuZGxlRnJvbUNGVVJMQ2FjaGVkUmVzcG9uc2UoU2hhcmVh YmxlUmVzb3VyY2U6OkhhbmRsZSYsIENGQ2FjaGVkVVJMUmVzcG9uc2VSZWYpOwogI2VuZGlmCiAK QEAgLTEzNiw3ICsxMzYsNyBAQCBwdWJsaWM6CiAjZW5kaWYKICAgICB2b2lkIGNvbnRpbnVlV2ls bFNlbmRSZXF1ZXN0KGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgbmV3UmVxdWVzdCk7 CiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwOTAKKyNpZiBQTEFU Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5MAogICAg IHN0YXRpYyB2b2lkIHRyeUdldFNoYXJlYWJsZUhhbmRsZUZyb21TaGFyZWRCdWZmZXIoU2hhcmVh YmxlUmVzb3VyY2U6OkhhbmRsZSYsIFdlYkNvcmU6OlNoYXJlZEJ1ZmZlciopOwogI2VuZGlmCiAK