120292 2013-08-26 01:47:30 -0700 [GTK] Improve the stop/reload button implementation in MiniBrowser 2013-08-26 03:30:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 920923 0 cgarcia 2013-08-26 01:47:30 -0700 - Use an instance member of BrowserWindow for the button widget instead of a global variable - Use notify::is-loading to monitor the WebView load instead of the estimated-load-progress property - Use webkit_web_view_is_loading() to check whether the view loading to change the button icon instead of a string comparison of the gtk stock icon id 920924 1 cgarcia 2013-08-26 01:48:06 -0700 And use the right casts to avoid compile warnings 920925 2 209627 cgarcia 2013-08-26 01:51:00 -0700 Created attachment 209627 Patch 920927 3 209627 svillar 2013-08-26 02:09:35 -0700 Comment on attachment 209627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209627&action=review Patch looks awesome to me. > Tools/ChangeLog:13 > + loading to change the button icon instead of a string nit: an 'is' is missing here? 920945 4 209627 pnormand 2013-08-26 03:21:43 -0700 Comment on attachment 209627 Patch Yep please fix this small nit spotted by Sergio :) 920948 5 cgarcia 2013-08-26 03:30:37 -0700 Committed r154594: <http://trac.webkit.org/changeset/154594> 209627 2013-08-26 01:51:00 -0700 2013-08-26 03:21:43 -0700 Patch mb-issues.diff text/plain 5453 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNGNh ZjhhLi5kY2IxN2VhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjggQEAKIDIwMTMtMDgtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIEltcHJvdmUgdGhlIHN0b3Av cmVsb2FkIGJ1dHRvbiBpbXBsZW1lbnRhdGlvbiBpbiBNaW5pQnJvd3NlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMjkyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBVc2UgYW4gaW5zdGFuY2UgbWVt YmVyIG9mIEJyb3dzZXJXaW5kb3cgZm9yIHRoZSBidXR0b24gd2lkZ2V0CisgICAgICAgICAgaW5z dGVhZCBvZiBhIGdsb2JhbCB2YXJpYWJsZS4KKyAgICAgICAgLSBVc2Ugbm90aWZ5Ojppcy1sb2Fk aW5nIHRvIG1vbml0b3IgdGhlIFdlYlZpZXcgbG9hZCBpbnN0ZWFkIG9mCisgICAgICAgICAgdGhl IGVzdGltYXRlZC1sb2FkLXByb2dyZXNzIHByb3BlcnR5LgorICAgICAgICAtIFVzZSB3ZWJraXRf d2ViX3ZpZXdfaXNfbG9hZGluZygpIHRvIGNoZWNrIHdoZXRoZXIgdGhlIHZpZXcKKyAgICAgICAg ICBsb2FkaW5nIHRvIGNoYW5nZSB0aGUgYnV0dG9uIGljb24gaW5zdGVhZCBvZiBhIHN0cmluZwor ICAgICAgICAgIGNvbXBhcmlzb24gb2YgdGhlIGd0ayBzdG9jayBpY29uIGlkLgorICAgICAgICAt IFVzZSB0aGUgcmlnaHQgY2FzdHMgdG8gZml4IGNvbXBpbGUgd2FybmluZy4KKworICAgICAgICAq IE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgIChyZWxvYWRPclN0b3BD YWxsYmFjayk6CisgICAgICAgICh3ZWJWaWV3TG9hZFByb2dyZXNzQ2hhbmdlZCk6CisgICAgICAg ICh3ZWJWaWV3SXNMb2FkaW5nQ2hhbmdlZCk6CisgICAgICAgIChicm93c2VyX3dpbmRvd19pbml0 KToKKyAgICAgICAgKGJyb3dzZXJXaW5kb3dDb25zdHJ1Y3RlZCk6CisKKzIwMTMtMDgtMjYgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtd IFNpbGVuY2UgTWluaUJyb3dzZXIgY29tcGlsZSB3YXJuaW5ncyBkdWUgdG8gcmVjZW50IEdUSysg ZGVwcmVjYXRpb25zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjAyOTAKIApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJX aW5kb3cuYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKaW5kZXggYzNk NjllMi4uNTEzMWY2MiAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJX aW5kb3cuYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCkBAIC01 Myw2ICs1Myw3IEBAIHN0cnVjdCBfQnJvd3NlcldpbmRvdyB7CiAgICAgV2ViS2l0V2ViVmlldyAq d2ViVmlldzsKICAgICBHdGtXaWRnZXQgKmRvd25sb2Fkc0JhcjsKICAgICBHZGtQaXhidWYgKmZh dmljb247CisgICAgR3RrV2lkZ2V0ICpyZWxvYWRPclN0b3BCdXR0b247CiAgICAgR3RrV2lkZ2V0 ICpmdWxsU2NyZWVuTWVzc2FnZUxhYmVsOwogICAgIGd1aW50IGZ1bGxTY3JlZW5NZXNzYWdlTGFi ZWxJZDsKIH07CkBAIC02Nyw3ICs2OCw2IEBAIHN0YXRpYyBjb25zdCBnZG91YmxlIG1pbmltdW1a b29tTGV2ZWwgPSAwLjU7CiBzdGF0aWMgY29uc3QgZ2RvdWJsZSBtYXhpbXVtWm9vbUxldmVsID0g MzsKIHN0YXRpYyBjb25zdCBnZG91YmxlIHpvb21TdGVwID0gMS4yOwogc3RhdGljIGdpbnQgd2lu ZG93Q291bnQgPSAwOwotc3RhdGljIEd0a1Rvb2xCdXR0b24qIHJlbG9hZE9yU3RvcEJ1dHRvbiA9 IDA7CiAKIEdfREVGSU5FX1RZUEUoQnJvd3NlcldpbmRvdywgYnJvd3Nlcl93aW5kb3csIEdUS19U WVBFX1dJTkRPVykKIApAQCAtMTA3LDcgKzEwNyw3IEBAIHN0YXRpYyB2b2lkIGFjdGl2YXRlVXJp RW50cnlDYWxsYmFjayhCcm93c2VyV2luZG93ICp3aW5kb3cpCiAKIHN0YXRpYyB2b2lkIHJlbG9h ZE9yU3RvcENhbGxiYWNrKEJyb3dzZXJXaW5kb3cgKndpbmRvdykKIHsKLSAgICBpZiAoIWdfc3Ry Y21wMChndGtfdG9vbF9idXR0b25fZ2V0X3N0b2NrX2lkKHJlbG9hZE9yU3RvcEJ1dHRvbiksIEdU S19TVE9DS19TVE9QKSkKKyAgICBpZiAod2Via2l0X3dlYl92aWV3X2lzX2xvYWRpbmcod2luZG93 LT53ZWJWaWV3KSkKICAgICAgICAgd2Via2l0X3dlYl92aWV3X3N0b3BfbG9hZGluZyh3aW5kb3ct PndlYlZpZXcpOwogICAgIGVsc2UKICAgICAgICAgd2Via2l0X3dlYl92aWV3X3JlbG9hZCh3aW5k b3ctPndlYlZpZXcpOwpAQCAtMTU5LDE0ICsxNTksOCBAQCBzdGF0aWMgdm9pZCB3ZWJWaWV3TG9h ZFByb2dyZXNzQ2hhbmdlZChXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBHUGFyYW1TcGVjICpwc3Bl YwogewogICAgIGdkb3VibGUgcHJvZ3Jlc3MgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2VzdGltYXRl ZF9sb2FkX3Byb2dyZXNzKHdlYlZpZXcpOwogICAgIGd0a19lbnRyeV9zZXRfcHJvZ3Jlc3NfZnJh Y3Rpb24oR1RLX0VOVFJZKHdpbmRvdy0+dXJpRW50cnkpLCBwcm9ncmVzcyk7Ci0KLSAgICBpZiAo cHJvZ3Jlc3MgPiAwLjAgJiYgcHJvZ3Jlc3MgPCAxLjApCi0gICAgICAgIGd0a190b29sX2J1dHRv bl9zZXRfc3RvY2tfaWQocmVsb2FkT3JTdG9wQnV0dG9uLCBHVEtfU1RPQ0tfU1RPUCk7Ci0KLSAg ICBpZiAocHJvZ3Jlc3MgPT0gMS4wKSB7Ci0gICAgICAgIGd0a190b29sX2J1dHRvbl9zZXRfc3Rv Y2tfaWQocmVsb2FkT3JTdG9wQnV0dG9uLCBHVEtfU1RPQ0tfUkVGUkVTSCk7CisgICAgaWYgKHBy b2dyZXNzID09IDEuMCkKICAgICAgICAgZ190aW1lb3V0X2FkZCg1MDAsIChHU291cmNlRnVuYyly ZXNldEVudHJ5UHJvZ3Jlc3MsIHdpbmRvdy0+dXJpRW50cnkpOwotICAgIH0KIH0KIAogc3RhdGlj IHZvaWQgZG93bmxvYWRTdGFydGVkKFdlYktpdFdlYkNvbnRleHQgKndlYkNvbnRleHQsIFdlYktp dERvd25sb2FkICpkb3dubG9hZCwgQnJvd3NlcldpbmRvdyAqd2luZG93KQpAQCAtNDY2LDYgKzQ2 MCwxMiBAQCBzdGF0aWMgdm9pZCBmYXZpY29uQ2hhbmdlZChHT2JqZWN0ICpvYmplY3QsIEdQYXJh bVNwZWMgKnBhcmFtU3BlYywgQnJvd3NlcldpbmRvdwogICAgIHVwZGF0ZVVyaUVudHJ5SWNvbih3 aW5kb3cpOwogfQogCitzdGF0aWMgdm9pZCB3ZWJWaWV3SXNMb2FkaW5nQ2hhbmdlZChHT2JqZWN0 ICpvYmplY3QsIEdQYXJhbVNwZWMgKnBhcmFtU3BlYywgQnJvd3NlcldpbmRvdyAqd2luZG93KQor eworICAgIGdib29sZWFuIGlzTG9hZGluZyA9IHdlYmtpdF93ZWJfdmlld19pc19sb2FkaW5nKHdp bmRvdy0+d2ViVmlldyk7CisgICAgZ3RrX3Rvb2xfYnV0dG9uX3NldF9zdG9ja19pZChHVEtfVE9P TF9CVVRUT04od2luZG93LT5yZWxvYWRPclN0b3BCdXR0b24pLCBpc0xvYWRpbmcgPyBHVEtfU1RP Q0tfU1RPUCA6IEdUS19TVE9DS19SRUZSRVNIKTsKK30KKwogc3RhdGljIHZvaWQgem9vbUluQ2Fs bGJhY2soQnJvd3NlcldpbmRvdyAqd2luZG93KQogewogICAgIGdkb3VibGUgem9vbUxldmVsID0g d2Via2l0X3dlYl92aWV3X2dldF96b29tX2xldmVsKHdpbmRvdy0+d2ViVmlldykgKiB6b29tU3Rl cDsKQEAgLTU4MSwxMSArNTgxLDEyIEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJfd2luZG93X2luaXQo QnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgIGd0a190b29sYmFyX2luc2VydChHVEtfVE9PTEJB Uih0b29sYmFyKSwgaXRlbSwgLTEpOwogICAgIGd0a193aWRnZXRfc2hvdyhHVEtfV0lER0VUKGl0 ZW0pKTsKIAotICAgIHJlbG9hZE9yU3RvcEJ1dHRvbiA9IGd0a190b29sX2J1dHRvbl9uZXdfZnJv bV9zdG9jayhHVEtfU1RPQ0tfUkVGUkVTSCk7Ci0gICAgZ19zaWduYWxfY29ubmVjdF9zd2FwcGVk KHJlbG9hZE9yU3RvcEJ1dHRvbiwgImNsaWNrZWQiLCBHX0NBTExCQUNLKHJlbG9hZE9yU3RvcENh bGxiYWNrKSwgd2luZG93KTsKLSAgICBndGtfdG9vbGJhcl9pbnNlcnQoR1RLX1RPT0xCQVIodG9v bGJhciksIHJlbG9hZE9yU3RvcEJ1dHRvbiwgLTEpOwotICAgIGd0a193aWRnZXRfYWRkX2FjY2Vs ZXJhdG9yKEdUS19XSURHRVQocmVsb2FkT3JTdG9wQnV0dG9uKSwgImNsaWNrZWQiLCBhY2NlbEdy b3VwLCBHREtfS0VZX0Y1LCAwLCBHVEtfQUNDRUxfVklTSUJMRSk7Ci0gICAgZ3RrX3dpZGdldF9z aG93KEdUS19XSURHRVQocmVsb2FkT3JTdG9wQnV0dG9uKSk7CisgICAgaXRlbSA9IGd0a190b29s X2J1dHRvbl9uZXdfZnJvbV9zdG9jayhHVEtfU1RPQ0tfUkVGUkVTSCk7CisgICAgd2luZG93LT5y ZWxvYWRPclN0b3BCdXR0b24gPSBHVEtfV0lER0VUKGl0ZW0pOworICAgIGdfc2lnbmFsX2Nvbm5l Y3Rfc3dhcHBlZChpdGVtLCAiY2xpY2tlZCIsIEdfQ0FMTEJBQ0socmVsb2FkT3JTdG9wQ2FsbGJh Y2spLCB3aW5kb3cpOworICAgIGd0a190b29sYmFyX2luc2VydChHVEtfVE9PTEJBUih0b29sYmFy KSwgaXRlbSwgLTEpOworICAgIGd0a193aWRnZXRfYWRkX2FjY2VsZXJhdG9yKHdpbmRvdy0+cmVs b2FkT3JTdG9wQnV0dG9uLCAiY2xpY2tlZCIsIGFjY2VsR3JvdXAsIEdES19LRVlfRjUsIDAsIEdU S19BQ0NFTF9WSVNJQkxFKTsKKyAgICBndGtfd2lkZ2V0X3Nob3cod2luZG93LT5yZWxvYWRPclN0 b3BCdXR0b24pOwogCiAgICAgR3RrV2lkZ2V0ICp2Ym94ID0gZ3RrX2JveF9uZXcoR1RLX09SSUVO VEFUSU9OX1ZFUlRJQ0FMLCAwKTsKICAgICB3aW5kb3ctPm1haW5Cb3ggPSB2Ym94OwpAQCAtNjE0 LDYgKzYxNSw3IEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dDb25zdHJ1Y3RlZChHT2JqZWN0 ICpnT2JqZWN0KQogICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2luZG93LT53ZWJWaWV3LCAibm90aWZ5 OjpmYXZpY29uIiwgR19DQUxMQkFDSyhmYXZpY29uQ2hhbmdlZCksIHdpbmRvdyk7CiAgICAgZ19z aWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZpZXcsICJlbnRlci1mdWxsc2NyZWVuIiwgR19DQUxM QkFDSyh3ZWJWaWV3RW50ZXJGdWxsU2NyZWVuKSwgd2luZG93KTsKICAgICBnX3NpZ25hbF9jb25u ZWN0KHdpbmRvdy0+d2ViVmlldywgImxlYXZlLWZ1bGxzY3JlZW4iLCBHX0NBTExCQUNLKHdlYlZp ZXdMZWF2ZUZ1bGxTY3JlZW4pLCB3aW5kb3cpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2luZG93 LT53ZWJWaWV3LCAibm90aWZ5Ojppcy1sb2FkaW5nIiwgR19DQUxMQkFDSyh3ZWJWaWV3SXNMb2Fk aW5nQ2hhbmdlZCksIHdpbmRvdyk7CiAKICAgICBnX3NpZ25hbF9jb25uZWN0KHdlYmtpdF93ZWJf dmlld19nZXRfY29udGV4dCh3aW5kb3ctPndlYlZpZXcpLCAiZG93bmxvYWQtc3RhcnRlZCIsIEdf Q0FMTEJBQ0soZG93bmxvYWRTdGFydGVkKSwgd2luZG93KTsKIAo=