120279 2013-08-25 16:28:01 -0700 Elements in a node list of the form element's name getter should not be added to the past names map 2013-08-26 20:45:31 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 120277 120328 1 rniwa rniwa darin eoconnor ian jonlee sam tkent oldest_to_newest 920871 0 209610 rniwa 2013-08-25 16:28:01 -0700 Created attachment 209610 Test case The current HTML5 specification http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-form-nameditem says: 1. Let candidates be a live RadioNodeList object containing all the listed elements whose form owner is the form element that have either an id attribute or a name attribute equal to name, with the exception of input elements whose type attribute is in the Image Button state, in tree order. 2. If candidates is empty, let candidates be a live RadioNodeList object containing all the img elements that are descendants of the form element and that have either an id attribute or a name attribute equal to name, in tree order. 3. If candidates is empty, name is the name of one of the entries in the form element's past names map: return the object associated with name in that map. 4. If candidates contains more than one node, return candidates and abort these steps. 5. Otherwise, candidates contains exactly one node. Add a mapping from name to the node in candidates in the form element's past names map, replacing the previous entry with the same name, if any. 6. Return the node in candidates. Steps 4-5 indicate that we should NOT be adding anything to the past names map when there are multiple elements found in steps 1-3. However, this is not what WebKit or Gekko does. At least both of these engines DO add the first element of those found in steps 1-3 to the past names map even when there are multiple elements at step 4. We need to figure out whether this is a bug in the specification, or we need to change our behavior due to some backward compatibility issues (maybe this is the Trident behavior?). 921121 1 rniwa 2013-08-26 12:12:32 -0700 Confirmed. The specification matches IE10's behavior. 921195 2 tkent 2013-08-26 15:30:21 -0700 Oh, I didn't know this behavior was standardized. So, Blink r156140 [1] was wrong. My test for IE10/IE11 might have been incorrect. [1] http://src.chromium.org/viewvc/blink?view=revision&revision=156140 921199 3 rniwa 2013-08-26 15:37:15 -0700 (In reply to comment #2) > Oh, I didn't know this behavior was standardized. > So, Blink r156140 [1] was wrong. My test for IE10/IE11 might have been incorrect. > > [1] http://src.chromium.org/viewvc/blink?view=revision&revision=156140 Indeed. It'll be really nice to be able to remove this feature but I don't think we can :( We can at least limit the scope. See my latest post on WHATWG: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2013-August/040586.html 921200 4 209683 rniwa 2013-08-26 15:37:19 -0700 Created attachment 209683 Fixes the bug 921318 5 rniwa 2013-08-26 20:45:31 -0700 Committed r154662: <http://trac.webkit.org/changeset/154662> 209610 2013-08-25 16:28:01 -0700 2013-08-25 16:28:01 -0700 Test case multi-element-named-item-should-not-be-added-to-past-named-map.html text/html 768 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGZvcm0+PGlucHV0IHR5cGU9InRleHQiIG5h bWU9ImZvbyI+PGlucHV0IHR5cGU9InRleHQiIG5hbWU9ImZvbyI+PC9mb3JtPgo8c2NyaXB0IHNy Yz0iaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC90cnVuay9MYXlvdXRU ZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CjxzY3JpcHQ+ Cgp2YXIgZm9ybSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2Zvcm0nKTsKc2hvdWxkQmUoImZv cm1bJ2ZvbyddLmxlbmd0aCIsIDIpOwpzaG91bGRCZSgiZm9ybVsnZm9vJ11bMF0iLCAiZm9ybS5m aXJzdENoaWxkIik7CnNob3VsZEJlKCJmb3JtWydmb28nXVsxXSIsICJmb3JtLmxhc3RDaGlsZCIp OwpzaG91bGRCZSgiZm9ybS5sYXN0Q2hpbGQubmFtZSA9ICdiYXInOyBmb3JtWydiYXInXSIsICJm b3JtLmxhc3RDaGlsZCIpOwpzaG91bGRCZSgiZm9ybS5maXJzdENoaWxkLm5hbWUgPSAnYmFyJzsg Zm9ybVsnYmFyJ10ubGVuZ3RoIiwgIjIiKTsKCnNob3VsZEJlVW5kZWZpbmVkKCJmb3JtWydmb28n XSIsICJmb3JtLmZpcnN0Q2hpbGQiKTsKc2hvdWxkTm90QmUoImZvcm1bJ2ZvbyddIiwgImZvcm0u Zmlyc3RDaGlsZCIpOwpzaG91bGROb3RCZSgiZm9ybVsnZm9vJ11bMF0iLCAiZm9ybS5maXJzdENo aWxkIik7CnNob3VsZE5vdEJlKCJmb3JtWydmb28nXVsxXSIsICJmb3JtLmZpcnN0Q2hpbGQiKTsK Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 209683 2013-08-26 15:37:19 -0700 2013-08-26 18:01:52 -0700 Fixes the bug bug-120279-20130826153719.patch text/plain 4779 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDY0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA4LTI2ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVsZW1lbnRzIGluIGEgbm9kZSBs aXN0IG9mIHRoZSBmb3JtIGVsZW1lbnQncyBuYW1lIGdldHRlciBzaG91bGQgYmUgYWRkZWQgdG8g dGhlIHBhc3QgbmFtZXMgbWFwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjAyNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBEb24ndCBhZGQgdGhlIGVsZW1lbnQgaW4gdGhlIG5hbWVkIGl0ZW1zIHRvIHRo ZSBwYXN0IG5hbWVzIG1hcCB3aGVuIHRoZXJlIGFyZSBtdWx0aXBsZSBlbGVtZW50cy4KKyAgICAg ICAgVGhpcyBtYXRjaGVzIElFMTAncyBiZWhhdmlvciBhbmQgdGhlIHNwZWNpZmllZCBiZWhhdmlv ciBpbiBIVE1MNToKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvMjAxMy9XRC1odG1sNTEt MjAxMzA1MjgvZm9ybXMuaHRtbCNkb20tZm9ybS1uYW1lZGl0ZW0KKworICAgICAgICBUZXN0OiBm YXN0L2Zvcm1zL3Bhc3QtbmFtZXMtbWFwLXNob3VsZC1ub3QtY29udGFpbi1ub2RlbGlzdC1pdGVt Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6Z2V0TmFtZWRFbGVtZW50cyk6CisKIDIwMTMtMDgtMjYg IFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgogCiAgICAgICAgIFBhZ2U6OmNv bnNvbGUoKSBzaG91bGQgcmV0dXJuIGEgcmVmZXJlbmNlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNTQ2MzQpCisrKyBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzOSw3ICs2Mzks NyBAQCB2b2lkIEhUTUxGb3JtRWxlbWVudDo6Z2V0TmFtZWRFbGVtZW50cyhjCiAKICAgICAvLyBG SVhNRTogVGhlIHNwZWNpZmljYXRpb24gc2F5cyB3ZSBzaG91bGQgbm90IGFkZCB0aGUgZWxlbWVu dCBmcm9tIHRoZSBwYXN0IHdoZW4gbmFtZXMgbWFwIHdoZW4gbmFtZWRJdGVtcyBpcyBub3QgZW1w dHkuCiAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVudCogZWxlbWVudEZyb21QYXN0ID0gZWxlbWVu dEZyb21QYXN0TmFtZXNNYXAobmFtZSk7Ci0gICAgaWYgKG5hbWVkSXRlbXMuc2l6ZSgpICYmIG5h bWVkSXRlbXMuZmlyc3QoKSAhPSBlbGVtZW50RnJvbVBhc3QpCisgICAgaWYgKG5hbWVkSXRlbXMu c2l6ZSgpID09IDEgJiYgbmFtZWRJdGVtcy5maXJzdCgpICE9IGVsZW1lbnRGcm9tUGFzdCkKICAg ICAgICAgYWRkRWxlbWVudFRvUGFzdE5hbWVzTWFwKHN0YXRpY19jYXN0PEhUTUxGb3JtQ29udHJv bEVsZW1lbnQqPihuYW1lZEl0ZW1zLmZpcnN0KCkuZ2V0KCkpLCBuYW1lKTsKICAgICBlbHNlIGlm IChlbGVtZW50RnJvbVBhc3QgJiYgbmFtZWRJdGVtcy5maW5kKGVsZW1lbnRGcm9tUGFzdCkgPT0g bm90Rm91bmQpCiAgICAgICAgIG5hbWVkSXRlbXMuYXBwZW5kKGVsZW1lbnRGcm9tUGFzdCk7Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTQ2NDUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wOC0yNiAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KKworICAgICAgICBFbGVtZW50cyBpbiBhIG5vZGUgbGlzdCBvZiB0aGUg Zm9ybSBlbGVtZW50J3MgbmFtZSBnZXR0ZXIgc2hvdWxkIGJlIGFkZGVkIHRvIHRoZSBwYXN0IG5h bWVzIG1hcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIwMjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGEgcmVncmVzc2lvbiB0ZXN0LgorCisgICAgICAgICogZmFzdC9mb3Jtcy9wYXN0LW5hbWVz LW1hcC1zaG91bGQtbm90LWNvbnRhaW4tbm9kZWxpc3QtaXRlbS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZm9ybXMvcGFzdC1uYW1lcy1tYXAtc2hvdWxkLW5vdC1jb250YWlu LW5vZGVsaXN0LWl0ZW0uaHRtbDogQWRkZWQuCisKIDIwMTMtMDgtMjYgIFJvYiBCdWlzICA8cnds YnVpc0B3ZWJraXQub3JnPgogCiAgICAgICAgIExvbmVseSBzdG9wIGNyYXNoZXMKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZm9ybXMvcGFzdC1uYW1lcy1tYXAtc2hvdWxkLW5vdC1jb250YWluLW5v ZGVsaXN0LWl0ZW0tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvcGFzdC1uYW1lcy1tYXAtc2hvdWxkLW5vdC1jb250YWluLW5vZGVsaXN0LWl0ZW0tZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wYXN0LW5h bWVzLW1hcC1zaG91bGQtbm90LWNvbnRhaW4tbm9kZWxpc3QtaXRlbS1leHBlY3RlZC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwxNSBAQAorVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBub25l IG9mIGVsZW1lbnRzIGluIGEgbm9kZSBsaXN0IHJldHVybmVkIGJ5IHRoZSBuYW1lZCBnZXR0ZXIg b2YgYSBmb3JtIGVsZW1lbnQgYXJlIGFkZGVkIHRvIHRoZSBwYXN0IG5hbWVzIG1hcCBvZiB0aGUg ZWxlbWVudC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZm9ybVsnZm9v J10ubGVuZ3RoIGlzIDIKK1BBU1MgZm9ybVsnZm9vJ11bMF0gaXMgZm9ybS5maXJzdENoaWxkCitQ QVNTIGZvcm1bJ2ZvbyddWzFdIGlzIGZvcm0ubGFzdENoaWxkCitQQVNTIGZvcm0ubGFzdENoaWxk Lm5hbWUgPSAnYmFyJzsgZm9ybVsnYmFyJ10gaXMgZm9ybS5sYXN0Q2hpbGQKK1BBU1MgZm9ybS5m aXJzdENoaWxkLm5hbWUgPSAnYmFyJzsgZm9ybVsnYmFyJ10ubGVuZ3RoIGlzIDIKK1BBU1MgZm9y bVsnZm9vJ10gaXMgdW5kZWZpbmVkLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcGFzdC1uYW1l cy1tYXAtc2hvdWxkLW5vdC1jb250YWluLW5vZGVsaXN0LWl0ZW0uaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Bhc3QtbmFtZXMtbWFwLXNob3VsZC1ub3QtY29udGFp bi1ub2RlbGlzdC1pdGVtLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3Bhc3QtbmFtZXMtbWFwLXNob3VsZC1ub3QtY29udGFpbi1ub2RlbGlzdC1pdGVtLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K Kzxib2R5PgorPGZvcm0+PGlucHV0IHR5cGU9InRleHQiIG5hbWU9ImZvbyI+PGlucHV0IHR5cGU9 InRleHQiIG5hbWU9ImZvbyI+PC9mb3JtPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbigiVGhpcyB0 ZXN0IGVuc3VyZXMgdGhhdCBub25lIG9mIGVsZW1lbnRzIGluIGEgbm9kZSBsaXN0IHJldHVybmVk IGJ5IHRoZSBuYW1lZCBnZXR0ZXIgb2YgYSBmb3JtIGVsZW1lbnQgYXJlIGFkZGVkIHRvIHRoZSBw YXN0IG5hbWVzIG1hcCBvZiB0aGUgZWxlbWVudC4iKTsKKwordmFyIGZvcm0gPSBkb2N1bWVudC5x dWVyeVNlbGVjdG9yKCdmb3JtJyk7CitzaG91bGRCZSgiZm9ybVsnZm9vJ10ubGVuZ3RoIiwgIjIi KTsKK3Nob3VsZEJlKCJmb3JtWydmb28nXVswXSIsICJmb3JtLmZpcnN0Q2hpbGQiKTsKK3Nob3Vs ZEJlKCJmb3JtWydmb28nXVsxXSIsICJmb3JtLmxhc3RDaGlsZCIpOworc2hvdWxkQmUoImZvcm0u bGFzdENoaWxkLm5hbWUgPSAnYmFyJzsgZm9ybVsnYmFyJ10iLCAiZm9ybS5sYXN0Q2hpbGQiKTsK K3Nob3VsZEJlKCJmb3JtLmZpcnN0Q2hpbGQubmFtZSA9ICdiYXInOyBmb3JtWydiYXInXS5sZW5n dGgiLCAiMiIpOworc2hvdWxkQmVVbmRlZmluZWQoImZvcm1bJ2ZvbyddIiwgImZvcm0uZmlyc3RD aGlsZCIpOworCitmb3JtLnN0eWxlLmRpc3BsYXkgPSAnbm9uZSc7CisKK3ZhciBzdWNjZXNzZnVs bHlQYXJzZWQgPSB0cnVlOworCis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K