120277 2013-08-25 15:52:59 -0700 JSHTMLFormElement::canGetItemsForName needlessly allocates a Vector 2013-08-28 11:39:22 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120279 120432 1 rniwa rniwa commit-queue kling koivisto sam oldest_to_newest 920860 0 rniwa 2013-08-25 15:52:59 -0700 There's no reason for JSHTMLFormElement::canGetItemsForName to be allocating a Vector since it only needs to figure out if there is a named item or not: bool JSHTMLFormElement::canGetItemsForName(ExecState*, HTMLFormElement* form, PropertyName propertyName) { Vector<RefPtr<Node> > namedItems; form->getNamedElements(propertyNameToAtomicString(propertyName), namedItems); return namedItems.size(); } 920863 1 209606 rniwa 2013-08-25 16:03:31 -0700 Created attachment 209606 Cleanup 920890 2 209606 commit-queue 2013-08-25 23:03:58 -0700 Comment on attachment 209606 Cleanup Clearing flags on attachment: 209606 Committed r154586: <http://trac.webkit.org/changeset/154586> 920891 3 commit-queue 2013-08-25 23:04:01 -0700 All reviewed patches have been landed. Closing bug. 209606 2013-08-25 16:03:31 -0700 2013-08-25 23:03:58 -0700 Cleanup bug-120277-20130825160330.patch text/plain 6964 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDU4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEzLTA4LTI1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEpTSFRNTEZvcm1FbGVtZW50Ojpj YW5HZXRJdGVtc0Zvck5hbWUgbmVlZGxlc3NseSBhbGxvY2F0ZXMgYSBWZWN0b3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDI3NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIEhUTUxGb3JtRWxl bWVudDo6aGFzTmFtZWRFbGVtZW50IGFuZCB1c2VkIGl0IGluIEpTSFRNTEZvcm1FbGVtZW50Ojpj YW5HZXRJdGVtc0Zvck5hbWUuCisKKyAgICAgICAgVGhpcyByZXF1aXJlZCBmaXhpbmcgYSBidWcg aW4gSFRNTEZvcm1FbGVtZW50OjpnZXROYW1lZEVsZW1lbnRzIHRoYXQgdGhlIGZpcnN0IGNhbGwg dG8gZ2V0TmFtZWRFbGVtZW50cworICAgICAgICBhZnRlciByZXBsYWNpbmcgYW4gZWxlbWVudCBB IHdpdGggYW5vdGhlciBlbGVtZW50IEIgb2YgdGhlIHNhbWUgbmFtZSBjYXVzZWQgaXQgdG8gZXJy b25lb3VzbHkgYXBwZW5kIEEKKyAgICAgICAgdG8gbmFtZWRJdGVtcyB2aWEgdGhlIGFsaWFzZXMg bWFwcGluZy4gQmVjYXVzZSBnZXROYW1lZEVsZW1lbnRzIHVzZWQgdG8gYmUgYWx3YXlzIGNhbGxl ZCBpbiBwYWlycywgdGhpcworICAgICAgICB3cm9uZyBiZWhhdmlvciB3YXMgbmV2ZXIgdmlzaWJs ZSB0byB0aGUgV2ViLiBGaXhlZCB0aGUgYnVnIGJ5IG5vdCBhZGRpbmcgdGhlIG9sZCBlbGVtZW50 IHRvIG5hbWVkSXRlbQorICAgICAgICB3aGVuIG5hbWVkSXRlbSdzIHNpemUgaXMgMS4KKworICAg ICAgICBBbHNvIHJlbmFtZWQgbV9lbGVtZW50QWxpYXNlcyB0byBtX3Bhc3ROYW1lc01hcCBhbG9u ZyB3aXRoIHJlbGF0ZWQgbWVtYmVyIGZ1bmN0aW9ucy4KKworICAgICAgICBObyBuZXcgdGVzdHMg YXJlIGFkZGVkIHNpbmNlIHRoZXJlIHNob3VsZCBiZSBubyBXZWIgZXhwb3NlZCBiZWhhdmlvcmFs IGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTEZvcm1FbGVtZW50Q3VzdG9t LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTSFRNTEZvcm1FbGVtZW50OjpjYW5HZXRJdGVtc0Zv ck5hbWUpOgorICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6ZWxlbWVudEZyb21QYXN0TmFtZXNNYXApOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50OjphZGRFbGVtZW50VG9QYXN0TmFtZXNNYXApOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50OjpoYXNOYW1lZEVsZW1lbnQpOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50OjpnZXROYW1lZEVsZW1lbnRzKToKKyAgICAg ICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5oOgorCiAyMDEzLTA4LTI1ICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBFbGVtZW50IGNoaWxkIGFuZCBkZXNjZW5k YW50IGl0ZXJhdG9ycwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MRm9y bUVsZW1lbnRDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTSFRNTEZvcm1FbGVtZW50Q3VzdG9tLmNwcAkocmV2aXNpb24gMTU0NTMyKQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MRm9ybUVsZW1lbnRDdXN0b20uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zOSw5ICszOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogYm9vbCBK U0hUTUxGb3JtRWxlbWVudDo6Y2FuR2V0SXRlbXNGb3JOYW1lKEV4ZWNTdGF0ZSosIEhUTUxGb3Jt RWxlbWVudCogZm9ybSwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSkKIHsKLSAgICBWZWN0b3I8 UmVmUHRyPE5vZGU+ID4gbmFtZWRJdGVtczsKLSAgICBmb3JtLT5nZXROYW1lZEVsZW1lbnRzKHBy b3BlcnR5TmFtZVRvQXRvbWljU3RyaW5nKHByb3BlcnR5TmFtZSksIG5hbWVkSXRlbXMpOwotICAg IHJldHVybiBuYW1lZEl0ZW1zLnNpemUoKTsKKyAgICByZXR1cm4gZm9ybS0+aGFzTmFtZWRFbGVt ZW50KHByb3BlcnR5TmFtZVRvQXRvbWljU3RyaW5nKHByb3BlcnR5TmFtZSkpOwogfQogCiBKU1Zh bHVlIEpTSFRNTEZvcm1FbGVtZW50OjpuYW1lR2V0dGVyKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1 ZSBzbG90QmFzZSwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSkKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAJKHJldmlzaW9uIDE1NDUzMikKKysrIFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjExLDM2 ICs2MTEsMzggQEAgYm9vbCBIVE1MRm9ybUVsZW1lbnQ6OmNoZWNrSW52YWxpZENvbnRybwogICAg IHJldHVybiBoYXNJbnZhbGlkQ29udHJvbHM7CiB9CiAKLUhUTUxGb3JtQ29udHJvbEVsZW1lbnQq IEhUTUxGb3JtRWxlbWVudDo6ZWxlbWVudEZvckFsaWFzKGNvbnN0IEF0b21pY1N0cmluZyYgYWxp YXMpCitIVE1MRm9ybUNvbnRyb2xFbGVtZW50KiBIVE1MRm9ybUVsZW1lbnQ6OmVsZW1lbnRGcm9t UGFzdE5hbWVzTWFwKGNvbnN0IEF0b21pY1N0cmluZyYgcGFzdE5hbWUpIGNvbnN0CiB7Ci0gICAg aWYgKGFsaWFzLmlzRW1wdHkoKSB8fCAhbV9lbGVtZW50QWxpYXNlcykKKyAgICBpZiAocGFzdE5h bWUuaXNFbXB0eSgpIHx8ICFtX3Bhc3ROYW1lc01hcCkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAg cmV0dXJuIG1fZWxlbWVudEFsaWFzZXMtPmdldChhbGlhcy5pbXBsKCkpOworICAgIHJldHVybiBt X3Bhc3ROYW1lc01hcC0+Z2V0KHBhc3ROYW1lLmltcGwoKSk7CiB9CiAKLXZvaWQgSFRNTEZvcm1F bGVtZW50OjphZGRFbGVtZW50QWxpYXMoSFRNTEZvcm1Db250cm9sRWxlbWVudCogZWxlbWVudCwg Y29uc3QgQXRvbWljU3RyaW5nJiBhbGlhcykKK3ZvaWQgSFRNTEZvcm1FbGVtZW50OjphZGRFbGVt ZW50VG9QYXN0TmFtZXNNYXAoSFRNTEZvcm1Db250cm9sRWxlbWVudCogZWxlbWVudCwgY29uc3Qg QXRvbWljU3RyaW5nJiBwYXN0TmFtZSkKIHsKLSAgICBpZiAoYWxpYXMuaXNFbXB0eSgpKQorICAg IGlmIChwYXN0TmFtZS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoIW1fZWxl bWVudEFsaWFzZXMpCi0gICAgICAgIG1fZWxlbWVudEFsaWFzZXMgPSBhZG9wdFB0cihuZXcgQWxp YXNNYXApOwotICAgIG1fZWxlbWVudEFsaWFzZXMtPnNldChhbGlhcy5pbXBsKCksIGVsZW1lbnQp OworICAgIGlmICghbV9wYXN0TmFtZXNNYXApCisgICAgICAgIG1fcGFzdE5hbWVzTWFwID0gYWRv cHRQdHIobmV3IFBhc3ROYW1lc01hcCk7CisgICAgbV9wYXN0TmFtZXNNYXAtPnNldChwYXN0TmFt ZS5pbXBsKCksIGVsZW1lbnQpOworfQorCitib29sIEhUTUxGb3JtRWxlbWVudDo6aGFzTmFtZWRF bGVtZW50KGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSkKK3sKKyAgICByZXR1cm4gZWxlbWVudHMo KS0+aGFzTmFtZWRJdGVtKG5hbWUpIHx8IGVsZW1lbnRGcm9tUGFzdE5hbWVzTWFwKG5hbWUpOwog fQogCiB2b2lkIEhUTUxGb3JtRWxlbWVudDo6Z2V0TmFtZWRFbGVtZW50cyhjb25zdCBBdG9taWNT dHJpbmcmIG5hbWUsIFZlY3RvcjxSZWZQdHI8Tm9kZT4gPiYgbmFtZWRJdGVtcykKIHsKKyAgICAv LyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrL211bHRp cGFnZS9mb3Jtcy5odG1sI2RvbS1mb3JtLW5hbWVkaXRlbQogICAgIGVsZW1lbnRzKCktPm5hbWVk SXRlbXMobmFtZSwgbmFtZWRJdGVtcyk7CiAKLSAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50KiBh bGlhc0VsZW1lbnQgPSBlbGVtZW50Rm9yQWxpYXMobmFtZSk7Ci0gICAgaWYgKGFsaWFzRWxlbWVu dCkgewotICAgICAgICBpZiAobmFtZWRJdGVtcy5maW5kKGFsaWFzRWxlbWVudCkgPT0gbm90Rm91 bmQpIHsKLSAgICAgICAgICAgIC8vIFdlIGhhdmUgc2VlbiBpdCBiZWZvcmUgYnV0IGl0IGlzIGdv bmUgbm93LiBTdGlsbCwgd2UgbmVlZCB0byByZXR1cm4gaXQuCi0gICAgICAgICAgICAvLyBGSVhN RTogVGhlIGFib3ZlIGNvbW1lbnQgaXMgbm90IGNsZWFyIGVub3VnaDsgaXQgZG9lcyBub3Qgc2F5 IHdoeSB3ZSBuZWVkIHRvIGRvIHRoaXMuCi0gICAgICAgICAgICBuYW1lZEl0ZW1zLmFwcGVuZChh bGlhc0VsZW1lbnQpOwotICAgICAgICB9Ci0gICAgfQotICAgIGlmIChuYW1lZEl0ZW1zLnNpemUo KSAmJiBuYW1lZEl0ZW1zLmZpcnN0KCkgIT0gYWxpYXNFbGVtZW50KQotICAgICAgICBhZGRFbGVt ZW50QWxpYXMoc3RhdGljX2Nhc3Q8SFRNTEZvcm1Db250cm9sRWxlbWVudCo+KG5hbWVkSXRlbXMu Zmlyc3QoKS5nZXQoKSksIG5hbWUpOworICAgIC8vIEZJWE1FOiBUaGUgc3BlY2lmaWNhdGlvbiBz YXlzIHdlIHNob3VsZCBub3QgYWRkIHRoZSBlbGVtZW50IGZyb20gdGhlIHBhc3Qgd2hlbiBuYW1l cyBtYXAgd2hlbiBuYW1lZEl0ZW1zIGlzIG5vdCBlbXB0eS4KKyAgICBIVE1MRm9ybUNvbnRyb2xF bGVtZW50KiBlbGVtZW50RnJvbVBhc3QgPSBlbGVtZW50RnJvbVBhc3ROYW1lc01hcChuYW1lKTsK KyAgICBpZiAobmFtZWRJdGVtcy5zaXplKCkgJiYgbmFtZWRJdGVtcy5maXJzdCgpICE9IGVsZW1l bnRGcm9tUGFzdCkKKyAgICAgICAgYWRkRWxlbWVudFRvUGFzdE5hbWVzTWFwKHN0YXRpY19jYXN0 PEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqPihuYW1lZEl0ZW1zLmZpcnN0KCkuZ2V0KCkpLCBuYW1l KTsKKyAgICBlbHNlIGlmIChlbGVtZW50RnJvbVBhc3QgJiYgbmFtZWRJdGVtcy5maW5kKGVsZW1l bnRGcm9tUGFzdCkgPT0gbm90Rm91bmQpCisgICAgICAgIG5hbWVkSXRlbXMuYXBwZW5kKGVsZW1l bnRGcm9tUGFzdCk7CiB9CiAKIHZvaWQgSFRNTEZvcm1FbGVtZW50Ojpkb2N1bWVudERpZFJlc3Vt ZUZyb21QYWdlQ2FjaGUoKQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1l bnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5o CShyZXZpc2lvbiAxNTQ1MzIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw2ICs0Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IH5IVE1MRm9ybUVsZW1lbnQoKTsKIAogICAgIFBhc3NSZWZQdHI8SFRNTENvbGxlY3Rpb24+IGVs ZW1lbnRzKCk7CisgICAgYm9vbCBoYXNOYW1lZEVsZW1lbnQoY29uc3QgQXRvbWljU3RyaW5nJik7 CiAgICAgdm9pZCBnZXROYW1lZEVsZW1lbnRzKGNvbnN0IEF0b21pY1N0cmluZyYsIFZlY3RvcjxS ZWZQdHI8Tm9kZT4gPiYpOwogCiAgICAgdW5zaWduZWQgbGVuZ3RoKCkgY29uc3Q7CkBAIC05OCw5 ICs5OSw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgY2hlY2tWYWxpZGl0eSgpOwogCi0gICAgSFRN TEZvcm1Db250cm9sRWxlbWVudCogZWxlbWVudEZvckFsaWFzKGNvbnN0IEF0b21pY1N0cmluZyYp OwotICAgIHZvaWQgYWRkRWxlbWVudEFsaWFzKEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqLCBjb25z dCBBdG9taWNTdHJpbmcmIGFsaWFzKTsKLQogICAgIENoZWNrZWRSYWRpb0J1dHRvbnMmIGNoZWNr ZWRSYWRpb0J1dHRvbnMoKSB7IHJldHVybiBtX2NoZWNrZWRSYWRpb0J1dHRvbnM7IH0KIAogICAg IGNvbnN0IFZlY3RvcjxGb3JtQXNzb2NpYXRlZEVsZW1lbnQqPiYgYXNzb2NpYXRlZEVsZW1lbnRz KCkgY29uc3QgeyByZXR1cm4gbV9hc3NvY2lhdGVkRWxlbWVudHM7IH0KQEAgLTE0MCwxMCArMTM4 LDE0IEBAIHByaXZhdGU6CiAgICAgLy8gYXJlIGFueSBpbnZhbGlkIGNvbnRyb2xzIGluIHRoaXMg Zm9ybS4KICAgICBib29sIGNoZWNrSW52YWxpZENvbnRyb2xzQW5kQ29sbGVjdFVuaGFuZGxlZChW ZWN0b3I8UmVmUHRyPEZvcm1Bc3NvY2lhdGVkRWxlbWVudD4gPiYpOwogCi0gICAgdHlwZWRlZiBI YXNoTWFwPFJlZlB0cjxBdG9taWNTdHJpbmdJbXBsPiwgUmVmUHRyPEhUTUxGb3JtQ29udHJvbEVs ZW1lbnQ+ID4gQWxpYXNNYXA7CisgICAgSFRNTEZvcm1Db250cm9sRWxlbWVudCogZWxlbWVudEZy b21QYXN0TmFtZXNNYXAoY29uc3QgQXRvbWljU3RyaW5nJikgY29uc3Q7CisgICAgdm9pZCBhZGRF bGVtZW50VG9QYXN0TmFtZXNNYXAoSFRNTEZvcm1Db250cm9sRWxlbWVudCosIGNvbnN0IEF0b21p Y1N0cmluZyYgcGFzdE5hbWUpOworCisgICAgLy8gRklYTUU6IFRoaXMgY2FuIGxlYWsgSFRNTEZv cm1Db250cm9sRWxlbWVudHMuCisgICAgdHlwZWRlZiBIYXNoTWFwPFJlZlB0cjxBdG9taWNTdHJp bmdJbXBsPiwgUmVmUHRyPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+ID4gUGFzdE5hbWVzTWFwOwog CiAgICAgRm9ybVN1Ym1pc3Npb246OkF0dHJpYnV0ZXMgbV9hdHRyaWJ1dGVzOwotICAgIE93blB0 cjxBbGlhc01hcD4gbV9lbGVtZW50QWxpYXNlczsKKyAgICBPd25QdHI8UGFzdE5hbWVzTWFwPiBt X3Bhc3ROYW1lc01hcDsKIAogICAgIENoZWNrZWRSYWRpb0J1dHRvbnMgbV9jaGVja2VkUmFkaW9C dXR0b25zOwogCg==