120268 2013-08-25 02:20:55 -0700 [WebKit2] Offsets for WKBundlePageLoaderClient in APIClientTraits are wrong 2013-08-26 11:19:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103377 1 cgarcia webkit-unassigned andersca ap zan oldest_to_newest 920743 0 cgarcia 2013-08-25 02:20:55 -0700 In r129810 a new offset was added for didLayout, but the offset of registerIntentServiceForFrame was added instead. Since then all other offsets look wrong because the last offset of the previous version is used instead of the first offset of the current version. 920744 1 209580 cgarcia 2013-08-25 02:24:10 -0700 Created attachment 209580 Patch I think this will fix the unit tests currently failing in mac 920809 2 zan 2013-08-25 12:04:50 -0700 I can confirm the patch fixes the unit tests on the GTK port. 921022 3 cgarcia 2013-08-26 08:01:44 -0700 Committed r154602: <http://trac.webkit.org/changeset/154602> 921043 4 ap 2013-08-26 09:40:52 -0700 What were the tests failing on Mac? I'm puzzled because this fixed a year old regression, did we have those tests failing for a year? 921098 5 cgarcia 2013-08-26 11:19:47 -0700 (In reply to comment #4) > What were the tests failing on Mac? I'm puzzled because this fixed a year old regression, did we have those tests failing for a year? I think it only affected to clients using a specific version of the API, versions < 6, the test failing were using version 6, and they started to fail when version 7 was added. 209580 2013-08-25 02:24:10 -0700 2013-08-26 07:57:35 -0700 Patch wk2-bundle-page-loader-client-traits.diff text/plain 1588 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMzY5NjljLi41MDMyZmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDgtMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtXZWJLaXQyXSBPZmZzZXRzIGZvciBXS0J1bmRsZVBhZ2VMb2FkZXJDbGll bnQgaW4gQVBJQ2xpZW50VHJhaXRzIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcDogVXNl IGFsd2F5cyB0aGUgZmlyc3QgbWVtYmVyIG9mIGV2ZXJ5CisgICAgICAgIHZlcnNpb24gYXMgdGhl IG9mZnNldCBvZiB0aGUgdmVyc2lvbi4KKwogMjAxMy0wOC0yNSAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgYnVpbGQgZml4IGFm dGVyIHIxNTQ1NjUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50 VHJhaXRzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUElDbGllbnRUcmFpdHMuY3BwCmlu ZGV4IDA0MjYxNjQuLjk1MmFkMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9B UElDbGllbnRUcmFpdHMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUElDbGllbnRU cmFpdHMuY3BwCkBAIC00MCwxMCArNDAsMTAgQEAgY29uc3Qgc2l6ZV90IEFQSUNsaWVudFRyYWl0 czxXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQ+OjppbnRlcmZhY2VTaXplc0J5VmVyc2lvblsKICAg ICBvZmZzZXRvZihXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQsIGRpZExheW91dEZvckZyYW1lKSwK ICAgICBvZmZzZXRvZihXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQsIGRpZEZpbmlzaFByb2dyZXNz KSwKICAgICBvZmZzZXRvZihXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQsIGRpZFJlY2VpdmVJbnRl bnRGb3JGcmFtZV91bmF2YWlsYWJsZSksCi0gICAgb2Zmc2V0b2YoV0tCdW5kbGVQYWdlTG9hZGVy Q2xpZW50LCByZWdpc3RlckludGVudFNlcnZpY2VGb3JGcmFtZV91bmF2YWlsYWJsZSksCiAgICAg b2Zmc2V0b2YoV0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50LCBkaWRMYXlvdXQpLAogICAgIG9mZnNl dG9mKFdLQnVuZGxlUGFnZUxvYWRlckNsaWVudCwgZmVhdHVyZXNVc2VkSW5QYWdlKSwKLSAgICBv ZmZzZXRvZihXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQsIHdpbGxMb2FkRGF0YVJlcXVlc3QpLAor ICAgIG9mZnNldG9mKFdLQnVuZGxlUGFnZUxvYWRlckNsaWVudCwgd2lsbExvYWRVUkxSZXF1ZXN0 KSwKKyAgICBvZmZzZXRvZihXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQsIHdpbGxEZXN0cm95RnJh bWUpLAogICAgIHNpemVvZihXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQpCiB9OwogCg==