120255 2013-08-24 15:40:35 -0700 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type 2013-08-24 16:39:44 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin andersca benjamin cmarcelo commit-queue jberlin oldest_to_newest 920661 0 darin 2013-08-24 15:40:35 -0700 RetainPtr need move constructor for case when argument is a RetainPtr of a different type 920666 1 209561 darin 2013-08-24 16:35:28 -0700 Created attachment 209561 Patch 920667 2 darin 2013-08-24 16:39:44 -0700 Committed r154555: <http://trac.webkit.org/changeset/154555> 209561 2013-08-24 16:35:28 -0700 2013-08-24 16:37:29 -0700 Patch bug-120255-20130824163527.patch text/plain 4707 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU1M2QzZGQyZWYzZmQ2M2MzODJlNWE4 MTFkMDIxNzZkNjI0MzZlMzguLjM4YzYyNGJkZjlhMDY4ZTRhNWE3ZjY4NGZhYWI3MDUwZjhiYzBh NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDgtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldGFpblB0ciBsYWNrcyBtb3ZlIGNvbnN0cnVjdG9yIGZv ciBjYXNlIHdoZW4gYXJndW1lbnQgaXMgYSBSZXRhaW5QdHIgb2YgYSBkaWZmZXJlbnQgdHlwZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMjU1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUmV0 YWluUHRyLmg6IEFkZGVkIG1pc3NpbmcgbW92ZSBjb25zdHJ1Y3RvciwgbW9kZWxlZCBvbiB0aGUg b3RoZXIgbW92ZSBjb25zdHJ1Y3RvciwKKyAgICAgICAgYW5kIHRoZSBvbmUgZnJvbSBSZXRQdHIu CisKIDIwMTMtMDgtMjQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBNYWtlIHRoZSB3b3JsZCBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1JldGFp blB0ci5oIGIvU291cmNlL1dURi93dGYvUmV0YWluUHRyLmgKaW5kZXggNGJmZDE3ZDE2NWUwNGQx YjQ5MDZhNmFhYjE5ZjBkNWMzM2U3YzM5NS4uOGRiNzBkMzQ3YzU3MWRiODZlNmRmY2VhODE0NTIz NjliMzBhMDczMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUmV0YWluUHRyLmgKKysrIGIv U291cmNlL1dURi93dGYvUmV0YWluUHRyLmgKQEAgLTk5LDYgKzk5LDcgQEAgbmFtZXNwYWNlIFdU RiB7CiAKICNpZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUlZBTFVFX1JFRkVSRU5DRVMpCiAgICAg ICAgIFJldGFpblB0cihSZXRhaW5QdHImJiBvKSA6IG1fcHRyKHRvU3RvcmFnZVR5cGUoby5sZWFr UmVmKCkpKSB7IH0KKyAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gUmV0YWluUHRyKFJldGFp blB0cjxVPiYmIG8pIDogbV9wdHIoby5sZWFrUmVmKCkpIHsgfQogI2VuZGlmCiAKICAgICAgICAg Ly8gSGFzaCB0YWJsZSBkZWxldGVkIHZhbHVlcywgd2hpY2ggYXJlIG9ubHkgY29uc3RydWN0ZWQg YW5kIG5ldmVyIGNvcGllZCBvciBkZXN0cm95ZWQuCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGQxYWFmNzI5NjUxNzQzYTMwYjI2NDBjMDc3NWVh NzU5MTRkNzVhOS4uNzE2YWI5NTExYjU4NGIzYmViZWQwMTE3NGRmNWViZjQ4NTI4NjA2NiAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDEzLTA4LTI0ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXRhaW5QdHIgbGFja3MgbW92ZSBjb25zdHJ1Y3RvciBmb3IgY2FzZSB3aGVuIGFyZ3Vt ZW50IGlzIGEgUmV0YWluUHRyIG9mIGEgZGlmZmVyZW50IHR5cGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDI1NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv bnMvUmV0YWluUHRyLm1tOiBBZGRlZCBmb3VyIHRlc3RzIGNvdmVyaW5nIG1vdmUgYXNzaWdubWVu dCBhbmQgY29uc3RydWN0aW9uLgorCiAyMDEzLTA4LTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgdHJlYXQgTlNMb2NhbGl6ZWREZXNjcmlw dGlvbktleSBhbmQgTlNMb2NhbGl6ZWRSZWNvdmVyeVN1Z2dlc3Rpb25FcnJvcktleSBhcyBOU0xv Y2FsaXplZCBtYWNyb3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L25zL1JldGFpblB0ci5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL25zL1JldGFp blB0ci5tbQppbmRleCBhMDM5NzFjNTcxNzYxNWI1ZGU4YWNkMDU4N2NhMDljZjU1ZTRlNGY3Li41 NWEyYzQzOGIxM2IzZjE4YzljZDkxNmM0NWYyODA0YTRjYTkxMjVjIDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9ucy9SZXRhaW5QdHIubW0KKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvbnMvUmV0YWluUHRyLm1tCkBAIC0xLDUgKzEsNSBAQAogLyoK LSAqIENvcHlyaWdodCAoQykgMjAxMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMTEsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0zOSw0ICszOSw4MCBAQCBURVNU KFJldGFpblB0ciwgQWRvcHROUykKICAgICBFWFBFQ1RfRVEoMSwgQ0ZHZXRSZXRhaW5Db3VudChm b28uZ2V0KCkpKTsKIH0KIAorVEVTVChSZXRhaW5QdHIsIE1vdmVBc3NpZ25tZW50RnJvbVNhbWVU eXBlKQoreworICAgIE5TU3RyaW5nICpzdHJpbmcgPSBAImZvbyI7CisgICAgUmV0YWluUHRyPE5T U3RyaW5nPiBwdHI7CisKKyAgICAvLyBUaGlzIHNob3VsZCBpbnZva2UgUmV0YWluUHRyJ3MgbW92 ZSBhc3NpZ25tZW50IG9wZXJhdG9yLgorICAgIHB0ciA9IFJldGFpblB0cjxOU1N0cmluZz4oc3Ry aW5nKTsKKworICAgIEVYUEVDVF9FUShzdHJpbmcsIHB0cik7CisKKyAgICBwdHIgPSAwOworICAg IFJldGFpblB0cjxOU1N0cmluZz4gdGVtcCA9IHN0cmluZzsKKworICAgIC8vIFRoaXMgc2hvdWxk IGludm9rZSBSZXRhaW5QdHIncyBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3IuCisgICAgcHRyID0g c3RkOjptb3ZlKHRlbXApOworCisgICAgRVhQRUNUX0VRKHN0cmluZywgcHRyKTsKKyAgICBFWFBF Q1RfRVEoKE5TU3RyaW5nICopMCwgdGVtcCk7Cit9CisKK1RFU1QoUmV0YWluUHRyLCBNb3ZlQXNz aWdubWVudEZyb21TaW1pbGFyVHlwZSkKK3sKKyAgICBOU011dGFibGVTdHJpbmcgKnN0cmluZyA9 IFtOU011dGFibGVTdHJpbmcgc3RyaW5nV2l0aFVURjhTdHJpbmc6ImZvbyJdOworICAgIFJldGFp blB0cjxOU1N0cmluZz4gcHRyOworCisgICAgLy8gVGhpcyBzaG91bGQgaW52b2tlIFJldGFpblB0 cidzIG1vdmUgYXNzaWdubWVudCBvcGVyYXRvci4KKyAgICBwdHIgPSBSZXRhaW5QdHI8TlNNdXRh YmxlU3RyaW5nPihzdHJpbmcpOworCisgICAgRVhQRUNUX0VRKHN0cmluZywgcHRyKTsKKworICAg IHB0ciA9IDA7CisgICAgUmV0YWluUHRyPE5TTXV0YWJsZVN0cmluZz4gdGVtcCA9IHN0cmluZzsK KworICAgIC8vIFRoaXMgc2hvdWxkIGludm9rZSBSZXRhaW5QdHIncyBtb3ZlIGFzc2lnbm1lbnQg b3BlcmF0b3IuCisgICAgcHRyID0gc3RkOjptb3ZlKHRlbXApOworCisgICAgRVhQRUNUX0VRKHN0 cmluZywgcHRyKTsKKyAgICBFWFBFQ1RfRVEoKE5TU3RyaW5nICopMCwgdGVtcCk7Cit9CisKK1RF U1QoUmV0YWluUHRyLCBDb25zdHJ1Y3Rpb25Gcm9tU2FtZVR5cGUpCit7CisgICAgTlNTdHJpbmcg KnN0cmluZyA9IEAiZm9vIjsKKworICAgIC8vIFRoaXMgc2hvdWxkIGludm9rZSBSZXRhaW5QdHIn cyBtb3ZlIGNvbnN0cnVjdG9yLgorICAgIFJldGFpblB0cjxOU1N0cmluZz4gcHRyID0gc3RkOjpt b3ZlKFJldGFpblB0cjxOU1N0cmluZz4oc3RyaW5nKSk7CisKKyAgICBFWFBFQ1RfRVEoc3RyaW5n LCBwdHIpOworCisgICAgUmV0YWluUHRyPE5TU3RyaW5nPiB0ZW1wID0gc3RyaW5nOworCisgICAg Ly8gVGhpcyBzaG91bGQgaW52b2tlIFJldGFpblB0cidzIG1vdmUgY29uc3RydWN0b3IuCisgICAg UmV0YWluUHRyPE5TU3RyaW5nPiBwdHIyKHN0ZDo6bW92ZSh0ZW1wKSk7CisKKyAgICBFWFBFQ1Rf RVEoc3RyaW5nLCBwdHIyKTsKKyAgICBFWFBFQ1RfRVEoKE5TU3RyaW5nICopMCwgdGVtcCk7Cit9 CisKK1RFU1QoUmV0YWluUHRyLCBDb25zdHJ1Y3Rpb25Gcm9tU2ltaWxhclR5cGUpCit7CisgICAg TlNNdXRhYmxlU3RyaW5nICpzdHJpbmcgPSBbTlNNdXRhYmxlU3RyaW5nIHN0cmluZ1dpdGhVVEY4 U3RyaW5nOiJmb28iXTsKKworICAgIC8vIFRoaXMgc2hvdWxkIGludm9rZSBSZXRhaW5QdHIncyBt b3ZlIGNvbnN0cnVjdG9yLgorICAgIFJldGFpblB0cjxOU1N0cmluZz4gcHRyID0gUmV0YWluUHRy PE5TTXV0YWJsZVN0cmluZz4oc3RyaW5nKTsKKworICAgIEVYUEVDVF9FUShzdHJpbmcsIHB0cik7 CisKKyAgICBSZXRhaW5QdHI8TlNNdXRhYmxlU3RyaW5nPiB0ZW1wID0gc3RyaW5nOworCisgICAg Ly8gVGhpcyBzaG91bGQgaW52b2tlIFJldGFpblB0cidzIG1vdmUgY29uc3RydWN0b3IuCisgICAg UmV0YWluUHRyPE5TU3RyaW5nPiBwdHIyKHN0ZDo6bW92ZSh0ZW1wKSk7CisKKyAgICBFWFBFQ1Rf RVEoc3RyaW5nLCBwdHIyKTsKKyAgICBFWFBFQ1RfRVEoKE5TU3RyaW5nICopMCwgdGVtcCk7Cit9 CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK