120240 2013-08-23 15:32:03 -0700 REGRESSION (r132545): Some PDFs generated by WebKit are blank when viewed in Adobe Reader 2013-08-23 18:09:16 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin simon.fraser oldest_to_newest 920467 0 bdakin 2013-08-23 15:32:03 -0700 http://trac.webkit.org/changeset/132545 caused a regression where some PDFs generated by WebKit are blank when viewed in Adobe Reader. It's pretty strange because they are not blank in other PDF-viewers, but we should be able to special-case PDF. <rdar://problem/14634453> 920468 1 209517 bdakin 2013-08-23 15:40:01 -0700 Created attachment 209517 Patch 920479 2 bdakin 2013-08-23 15:56:37 -0700 Thank you! http://trac.webkit.org/changeset/154528 920520 3 simon.fraser 2013-08-23 18:09:16 -0700 This broke the windows build. 209517 2013-08-23 15:40:01 -0700 2013-08-23 15:48:36 -0700 Patch for-review-os.txt text/plain 7282 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDUyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA4LTIzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTMyNTQ1KTog U29tZSBQREZzIGdlbmVyYXRlZCBieSBXZWJLaXQgYXJlIGJsYW5rIHdoZW4gdmlld2VkIGluIAor ICAgICAgICBBZG9iZSBSZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMDI0MAorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNDYzNDQ1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIGl0IHNvIHRoYXQgd2UgZG9u4oCZ dCB1c2UgdGhlIGluZmluaXRlIHJlY3QgZm9yIHRoZSBQREYgY29udGV4dCwgCisgICAgICAgIGFu ZCBpdCBhZGRzIFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2UgQVBJIHRvIGZpbmQgb3V0IGlmIHRoZSBj dXJyZW50IGNvbnRlbnQgaXMgdGhlIAorICAgICAgICBQREYgY29udGV4dC4gCisKKyAgICAgICAg KiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGlj c0NvbnRleHRDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNsaXBP dXQpOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmg6Cisg ICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UubW06CisKIDIwMTMt MDgtMjMgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBF bGVtZW50VHJhdmVyc2FsIHNvbWUgbW9yZQpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5l eHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlz aW9uIDE1NDQ5OSkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3b3JraW5nIGNv cHkpCkBAIC0xNzA5LDYgKzE3MDksNyBAQCBfaGFzQ2FzZUluc2Vuc2l0aXZlU3VmZml4CiBfc3Ry aW5nSXNDYXNlSW5zZW5zaXRpdmVFcXVhbFRvU3RyaW5nCiBfc3VnZ2VzdGVkRmlsZW5hbWVXaXRo TUlNRVR5cGUKIF93a0NHQ29udGV4dEdldFNob3VsZFNtb290aEZvbnRzCitfd2tDR0NvbnRleHRJ c1BERkNvbnRleHQKIF93a0NHQ29udGV4dFJlc2V0Q2xpcAogX3drQ0dQYXR0ZXJuQ3JlYXRlV2l0 aEltYWdlQW5kVHJhbnNmb3JtCiBfd2tDVFJ1bkdldEluaXRpYWxBZHZhbmNlCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3ND b250ZXh0Q0cuY3BwCShyZXZpc2lvbiAxNTQ0OTkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgz OCw5ICs4MzgsMTAgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsaXBPdXQoY29uc3QgSW50Ugog CiAgICAgLy8gRklYTUU6IFVzaW5nIENHUmVjdEluZmluaXRlIGlzIG11Y2ggZmFzdGVyIHRoYW4g Z2V0dGluZyB0aGUgY2xpcCBib3VuZGluZyBib3guIEhvd2V2ZXIsIGR1ZQogICAgIC8vIHRvIDxy ZGFyOi8vcHJvYmxlbS8xMjU4NDQ5Mj4sIENHUmVjdEluZmluaXRlIGNhbid0IGJlIHVzZWQgd2l0 aCBhbiBhY2NlbGVyYXRlZCBjb250ZXh0IHRoYXQKLSAgICAvLyBoYXMgY2VydGFpbiB0cmFuc2Zv cm1zIHRoYXQgYXJlbid0IGp1c3QgYSB0cmFuc2xhdGlvbiBvciBhIHNjYWxlLgorICAgIC8vIGhh cyBjZXJ0YWluIHRyYW5zZm9ybXMgdGhhdCBhcmVuJ3QganVzdCBhIHRyYW5zbGF0aW9uIG9yIGEg c2NhbGUuIEFuZCBkdWUgdG8gPHJkYXI6Ly9wcm9ibGVtLzE0NjM0NDUzPgorICAgIC8vIHdlIGNh bm5vdCB1c2UgaXQgaW4gZm9yIGEgcHJpbnRpbmcgY29udGV4dCBlaXRoZXIuCiAgICAgY29uc3Qg QWZmaW5lVHJhbnNmb3JtJiBjdG0gPSBnZXRDVE0oKTsKLSAgICBib29sIGNhblVzZUNHUmVjdElu ZmluaXRlID0gIWlzQWNjZWxlcmF0ZWRDb250ZXh0KCkgfHwgKCFjdG0uYigpICYmICFjdG0uYygp KTsKKyAgICBib29sIGNhblVzZUNHUmVjdEluZmluaXRlID0gIXdrQ0dDb250ZXh0SXNQREZDb250 ZXh0KHBsYXRmb3JtQ29udGV4dCgpKSAmJiAoIWlzQWNjZWxlcmF0ZWRDb250ZXh0KCkgfHwgKCFj dG0uYigpICYmICFjdG0uYygpKSk7CiAgICAgQ0dSZWN0IHJlY3RzWzJdID0geyBjYW5Vc2VDR1Jl Y3RJbmZpbml0ZSA/IENHUmVjdEluZmluaXRlIDogQ0dDb250ZXh0R2V0Q2xpcEJvdW5kaW5nQm94 KHBsYXRmb3JtQ29udGV4dCgpKSwgcmVjdCB9OwogICAgIENHQ29udGV4dEJlZ2luUGF0aChwbGF0 Zm9ybUNvbnRleHQoKSk7CiAgICAgQ0dDb250ZXh0QWRkUmVjdHMocGxhdGZvcm1Db250ZXh0KCks IHJlY3RzLCAyKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlU3lz dGVtSW50ZXJmYWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UuaAkocmV2aXNpb24gMTU0NDk5KQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UuaAkod29ya2luZyBjb3B5 KQpAQCAtMjAyLDYgKzIwMiw3IEBAIGV4dGVybiB2b2lkICgqd2tTZXROU1VSTFJlcXVlc3RTaG91 bGRDb24KIGV4dGVybiB2b2lkICgqd2tTZXRCYXNlQ1RNKShDR0NvbnRleHRSZWYsIENHQWZmaW5l VHJhbnNmb3JtKTsKIGV4dGVybiB2b2lkICgqd2tTZXRQYXR0ZXJuUGhhc2VJblVzZXJTcGFjZSko Q0dDb250ZXh0UmVmLCBDR1BvaW50KTsKIGV4dGVybiBDR0FmZmluZVRyYW5zZm9ybSAoKndrR2V0 VXNlclRvQmFzZUNUTSkoQ0dDb250ZXh0UmVmKTsKK2V4dGVybiBib29sICgqd2tDR0NvbnRleHRJ c1BERkNvbnRleHQpKENHQ29udGV4dFJlZik7CiBleHRlcm4gdm9pZCAoKndrU2V0VXBGb250Q2Fj aGUpKCk7CiBleHRlcm4gdm9pZCAoKndrU2lnbmFsQ0ZSZWFkU3RyZWFtRW5kKShDRlJlYWRTdHJl YW1SZWYgc3RyZWFtKTsKIGV4dGVybiB2b2lkICgqd2tTaWduYWxDRlJlYWRTdHJlYW1FcnJvciko Q0ZSZWFkU3RyZWFtUmVmIHN0cmVhbSwgQ0ZTdHJlYW1FcnJvciAqZXJyb3IpOwpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZh Y2UubW0JKHJldmlzaW9uIDE1NDQ5OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9X ZWJDb3JlU3lzdGVtSW50ZXJmYWNlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5Miw3IEBA IHZvaWQgKCp3a1NldERyYWdJbWFnZSkoTlNJbWFnZSosIE5TUG9pbnQKIHZvaWQgKCp3a1NldEJh c2VDVE0pKENHQ29udGV4dFJlZiwgQ0dBZmZpbmVUcmFuc2Zvcm0pOwogdm9pZCAoKndrU2V0UGF0 dGVyblBoYXNlSW5Vc2VyU3BhY2UpKENHQ29udGV4dFJlZiwgQ0dQb2ludCBwb2ludCk7CiBDR0Fm ZmluZVRyYW5zZm9ybSAoKndrR2V0VXNlclRvQmFzZUNUTSkoQ0dDb250ZXh0UmVmKTsKK2Jvb2wg KCp3a0NHQ29udGV4dElzUERGQ29udGV4dCkoQ0dDb250ZXh0UmVmKTsKIHZvaWQgKCp3a1NldFVw Rm9udENhY2hlKSgpOwogdm9pZCAoKndrU2lnbmFsQ0ZSZWFkU3RyZWFtRW5kKShDRlJlYWRTdHJl YW1SZWYgc3RyZWFtKTsKIHZvaWQgKCp3a1NpZ25hbENGUmVhZFN0cmVhbUhhc0J5dGVzKShDRlJl YWRTdHJlYW1SZWYgc3RyZWFtKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDUyNSkKKysr IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTA4LTIzICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBS RUdSRVNTSU9OIChyMTMyNTQ1KTogU29tZSBQREZzIGdlbmVyYXRlZCBieSBXZWJLaXQgYXJlIGJs YW5rIHdoZW4gdmlld2VkIGluIAorICAgICAgICBBZG9iZSBSZWFkZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDI0MAorICAgICAgICAtYW5kIGNv cnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDYzNDQ1Mz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIb29rIHVwIG5ldyBXZWJT eXN0ZW1JbnRlcmZhY2UgQVBJIHRvIGZpbmQgb3V0IGlmIHRoZSBjdXJyZW50IGNvbnRleHQgaXMg dGhlIFBERiAKKyAgICAgICAgY29udGV4dC4gCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L21hYy9XZWJTeXN0ZW1JbnRlcmZhY2UubW06CisgICAgICAgIChJbml0V2ViQ29y ZVN5c3RlbUludGVyZmFjZSk6CisKIDIwMTMtMDgtMjMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gQXNzZXJ0aW9uIGZhaWx1cmVzIHdoZW4gbG9h ZGluZyBYU0wgc3R5bGVzaGVldHMgd2l0aCBOZXR3b3JrUHJvY2VzcwpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViU3lzdGVtSW50ZXJmYWNlLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv bWFjL1dlYlN5c3RlbUludGVyZmFjZS5tbQkocmV2aXNpb24gMTU0NDk5KQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViU3lzdGVtSW50ZXJmYWNlLm1t CSh3b3JraW5nIGNvcHkpCkBAIC03Miw2ICs3Miw3IEBAIHZvaWQgSW5pdFdlYkNvcmVTeXN0ZW1J bnRlcmZhY2Uodm9pZCkKICAgICAgICAgSU5JVChTaWduZWRQdWJsaWNLZXlBbmRDaGFsbGVuZ2VT dHJpbmcpOwogICAgICAgICBJTklUKEdldFByZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVUeXBlKTsK ICAgICAgICAgSU5JVChHZXRVc2VyVG9CYXNlQ1RNKTsKKyAgICAgICAgSU5JVChDR0NvbnRleHRJ c1BERkNvbnRleHQpOwogICAgICAgICBJTklUKEdldFdoZWVsRXZlbnREZWx0YXMpOwogICAgICAg ICBJTklUKEdldE5TRXZlbnRLZXlDaGFyKTsKICAgICAgICAgSU5JVChIaXRUZXN0TWVkaWFVSVBh cnQpOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0NTI1KQorKysgU291cmNlL1dl YktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMt MDgtMjMgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIxMzI1NDUpOiBTb21lIFBERnMgZ2VuZXJhdGVkIGJ5IFdlYktpdCBhcmUgYmxhbmsgd2hl biB2aWV3ZWQgaW4gCisgICAgICAgIEFkb2JlIFJlYWRlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMjQwCisgICAgICAgIC1hbmQgY29ycmVzcG9u ZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE0NjM0NDUzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhvb2sgdXAgbmV3IFdlYlN5c3RlbUlu dGVyZmFjZSBBUEkgdG8gZmluZCBvdXQgaWYgdGhlIGN1cnJlbnQgY29udGV4dCBpcyB0aGUgUERG IAorICAgICAgICBjb250ZXh0LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViU3lzdGVt SW50ZXJmYWNlLm1tOgorICAgICAgICAoSW5pdFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2UpOgorCiAy MDEzLTA4LTIwICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTIwMDI5PiBEb2N1bWVudDo6bWFya2VycygpIHNob3Vs ZCByZXR1cm4gYSByZWZlcmVuY2UKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBw b3J0L1dlYlN5c3RlbUludGVyZmFjZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21h Yy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0ZW1JbnRlcmZhY2UubW0JKHJldmlzaW9uIDE1NDQ5OSkK KysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5t bQkod29ya2luZyBjb3B5KQpAQCAtOTksNiArOTksNyBAQCB2b2lkIEluaXRXZWJDb3JlU3lzdGVt SW50ZXJmYWNlKHZvaWQpCiAgICAgSU5JVChTZXROU1VSTENvbm5lY3Rpb25EZWZlcnNDYWxsYmFj a3MpOwogICAgIElOSVQoU2V0TlNVUkxSZXF1ZXN0U2hvdWxkQ29udGVudFNuaWZmKTsKICAgICBJ TklUKFNldFBhdHRlcm5QaGFzZUluVXNlclNwYWNlKTsKKyAgICBJTklUKENHQ29udGV4dElzUERG Q29udGV4dCk7CiAgICAgSU5JVChHZXRVc2VyVG9CYXNlQ1RNKTsKICAgICBJTklUKFNldFVwRm9u dENhY2hlKTsKICAgICBJTklUKFNpZ25hbENGUmVhZFN0cmVhbUVuZCk7Cg==