120233 2013-08-23 14:02:29 -0700 Let Document keep its RenderView during render tree detach. 2013-08-24 15:14:01 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kangil.han kling kondapallykalyan oldest_to_newest 920439 0 kling 2013-08-23 14:02:29 -0700 Let Document keep its RenderView during render tree detach. 920442 1 209509 kling 2013-08-23 14:04:44 -0700 Created attachment 209509 Patch 920444 2 209509 koivisto 2013-08-23 14:12:21 -0700 Comment on attachment 209509 Patch Search for documentBeingDestroyed() 920573 3 209539 kling 2013-08-24 04:07:07 -0700 Created attachment 209539 Patch v2 Okay, give Document a flag for "render tree being ripped out LOL" mode. 920575 4 209539 koivisto 2013-08-24 04:10:21 -0700 Comment on attachment 209539 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=209539&action=review > Source/WebCore/dom/Document.cpp:2038 > + m_renderTreeBeingDestroyed = true; maybe TemporaryChange<bool>? 920577 5 kling 2013-08-24 04:20:30 -0700 Committed r154542: <http://trac.webkit.org/changeset/154542> 920655 6 209539 darin 2013-08-24 15:12:45 -0700 Comment on attachment 209539 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=209539&action=review > Source/WebCore/dom/Document.cpp:483 > + , m_renderTreeBeingDestroyed(false) I would call this m_isDestroyingRenderTree as in “document is destroying render tree”. > Source/WebCore/dom/Document.h:550 > + bool renderTreeBeingDestroyed() const { return m_renderTreeBeingDestroyed; } I would call this isDestroyingRenderTree() as in “document is destroying render tree”. 920656 7 kling 2013-08-24 15:14:01 -0700 (In reply to comment #6) > (From update of attachment 209539 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209539&action=review > > > Source/WebCore/dom/Document.cpp:483 > > + , m_renderTreeBeingDestroyed(false) > > I would call this m_isDestroyingRenderTree as in “document is destroying render tree”. > > > Source/WebCore/dom/Document.h:550 > > + bool renderTreeBeingDestroyed() const { return m_renderTreeBeingDestroyed; } > > I would call this isDestroyingRenderTree() as in “document is destroying render tree”. Yeah, in retrospect that is a better name. isDetachingRenderTree() is another alternative. 209509 2013-08-23 14:04:44 -0700 2013-08-24 04:07:07 -0700 Patch bug-120233.diff text/plain 1651 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDYwYzQ2Li5lNWI0NTVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMDgtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIExldCBEb2N1bWVudCBrZWVwIGl0cyBSZW5kZXJWaWV3IGR1cmluZyByZW5kZXIgdHJlZSBk ZXRhY2guCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjAyMzM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHByZWhpc3Rvcmlj IGNvZGUgdGhhdCBjbGVhcmVkIERvY3VtZW50J3MgcmVuZGVyZXIgcG9pbnRlciBkdXJpbmcgdHJl ZSBkZXRhY2guCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OmRldGFjaCk6CisKKzIwMTMtMDgtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xp bmdAYXBwbGUuY29tPgorCiAgICAgICAgIExldCBEb2N1bWVudCBrZWVwIGl0cyBSZW5kZXJWaWV3 IGR1cmluZyByZW5kZXIgdHJlZSBhdHRhY2guCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcv Yi8xMjAyMjQ+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGIyNmZhZDkuLmQyYzczNjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMjAxMCw4ICsyMDEwLDYgQEAgdm9pZCBEb2N1 bWVudDo6ZGV0YWNoKCkKICAgICBjbGVhclNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcigpOwog I2VuZGlmCiAKLSAgICBSZW5kZXJPYmplY3QqIHJlbmRlciA9IHJlbmRlcmVyKCk7Ci0KICAgICBk b2N1bWVudFdpbGxCZWNvbWVJbmFjdGl2ZSgpOwogCiAjaWYgRU5BQkxFKFNIQVJFRF9XT1JLRVJT KQpAQCAtMjAyNCw5ICsyMDIyLDYgQEAgdm9pZCBEb2N1bWVudDo6ZGV0YWNoKCkKICAgICAgICAg ICAgIHZpZXctPmRldGFjaEN1c3RvbVNjcm9sbGJhcnMoKTsKIAogICAgIH0KLQotICAgIC8vIGlu ZGljYXRlIGRlc3RydWN0aW9uIG1vZGUsICBpLmUuIGF0dGFjaGVkKCkgYnV0IHJlbmRlcmVyID09 IDAKLSAgICBzZXRSZW5kZXJlcigwKTsKICAgICAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkp CiAgICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKQpAQCAtMjA0NSw4ICsyMDQwLDkgQEAgdm9p ZCBEb2N1bWVudDo6ZGV0YWNoKCkKIAogICAgIHVuc2NoZWR1bGVTdHlsZVJlY2FsYygpOwogCi0g ICAgaWYgKHJlbmRlcikKLSAgICAgICAgcmVuZGVyLT5kZXN0cm95KCk7CisgICAgaWYgKHJlbmRl cmVyKCkpCisgICAgICAgIHJlbmRlcmVyKCktPmRlc3Ryb3koKTsKKyAgICBzZXRSZW5kZXJlcigw KTsKIAogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAgICAgaWYgKG1fdG91Y2hFdmVudFRhcmdl dHMgJiYgbV90b3VjaEV2ZW50VGFyZ2V0cy0+c2l6ZSgpICYmIHBhcmVudERvY3VtZW50KCkpCg== 209539 2013-08-24 04:07:07 -0700 2013-08-24 15:12:45 -0700 Patch v2 bug-120233-v2.diff text/plain 3548 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMzdiZDhjLi44MzQ1ZTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMDgtMjQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIExldCBEb2N1bWVudCBrZWVwIGl0cyBSZW5kZXJWaWV3IGR1cmluZyByZW5kZXIgdHJlZSBk ZXRhY2guCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjAyMzM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAgICAgICBJbnN0ZWFkIG9mIGhhdmluZyAi RG9jdW1lbnQ6OnJlbmRlcmVyKCkgPT0gTlVMTCIgc2lnbmlmeSB0aGF0IHRoZSByZW5kZXIgdHJl ZSBpcyBiZWluZworICAgICAgICB0b3JuIGRvd24sIGdpdmUgRG9jdW1lbnQgYW4gZXhwbGljaXQg ZmxhZyBmb3IgdGhpcyBpbnN0ZWFkLgorCisgICAgICAgIFRoaXMgd2F5LCB3ZSBjYW4ga2VlcCBE b2N1bWVudCdzIFJlbmRlclZpZXcgaW4gcGxhY2UgZHVyaW5nIHRyZWUgZGV0YWNoLgorCisgICAg ICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpEb2N1 bWVudCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6ZGV0YWNoKToKKyAgICAgICAgKiBk b20vRG9jdW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpyZW5kZXJUcmVlQmVp bmdEZXN0cm95ZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCk6CisKIDIw MTMtMDgtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNp bXBsaWZ5IHNvbWUgU2V0dGluZ3MgYWNjZXNzIHdoZXJlIHdlIGhhdmUgYSBGcmFtZSBpbiByZWFj aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGIyNmZhZDkuLmNkNDg3NjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcApAQCAtNDgwLDYgKzQ4MCw3IEBAIERvY3VtZW50OjpEb2N1bWVudChG cmFtZSogZnJhbWUsIGNvbnN0IEtVUkwmIHVybCwgdW5zaWduZWQgZG9jdW1lbnRDbGFzc2VzKQog I2VuZGlmCiAgICAgLCBtX2RpZEFzc29jaWF0ZUZvcm1Db250cm9sc1RpbWVyKHRoaXMsICZEb2N1 bWVudDo6ZGlkQXNzb2NpYXRlRm9ybUNvbnRyb2xzVGltZXJGaXJlZCkKICAgICAsIG1faGFzSW5q ZWN0ZWRQbHVnSW5zU2NyaXB0KGZhbHNlKQorICAgICwgbV9yZW5kZXJUcmVlQmVpbmdEZXN0cm95 ZWQoZmFsc2UpCiB7CiAgICAgaWYgKG1fZnJhbWUpCiAgICAgICAgIHByb3ZpZGVDb250ZXh0RmVh dHVyZXNUb0RvY3VtZW50RnJvbSh0aGlzLCBtX2ZyYW1lLT5wYWdlKCkpOwpAQCAtMjAyNSw5ICsy MDI2LDYgQEAgdm9pZCBEb2N1bWVudDo6ZGV0YWNoKCkKIAogICAgIH0KIAotICAgIC8vIGluZGlj YXRlIGRlc3RydWN0aW9uIG1vZGUsICBpLmUuIGF0dGFjaGVkKCkgYnV0IHJlbmRlcmVyID09IDAK LSAgICBzZXRSZW5kZXJlcigwKTsKLSAgICAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAg ICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKQogICAgICAgICBzZXRGdWxsU2NyZWVuUmVuZGVy ZXIoMCk7CkBAIC0yMDM3LDYgKzIwMzUsOCBAQCB2b2lkIERvY3VtZW50OjpkZXRhY2goKQogICAg IG1fZm9jdXNlZEVsZW1lbnQgPSAwOwogICAgIG1fYWN0aXZlRWxlbWVudCA9IDA7CiAKKyAgICBt X3JlbmRlclRyZWVCZWluZ0Rlc3Ryb3llZCA9IHRydWU7CisKICAgICBmb3IgKEVsZW1lbnQqIGNo aWxkID0gRWxlbWVudFRyYXZlcnNhbDo6Zmlyc3RXaXRoaW4odGhpcyk7IGNoaWxkOyBjaGlsZCA9 IEVsZW1lbnRUcmF2ZXJzYWw6Om5leHRTaWJsaW5nKGNoaWxkKSkKICAgICAgICAgU3R5bGU6OmRl dGFjaFJlbmRlclRyZWUoY2hpbGQpOwogCkBAIC0yMDQ3LDYgKzIwNDcsOSBAQCB2b2lkIERvY3Vt ZW50OjpkZXRhY2goKQogCiAgICAgaWYgKHJlbmRlcikKICAgICAgICAgcmVuZGVyLT5kZXN0cm95 KCk7CisgICAgc2V0UmVuZGVyZXIoMCk7CisKKyAgICBtX3JlbmRlclRyZWVCZWluZ0Rlc3Ryb3ll ZCA9IGZhbHNlOwogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICAgICBpZiAobV90b3VjaEV2 ZW50VGFyZ2V0cyAmJiBtX3RvdWNoRXZlbnRUYXJnZXRzLT5zaXplKCkgJiYgcGFyZW50RG9jdW1l bnQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggNWUxNmVkYi4uNGVlODZiMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmgKQEAgLTU0Nyw2ICs1NDcsOCBAQCBwdWJsaWM6CiAgICAgICAgIE5vZGU6OnNl dFJlbmRlcmVyKHJlbmRlcmVyKTsKICAgICB9CiAKKyAgICBib29sIHJlbmRlclRyZWVCZWluZ0Rl c3Ryb3llZCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVuZGVyVHJlZUJlaW5nRGVzdHJveWVkOyB9CisK ICAgICBBWE9iamVjdENhY2hlKiBleGlzdGluZ0FYT2JqZWN0Q2FjaGUoKSBjb25zdDsKICAgICBB WE9iamVjdENhY2hlKiBheE9iamVjdENhY2hlKCkgY29uc3Q7CiAgICAgdm9pZCBjbGVhckFYT2Jq ZWN0Q2FjaGUoKTsKQEAgLTE1NTgsNiArMTU2MCw3IEBAIHByaXZhdGU6CiAgICAgSGFzaFNldDxS ZWZQdHI8RWxlbWVudD4gPiBtX2Fzc29jaWF0ZWRGb3JtQ29udHJvbHM7CiAKICAgICBib29sIG1f aGFzSW5qZWN0ZWRQbHVnSW5zU2NyaXB0OworICAgIGJvb2wgbV9yZW5kZXJUcmVlQmVpbmdEZXN0 cm95ZWQ7CiB9OwogCiBpbmxpbmUgdm9pZCBEb2N1bWVudDo6bm90aWZ5UmVtb3ZlUGVuZGluZ1No ZWV0SWZOZWVkZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4 IDcwZGIxMWEuLjAyOTVhMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmgKQEAgLTExNzcsNyArMTE3Nyw3IEBAIHByaXZhdGU6CiAKIGlubGluZSBib29sIFJlbmRlck9i amVjdDo6ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuICFkb2N1 bWVudCgpLT5yZW5kZXJlcigpOworICAgIHJldHVybiBkb2N1bWVudCgpLT5yZW5kZXJUcmVlQmVp bmdEZXN0cm95ZWQoKTsKIH0KIAogaW5saW5lIGJvb2wgUmVuZGVyT2JqZWN0Ojppc0JlZm9yZUNv bnRlbnQoKSBjb25zdAo=