120231 2013-08-23 13:49:47 -0700 Web Inspector: Fix js minification of updated CodeMirror 2013-08-24 08:14:25 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 920431 0 joepeck 2013-08-23 13:49:47 -0700 Oops. We'll have to work around this a bit better in the future, but lets fix this now. 920432 1 webkit-bug-importer 2013-08-23 13:50:13 -0700 <rdar://problem/14822804> 920435 2 209508 joepeck 2013-08-23 13:51:59 -0700 Created attachment 209508 [PATCH] Proposed Fix 920457 3 209508 commit-queue 2013-08-23 14:57:13 -0700 Comment on attachment 209508 [PATCH] Proposed Fix Clearing flags on attachment: 209508 Committed r154524: <http://trac.webkit.org/changeset/154524> 920458 4 commit-queue 2013-08-23 14:57:14 -0700 All reviewed patches have been landed. Closing bug. 920589 5 timothy 2013-08-24 08:14:25 -0700 I tried to submit a similar change to CodeMirror so we would keep having this issue. But he didn't want a workaround. We likely need to switch minifier scripts to fix this. 209508 2013-08-23 13:51:59 -0700 2013-08-23 14:57:12 -0700 [PATCH] Proposed Fix biuld-fix.patch text/plain 2315 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhiMmE1YWMuLjBiNGI5NjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA4LTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IGpz IG1pbmlmaWNhdGlvbiBvZiB1cGRhdGVkIENvZGVNaXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDIzMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdvcmthcm91bmQgYSBqc21pbiBpc3N1ZSB3aXRo ICJyZXR1cm4gLy8udGVzdCgpOyIgbGluZXMgd2hlbgorICAgICAgICBtaW5pZnlpbmcgSmF2YVNj cmlwdCBpbiBwcm9kdWN0aW9uIGJ1aWxkcy4KKworICAgICAgICAqIFNjcmlwdHMvY29weS11c2Vy LWludGVyZmFjZS1yZXNvdXJjZXMuc2g6CisgICAgICAgICogVXNlckludGVyZmFjZS9FeHRlcm5h bC9Db2RlTWlycm9yL2NvZGVtaXJyb3IuanM6CisgICAgICAgICh3aW5kb3cuQ29kZU1pcnJvcik6 CisKIDIwMTMtMDgtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBEZWJ1Z2dlciBzaG91bGQgaGF2ZSBDb250aW51ZSB0byBI ZXJlIENvbnRleHQgTWVudQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvRXh0ZXJuYWwvQ29kZU1pcnJvci9jb2RlbWlycm9yLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRXh0ZXJuYWwvQ29kZU1pcnJvci9jb2RlbWlycm9yLmpz CmluZGV4IGJjMjM4YTIuLjdhNWExZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0V4dGVybmFsL0NvZGVNaXJyb3IvY29kZW1pcnJvci5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9FeHRlcm5hbC9Db2RlTWlycm9yL2Nv ZGVtaXJyb3IuanMKQEAgLTU0NjQsNyArNTQ2NCw4IEBAIHdpbmRvdy5Db2RlTWlycm9yID0gKGZ1 bmN0aW9uKCkgewogICAgIH07CiAgIGVsc2UgaWYgKHNhZmFyaSAmJiAhL1ZlcnNpb25cLyhbNi05 XXxcZFxkKVxiLy50ZXN0KG5hdmlnYXRvci51c2VyQWdlbnQpKQogICAgIHNwYW5BZmZlY3RzV3Jh cHBpbmcgPSBmdW5jdGlvbihzdHIsIGkpIHsKLSAgICAgIHJldHVybiAvXC1bXiBcLT9dfFw/W14g IVwnXCJcKSwuXC1cLzo7XD9cXVx9XS8udGVzdChzdHIuc2xpY2UoaSAtIDEsIGkgKyAxKSk7Cisg ICAgICB2YXIgcmVzdWx0ID0gL1wtW14gXC0/XXxcP1teICFcJ1wiXCksLlwtXC86O1w/XF1cfV0v LnRlc3Qoc3RyLnNsaWNlKGkgLSAxLCBpICsgMSkpOworICAgICAgcmV0dXJuIHJlc3VsdDsKICAg ICB9OwogICBlbHNlIGlmICh3ZWJraXQgJiYgIS9DaHJvbWVcLyg/OjI5fFszLTldXGR8XGRcZFxk KVwuLy50ZXN0KG5hdmlnYXRvci51c2VyQWdlbnQpKQogICAgIHNwYW5BZmZlY3RzV3JhcHBpbmcg PSBmdW5jdGlvbihzdHIsIGkpIHsKQEAgLTU0NzIsNyArNTQ3Myw4IEBAIHdpbmRvdy5Db2RlTWly cm9yID0gKGZ1bmN0aW9uKCkgewogICAgICAgICBpZiAoL1x3Ly50ZXN0KHN0ci5jaGFyQXQoaSAt IDIpKSAmJiAvW15cLT9cLl0vLnRlc3Qoc3RyLmNoYXJBdChpKSkpIHJldHVybiB0cnVlOwogICAg ICAgICBpZiAoaSA+IDIgJiYgL1tcZFwuLF0vLnRlc3Qoc3RyLmNoYXJBdChpIC0gMikpICYmIC9b XGRcLixdLy50ZXN0KHN0ci5jaGFyQXQoaSkpKSByZXR1cm4gZmFsc2U7CiAgICAgICB9Ci0gICAg ICByZXR1cm4gL1t+ISMlJiopPSt9XF18XCJcLj4sOjtdWyh7WzxdfC1bXlwtP1wuXHUyMDEwLVx1 MjAxZlx1MjAyNl18XD9bXHd+YEAjJCVcXiYqKF89K3tbfD48XXzigKZbXHd+YEAjJCVcXiYqKF89 K3tbPjxdLy50ZXN0KHN0ci5zbGljZShpIC0gMSwgaSArIDEpKTsKKyAgICAgIHZhciByZXN1bHQg PSAvW34hIyUmKik9K31cXXxcIlwuPiw6O11bKHtbPF18LVteXC0/XC5cdTIwMTAtXHUyMDFmXHUy MDI2XXxcP1tcd35gQCMkJVxeJiooXz0re1t8PjxdfOKApltcd35gQCMkJVxeJiooXz0re1s+PF0v LnRlc3Qoc3RyLnNsaWNlKGkgLSAxLCBpICsgMSkpOworICAgICAgcmV0dXJuIHJlc3VsdDsKICAg ICB9OwogCiAgIHZhciBrbm93blNjcm9sbGJhcldpZHRoOwo=