120218 2013-08-23 11:54:30 -0700 Web Inspector: Cleanup Inspector Agents a bit 2013-08-24 04:23:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 920332 0 joepeck 2013-08-23 11:54:30 -0700 Some cleanup noticed in Blink that we can do as well: <https://chromium.googlesource.com/chromium/blink/+/8693dcb8ba42a5c225f516c664fb0f453c8ba6f0%5E%21/> 920333 1 webkit-bug-importer 2013-08-23 11:54:44 -0700 <rdar://problem/14821569> 920352 2 209489 joepeck 2013-08-23 12:11:03 -0700 Created attachment 209489 [PATCH] Proposed Fix 920570 3 209489 kling 2013-08-24 04:00:08 -0700 Comment on attachment 209489 [PATCH] Proposed Fix Looks all right. 920578 4 209489 commit-queue 2013-08-24 04:23:07 -0700 Comment on attachment 209489 [PATCH] Proposed Fix Clearing flags on attachment: 209489 Committed r154543: <http://trac.webkit.org/changeset/154543> 920579 5 commit-queue 2013-08-24 04:23:08 -0700 All reviewed patches have been landed. Closing bug. 209489 2013-08-23 12:11:03 -0700 2013-08-24 04:23:07 -0700 [PATCH] Proposed Fix cleanup.patch text/plain 4095 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTBhZjM2Li4xNWZkNTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDgtMjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhbnVwIEluc3BlY3RvciBBZ2VudHMgYSBiaXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDIxOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lcmdlIGh0dHBz Oi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8rLzg2OTNkY2I4YmE0 MmE1YzIyNWY1MTZjNjY0ZmIwZjQ1M2M4YmE2ZjAuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5z cGVjdG9yQ1NTQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTQWdlbnQ6 OmVsZW1lbnRGb3JJZCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQu Y3BwOgorICAgICAgICAoUGFyc2VkU3R5bGVTaGVldDo6UGFyc2VkU3R5bGVTaGVldCk6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZTo6c2V0UHJvcGVydHlUZXh0KToKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3RvclN0eWxlOjpwb3B1bGF0ZUFsbFByb3BlcnRpZXMpOgorICAgICAg ICAoV2ViQ29yZTo6SW5zcGVjdG9yU3R5bGVTaGVldDo6aW5saW5lU3R5bGVTaGVldFRleHQpOgor CiAyMDEzLTA4LTIyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQnJlYWtwb2ludHMgc2hvdWxkIGhhdmUgQXV0b21hdGljYWxs eSBDb250aW51ZSBPcHRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JDU1NBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y Q1NTQWdlbnQuY3BwCmluZGV4IGRhMDE4YjkuLjU2YTcyY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDU1NBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNTU0FnZW50LmNwcApAQCAtMTE0Niw3ICsxMTQ2LDcgQEAg RWxlbWVudCogSW5zcGVjdG9yQ1NTQWdlbnQ6OmVsZW1lbnRGb3JJZChFcnJvclN0cmluZyogZXJy b3JTdHJpbmcsIGludCBub2RlSWQpCiAgICAgICAgICplcnJvclN0cmluZyA9ICJObyBub2RlIHdp dGggZ2l2ZW4gaWQgZm91bmQiOwogICAgICAgICByZXR1cm4gMDsKICAgICB9Ci0gICAgaWYgKG5v ZGUtPm5vZGVUeXBlKCkgIT0gTm9kZTo6RUxFTUVOVF9OT0RFKSB7CisgICAgaWYgKCFub2RlLT5p c0VsZW1lbnROb2RlKCkpIHsKICAgICAgICAgKmVycm9yU3RyaW5nID0gIk5vdCBhbiBlbGVtZW50 IG5vZGUiOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKaW5kZXggMmIwODQxMS4uMmM5ODg4NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNw cApAQCAtNzUsNyArNzUsNiBAQCBjbGFzcyBQYXJzZWRTdHlsZVNoZWV0IHsKIHB1YmxpYzoKICAg ICBQYXJzZWRTdHlsZVNoZWV0KCk7CiAKLSAgICBXZWJDb3JlOjpDU1NTdHlsZVNoZWV0KiBjc3NT dHlsZVNoZWV0KCkgY29uc3QgeyByZXR1cm4gbV9wYXJzZXJPdXRwdXQ7IH0KICAgICBjb25zdCBT dHJpbmcmIHRleHQoKSBjb25zdCB7IEFTU0VSVChtX2hhc1RleHQpOyByZXR1cm4gbV90ZXh0OyB9 CiAgICAgdm9pZCBzZXRUZXh0KGNvbnN0IFN0cmluZyYgdGV4dCk7CiAgICAgYm9vbCBoYXNUZXh0 KCkgY29uc3QgeyByZXR1cm4gbV9oYXNUZXh0OyB9CkBAIC04NiwxNiArODUsMTMgQEAgcHVibGlj OgogCiBwcml2YXRlOgogCi0gICAgLy8gU3R5bGVTaGVldCBjb25zdHJ1Y3RlZCB3aGlsZSBwYXJz aW5nIG1fdGV4dC4KLSAgICBXZWJDb3JlOjpDU1NTdHlsZVNoZWV0KiBtX3BhcnNlck91dHB1dDsK ICAgICBTdHJpbmcgbV90ZXh0OwogICAgIGJvb2wgbV9oYXNUZXh0OwogICAgIE93blB0cjxSdWxl U291cmNlRGF0YUxpc3Q+IG1fc291cmNlRGF0YTsKIH07CiAKIFBhcnNlZFN0eWxlU2hlZXQ6OlBh cnNlZFN0eWxlU2hlZXQoKQotICAgIDogbV9wYXJzZXJPdXRwdXQoMCkKLSAgICAsIG1faGFzVGV4 dChmYWxzZSkKKyAgICA6IG1faGFzVGV4dChmYWxzZSkKIHsKIH0KIApAQCAtMzY5LDkgKzM2NSw2 IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGU6OnNldFByb3BlcnR5VGV4dCh1bnNpZ25lZCBpbmRleCwg Y29uc3QgU3RyaW5nJiBwcm9wZXJ0eVRleHQsCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 CiAKLSAgICBWZWN0b3I8SW5zcGVjdG9yU3R5bGVQcm9wZXJ0eT4gYWxsUHJvcGVydGllczsKLSAg ICBwb3B1bGF0ZUFsbFByb3BlcnRpZXMoJmFsbFByb3BlcnRpZXMpOwotCiAgICAgaWYgKHByb3Bl cnR5VGV4dC5zdHJpcFdoaXRlU3BhY2UoKS5sZW5ndGgoKSkgewogICAgICAgICBSZWZQdHI8TXV0 YWJsZVN0eWxlUHJvcGVydHlTZXQ+IHRlbXBNdXRhYmxlU3R5bGUgPSBNdXRhYmxlU3R5bGVQcm9w ZXJ0eVNldDo6Y3JlYXRlKCk7CiAgICAgICAgIFJlZlB0cjxDU1NSdWxlU291cmNlRGF0YT4gc291 cmNlRGF0YSA9IENTU1J1bGVTb3VyY2VEYXRhOjpjcmVhdGUoQ1NTUnVsZVNvdXJjZURhdGE6OlNU WUxFX1JVTEUpOwpAQCAtNDA2LDYgKzM5OSw5IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGU6OnNldFBy b3BlcnR5VGV4dCh1bnNpZ25lZCBpbmRleCwgY29uc3QgU3RyaW5nJiBwcm9wZXJ0eVRleHQsCiAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKKyAgICBWZWN0b3I8SW5zcGVjdG9yU3R5bGVQ cm9wZXJ0eT4gYWxsUHJvcGVydGllczsKKyAgICBwb3B1bGF0ZUFsbFByb3BlcnRpZXMoJmFsbFBy b3BlcnRpZXMpOworCiAgICAgSW5zcGVjdG9yU3R5bGVUZXh0RWRpdG9yIGVkaXRvcigmYWxsUHJv cGVydGllcywgJm1fZGlzYWJsZWRQcm9wZXJ0aWVzLCB0ZXh0LCBuZXdMaW5lQW5kV2hpdGVzcGFj ZURlbGltaXRlcnMoKSk7CiAgICAgaWYgKG92ZXJ3cml0ZSkgewogICAgICAgICBpZiAoaW5kZXgg Pj0gYWxsUHJvcGVydGllcy5zaXplKCkpIHsKQEAgLTQ4MCw3ICs0NzYsNiBAQCBib29sIEluc3Bl Y3RvclN0eWxlOjpnZXRUZXh0KFN0cmluZyogcmVzdWx0KSBjb25zdAogCiBib29sIEluc3BlY3Rv clN0eWxlOjpwb3B1bGF0ZUFsbFByb3BlcnRpZXMoVmVjdG9yPEluc3BlY3RvclN0eWxlUHJvcGVy dHk+KiByZXN1bHQpIGNvbnN0CiB7Ci0gICAgSGFzaFNldDxTdHJpbmc+IGZvdW5kU2hvcnRoYW5k czsKICAgICBIYXNoU2V0PFN0cmluZz4gc291cmNlUHJvcGVydHlOYW1lczsKICAgICB1bnNpZ25l ZCBkaXNhYmxlZEluZGV4ID0gMDsKICAgICB1bnNpZ25lZCBkaXNhYmxlZExlbmd0aCA9IG1fZGlz YWJsZWRQcm9wZXJ0aWVzLnNpemUoKTsKQEAgLTEzOTcsNyArMTM5Miw3IEBAIGJvb2wgSW5zcGVj dG9yU3R5bGVTaGVldDo6aW5saW5lU3R5bGVTaGVldFRleHQoU3RyaW5nKiByZXN1bHQpIGNvbnN0 CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIE5vZGUqIG93bmVyTm9kZSA9IG1fcGFnZVN0 eWxlU2hlZXQtPm93bmVyTm9kZSgpOwotICAgIGlmICghb3duZXJOb2RlIHx8IG93bmVyTm9kZS0+ bm9kZVR5cGUoKSAhPSBOb2RlOjpFTEVNRU5UX05PREUpCisgICAgaWYgKCFvd25lck5vZGUgfHwg IW93bmVyTm9kZS0+aXNFbGVtZW50Tm9kZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg RWxlbWVudCogb3duZXJFbGVtZW50ID0gdG9FbGVtZW50KG93bmVyTm9kZSk7CiAK