120191 2013-08-22 18:14:22 -0700 Editable text nodes should be have EditableTextRole 2013-10-30 10:24:16 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Windows 7 RESOLVED INVALID InRadar P2 Normal --- 1 roger_fong webkit-unassigned cfleizach roger_fong webkit-bug-importer oldest_to_newest 920065 0 roger_fong 2013-08-22 18:14:22 -0700 previously they were considered static text. 920066 1 webkit-bug-importer 2013-08-22 18:14:47 -0700 <rdar://problem/14815202> 920293 2 roger_fong 2013-08-23 10:49:48 -0700 I'm going to add + if (node()->isTextNode() && node()->isContentEditable()) + return EditableTextRole; to determineAccessibilityRole in AccessibilityNodeObject.cpp 920306 3 cfleizach 2013-08-23 11:17:06 -0700 On the Mac, I believe we mark these are what they normally are (DivRole, or GroupRole) but we mark that the value is writable. VO has some good to handle that then. I think this change is OK, but it will cause some failures in Mac and maybe others because this role will need to be handled the right way to return the right platform specific role 920307 4 209477 roger_fong 2013-08-23 11:17:46 -0700 Created attachment 209477 patch 920313 5 209477 cfleizach 2013-08-23 11:27:30 -0700 Comment on attachment 209477 patch View in context: https://bugs.webkit.org/attachment.cgi?id=209477&action=review > accessibility/AccessibilityNodeObject.cpp:281 > + return EditableTextRole; this should probably go inside the next line so we have if (node()->isTextNode()) { if (node()->isContent()) return Editable return Static } 920319 6 roger_fong 2013-08-23 11:39:49 -0700 (In reply to comment #3) > On the Mac, I believe we mark these are what they normally are (DivRole, or GroupRole) but we mark that the value is writable. VO has some good to handle that then. > > I think this change is OK, but it will cause some failures in Mac and maybe others because this role will need to be handled the right way to return the right platform specific role How about I add a isTextNode() && isContentEditable() check to AccessibleBase (windows specific) where I decide to create the AccessibleText instance. That way I won't have to modify this platform agnostic stuff. That sound okay? 920322 7 cfleizach 2013-08-23 11:41:06 -0700 (In reply to comment #6) > (In reply to comment #3) > > On the Mac, I believe we mark these are what they normally are (DivRole, or GroupRole) but we mark that the value is writable. VO has some good to handle that then. > > > > I think this change is OK, but it will cause some failures in Mac and maybe others because this role will need to be handled the right way to return the right platform specific role > > How about I add a isTextNode() && isContentEditable() check to AccessibleBase (windows specific) where I decide to create the AccessibleText instance. > > That way I won't have to modify this platform agnostic stuff. > That sound okay? Sounds ok 920324 8 roger_fong 2013-08-23 11:42:17 -0700 Will move this check into Windows specific code. 944972 9 209477 bfulgham 2013-10-30 10:24:16 -0700 Comment on attachment 209477 patch Clearing flag to remove from review queue. 209477 2013-08-23 11:17:46 -0700 2013-10-30 10:24:16 -0700 patch patch3.patch text/plain 1147 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDUw MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA4 LTIzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRWRpdGFi bGUgdGV4dCBub2RlcyBzaG91bGQgYmUgaGF2ZSBFZGl0YWJsZVRleHRSb2xlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMTkxLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5Tm9kZU9iamVjdDo6ZGV0ZXJtaW5lQWNjZXNzaWJpbGl0eVJvbGUpOgorCiAyMDEzLTA4LTIz ICBZb2F2IFdlaXNzICA8eW9hdkB5b2F2LndzPgogCiAgICAgICAgIEZpeCBzcmNzZXQncyBpbWFn ZSBjYW5kaWRhdGUgYWxnb3JpdGhtIHdoZW4gRFBSIGV4Y2VlZHMgYWxsIGNhbmRpZGF0ZXMKSW5k ZXg6IGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCShyZXZpc2lvbiAx NTQ0OTYpCisrKyBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjc3LDYgKzI3Nyw4IEBACiAKICAgICBpZiAobm9kZSgpLT5pc0xpbmso KSkKICAgICAgICAgcmV0dXJuIFdlYkNvcmVMaW5rUm9sZTsKKyAgICBpZiAobm9kZSgpLT5pc1Rl eHROb2RlKCkgJiYgbm9kZSgpLT5pc0NvbnRlbnRFZGl0YWJsZSgpKQorICAgICAgICByZXR1cm4g RWRpdGFibGVUZXh0Um9sZTsKICAgICBpZiAobm9kZSgpLT5pc1RleHROb2RlKCkpCiAgICAgICAg IHJldHVybiBTdGF0aWNUZXh0Um9sZTsKICAgICBpZiAobm9kZSgpLT5oYXNUYWdOYW1lKGJ1dHRv blRhZykpCg==