120182 2013-08-22 17:07:17 -0700 Need to disable FakeSYSVSHM when sandboxing is not enabled 2013-08-22 21:38:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P1 Critical --- 1 scooper scooper ap buildbot commit-queue rniwa scooper oldest_to_newest 920023 0 scooper 2013-08-22 17:07:17 -0700 Need to disable FakeSYSVSHM when sandboxing is not enabled 920024 1 209408 scooper 2013-08-22 17:13:38 -0700 Created attachment 209408 Patch 920030 2 scooper 2013-08-22 17:20:01 -0700 To test this, a) Visit Youtube.com (make sure you are not in the HTML5 beta, so that you get flash) b) use activity monitor to verify the flash player is sandboxed c) use "sudo ipcs" to see if there are any shared memory segments registered (there should not be any -- specific none with the key "0x53414e44") d) Go to Safari -> Preferences -> Security -> Manage Webite Settings. Allow the Flash Player to "Run in Unsafe Mode" for Youtube.com. e) Refresh the page f) use activity monitor to see that there is now a flash player that is unsandboxed (note, you may also see a sandboxed player if you did not stop / start Safari) g) use "sudo ipcs" to see that there is now a shared memory segment registered using the key "0x53414e44". 920035 3 209408 buildbot 2013-08-22 17:27:24 -0700 Comment on attachment 209408 Patch Attachment 209408 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1523745 920042 4 209408 buildbot 2013-08-22 17:36:30 -0700 Comment on attachment 209408 Patch Attachment 209408 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1526472 920046 5 209413 scooper 2013-08-22 17:52:45 -0700 Created attachment 209413 Patch 920048 6 scooper 2013-08-22 17:56:44 -0700 Because this uses header information not available on the open source builders I’ve had to guard and include the specific pieces that are necessary. The updated patch will work on both internal and external builders (and create the same result). 920067 7 209413 buildbot 2013-08-22 18:19:37 -0700 Comment on attachment 209413 Patch Attachment 209413 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1546130 920074 8 209413 buildbot 2013-08-22 18:34:29 -0700 Comment on attachment 209413 Patch Attachment 209413 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1555092 920091 9 209426 scooper 2013-08-22 20:05:08 -0700 Created attachment 209426 Patch 920095 10 scooper 2013-08-22 20:08:13 -0700 The file is Objective-C++ but sandbox_check() is a C function, so need to declare it correctly for the open source webkit builders. 920105 11 209426 commit-queue 2013-08-22 21:38:51 -0700 Comment on attachment 209426 Patch Clearing flags on attachment: 209426 Committed r154473: <http://trac.webkit.org/changeset/154473> 920106 12 commit-queue 2013-08-22 21:38:53 -0700 All reviewed patches have been landed. Closing bug. 209408 2013-08-22 17:13:38 -0700 2013-08-22 17:52:43 -0700 Patch bug-120182-20130822171341.patch text/plain 1785 scooper U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODBjYTUyNzk4OTc1ZGYx NWNiZTMyNWU3OTRiOGI2NDVjOWZhYzVjNS4uMGQ1ZWE2ZTJjZTI4YjVjNGQ2ZDhjMGYzOGFiZmQ5 MjJlNzdkMTNhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA4LTIyICBTaW1v biBDb29wZXIgIDxzY29vcGVyQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHRvIGRpc2FibGUg RmFrZVNZU1ZTSE0gd2hlbiBzYW5kYm94aW5nIGlzIG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAxODIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE0ODE0NDYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gbm90IGluIGEgc2FuZGJveCBkbyBub3QgZW5hYmxlIHRoZSBGYWtl U1lTVlNISU0uIFRoaXMKKyAgICAgICAgYWxsb3dzIExvY2FsQ29ubmVjdGlvbiB0byB3b3JrIHdo ZW4gRmxhc2ggUGxheWVyIGlzIHJ1biBpbgorICAgICAgICAiVW5zYWZlIE1vZGUiLgorCisgICAg ICAgICogUGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc1NoaW0ubW06CisgICAgICAgIChX ZWJLaXQ6OnNoaW1fZGlzYWJsZWQpOgorCiAyMDEzLTA4LTIxICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgbnVsbC1kZXJlZiB1bmRlciBX ZWJEcmFnQ2xpZW50OjpzdGFydERyYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdp blByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NTaGltLm1tIGIvU291cmNlL1dlYktpdDIvUGx1Z2lu UHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc1NoaW0ubW0KaW5kZXggMGM0YjdmY2EyNjBiMjM2MjVk NzZkMGFlYjJkYmQ3MTk4YjkyNzhkMi4uNzBlZTY5OWE3Nzc5MGNlNWJiMDdiYjU2NDZiYmI1MGM1 Yzk3OWNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMvUGx1 Z2luUHJvY2Vzc1NoaW0ubW0KKysrIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMv UGx1Z2luUHJvY2Vzc1NoaW0ubW0KQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlIDxzeXMvc2ht Lmg+CiAjaW5jbHVkZSA8c3lzL2lwYy5oPgogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CisjaW5jbHVk ZSA8c2FuZGJveC5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtMTc4LDggKzE3OSwxMSBA QCBzdGF0aWMgQm9vbGVhbiBzaGltX2Rpc2FibGVkKHZvaWQpCiAKICAgICAgICAgaWYgKGtleUV4 aXN0c0FuZEhhc1ZhbGlkRm9ybWF0ICYmIHByZWZWYWx1ZSkKICAgICAgICAgICAgIGlzRmFrZVNI TURpc2FibGVkID0gdHJ1ZTsKKyAgICAgICAgZWxzZSBpZiAoc2FuZGJveF9jaGVjayhnZXRwaWQo KSwgTlVMTCwgU0FOREJPWF9GSUxURVJfTk9ORSkgPT0gMSkKKyAgICAgICAgICAgIGlzRmFrZVNI TURpc2FibGVkID0gZmFsc2U7ICAvLyBTYW5kYm94ZWQKICAgICAgICAgZWxzZQotICAgICAgICAg ICAgaXNGYWtlU0hNRGlzYWJsZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIGlzRmFrZVNITURpc2Fi bGVkID0gdHJ1ZTsgICAvLyBOb3QgU2FuZGJveGVkCisKICAgICB9KTsKIAogICAgIHJldHVybiBp c0Zha2VTSE1EaXNhYmxlZDsK 209413 2013-08-22 17:52:45 -0700 2013-08-22 20:05:05 -0700 Patch bug-120182-20130822175249.patch text/plain 2082 scooper U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODBjYTUyNzk4OTc1ZGYx NWNiZTMyNWU3OTRiOGI2NDVjOWZhYzVjNS4uMGQ1ZWE2ZTJjZTI4YjVjNGQ2ZDhjMGYzOGFiZmQ5 MjJlNzdkMTNhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA4LTIyICBTaW1v biBDb29wZXIgIDxzY29vcGVyQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHRvIGRpc2FibGUg RmFrZVNZU1ZTSE0gd2hlbiBzYW5kYm94aW5nIGlzIG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAxODIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE0ODE0NDYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gbm90IGluIGEgc2FuZGJveCBkbyBub3QgZW5hYmxlIHRoZSBGYWtl U1lTVlNISU0uIFRoaXMKKyAgICAgICAgYWxsb3dzIExvY2FsQ29ubmVjdGlvbiB0byB3b3JrIHdo ZW4gRmxhc2ggUGxheWVyIGlzIHJ1biBpbgorICAgICAgICAiVW5zYWZlIE1vZGUiLgorCisgICAg ICAgICogUGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc1NoaW0ubW06CisgICAgICAgIChX ZWJLaXQ6OnNoaW1fZGlzYWJsZWQpOgorCiAyMDEzLTA4LTIxICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgbnVsbC1kZXJlZiB1bmRlciBX ZWJEcmFnQ2xpZW50OjpzdGFydERyYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdp blByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NTaGltLm1tIGIvU291cmNlL1dlYktpdDIvUGx1Z2lu UHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc1NoaW0ubW0KaW5kZXggMGM0YjdmY2EyNjBiMjM2MjVk NzZkMGFlYjJkYmQ3MTk4YjkyNzhkMi4uODEwMDk5ZjBhMjFjZjUyMzU2YzNmMDBiYmI5ZWJiODAz ZGRlZDg4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMvUGx1 Z2luUHJvY2Vzc1NoaW0ubW0KKysrIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMv UGx1Z2luUHJvY2Vzc1NoaW0ubW0KQEAgLTM3LDYgKzM3LDE2IEBACiAjaW5jbHVkZSA8c3lzL2lw Yy5oPgogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAKKyN1bmRlZiBfX0FQUExFX0FQSV9QUklWQVRF CisjaW5jbHVkZSA8c2FuZGJveC5oPgorCisjaWZuZGVmIF9TQU5EQk9YX1BSSVZBVEVfSF8KK2Vu dW0gc2FuZGJveF9maWx0ZXJfdHlwZSB7CisgICAgICAgIFNBTkRCT1hfRklMVEVSX05PTkUsCit9 OworaW50IHNhbmRib3hfY2hlY2socGlkX3QgcGlkLCBjb25zdCBjaGFyICpvcGVyYXRpb24sIGVu dW0gc2FuZGJveF9maWx0ZXJfdHlwZSB0eXBlLCAuLi4pOworI2VuZGlmCisKIG5hbWVzcGFjZSBX ZWJLaXQgewogCiBleHRlcm4gIkMiIHZvaWQgV2ViS2l0UGx1Z2luUHJvY2Vzc1NoaW1Jbml0aWFs aXplKGNvbnN0IFBsdWdpblByb2Nlc3NTaGltQ2FsbGJhY2tzJiBjYWxsYmFja3MpOwpAQCAtMTc4 LDggKzE4OCwxMSBAQCBzdGF0aWMgQm9vbGVhbiBzaGltX2Rpc2FibGVkKHZvaWQpCiAKICAgICAg ICAgaWYgKGtleUV4aXN0c0FuZEhhc1ZhbGlkRm9ybWF0ICYmIHByZWZWYWx1ZSkKICAgICAgICAg ICAgIGlzRmFrZVNITURpc2FibGVkID0gdHJ1ZTsKKyAgICAgICAgZWxzZSBpZiAoc2FuZGJveF9j aGVjayhnZXRwaWQoKSwgTlVMTCwgU0FOREJPWF9GSUxURVJfTk9ORSkgPT0gMSkKKyAgICAgICAg ICAgIGlzRmFrZVNITURpc2FibGVkID0gZmFsc2U7ICAvLyBTYW5kYm94ZWQKICAgICAgICAgZWxz ZQotICAgICAgICAgICAgaXNGYWtlU0hNRGlzYWJsZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIGlz RmFrZVNITURpc2FibGVkID0gdHJ1ZTsgICAvLyBOb3QgU2FuZGJveGVkCisKICAgICB9KTsKIAog ICAgIHJldHVybiBpc0Zha2VTSE1EaXNhYmxlZDsK 209426 2013-08-22 20:05:08 -0700 2013-08-22 21:38:51 -0700 Patch bug-120182-20130822200508.patch text/plain 2093 scooper U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODBjYTUyNzk4OTc1ZGYx NWNiZTMyNWU3OTRiOGI2NDVjOWZhYzVjNS4uMGQ1ZWE2ZTJjZTI4YjVjNGQ2ZDhjMGYzOGFiZmQ5 MjJlNzdkMTNhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA4LTIyICBTaW1v biBDb29wZXIgIDxzY29vcGVyQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHRvIGRpc2FibGUg RmFrZVNZU1ZTSE0gd2hlbiBzYW5kYm94aW5nIGlzIG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAxODIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE0ODE0NDYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gbm90IGluIGEgc2FuZGJveCBkbyBub3QgZW5hYmxlIHRoZSBGYWtl U1lTVlNISU0uIFRoaXMKKyAgICAgICAgYWxsb3dzIExvY2FsQ29ubmVjdGlvbiB0byB3b3JrIHdo ZW4gRmxhc2ggUGxheWVyIGlzIHJ1biBpbgorICAgICAgICAiVW5zYWZlIE1vZGUiLgorCisgICAg ICAgICogUGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc1NoaW0ubW06CisgICAgICAgIChX ZWJLaXQ6OnNoaW1fZGlzYWJsZWQpOgorCiAyMDEzLTA4LTIxICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgbnVsbC1kZXJlZiB1bmRlciBX ZWJEcmFnQ2xpZW50OjpzdGFydERyYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdp blByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NTaGltLm1tIGIvU291cmNlL1dlYktpdDIvUGx1Z2lu UHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc1NoaW0ubW0KaW5kZXggMGM0YjdmY2EyNjBiMjM2MjVk NzZkMGFlYjJkYmQ3MTk4YjkyNzhkMi4uZDgzYTc0Zjk2NWI1OWI3YjRmYmNjMzEyZWMwYWQ0Njhj NTc4ZjIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMvUGx1 Z2luUHJvY2Vzc1NoaW0ubW0KKysrIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMv UGx1Z2luUHJvY2Vzc1NoaW0ubW0KQEAgLTM3LDYgKzM3LDE2IEBACiAjaW5jbHVkZSA8c3lzL2lw Yy5oPgogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAKKyN1bmRlZiBfX0FQUExFX0FQSV9QUklWQVRF CisjaW5jbHVkZSA8c2FuZGJveC5oPgorCisjaWZuZGVmIF9TQU5EQk9YX1BSSVZBVEVfSF8KK2Vu dW0gc2FuZGJveF9maWx0ZXJfdHlwZSB7CisgICAgICAgIFNBTkRCT1hfRklMVEVSX05PTkUsCit9 OworZXh0ZXJuICJDIiBpbnQgc2FuZGJveF9jaGVjayhwaWRfdCBwaWQsIGNvbnN0IGNoYXIgKm9w ZXJhdGlvbiwgZW51bSBzYW5kYm94X2ZpbHRlcl90eXBlIHR5cGUsIC4uLik7CisjZW5kaWYKKwog bmFtZXNwYWNlIFdlYktpdCB7CiAKIGV4dGVybiAiQyIgdm9pZCBXZWJLaXRQbHVnaW5Qcm9jZXNz U2hpbUluaXRpYWxpemUoY29uc3QgUGx1Z2luUHJvY2Vzc1NoaW1DYWxsYmFja3MmIGNhbGxiYWNr cyk7CkBAIC0xNzgsOCArMTg4LDExIEBAIHN0YXRpYyBCb29sZWFuIHNoaW1fZGlzYWJsZWQodm9p ZCkKIAogICAgICAgICBpZiAoa2V5RXhpc3RzQW5kSGFzVmFsaWRGb3JtYXQgJiYgcHJlZlZhbHVl KQogICAgICAgICAgICAgaXNGYWtlU0hNRGlzYWJsZWQgPSB0cnVlOworICAgICAgICBlbHNlIGlm IChzYW5kYm94X2NoZWNrKGdldHBpZCgpLCBOVUxMLCBTQU5EQk9YX0ZJTFRFUl9OT05FKSA9PSAx KQorICAgICAgICAgICAgaXNGYWtlU0hNRGlzYWJsZWQgPSBmYWxzZTsgIC8vIFNhbmRib3hlZAog ICAgICAgICBlbHNlCi0gICAgICAgICAgICBpc0Zha2VTSE1EaXNhYmxlZCA9IGZhbHNlOworICAg ICAgICAgICAgaXNGYWtlU0hNRGlzYWJsZWQgPSB0cnVlOyAgIC8vIE5vdCBTYW5kYm94ZWQKKwog ICAgIH0pOwogCiAgICAgcmV0dXJuIGlzRmFrZVNITURpc2FibGVkOwo=