120174 2013-08-22 15:00:31 -0700 Don't leak registers for redeclared variables 2013-08-23 10:50:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough ggaren oldest_to_newest 919982 0 barraclough 2013-08-22 15:00:31 -0700 We currently always allocate registers for new global variables, but these are wasted when the variable is being redeclared. Only allocate new registers when necessary. 919983 1 209397 barraclough 2013-08-22 15:02:25 -0700 Created attachment 209397 Fix 919995 2 209397 barraclough 2013-08-22 15:40:57 -0700 Comment on attachment 209397 Fix Ooops, self r+! 920000 3 209397 ggaren 2013-08-22 16:02:12 -0700 Comment on attachment 209397 Fix r=me 920294 4 barraclough 2013-08-23 10:50:14 -0700 Committed revision 154466. 209397 2013-08-22 15:02:25 -0700 2013-08-22 16:02:12 -0700 Fix 120174.1.patch text/plain 3521 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0NDYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEzLTA4LTIyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBEb24ndCBsZWFrIHJlZ2lzdGVycyBmb3IgcmVkZWNsYXJlZCB2YXJpYWJsZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDE3NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJl bnRseSBhbHdheXMgYWxsb2NhdGUgcmVnaXN0ZXJzIGZvciBuZXcgZ2xvYmFsIHZhcmlhYmxlcywg YnV0IHRoZXNlIGFyZSB3YXN0ZWQgd2hlbiB0aGUgdmFyaWFibGUgaXMgYmVpbmcgcmVkZWNsYXJl ZC4KKyAgICAgICAgT25seSBhbGxvY2F0ZSBuZXcgcmVnaXN0ZXJzIHdoZW4gbmVjZXNzYXJ5Lgor CisgICAgICAgIE5vIHBlcmZvcm1hbmNlIGltcGFjdC4KKworICAgICAgICAqIGludGVycHJldGVy L0ludGVycHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6SW50ZXJwcmV0ZXI6OmV4ZWN1dGUpOgor ICAgICAgICAqIHJ1bnRpbWUvRXhlY3V0YWJsZS5jcHA6CisgICAgICAgIChKU0M6OlByb2dyYW1F eGVjdXRhYmxlOjppbml0aWFsaXplR2xvYmFsUHJvcGVydGllcyk6CisgICAgICAgICAgICAtIERv bid0IGFsbG9jYXRlIHRoZSByZWdpc3RlciBoZXJlLgorICAgICAgICAqIHJ1bnRpbWUvSlNHbG9i YWxPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6YWRkR2xvYmFsVmFy KToKKyAgICAgICAgICAgIC0gQWxsb2NhdGUgdGhlIHJlZ2lzdGVyIGhlcmUgaW5zdGVhZC4KKwog MjAxMy0wOC0yMiAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDEyOApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0 ZXIuY3BwCShyZXZpc2lvbiAxNTQ0NjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJw cmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MzUsNyArNzM1LDYgQEAg SlNWYWx1ZSBJbnRlcnByZXRlcjo6ZXhlY3V0ZShQcm9ncmFtRXhlYwogICAgICAgICAgICAgSlNP TlBQYXRoLnN3YXAoSlNPTlBEYXRhW2VudHJ5XS5tX3BhdGgpOwogICAgICAgICAgICAgSlNWYWx1 ZSBKU09OUFZhbHVlID0gSlNPTlBEYXRhW2VudHJ5XS5tX3ZhbHVlLmdldCgpOwogICAgICAgICAg ICAgaWYgKEpTT05QUGF0aC5zaXplKCkgPT0gMSAmJiBKU09OUFBhdGhbMF0ubV90eXBlID09IEpT T05QUGF0aEVudHJ5VHlwZURlY2xhcmUpIHsKLSAgICAgICAgICAgICAgICBnbG9iYWxPYmplY3Qt PmFkZFJlZ2lzdGVycygxKTsKICAgICAgICAgICAgICAgICBnbG9iYWxPYmplY3QtPmFkZFZhcihj YWxsRnJhbWUsIEpTT05QUGF0aFswXS5tX3BhdGhFbnRyeU5hbWUpOwogICAgICAgICAgICAgICAg IFB1dFByb3BlcnR5U2xvdCBzbG90OwogICAgICAgICAgICAgICAgIGdsb2JhbE9iamVjdC0+bWV0 aG9kVGFibGUoKS0+cHV0KGdsb2JhbE9iamVjdCwgY2FsbEZyYW1lLCBKU09OUFBhdGhbMF0ubV9w YXRoRW50cnlOYW1lLCBKU09OUFZhbHVlLCBzbG90KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCShyZXZpc2lvbiAxNTQ0NTgpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzkwLDEwICszOTAsNiBAQCBKU09iamVjdCogUHJvZ3JhbUV4ZWN1dGFibGU6OmluaXRpYWxp emVHCiAgICAgY29uc3QgVW5saW5rZWRQcm9ncmFtQ29kZUJsb2NrOjpWYXJpYWJsZURlY2xhdGlv bnMmIHZhcmlhYmxlRGVjbGFyYXRpb25zID0gdW5saW5rZWRDb2RlLT52YXJpYWJsZURlY2xhcmF0 aW9ucygpOwogICAgIGNvbnN0IFVubGlua2VkUHJvZ3JhbUNvZGVCbG9jazo6RnVuY3Rpb25EZWNs YXRpb25zJiBmdW5jdGlvbkRlY2xhcmF0aW9ucyA9IHVubGlua2VkQ29kZS0+ZnVuY3Rpb25EZWNs YXJhdGlvbnMoKTsKIAotICAgIHNpemVfdCBuZXdHbG9iYWxzID0gdmFyaWFibGVEZWNsYXJhdGlv bnMuc2l6ZSgpICsgZnVuY3Rpb25EZWNsYXJhdGlvbnMuc2l6ZSgpOwotICAgIGlmICghbmV3R2xv YmFscykKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgZ2xvYmFsT2JqZWN0LT5hZGRSZWdpc3RlcnMo bmV3R2xvYmFscyk7CiAgICAgQ2FsbEZyYW1lKiBnbG9iYWxFeGVjID0gZ2xvYmFsT2JqZWN0LT5n bG9iYWxFeGVjKCk7CiAKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGZ1bmN0aW9uRGVjbGFy YXRpb25zLnNpemUoKTsgKytpKSB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0dsb2JhbE9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCShyZXZpc2lvbiAxNTQ0NTkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE4Niw3ICsxODYsOSBAQCBpbnQgSlNHbG9iYWxPYmplY3Q6OmFkZEdsb2JhbFZhcihjb25z dCBJCiAgICAgaWYgKGZ1bmN0aW9uTW9kZSA9PSBJc0Z1bmN0aW9uVG9TcGVjaWFsaXplKQogICAg ICAgICBuZXdFbnRyeS5hdHRlbXB0VG9XYXRjaCgpOwogICAgIFN5bWJvbFRhYmxlOjpNYXA6OkFk ZFJlc3VsdCByZXN1bHQgPSBzeW1ib2xUYWJsZSgpLT5hZGQobG9ja2VyLCBpZGVudC5pbXBsKCks IG5ld0VudHJ5KTsKLSAgICBpZiAoIXJlc3VsdC5pc05ld0VudHJ5KSB7CisgICAgaWYgKHJlc3Vs dC5pc05ld0VudHJ5KQorICAgICAgICBhZGRSZWdpc3RlcnMoMSk7CisgICAgZWxzZSB7CiAgICAg ICAgIHJlc3VsdC5pdGVyYXRvci0+dmFsdWUubm90aWZ5V3JpdGUoKTsKICAgICAgICAgaW5kZXgg PSByZXN1bHQuaXRlcmF0b3ItPnZhbHVlLmdldEluZGV4KCk7CiAgICAgfQo=