120151 2013-08-22 01:52:40 -0700 [Qt] DRT bug revealed/caused by r154300 2013-09-02 01:37:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 120595 79666 119995 1 ossy allan.jensen abecsi abrhm allan.jensen barraclough commit-queue hausmann jturcotte kadam ossy sam zarvai oldest_to_newest 919759 0 ossy 2013-08-22 01:52:40 -0700 After https://trac.webkit.org/changeset/154300 all dumpastext test started to fail on Qt WK1 and made Qt WK1 testers exit early after 500 failures. See https://bugs.webkit.org/show_bug.cgi?id=119995#c14 and https://bugs.webkit.org/show_bug.cgi?id=119995#c15 for details. (Just a note: I'm not working on Qt long time ago, so I can't and won't try to fix this bug. I just reported it by courtesy.) But it would be great to fix it if you want greater test coverage than 0% for QtWebKit WK1. The bots can't catch any new regression come from JSC, WebCore, ... from r154300. (Now r154437 is the latest revision.) 919772 1 allan.jensen 2013-08-22 03:21:00 -0700 It seems that QtInstance never had a getOwnPropertyDescriptor implementation but had a getOwnPropertySlot implementation. This means the behavior of getOwnPropertyDescriptor changed after it got implemented using getOwnPropertySlot. 919804 2 209348 allan.jensen 2013-08-22 05:01:39 -0700 Created attachment 209348 Patch 919805 3 commit-queue 2013-08-22 05:04:28 -0700 Attachment 209348 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp']" exit_code: 1 Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:776: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 919820 4 allan.jensen 2013-08-22 05:45:15 -0700 Committed r154444: <http://trac.webkit.org/changeset/154444> 209348 2013-08-22 05:01:39 -0700 2013-08-22 05:31:14 -0700 Patch bug-120151-20130822140137.patch text/plain 2594 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MzgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjM5NjJiOTMwMTBjNmI5NTIzMDZjNjkwZWY5OTJmZTZj ODNiMDczMC4uNzZiODRkNzZkMWNkMDg3ODVkNzIzMTBlNjg2MzY4ZGJlNGQ5MTZiYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTA4LTIyICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgorCisgICAgICAgIFtRdF0gRFJUIGJ1ZyByZXZlYWxlZC9jYXVzZWQgYnkgcjE1NDMw MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMTUx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2Ug UXRJbnN0YW5jZSBoYWQgYW4gaW1wbGVtZW50YXRpb24gb2YgZ2V0T3duUHJvcGVydHlTbG90IGFu ZCBub3QgZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yLAorICAgICAgICB0aGUgYmVoYXZpb3Igb2Yg Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yIGNoYW5nZWQgd2hlbiBpdCBnb3QgaW1wbGVtZW50ZWQg dXNpbmcgZ2V0T3duUHJvcGVydHlTbG90CisgICAgICAgIGluIHIxNTQzMDAuCisKKyAgICAgICAg RFJUIHJlbGllZCBvbiBnZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IgcmV0dXJuaW5nIHVuZGVmaW5l ZCBmb3IgSlMgc2V0IHByb3BlcnRpZXMgdG8gZGlzdGluZ3Vpc2gKKyAgICAgICAgYmV0d2VlbiBu YXRpdmUgUXQgbWV0aG9kcyBhbmQgSlNDIGJvdW5kIG1ldGhvZHMuIFRoaXMgcGF0Y2ggY2hhbmdl cyB0aGUgY2hlY2sgdG8gc2VlIGlmIHRoZSAKKyAgICAgICAgcHJvcGVydHkgaXMgd3JpdGFibGUg c2luY2UgdGhlIFF0IG1ldGhvZHMgYXJlIFJlYWRPbmx5LgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZTo6 aW5pdEpTT2JqZWN0cyk6CisKIDIwMTMtMDgtMjAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBMaW5raW5nIGZpeCBmb3IgV2lu NjQuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0 LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCmluZGV4 IDEzNDYyMTQzZDkzYmVmZmQxMDM1NGFmZGRhNzAyY2NhZGM2YWEyNmIuLjUwNjJkZGUzZDliNzcw YmZlNWU2YTkwMzk2ODc3MmQ3NGM1ZjI0MTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0R1bXBSZW5kZXJUcmVlUXQuY3BwCkBAIC03NzMsNyArNzczLDcgQEAgdm9pZCBEdW1wUmVuZGVy VHJlZTo6aW5pdEpTT2JqZWN0cygpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIgICAgfVxu IgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiZm9yICh2YXIgcHJvcCBpbiB0aGlzLmpzY0Jh c2VkVGVzdFJ1bm5lcikge1xuIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiICAgIHZhciBw ZCA9IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IodGhpcy5xdEJhc2VkVGVzdFJ1bm5l ciwgcHJvcCk7XG4iCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIgICAgaWYgKHBkICE9PSB1 bmRlZmluZWQpIGNvbnRpbnVlO1xuIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiICAgIGlm IChwZCAhPT0gdW5kZWZpbmVkICYmICFwZC53cml0YWJsZSkgY29udGludWU7XG4iCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICIgICAgcGQgPSBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlw dG9yKHRoaXMuanNjQmFzZWRUZXN0UnVubmVyLCBwcm9wKTtcbiIKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIiAgICB0aGlzLnF0QmFzZWRUZXN0UnVubmVyW3Byb3BdID0gYmluZCh0aGlzLmpz Y0Jhc2VkVGVzdFJ1bm5lcltwcm9wXSwgdGhpcy5qc2NCYXNlZFRlc3RSdW5uZXIpO1xuIgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAifVxuIgo=