<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>120133</bug_id>
          
          <creation_ts>2013-08-21 13:23:29 -0700</creation_ts>
          <short_desc>Remove support for the hspace/vspace attributes on table</short_desc>
          <delta_ts>2022-08-25 12:33:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tables</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=244279</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BrowserCompat, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Pieters (:zcorpan)">zcorpan</reporter>
          <assigned_to name="Ahmad Saleem">ahmad.saleem792</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>karlcow</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
    
    <cc>mathias</cc>
    
    <cc>rniwa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>webkit.bugzilla</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>919600</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Pieters (:zcorpan)">zcorpan</who>
    <bug_when>2013-08-21 13:23:29 -0700</bug_when>
    <thetext>WebKit supports vspace and hspace attributes on &lt;table&gt; while IE doesn&apos;t and Gecko only does in quirks mode and they are considering dropping that, too.

See https://bugzilla.mozilla.org/show_bug.cgi?id=725646

Compatibility analysis in https://bugzilla.mozilla.org/show_bug.cgi?id=725646#c14 and #c15 (summary: 4 out of top 53,000 sites&apos; front pages have minor visual difference if vspace/hspace on table is dropped)

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=277080</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271454</commentid>
    <comment_count>1</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2017-01-30 15:53:35 -0800</bug_when>
    <thetext>*** Bug 167612 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271455</commentid>
    <comment_count>2</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2017-01-30 15:54:01 -0800</bug_when>
    <thetext>See https://github.com/whatwg/html/pull/13</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1892279</commentid>
    <comment_count>3</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-08-18 12:05:14 -0700</bug_when>
    <thetext>Webkit still support &apos;hspace&apos; and &apos;vspace&apos;:

https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L330

Chrome / Blink removed it in 2015:

https://src.chromium.org/viewvc/blink?view=revision&amp;revision=190025

Safari also fail following WPT tests:

https://wpt.fyi/results/html/rendering/non-replaced-elements/tables?label=master&amp;label=experimental&amp;aligned&amp;view=subtest&amp;q=table-vspace-hspace

Also Safari 15.6.1 on macOS 12.5.1 render this test case (from Chrome bug - Comment 9) different compared to Chrome Canary 106 and Firefox Nightly 105:

http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2984

Just wanted to share updated test results. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1893161</commentid>
    <comment_count>4</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-08-22 23:46:06 -0700</bug_when>
    <thetext>I will work on it later tonight.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1893215</commentid>
    <comment_count>5</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-08-23 04:19:24 -0700</bug_when>
    <thetext>https://github.com/WebKit/WebKit/pull/3573</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1893782</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-08-25 12:32:34 -0700</bug_when>
    <thetext>Committed 253788@main (6676a3759ed3): &lt;https://commits.webkit.org/253788@main&gt;

Reviewed commits have been landed. Closing PR #3631 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1893783</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-08-25 12:33:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/99150785&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>