<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>120131</bug_id>
          
          <creation_ts>2013-08-21 12:52:22 -0700</creation_ts>
          <short_desc>REGRESSION (r154022): webkitbot failed to make a changelog for a revert in https://bugs.webkit.org/show_bug.cgi?id=120129</short_desc>
          <delta_ts>2013-08-22 00:25:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>rniwa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>919586</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-08-21 12:52:22 -0700</bug_when>
    <thetext>In https://bugs.webkit.org/show_bug.cgi?id=120129 I requested a revert of http://trac.webkit.org/changeset/154399.

webkitbot made the bug and the patch, but the patch had lots of OOPS in it (in fact it looks like it hasn&apos;t been modified at all!).

This is not useful.

Is this because the changelog format changed recently? Or something else?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>919591</commentid>
    <comment_count>1</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-08-21 13:02:57 -0700</bug_when>
    <thetext>update_with_unreviewed_message looks for a line that no longer exists:

def update_with_unreviewed_message(self, message):
        first_boilerplate_line_regexp = re.compile(
                &quot;%sNeed a short description \(OOPS!\)\.&quot; % self._changelog_indent)

Dino&apos;s change makes it look like this:

&lt;Need the bug URL (OOPS!)&gt; Need a short description (OOPS!)

Which doesn&apos;t match anymore. I&apos;ll fix this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>919601</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-08-21 13:25:36 -0700</bug_when>
    <thetext>Actually, I&apos;m going to roll out the original patch. I don&apos;t like the new format enough to spend the time to fix this, the original author can do it if they want :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>919602</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-08-21 13:26:18 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=119766 is the bug that changed this, btw.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>919748</commentid>
    <comment_count>4</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-08-22 00:25:10 -0700</bug_when>
    <thetext>*** Bug 119894 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>