120127 2013-08-21 11:50:34 -0700 Remove JSObject::propertyIsEnumerable 2013-08-21 12:50:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 919557 0 barraclough 2013-08-21 11:50:34 -0700 This method just a wart. Unnecessary const-casting, unnecessary function call, and less code if we remove. 919559 1 209290 barraclough 2013-08-21 11:52:48 -0700 Created attachment 209290 Fix 919567 2 209290 sam 2013-08-21 12:01:45 -0700 Comment on attachment 209290 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=209290&action=review > Source/JavaScriptCore/ChangeLog:8 > + This method just a wart. This sentence just a wart. > Source/JavaScriptCore/ChangeLog:9 > + Unnecessary const-casting, unnecessary function call, and less code if we remove. This sentence would be less words if we remove. > Source/JavaScriptCore/runtime/ObjectPrototype.cpp:188 > + PropertyDescriptor descriptor; > + bool enumerable = thisObject->getOwnPropertyDescriptor(exec, propertyName, descriptor) && descriptor.enumerable(); > + return JSValue::encode(jsBoolean(enumerable)); This should should have a FIXME saying to use getOwnPropertySlot when it no longer has the global object hack. 919585 3 barraclough 2013-08-21 12:50:15 -0700 Committed revision 154405. 209290 2013-08-21 11:52:48 -0700 2013-08-21 12:01:45 -0700 Fix 120127.1.patch text/plain 3572 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0NDAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTA4LTIxICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMTI3 CisgICAgICAgIFJlbW92ZSBKU09iamVjdDo6cHJvcGVydHlJc0VudW1lcmFibGUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIG1ldGhvZCBqdXN0 IGEgd2FydC4KKyAgICAgICAgVW5uZWNlc3NhcnkgY29uc3QtY2FzdGluZywgdW5uZWNlc3Nhcnkg ZnVuY3Rpb24gY2FsbCwgYW5kIGxlc3MgY29kZSBpZiB3ZSByZW1vdmUuCisKKyAgICAgICAgKiBy dW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0Lmg6CisgICAg ICAgICAgICAtIHJlbW92ZSBwcm9wZXJ0eUlzRW51bWVyYWJsZQorICAgICAgICAqIHJ1bnRpbWUv T2JqZWN0UHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6b2JqZWN0UHJvdG9GdW5jUHJvcGVy dHlJc0VudW1lcmFibGUpOgorICAgICAgICAgICAgLSBNb3ZlIGltcGxlbWVudGF0aW9uIGhlcmUg dXNpbmcgZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yIGRpcmVjdGx5LgorCiAyMDEzLTA4LTIxICBK dWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgogCiAgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xMjAxMDY+IEZpeCBWX0RGR09wZXJhdGlvbl9FSlBQIHNpZ25hdHVyZSBp biBERkcuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3Bw CShyZXZpc2lvbiAxNTQzNzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09i amVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MDcsMTQgKzE0MDcsNiBAQCBib29sIEpTT2Jq ZWN0OjpkZWZhdWx0SGFzSW5zdGFuY2UoRXhlY1N0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1i b29sIEpTT2JqZWN0Ojpwcm9wZXJ0eUlzRW51bWVyYWJsZShFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0 IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSkgY29uc3QKLXsKLSAgICBQcm9wZXJ0eURlc2NyaXB0 b3IgZGVzY3JpcHRvcjsKLSAgICBpZiAoIWNvbnN0X2Nhc3Q8SlNPYmplY3QqPih0aGlzKS0+Z2V0 T3duUHJvcGVydHlEZXNjcmlwdG9yKGV4ZWMsIHByb3BlcnR5TmFtZSwgZGVzY3JpcHRvcikpCi0g ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gZGVzY3JpcHRvci5lbnVtZXJhYmxlKCk7 Ci19Ci0KIGJvb2wgSlNPYmplY3Q6OmdldFByb3BlcnR5U3BlY2lmaWNWYWx1ZShFeGVjU3RhdGUq IGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUsIEpTQ2VsbComIHNwZWNpZmljVmFsdWUp IGNvbnN0CiB7CiAgICAgdW5zaWduZWQgYXR0cmlidXRlczsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkocmV2aXNpb24gMTU0Mzc4KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNDYzLDgg KzQ2Myw2IEBAIHB1YmxpYzoKICAgICB2b2lkIHB1dERpcmVjdFdpdGhvdXRUcmFuc2l0aW9uKFZN JiwgUHJvcGVydHlOYW1lLCBKU1ZhbHVlLCB1bnNpZ25lZCBhdHRyaWJ1dGVzID0gMCk7CiAgICAg dm9pZCBwdXREaXJlY3RBY2Nlc3NvcihFeGVjU3RhdGUqLCBQcm9wZXJ0eU5hbWUsIEpTVmFsdWUs IHVuc2lnbmVkIGF0dHJpYnV0ZXMpOwogCi0gICAgYm9vbCBwcm9wZXJ0eUlzRW51bWVyYWJsZShF eGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpIGNvbnN0OwotCiAgICAg SlNfRVhQT1JUX1BSSVZBVEUgYm9vbCBoYXNQcm9wZXJ0eShFeGVjU3RhdGUqLCBQcm9wZXJ0eU5h bWUpIGNvbnN0OwogICAgIEpTX0VYUE9SVF9QUklWQVRFIGJvb2wgaGFzUHJvcGVydHkoRXhlY1N0 YXRlKiwgdW5zaWduZWQgcHJvcGVydHlOYW1lKSBjb25zdDsKICAgICBib29sIGhhc093blByb3Bl cnR5KEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSkgY29uc3Q7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PYmplY3RQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdFByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDE1 NDM3OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdFByb3RvdHlwZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE4MCw4ICsxODAsMTIgQEAgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBvYmplY3RQcm90bwogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIG9i amVjdFByb3RvRnVuY1Byb3BlcnR5SXNFbnVtZXJhYmxlKEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAg ICBKU1ZhbHVlIHRoaXNWYWx1ZSA9IGV4ZWMtPmhvc3RUaGlzVmFsdWUoKS50b1RoaXMoZXhlYywg U3RyaWN0TW9kZSk7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc0Jvb2xlYW4odGhpc1Zh bHVlLnRvT2JqZWN0KGV4ZWMpLT5wcm9wZXJ0eUlzRW51bWVyYWJsZShleGVjLCBJZGVudGlmaWVy KGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKSkpKSk7 CisgICAgSlNPYmplY3QqIHRoaXNPYmplY3QgPSBleGVjLT5ob3N0VGhpc1ZhbHVlKCkudG9UaGlz KGV4ZWMsIFN0cmljdE1vZGUpLnRvT2JqZWN0KGV4ZWMpOworICAgIElkZW50aWZpZXIgcHJvcGVy dHlOYW1lKGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVj KSk7CisKKyAgICBQcm9wZXJ0eURlc2NyaXB0b3IgZGVzY3JpcHRvcjsKKyAgICBib29sIGVudW1l cmFibGUgPSB0aGlzT2JqZWN0LT5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoZXhlYywgcHJvcGVy dHlOYW1lLCBkZXNjcmlwdG9yKSAmJiBkZXNjcmlwdG9yLmVudW1lcmFibGUoKTsKKyAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzQm9vbGVhbihlbnVtZXJhYmxlKSk7CiB9CiAKIC8vIDE1LjIu NC4zIE9iamVjdC5wcm90b3R5cGUudG9Mb2NhbGVTdHJpbmcoKQo=