120121 2013-08-21 10:35:03 -0700 Fix startOfWord method to not include white space between words. 2013-09-05 18:33:50 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 119829 1 roger_fong webkit-unassigned ap bfulgham jonlee rniwa roger_fong webkit-bug-importer oldest_to_newest 919517 0 roger_fong 2013-08-21 10:35:03 -0700 In VisibileUnits.cpp. Consider startOfWord for the boundary argument LEFT_WORD_IF_ON_BOUNDARY. If the current position of the caret is at the start of a word, that is considered on the boundary. The method in this case returns the previous boundary hoping to get the start of the previous word. However, instead it just returns the end of the previous word, as that is indeed the previous boundary. Will fix this so that startOfWord does not treat the whitespace between words as boundaries. I'm not sure yet whether it makes sense to ignore situations where there is more than one character being used as whitespace between words since that seems to be more deliberate. 919518 1 webkit-bug-importer 2013-08-21 10:35:36 -0700 <rdar://problem/14797275> 919961 2 209392 roger_fong 2013-08-22 13:57:12 -0700 Created attachment 209392 patch This just ignores a single whitespace character between words... I'm not yet sure I want to extend this to more than one. 919994 3 209392 ap 2013-08-22 15:38:16 -0700 Comment on attachment 209392 patch View in context: https://bugs.webkit.org/attachment.cgi?id=209392&action=review > Source/WebCore/ChangeLog:3 > + <https://bugs.webkit.org/show_bug.cgi?id=120119> Fix startOfWord method to not include white space between words. This is a major change very low at the editing stack. I'll be surprised if it doesn't change any behavior. 919997 4 roger_fong 2013-08-22 15:51:07 -0700 (In reply to comment #3) > (From update of attachment 209392 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209392&action=review > > > Source/WebCore/ChangeLog:3 > > + <https://bugs.webkit.org/show_bug.cgi?id=120119> Fix startOfWord method to not include white space between words. I liked to the wrong bug in my changelog -_- > > This is a major change very low at the editing stack. I'll be surprised if it doesn't change any behavior. I'll try to find a good way to test this on both mac and windows. 919999 5 ap 2013-08-22 16:00:38 -0700 Looks like this patch is failing a bunch of tests, EWS just couldn't make up its mind enough to tell us about that. You can see the failures if you click on a yellow bubble. 920013 6 roger_fong 2013-08-22 16:34:05 -0700 Actually I can't imagine this working in the more general case at all. startOfWord calls isStartOfWord, which calls startOfWord....etc etc...my manual tests were clearly not extensive enough. Will rework things or find a higher level place to fix this. 920018 7 roger_fong 2013-08-22 16:49:47 -0700 (In reply to comment #6) > Actually I can't imagine this working in the more general case at all. > startOfWord calls isStartOfWord, which calls startOfWord....etc etc...my manual tests were clearly not extensive enough. > > Will rework things or find a higher level place to fix this. So in webkit, the white space between words also counts as a word. So no change needs to be made to this file. 920045 8 roger_fong 2013-08-22 17:45:52 -0700 Holding on that thought, need to first investigate the impact of this on text navigation in screen readers that use iaccessible text like nvda 921097 9 209392 cfleizach 2013-08-26 11:18:09 -0700 Comment on attachment 209392 patch r- to help clear the r? queue 925343 10 roger_fong 2013-09-05 18:33:40 -0700 Not a bug, there are other ways of navigating through words while ignoring white space in place. 209392 2013-08-22 13:57:12 -0700 2013-08-26 11:18:09 -0700 patch patch.patch text/plain 1730 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDQwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA4LTIxICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAxMTk+IEZpeCBzdGFydE9mV29yZCBtZXRob2QgdG8g bm90IGluY2x1ZGUgd2hpdGUgc3BhY2UgYmV0d2VlbiB3b3Jkcy4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIENvbnNpZGVyIHN0YXJ0T2ZX b3JkIGZvciB0aGUgYm91bmRhcnkgYXJndW1lbnQgTEVGVF9XT1JEX0lGX09OX0JPVU5EQVJZLgor ICAgICAgICBJZiB0aGUgY3VycmVudCBwb3NpdGlvbiBvZiB0aGUgY2FyZXQgaXMgYXQgdGhlIHN0 YXJ0IG9mIGEgd29yZCwgdGhhdCBpcyBjb25zaWRlcmVkIG9uIHRoZSBib3VuZGFyeS4KKyAgICAg ICAgVGhlIG1ldGhvZCBpbiB0aGlzIGNhc2UgcmV0dXJucyB0aGUgcHJldmlvdXMgYm91bmRhcnkg aG9waW5nIHRvIGdldCB0aGUgc3RhcnQgb2YgdGhlIHByZXZpb3VzIHdvcmQuCisgICAgICAgIEhv d2V2ZXIsIGluc3RlYWQgaXQganVzdCByZXR1cm5zIHRoZSBlbmQgb2YgdGhlIHByZXZpb3VzIHdv cmQsIGFzIHRoYXQgaXMgaW5kZWVkIHRoZSBwcmV2aW91cyBib3VuZGFyeS4KKyAgICAgICAgCisg ICAgICAgIFRlc3RzIGFscmVhZHkgY292ZXJlZCBieSBleGlzdGluZyBhY2Nlc3NpYmlsaXR5IHRl c3RzLgorCisgICAgICAgICogZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c3RhcnRPZldvcmQpOgorCiAyMDEzLTA4LTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IG9wYWNpdHkgdG8gYXBwbHkgdG8gY3Vz dG9tIHNjcm9sbGJhcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRz LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0cy5j cHAJKHJldmlzaW9uIDE1NDM3NykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVu aXRzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMzLDkgKzYzMywxOCBAQAogICAgICAgICAgICAg cmV0dXJuIGM7CiAgICAgICAgIAogICAgICAgICBwID0gYy5uZXh0KCk7Ci0gICAgICAgIGlmIChw LmlzTnVsbCgpKQorICAgIH0gZWxzZSBpZiAoc2lkZSA9PSBMZWZ0V29yZElmT25Cb3VuZGFyeSkg eworICAgICAgICBpZiAoaXNTdGFydE9mUGFyYWdyYXBoKGMpKQogICAgICAgICAgICAgcmV0dXJu IGM7CisKKyAgICAgICAgcCA9IGMucHJldmlvdXMoKTsKICAgICB9CisgICAgCisgICAgaWYgKHAu aXNOdWxsKCkpCisgICAgICAgIHJldHVybiBjOworCisgICAgaWYgKGlzU3RhcnRPZldvcmQocCkp CisgICAgICAgIHJldHVybiBwOwogICAgIHJldHVybiBwcmV2aW91c0JvdW5kYXJ5KHAsIHN0YXJ0 V29yZEJvdW5kYXJ5KTsKIH0KIAo=