12011 2006-12-27 19:39:46 -0800 svg/custom/dynamic-svg-document-creation.svg is failing 2006-12-28 01:06:45 -0800 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 ggaren webkit-unassigned rwlbuis oldest_to_newest 39339 0 ggaren 2006-12-27 19:39:46 -0800 This is the change that broke it: Changed by: rwlbuis Changed at: Thu 28 Dec 2006 11:12:41 Revision: 18440 Changed files: /LayoutTests/ChangeLog /LayoutTests/svg/custom/transform-invalid-expected.txt /LayoutTests/svg/custom/transform-invalid.svg /WebCore/CMakeLists.txt /WebCore/ChangeLog /WebCore/WebCore.xcodeproj/project.pbxproj /WebCore/ksvg2/svg/SVGParserUtilities.cpp /WebCore/ksvg2/svg/SVGParserUtilities.h /WebCore/ksvg2/svg/SVGPathElement.cpp /WebCore/ksvg2/svg/SVGPathElement.h /WebCore/ksvg2/svg/SVGTransformable.cpp /WebCore/ksvg2/svg/svgpathparser.cpp /WebCore/ksvg2/svg/svgpathparser.h Comments: Reviewed by Eric. http://bugs.webkit.org/show_bug.cgi?id=11108 Replace usage of split by proper parsers http://bugs.webkit.org/show_bug.cgi?id=11908 WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes Get rid of split() when parsing transform attribute. 39260 1 12079 rwlbuis 2006-12-28 00:56:01 -0800 Created attachment 12079 Fix testcase 39258 2 12079 mitz 2006-12-28 00:59:12 -0800 Comment on attachment 12079 Fix testcase r=me 39257 3 rwlbuis 2006-12-28 01:06:45 -0800 Landed in r18450. 12079 2006-12-28 00:56:01 -0800 2006-12-28 00:59:12 -0800 Fix testcase 12011.diff text/plain 1120 rwlbuis SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4NDQ5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMTItMjggIFJvYiBCdWlzICA8YnVpc0Br ZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDExCisgICAgICAgIHN2 Zy9jdXN0b20vZHluYW1pYy1zdmctZG9jdW1lbnQtY3JlYXRpb24uc3ZnIGlzIGZhaWxpbmcKKwor ICAgICAgICBDb3JyZWN0IHRoZSB0cmFuc2Zvcm0gc3ludGF4IGVycm9ycyAoc2luY2UgdGhlIG5l dyB0cmFuc2Zvcm0KKyAgICAgICAgcGFyc2VyIGlzIG1vcmUgc3RyaWN0KS4KKworICAgICAgICAq IHN2Zy9jdXN0b20vZHluYW1pYy1zdmctZG9jdW1lbnQtY3JlYXRpb24uc3ZnOgorCiAyMDA2LTEy LTI3ICBFcmljIFNlaWRlbCAgPGVyaWNAZXNlaWRlbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgZ2dhcmVuLgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9keW5hbWljLXN2Zy1kb2N1 bWVudC1jcmVhdGlvbi5zdmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9k eW5hbWljLXN2Zy1kb2N1bWVudC1jcmVhdGlvbi5zdmcJKHJldmlzaW9uIDE4NDQ5KQorKysgTGF5 b3V0VGVzdHMvc3ZnL2N1c3RvbS9keW5hbWljLXN2Zy1kb2N1bWVudC1jcmVhdGlvbi5zdmcJKHdv cmtpbmcgY29weSkKQEAgLTUxLDYgKzUxLDYgQEAgZnVuY3Rpb24gaW5pdCgpIHsgCiB9CiBdXT4K IDwvc2NyaXB0PgotPGcgaWQ9ImNvbnRlbnQiIHRyYW5zZm9ybT0idHJhbnNsYXRlKDI1MCwgMjUw KTsgcm90YXRlKDQ1ZGVnKSI+Cis8ZyBpZD0iY29udGVudCIgdHJhbnNmb3JtPSJ0cmFuc2xhdGUo MjUwLCAyNTApIHJvdGF0ZSg0NSkiPgogPC9nPgogPC9zdmc+Cg==