<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>120081</bug_id>
          
          <creation_ts>2013-08-20 13:28:55 -0700</creation_ts>
          <short_desc>lint-test-expectations complains about a seemingly-legitimate override</short_desc>
          <delta_ts>2017-06-08 20:57:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=138698</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dpranke</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>919190</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-08-20 13:28:55 -0700</bug_when>
    <thetext>platform/mac/TestExpectations has the following pair of lines:

webkit.org/b/60731 ietestcenter/css3/grid/grid-items-003.htm [ ImageOnlyFailure ]
webkit.org/b/60731 [ MountainLion Release ] ietestcenter/css3/grid/grid-items-003.htm [ Pass ImageOnlyFailure ]

This seems like a reasonable override, but lint-test-expectations complains like so:

LayoutTests/platform/mac/TestExpectations:987 More specific entry for ietestcenter/css3/grid/grid-items-003.htm on line LayoutTests/platform/mac/TestExpectations:986 overrides line LayoutTests/platform/mac/TestExpectations:987. ietestcenter/css3/grid/grid-items-003.htm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>919202</commentid>
    <comment_count>1</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-08-20 13:48:08 -0700</bug_when>
    <thetext>Two lines in the same file are not allowed to have overlapping sets of modifiers. You would have to change this to something like:

[Lion] .... [ ImageOnlyFailure]
[MountainLion Debug] ... [ ImageOnlyFailure ]
[ML Release] ... [ Pass ImageOnlyFailure ]

At one point fairly early on in the evolution of new-run-webkit-tests, there was logic so that a more specific set of modifiers could legally override a less-specific set of modifiers, but it was deemed that this made things too confusing and hard to maintain. I think the code for this may actually mostly still be in test_expectations.py, but I don&apos;t know that you&apos;d want to change it.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>