120075 2013-08-20 11:06:15 -0700 REGRESSION (r128400): BBC4 website not displaying pictures 2013-08-20 11:46:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED http://www.bbc.co.uk/bbcfour/best-of InRadar P2 Normal --- 1 msaboff msaboff oldest_to_newest 919126 0 msaboff 2013-08-20 11:06:15 -0700 Javascript is used to process the image paths shown on http://www.bbc.co.uk/bbcfour/best-of. As of r128400, that processing is not working. It turns out that the array returned by RegExp.match gets reified after PutByVal write are done to the array, thus overwriting the modifications to the array. This is due to the array indexing type being wrong for RegExpMatchesArray objects. Currently it is ArrayWithArrayStorage and should be ArrayWithSlowPutArrayStorage. Patch forthcoming. <rdar://problem/14716775> 919139 1 209211 msaboff 2013-08-20 11:41:14 -0700 Created attachment 209211 Patch 919143 2 msaboff 2013-08-20 11:46:39 -0700 Committed r154346: <http://trac.webkit.org/changeset/154346> 209211 2013-08-20 11:41:14 -0700 2013-08-20 11:42:09 -0700 Patch 120075.patch text/plain 4469 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MzQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTA4LTIwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAwNzUKKyAgICAg ICAgUkVHUkVTU0lPTiAocjEyODQwMCk6IEJCQzQgd2Vic2l0ZSBub3QgZGlzcGxheWluZyBwaWN0 dXJlcworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cnVudGltZS9SZWdFeHBNYXRjaGVzQXJyYXkuaDoKKyAgICAgICAgKEpTQzo6UmVnRXhwTWF0Y2hl c0FycmF5OjpjcmVhdGVTdHJ1Y3R1cmUpOiBDaGFuZ2VkIHRoZSBhcnJheSBJbmRleGluZ1R5cGUg dG8gYmUgQXJyYXlXaXRoU2xvd1B1dEFycmF5U3RvcmFnZQorICAgICAgICBzbyB0aGF0IHRoZSBt YXRjaCByZXN1bHRzIHdpbGwgYmUgcmVpZmllZCBiZWZvcmUgYW55IG90aGVyIG1vZGlmaWNhdGlv biB0byB0aGUgcmVzdWx0cyBhcnJheS4KKwogMjAxMy0wOC0xOSAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEluY29ycmVjdCBiZWhhdmlvciBvbiBlbXNjcmlwdGVu LWNvbXBpbGVkIGN1YmUyaGFzaApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv UmVnRXhwTWF0Y2hlc0FycmF5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvUmVnRXhwTWF0Y2hlc0FycmF5LmgJKHJldmlzaW9uIDE1NDM0NSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE1hdGNoZXNBcnJheS5oCSh3b3JraW5nIGNv cHkpCkBAIC00NCw3ICs0NCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIHN0YXRpYyBT dHJ1Y3R1cmUqIGNyZWF0ZVN0cnVjdHVyZShWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxP YmplY3QsIEpTVmFsdWUgcHJvdG90eXBlKQogICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4g U3RydWN0dXJlOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCwgcHJvdG90eXBlLCBUeXBlSW5mbyhP YmplY3RUeXBlLCBTdHJ1Y3R1cmVGbGFncyksIGluZm8oKSwgQXJyYXlXaXRoQXJyYXlTdG9yYWdl KTsKKyAgICAgICAgICAgIHJldHVybiBTdHJ1Y3R1cmU6OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0 LCBwcm90b3R5cGUsIFR5cGVJbmZvKE9iamVjdFR5cGUsIFN0cnVjdHVyZUZsYWdzKSwgaW5mbygp LCBBcnJheVdpdGhTbG93UHV0QXJyYXlTdG9yYWdlKTsKICAgICAgICAgfQogCiAgICAgICAgIHN0 YXRpYyB2b2lkIHZpc2l0Q2hpbGRyZW4oSlNDZWxsKiwgU2xvdFZpc2l0b3ImKTsKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDE1NDM0NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTIwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZA YXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjAwNzUKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyODQwMCk6IEJCQzQgd2Vic2l0ZSBu b3QgZGlzcGxheWluZyBwaWN0dXJlcworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZGVkIHJlZ3Jlc3Npb24gdGVzdHMgZm9yIGZpeC4KKworICAgICAg ICAqIGZhc3QvanMvcmVncmVzcy9yZWdleHAtbWF0Y2gtcmVpZnktYmVmb3JlLXB1dGJ5dmFsLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9yZWdyZXNzL3JlZ2V4cC1tYXRj aC1yZWlmeS1iZWZvcmUtcHV0Ynl2YWwuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9y ZWdyZXNzL3NjcmlwdC10ZXN0cy9yZWdleHAtbWF0Y2gtcmVpZnktYmVmb3JlLXB1dGJ5dmFsLmpz OiBBZGRlZC4KKwogMjAxMy0wOC0xOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIEluY29ycmVjdCBiZWhhdmlvciBvbiBlbXNjcmlwdGVuLWNvbXBpbGVkIGN1YmUy aGFzaApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZWdyZXNzL3JlZ2V4cC1tYXRjaC1yZWlm eS1iZWZvcmUtcHV0Ynl2YWwtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvanMvcmVncmVzcy9yZWdleHAtbWF0Y2gtcmVpZnktYmVmb3JlLXB1dGJ5dmFsLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcmVncmVzcy9yZWdl eHAtbWF0Y2gtcmVpZnktYmVmb3JlLXB1dGJ5dmFsLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDExIEBACitKU1JlZ3Jlc3MvcmVnZXhwLW1hdGNoLXJlaWZ5LWJlZm9yZS1w dXRieXZhbAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBtYXRjaGVzIGlz IFsnaHR0cDovL3d3dy5kdW1teS5jb20vaW1hZ2VzLzEyM3g0NTYvaW1hZ2UuanBnJywnaHR0cDov L3d3dy5kdW1teS5jb20vaW1hZ2VzLycsMTExLCd4JywyMjIsJy9pbWFnZS5qcGcnXQorUEFTUyBu byBleGNlcHRpb24gdGhyb3duCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RF U1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZWdyZXNzL3JlZ2V4cC1t YXRjaC1yZWlmeS1iZWZvcmUtcHV0Ynl2YWwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2pzL3JlZ3Jlc3MvcmVnZXhwLW1hdGNoLXJlaWZ5LWJlZm9yZS1wdXRieXZhbC5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9yZWdyZXNzL3JlZ2V4cC1tYXRj aC1yZWlmeS1iZWZvcmUtcHV0Ynl2YWwuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEy IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRt bD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcmVncmVzcy1w cmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9yZWdleHAtbWF0Y2gt cmVpZnktYmVmb3JlLXB1dGJ5dmFsLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJj ZXMvcmVncmVzcy1wb3N0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMv anMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvanMvcmVncmVzcy9zY3JpcHQtdGVzdHMvcmVnZXhwLW1hdGNoLXJlaWZ5LWJl Zm9yZS1wdXRieXZhbC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3JlZ3Jl c3Mvc2NyaXB0LXRlc3RzL3JlZ2V4cC1tYXRjaC1yZWlmeS1iZWZvcmUtcHV0Ynl2YWwuanMJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL3Jl Z2V4cC1tYXRjaC1yZWlmeS1iZWZvcmUtcHV0Ynl2YWwuanMJKHdvcmtpbmcgY29weSkKQEAgLTAs MCArMSw3IEBACit2YXIgc3JjID0gJ2h0dHA6Ly93d3cuZHVtbXkuY29tL2ltYWdlcy8xMjN4NDU2 L2ltYWdlLmpwZyc7CisKK3ZhciBtYXRjaGVzID0gc3JjLm1hdGNoKCJeKC4qLykoWzAtOV0rKSh4 KShbMC05XSspKC8uKikkIik7CittYXRjaGVzWzJdID0gMTExOworbWF0Y2hlc1s0XSA9IDIyMjsK KyAgICAKK3Nob3VsZEJlKCJtYXRjaGVzIiwgIlsnaHR0cDovL3d3dy5kdW1teS5jb20vaW1hZ2Vz LzEyM3g0NTYvaW1hZ2UuanBnJywnaHR0cDovL3d3dy5kdW1teS5jb20vaW1hZ2VzLycsMTExLCd4 JywyMjIsJy9pbWFnZS5qcGcnXSIpOwo=