120074 2013-08-20 10:38:28 -0700 In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction 2013-08-21 09:44:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 119759 1 robert robert commit-queue esprehn+autocc glenn kondapallykalyan robert oldest_to_newest 919115 0 robert 2013-08-20 10:38:28 -0700 cellAbove(), cellBelow() check the logical rather than the physical direction. This isn't what's needed in paintCollapsedBorders() 919119 1 209207 robert 2013-08-20 10:47:28 -0700 Created attachment 209207 Patch 919147 2 209207 hyatt 2013-08-20 11:51:28 -0700 Comment on attachment 209207 Patch This patch looks good, but it does highlight the fact that we need to rename cellBefore/After/Above/Below, since they aren't truly physical. I think we should rename them to: previousCellInRow, nextCellInRow, cellInPreviousRow, cellInNextRow I think that would be more clear than above/below/before/after, especially with how before/after is overloaded to mean "above/below" in writing modes. :) 919482 3 209207 commit-queue 2013-08-21 09:43:58 -0700 Comment on attachment 209207 Patch Clearing flags on attachment: 209207 Committed r154389: <http://trac.webkit.org/changeset/154389> 919483 4 commit-queue 2013-08-21 09:44:00 -0700 All reviewed patches have been landed. Closing bug. 209207 2013-08-20 10:47:28 -0700 2013-08-21 09:43:58 -0700 Patch bug-120074-20130820184711.patch text/plain 6059 robert U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODY0MzYwNTZmNGIxZGVj NjU0MTIyOGY2NTg0Y2I2YTA4NjhkYzQ1ZC4uNDE5ZjAzNGE3N2I1ZDBmMDNlNGU3OWU4MzRhYTg5 NmYwNWFjNjg2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA4LTIwICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBJbiBSZW5kZXJUYWJsZUNl bGw6OnBhaW50Q29sbGFwc2VkQm9yZGVycygpIGNoZWNrIHN1cnJvdW5kaW5nIGNlbGxzIHVzaW5n IHBoeXNpY2FsIHJhdGhlciB0aGFuIGxvZ2ljYWwgZGlyZWN0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAwNzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkg ZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9ucyBjZWxsQWJvdmUoKSwgY2Vs bEJlbG93KCkgZXRjLiBjaGVjayB0aGUgbG9naWNhbCByYXRoZXIgdGhhbiB0aGUgcGh5c2ljYWwg ZGlyZWN0aW9uIGJ1dCB0aGV5J3JlIGJlaW5nCisgICAgICAgIHVzZWQgdG8gZGVjaWRlIHRoZSBw YWludGluZyBvZiB0aGUgcGh5c2ljYWwgYm9yZGVycyBvZiB0aGUgY2VsbC4gQXMgd2UgcGFpbnQg YWxsIGZvdXIgc2lkZXMgb2YgZXZlcnkgY2VsbCwgYW5kCisgICAgICAgIHRoZSBib3JkZXJzIG9m IGFkam9pbmluZyBjZWxscyB0d2ljZSBvdmVyLCB0aGlzIGhhcyBubyBpbXBhY3Qgb24gcGFpbnRp bmcgY3VycmVudGx5IGJ1dCBtYWtpbmcgdGhlIGNoZWNrIGNvbnNpc3RlbnQKKyAgICAgICAgaW4g aXRzIHRyZWF0bWVudCBvZiBwaHlzaWNhbCBhbmQgbG9naWNhbCBkaXJlY3Rpb24gd2lsbCBoZWxw IHdpdGggd2Via2l0Lm9yZy9iLzExOTc1OSBhbmQgbWFrZSB0aGUgY29kZSBsZXNzIGNvbmZ1c2lu ZworICAgICAgICB0byB0aGUgbmV4dCBndXkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy VGFibGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6Y2VsbEF0 TGVmdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZUNlbGw6OmNlbGxBdFJpZ2h0KToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6Y2VsbEF0VG9wKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6Y2VsbEF0Qm90dG9tKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclRhYmxlQ2VsbDo6cGFpbnRDb2xsYXBzZWRCb3JkZXJzKToKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmg6CisKIDIwMTMtMDgtMTMgIFJvYmVydCBIb2dhbiAg PHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIENvbGxhcHNlZCBib3JkZXJzIGJldHdlZW4g YWRqb2luaW5nIHNlY3Rpb25zIHNob3VsZG4ndCBvdmVycGFpbnQgZWFjaCBvdGhlcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAppbmRleCA5YjBkNTdjZDM2 MGMwYjFhMmU4MTRkMjgxNzQwODg0YmY4ZTJmODA2Li5iM2YwNmJmYTdjYzU4OWVmODE1YjNkNWZh N2Y1NGU0MmQ1OTYyYWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGFibGVDZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFi bGVDZWxsLmNwcApAQCAtODk1LDYgKzg5NSwzNCBAQCBpbmxpbmUgQ29sbGFwc2VkQm9yZGVyVmFs dWUgUmVuZGVyVGFibGVDZWxsOjpjYWNoZWRDb2xsYXBzZWRCb3R0b21Cb3JkZXIoY29uc3QgUgog ICAgIHJldHVybiBzdHlsZUZvckNlbGxGbG93LT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkgPyBz ZWN0aW9uKCktPmNhY2hlZENvbGxhcHNlZEJvcmRlcih0aGlzLCBDQlNFbmQpIDogc2VjdGlvbigp LT5jYWNoZWRDb2xsYXBzZWRCb3JkZXIodGhpcywgQ0JTU3RhcnQpOwogfQogCitpbmxpbmUgUmVu ZGVyVGFibGVDZWxsKiBSZW5kZXJUYWJsZUNlbGw6OmNlbGxBdExlZnQoY29uc3QgUmVuZGVyU3R5 bGUqIHN0eWxlRm9yQ2VsbEZsb3cpIGNvbnN0Cit7CisgICAgaWYgKHN0eWxlRm9yQ2VsbEZsb3ct PmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCisgICAgICAgIHJldHVybiBzdHlsZUZvckNlbGxG bG93LT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkgPyB0YWJsZSgpLT5jZWxsQmVmb3JlKHRoaXMp IDogdGFibGUoKS0+Y2VsbEFmdGVyKHRoaXMpOworICAgIHJldHVybiBzdHlsZUZvckNlbGxGbG93 LT5pc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpID8gdGFibGUoKS0+Y2VsbEJlbG93KHRoaXMp IDogdGFibGUoKS0+Y2VsbEFib3ZlKHRoaXMpOworfQorCitpbmxpbmUgUmVuZGVyVGFibGVDZWxs KiBSZW5kZXJUYWJsZUNlbGw6OmNlbGxBdFJpZ2h0KGNvbnN0IFJlbmRlclN0eWxlKiBzdHlsZUZv ckNlbGxGbG93KSBjb25zdAoreworICAgIGlmIChzdHlsZUZvckNlbGxGbG93LT5pc0hvcml6b250 YWxXcml0aW5nTW9kZSgpKQorICAgICAgICByZXR1cm4gc3R5bGVGb3JDZWxsRmxvdy0+aXNMZWZ0 VG9SaWdodERpcmVjdGlvbigpID8gdGFibGUoKS0+Y2VsbEFmdGVyKHRoaXMpIDogdGFibGUoKS0+ Y2VsbEJlZm9yZSh0aGlzKTsKKyAgICByZXR1cm4gc3R5bGVGb3JDZWxsRmxvdy0+aXNGbGlwcGVk QmxvY2tzV3JpdGluZ01vZGUoKSA/IHRhYmxlKCktPmNlbGxBYm92ZSh0aGlzKSA6IHRhYmxlKCkt PmNlbGxCZWxvdyh0aGlzKTsKK30KKworaW5saW5lIFJlbmRlclRhYmxlQ2VsbCogUmVuZGVyVGFi bGVDZWxsOjpjZWxsQXRUb3AoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlRm9yQ2VsbEZsb3cpIGNv bnN0Cit7CisgICAgaWYgKHN0eWxlRm9yQ2VsbEZsb3ctPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2Rl KCkpCisgICAgICAgIHJldHVybiBzdHlsZUZvckNlbGxGbG93LT5pc0ZsaXBwZWRCbG9ja3NXcml0 aW5nTW9kZSgpID8gdGFibGUoKS0+Y2VsbEJlbG93KHRoaXMpIDogdGFibGUoKS0+Y2VsbEFib3Zl KHRoaXMpOworICAgIHJldHVybiBzdHlsZUZvckNlbGxGbG93LT5pc0xlZnRUb1JpZ2h0RGlyZWN0 aW9uKCkgPyB0YWJsZSgpLT5jZWxsQmVmb3JlKHRoaXMpIDogdGFibGUoKS0+Y2VsbEFmdGVyKHRo aXMpOworfQorCitpbmxpbmUgUmVuZGVyVGFibGVDZWxsKiBSZW5kZXJUYWJsZUNlbGw6OmNlbGxB dEJvdHRvbShjb25zdCBSZW5kZXJTdHlsZSogc3R5bGVGb3JDZWxsRmxvdykgY29uc3QKK3sKKyAg ICBpZiAoc3R5bGVGb3JDZWxsRmxvdy0+aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSkKKyAgICAg ICAgcmV0dXJuIHN0eWxlRm9yQ2VsbEZsb3ctPmlzRmxpcHBlZEJsb2Nrc1dyaXRpbmdNb2RlKCkg PyB0YWJsZSgpLT5jZWxsQWJvdmUodGhpcykgOiB0YWJsZSgpLT5jZWxsQmVsb3codGhpcyk7Cisg ICAgcmV0dXJuIHN0eWxlRm9yQ2VsbEZsb3ctPmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSA/IHRh YmxlKCktPmNlbGxBZnRlcih0aGlzKSA6IHRhYmxlKCktPmNlbGxCZWZvcmUodGhpcyk7Cit9CisK IGludCBSZW5kZXJUYWJsZUNlbGw6OmJvcmRlckxlZnQoKSBjb25zdAogewogICAgIHJldHVybiB0 YWJsZSgpLT5jb2xsYXBzZUJvcmRlcnMoKSA/IGJvcmRlckhhbGZMZWZ0KGZhbHNlKSA6IFJlbmRl ckJsb2NrOjpib3JkZXJMZWZ0KCk7CkBAIC0xMTcyLDE5ICsxMjAwLDE5IEBAIHZvaWQgUmVuZGVy VGFibGVDZWxsOjpwYWludENvbGxhcHNlZEJvcmRlcnMoUGFpbnRJbmZvJiBwYWludEluZm8sIGNv bnN0IExheW91dFBvCiAgICAgYm9vbCBzaG91bGREcmF3TGVmdEJvcmRlciA9IHRydWU7CiAgICAg Ym9vbCBzaG91bGREcmF3UmlnaHRCb3JkZXIgPSB0cnVlOwogCi0gICAgaWYgKFJlbmRlclRhYmxl Q2VsbCogdG9wID0gdGFibGUoKS0+Y2VsbEFib3ZlKHRoaXMpKSB7CisgICAgaWYgKFJlbmRlclRh YmxlQ2VsbCogdG9wID0gY2VsbEF0VG9wKHN0eWxlRm9yQ2VsbEZsb3cpKSB7CiAgICAgICAgIHNo b3VsZERyYXdUb3BCb3JkZXIgPSB0b3AtPmFsaWduTGVmdFJpZ2h0Qm9yZGVyUGFpbnRSZWN0KGxl ZnRYT2Zmc2V0VG9wLCByaWdodFhPZmZzZXRUb3ApOwogICAgICAgICBpZiAodGhpcy0+Y29sU3Bh bigpID4gMSkKICAgICAgICAgICAgIHNob3VsZERyYXdUb3BCb3JkZXIgPSBmYWxzZTsKICAgICB9 CiAKLSAgICBpZiAoUmVuZGVyVGFibGVDZWxsKiBib3R0b20gPSB0YWJsZSgpLT5jZWxsQmVsb3co dGhpcykpCisgICAgaWYgKFJlbmRlclRhYmxlQ2VsbCogYm90dG9tID0gY2VsbEF0Qm90dG9tKHN0 eWxlRm9yQ2VsbEZsb3cpKQogICAgICAgICBib3R0b20tPmFsaWduTGVmdFJpZ2h0Qm9yZGVyUGFp bnRSZWN0KGxlZnRYT2Zmc2V0Qm90dG9tLCByaWdodFhPZmZzZXRCb3R0b20pOwogCi0gICAgaWYg KFJlbmRlclRhYmxlQ2VsbCogbGVmdCA9IHRhYmxlKCktPmNlbGxCZWZvcmUodGhpcykpCisgICAg aWYgKFJlbmRlclRhYmxlQ2VsbCogbGVmdCA9IGNlbGxBdExlZnQoc3R5bGVGb3JDZWxsRmxvdykp CiAgICAgICAgIHNob3VsZERyYXdMZWZ0Qm9yZGVyID0gbGVmdC0+YWxpZ25Ub3BCb3R0b21Cb3Jk ZXJQYWludFJlY3QodG9wWU9mZnNldExlZnQsIGJvdHRvbVlPZmZzZXRMZWZ0KTsKIAotICAgIGlm IChSZW5kZXJUYWJsZUNlbGwqIHJpZ2h0ID0gdGFibGUoKS0+Y2VsbEFmdGVyKHRoaXMpKQorICAg IGlmIChSZW5kZXJUYWJsZUNlbGwqIHJpZ2h0ID0gY2VsbEF0UmlnaHQoc3R5bGVGb3JDZWxsRmxv dykpCiAgICAgICAgIHNob3VsZERyYXdSaWdodEJvcmRlciA9IHJpZ2h0LT5hbGlnblRvcEJvdHRv bUJvcmRlclBhaW50UmVjdCh0b3BZT2Zmc2V0UmlnaHQsIGJvdHRvbVlPZmZzZXRSaWdodCk7CiAK ICAgICBJbnRSZWN0IGNlbGxSZWN0ID0gcGl4ZWxTbmFwcGVkSW50UmVjdChwYWludFJlY3QueCgp LCBwYWludFJlY3QueSgpLCBwYWludFJlY3Qud2lkdGgoKSwgcGFpbnRSZWN0LmhlaWdodCgpKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaAppbmRleCAyMjMzMmZl MDQwNGQ3NmE5OWFjZmI1YzNiZjVmMDdkNDgzNDI4MmFiLi5kNTU0MzZkMDYxZWNmOTZkYTMzNmUx MjM1MWVmMDk3YjdlZjEwMjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGFibGVDZWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRh YmxlQ2VsbC5oCkBAIC0yNjYsNiArMjY2LDExIEBAIHByaXZhdGU6CiAgICAgQ29sbGFwc2VkQm9y ZGVyVmFsdWUgY29tcHV0ZUNvbGxhcHNlZEJlZm9yZUJvcmRlcihJbmNsdWRlQm9yZGVyQ29sb3JP ck5vdCA9IEluY2x1ZGVCb3JkZXJDb2xvcikgY29uc3Q7CiAgICAgQ29sbGFwc2VkQm9yZGVyVmFs dWUgY29tcHV0ZUNvbGxhcHNlZEFmdGVyQm9yZGVyKEluY2x1ZGVCb3JkZXJDb2xvck9yTm90ID0g SW5jbHVkZUJvcmRlckNvbG9yKSBjb25zdDsKIAorICAgIFJlbmRlclRhYmxlQ2VsbCogY2VsbEF0 TGVmdChjb25zdCBSZW5kZXJTdHlsZSopIGNvbnN0OworICAgIFJlbmRlclRhYmxlQ2VsbCogY2Vs bEF0UmlnaHQoY29uc3QgUmVuZGVyU3R5bGUqKSBjb25zdDsKKyAgICBSZW5kZXJUYWJsZUNlbGwq IGNlbGxBdFRvcChjb25zdCBSZW5kZXJTdHlsZSopIGNvbnN0OworICAgIFJlbmRlclRhYmxlQ2Vs bCogY2VsbEF0Qm90dG9tKGNvbnN0IFJlbmRlclN0eWxlKikgY29uc3Q7CisKICAgICBMZW5ndGgg bG9naWNhbFdpZHRoRnJvbUNvbHVtbnMoUmVuZGVyVGFibGVDb2wqIGZpcnN0Q29sRm9yVGhpc0Nl bGwsIExlbmd0aCB3aWR0aEZyb21TdHlsZSkgY29uc3Q7CiAKICAgICB2b2lkIHVwZGF0ZUNvbEFu ZFJvd1NwYW5GbGFncygpOwo=