120072 2013-08-20 10:09:12 -0700 Use nullAtom instead of defining static local in Accessibility{Object, RenderObject}::actionVerb() 2013-08-20 11:11:59 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aboxhall apinheiro cfleizach commit-queue darin dmazzoni jdiggs mario webkit-bug-importer oldest_to_newest 919104 0 dbates 2013-08-20 10:09:12 -0700 As pointed out by Darin Adler in comment 5 bug #119914, we should use the global variable nullAtom instead of defining a static local variable to represent a null string. 919105 1 webkit-bug-importer 2013-08-20 10:09:26 -0700 <rdar://problem/14785714> 919124 2 209208 dbates 2013-08-20 10:58:32 -0700 Created attachment 209208 Patch 919127 3 dbates 2013-08-20 11:11:59 -0700 Committed r154343: <http://trac.webkit.org/changeset/154343> 209208 2013-08-20 10:58:32 -0700 2013-08-20 10:59:20 -0700 Patch bug-120072-20130820105832.patch text/plain 3205 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGI3MTQ0N2Y4NGFmODYx MTM3ZGZmMGIzNmM3Y2MxOGQ5Y2U5MTQxZS4uMTQyYTY4ODMwMmJmYzkxOTBhNTQ0M2M0ZjYzNzc2 MzNmZGEzNjYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA4LTIwICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQu b3JnL2IvMTIwMDcyPiBVc2UgbnVsbEF0b20gaW5zdGVhZCBvZiBkZWZpbmluZyBzdGF0aWMgbG9j YWwgaW4KKyAgICAgICAgQWNjZXNzaWJpbGl0eXtPYmplY3QsIFJlbmRlck9iamVjdH06OmFjdGlv blZlcmIoKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFjdGlvblZlcmIpOgorICAgICAgICAqIGFjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpB Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphY3Rpb25WZXJiKToKKworMjAxMy0wOC0yMCAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKICAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzExOTkxND4gW2lPU10gVXBzdHJlYW0gY2hhbmdlcyB0byBXZWJDb3JlL2FjY2Vzc2li aWxpdHkKIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlciBhbmQgQ2hyaXMgRmxlaXph Y2guCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 T2JqZWN0LmNwcAppbmRleCA5N2ZlN2FiNmYyMzIxZTc4OTRlMTQ5MTQ2MzhhNTczODU4MmFiODFl Li5mMzFjMWI4ZTVlZGYxNmQ0ZTA1MjczNzI4MDBhYTUwY2M0OWE5YWU4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKQEAg LTEzMDIsNyArMTMwMiw2IEBAIGNvbnN0IFN0cmluZyYgQWNjZXNzaWJpbGl0eU9iamVjdDo6YWN0 aW9uVmVyYigpIGNvbnN0CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIG1l bnVMaXN0QWN0aW9uLCAoQVhNZW51TGlzdEFjdGlvblZlcmIoKSkpOwogICAgIERFRklORV9TVEFU SUNfTE9DQUwoY29uc3QgU3RyaW5nLCBtZW51TGlzdFBvcHVwQWN0aW9uLCAoQVhNZW51TGlzdFBv cHVwQWN0aW9uVmVyYigpKSk7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcs IGxpc3RJdGVtQWN0aW9uLCAoQVhMaXN0SXRlbUFjdGlvblZlcmIoKSkpOwotICAgIERFRklORV9T VEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBub0FjdGlvbiwgKCkpOwogCiAgICAgc3dpdGNoIChy b2xlVmFsdWUoKSkgewogICAgIGNhc2UgQnV0dG9uUm9sZToKQEAgLTEzMjUsMTEgKzEzMjQsMTAg QEAgY29uc3QgU3RyaW5nJiBBY2Nlc3NpYmlsaXR5T2JqZWN0OjphY3Rpb25WZXJiKCkgY29uc3QK ICAgICBjYXNlIExpc3RJdGVtUm9sZToKICAgICAgICAgcmV0dXJuIGxpc3RJdGVtQWN0aW9uOwog ICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBub0FjdGlvbjsKKyAgICAgICAgcmV0dXJuIG51 bGxBdG9tOwogICAgIH0KICNlbHNlCi0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJp bmcsIG5vQWN0aW9uLCAoKSk7Ci0gICAgcmV0dXJuIG5vQWN0aW9uOworICAgIHJldHVybiBudWxs QXRvbTsKICNlbmRpZgogfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCBlMmQ5YzE5 MDYxNjMzNGEyNDhlY2Q1OWQyMmRiNTMxNTcyNmQ4NmVmLi5kN2EwY2E4NDdiMWVmYmZmMjBiNjE1 YzY3ZDE5MDY3MjIyZjNmNGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTMxNTEsOCArMzE1 MSw3IEBAIGNvbnN0IFN0cmluZyYgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWN0aW9uVmVy YigpIGNvbnN0CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIGNoZWNrZWRD aGVja0JveEFjdGlvbiwgKEFYQ2hlY2tlZENoZWNrQm94QWN0aW9uVmVyYigpKSk7CiAgICAgREVG SU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHVuY2hlY2tlZENoZWNrQm94QWN0aW9uLCAo QVhVbmNoZWNrZWRDaGVja0JveEFjdGlvblZlcmIoKSkpOwogICAgIERFRklORV9TVEFUSUNfTE9D QUwoY29uc3QgU3RyaW5nLCBsaW5rQWN0aW9uLCAoQVhMaW5rQWN0aW9uVmVyYigpKSk7Ci0gICAg REVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIG5vQWN0aW9uLCAoKSk7Ci0gICAgCisK ICAgICBzd2l0Y2ggKHJvbGVWYWx1ZSgpKSB7CiAgICAgY2FzZSBCdXR0b25Sb2xlOgogICAgIGNh c2UgVG9nZ2xlQnV0dG9uUm9sZToKQEAgLTMxNjgsMTEgKzMxNjcsMTAgQEAgY29uc3QgU3RyaW5n JiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphY3Rpb25WZXJiKCkgY29uc3QKICAgICBjYXNl IFdlYkNvcmVMaW5rUm9sZToKICAgICAgICAgcmV0dXJuIGxpbmtBY3Rpb247CiAgICAgZGVmYXVs dDoKLSAgICAgICAgcmV0dXJuIG5vQWN0aW9uOworICAgICAgICByZXR1cm4gbnVsbEF0b207CiAg ICAgfQogI2Vsc2UKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywgbm9BY3Rp b24sICgpKTsKLSAgICByZXR1cm4gbm9BY3Rpb247CisgICAgcmV0dXJuIG51bGxBdG9tOwogI2Vu ZGlmCiB9CiAgICAgCg==