120067 2013-08-20 07:20:51 -0700 Remove getPropertyDescriptor 2013-08-20 10:11:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough gtk-ews xan.lopez oldest_to_newest 919041 0 barraclough 2013-08-20 07:20:51 -0700 This is used by lookupGetter/lookupSetter – this can easily bee replaced by getPropertySlot. Since we'll be getting the GetterSetter from the slot in the setter case, rename isGetter() to isAccessor(). 919042 1 209194 barraclough 2013-08-20 07:27:44 -0700 Created attachment 209194 Fix 919058 2 209194 gtk-ews 2013-08-20 08:27:28 -0700 Comment on attachment 209194 Fix Attachment 209194 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1514595 919091 3 209194 oliver 2013-08-20 09:52:01 -0700 Comment on attachment 209194 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=209194&action=review Fix gtk before landing > Source/JavaScriptCore/ChangeLog:8 > + This is used by lookupGetter/lookupSetter – this can easily bee replaced by getPropertySlot. no unicode!!! 919106 4 barraclough 2013-08-20 10:11:27 -0700 Committed revision 154337. 209194 2013-08-20 07:27:44 -0700 2013-08-20 09:52:01 -0700 Fix 120067.1.patch text/plain 6988 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MzI1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEzLTA4LTIwICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMDY3 CisgICAgICAgIFJlbW92ZSBnZXRQcm9wZXJ0eURlc2NyaXB0b3IKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIHVzZWQgYnkgbG9va3VwR2V0 dGVyL2xvb2t1cFNldHRlciDigJPCoHRoaXMgY2FuIGVhc2lseSBiZWUgcmVwbGFjZWQgYnkgZ2V0 UHJvcGVydHlTbG90LgorICAgICAgICBTaW5jZSB3ZSdsbCBiZSBnZXR0aW5nIHRoZSBHZXR0ZXJT ZXR0ZXIgZnJvbSB0aGUgc2xvdCBpbiB0aGUgc2V0dGVyIGNhc2UsIHJlbmFtZSBpc0dldHRlcigp IHRvIGlzQWNjZXNzb3IoKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAg ICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAgICAgICAgICAgIC0gcmVtb3ZlIGdldFByb3Bl cnR5RGVzY3JpcHRvcgorICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0UHJvdG90eXBlLmNwcDoKKyAg ICAgICAgKEpTQzo6b2JqZWN0UHJvdG9GdW5jTG9va3VwR2V0dGVyKToKKyAgICAgICAgKEpTQzo6 b2JqZWN0UHJvdG9GdW5jTG9va3VwU2V0dGVyKToKKyAgICAgICAgICAgIC0gcmVwbGFjZSBjYWxs IHRvIGdldFByb3BlcnR5RGVzY3JpcHRvciB3aXRoIGdldFByb3BlcnR5U2xvdAorICAgICAgICAq IHJ1bnRpbWUvUHJvcGVydHlEZXNjcmlwdG9yLmg6CisgICAgICAgICogcnVudGltZS9Qcm9wZXJ0 eVNsb3QuaDoKKyAgICAgICAgKEpTQzo6UHJvcGVydHlTbG90Ojppc0FjY2Vzc29yKToKKyAgICAg ICAgKEpTQzo6UHJvcGVydHlTbG90Ojppc0NhY2hlYWJsZUdldHRlcik6CisgICAgICAgIChKU0M6 OlByb3BlcnR5U2xvdDo6Z2V0dGVyU2V0dGVyKToKKyAgICAgICAgICAgIC0gcmVuYW1lIGlzR2V0 dGVyKCkgdG8gaXNBY2Nlc3NvcigpCisKIDIwMTMtMDgtMjAgIEp1bGllbiBCcmlhbmNlYXUgIDxq YnJpYW5jZWF1QG5kcy5jb20+CiAKICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyMDA2 Mj4gTWlzc2luZyBlbnN1cmVTcGFjZSBjYWxsIGluIHNoNCBiYXNlbGluZSBKSVQuCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAxNTQz MTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIzODMsMTkgKzIzODMsNiBAQCBCdXR0ZXJmbHkqIEpTT2JqZWN0Ojpncm93 T3V0T2ZMaW5lU3RvcmFnCiAKIEdFVF9PV05fUFJPUEVSVFlfREVTQ1JJUFRPUl9JTVBMKEpTT2Jq ZWN0KQogCi1ib29sIEpTT2JqZWN0OjpnZXRQcm9wZXJ0eURlc2NyaXB0b3IoRXhlY1N0YXRlKiBl eGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eURlc2NyaXB0b3ImIGRlc2Ny aXB0b3IpCi17Ci0gICAgSlNPYmplY3QqIG9iamVjdCA9IHRoaXM7Ci0gICAgd2hpbGUgKHRydWUp IHsKLSAgICAgICAgaWYgKG9iamVjdC0+bWV0aG9kVGFibGUoKS0+Z2V0T3duUHJvcGVydHlEZXNj cmlwdG9yKG9iamVjdCwgZXhlYywgcHJvcGVydHlOYW1lLCBkZXNjcmlwdG9yKSkKLSAgICAgICAg ICAgIHJldHVybiB0cnVlOwotICAgICAgICBKU1ZhbHVlIHByb3RvdHlwZSA9IG9iamVjdC0+cHJv dG90eXBlKCk7Ci0gICAgICAgIGlmICghcHJvdG90eXBlLmlzT2JqZWN0KCkpCi0gICAgICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIG9iamVjdCA9IGFzT2JqZWN0KHByb3RvdHlwZSk7Ci0g ICAgfQotfQotCiBzdGF0aWMgYm9vbCBwdXREZXNjcmlwdG9yKEV4ZWNTdGF0ZSogZXhlYywgSlNP YmplY3QqIHRhcmdldCwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgUHJvcGVydHlEZXNjcmlw dG9yJiBkZXNjcmlwdG9yLCB1bnNpZ25lZCBhdHRyaWJ1dGVzLCBjb25zdCBQcm9wZXJ0eURlc2Ny aXB0b3ImIG9sZERlc2NyaXB0b3IpCiB7CiAgICAgaWYgKGRlc2NyaXB0b3IuaXNHZW5lcmljRGVz Y3JpcHRvcigpIHx8IGRlc2NyaXB0b3IuaXNEYXRhRGVzY3JpcHRvcigpKSB7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgJKHJldmlzaW9uIDE1NDMxMikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgJKHdvcmtpbmcgY29weSkK QEAgLTEyMyw3ICsxMjMsNiBAQCBwdWJsaWM6CiAgICAgYm9vbCBmYXN0R2V0T3duUHJvcGVydHlT bG90KEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90Jik7CiAgICAgYm9vbCBn ZXRQcm9wZXJ0eVNsb3QoRXhlY1N0YXRlKiwgUHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmKTsK ICAgICBib29sIGdldFByb3BlcnR5U2xvdChFeGVjU3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5h bWUsIFByb3BlcnR5U2xvdCYpOwotICAgIEpTX0VYUE9SVF9QUklWQVRFIGJvb2wgZ2V0UHJvcGVy dHlEZXNjcmlwdG9yKEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgUHJvcGVydHlEZXNjcmlwdG9y Jik7CiAKICAgICBzdGF0aWMgYm9vbCBnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPYmplY3QqLCBFeGVj U3RhdGUqLCBQcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYpOwogICAgIEpTX0VYUE9SVF9QUklW QVRFIHN0YXRpYyBib29sIGdldE93blByb3BlcnR5U2xvdEJ5SW5kZXgoSlNPYmplY3QqLCBFeGVj U3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYpOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0UHJvdG90eXBlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RQcm90b3R5cGUuY3BwCShy ZXZpc2lvbiAxNTQzMTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RQ cm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMiw2ICsyMiw3IEBACiAjaW5jbHVkZSAi T2JqZWN0UHJvdG90eXBlLmgiCiAKICNpbmNsdWRlICJFcnJvci5oIgorI2luY2x1ZGUgIkdldHRl clNldHRlci5oIgogI2luY2x1ZGUgIkpTRnVuY3Rpb24uaCIKICNpbmNsdWRlICJKU1N0cmluZy5o IgogI2luY2x1ZGUgIkpTU3RyaW5nQnVpbGRlci5oIgpAQCAtMTU1LDEwICsxNTYsMTAgQEAgRW5j b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBvYmplY3RQcm90bwogICAgIGlmIChleGVjLT5oYWRF eGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgp KTsKIAotICAgIFByb3BlcnR5RGVzY3JpcHRvciBkZXNjcmlwdG9yOwotICAgIGlmICh0aGlzT2Jq ZWN0LT5nZXRQcm9wZXJ0eURlc2NyaXB0b3IoZXhlYywgSWRlbnRpZmllcihleGVjLCBleGVjLT5h cmd1bWVudCgwKS50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYykpLCBkZXNjcmlwdG9yKQotICAg ICAgICAmJiBkZXNjcmlwdG9yLmdldHRlclByZXNlbnQoKSkKLSAgICAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZShkZXNjcmlwdG9yLmdldHRlcigpKTsKKyAgICBQcm9wZXJ0eVNsb3Qgc2xvdCh0 aGlzT2JqZWN0KTsKKyAgICBpZiAodGhpc09iamVjdC0+Z2V0UHJvcGVydHlTbG90KGV4ZWMsIElk ZW50aWZpZXIoZXhlYywgZXhlYy0+YXJndW1lbnQoMCkudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4 ZWMpKSwgc2xvdCkKKyAgICAgICAgJiYgc2xvdC5pc0FjY2Vzc29yKCkpCisgICAgICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoc2xvdC5nZXR0ZXJTZXR0ZXIoKS0+Z2V0dGVyKCkpOwogCiAgICAg cmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KQEAgLTE2OSwxMCArMTcw LDEwIEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgb2JqZWN0UHJvdG8KICAgICBpZiAo ZXhlYy0+aGFkRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNV bmRlZmluZWQoKSk7CiAKLSAgICBQcm9wZXJ0eURlc2NyaXB0b3IgZGVzY3JpcHRvcjsKLSAgICBp ZiAodGhpc09iamVjdC0+Z2V0UHJvcGVydHlEZXNjcmlwdG9yKGV4ZWMsIElkZW50aWZpZXIoZXhl YywgZXhlYy0+YXJndW1lbnQoMCkudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMpKSwgZGVzY3Jp cHRvcikKLSAgICAgICAgJiYgZGVzY3JpcHRvci5zZXR0ZXJQcmVzZW50KCkpCi0gICAgICAgIHJl dHVybiBKU1ZhbHVlOjplbmNvZGUoZGVzY3JpcHRvci5zZXR0ZXIoKSk7CisgICAgUHJvcGVydHlT bG90IHNsb3QodGhpc09iamVjdCk7CisgICAgaWYgKHRoaXNPYmplY3QtPmdldFByb3BlcnR5U2xv dChleGVjLCBJZGVudGlmaWVyKGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMp LT52YWx1ZShleGVjKSksIHNsb3QpCisgICAgICAgICYmIHNsb3QuaXNBY2Nlc3NvcigpKQorICAg ICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHNsb3QuZ2V0dGVyU2V0dGVyKCktPnNldHRlcigp KTsKIAogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiB9CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eURlc2NyaXB0b3IuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eURlc2NyaXB0 b3IuaAkocmV2aXNpb24gMTU0MzEzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv UHJvcGVydHlEZXNjcmlwdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTk0LDcgKzk0LDcgQEAgYm9v bCBDbGFzc05hbWU6OmdldE93blByb3BlcnR5RGVzY3JpcHRvcgogICAgIC8qIFdvcmthcm91bmQs IEpTRE9NV2luZG93OjpnZXRPd25Qcm9wZXJ0eVNsb3Qgc2VhcmNoZXMgdGhlIHByb3RvdHlwZSBj aGFpbi4gOi0oICovIFwKICAgICBpZiAoc2xvdC5zbG90QmFzZSgpICYmIHNsb3Quc2xvdEJhc2Uo KSAhPSBvYmplY3QpIFwKICAgICAgICAgcmV0dXJuIGZhbHNlOyBcCi0gICAgaWYgKHNsb3QuaXNH ZXR0ZXIoKSkgXAorICAgIGlmIChzbG90LmlzQWNjZXNzb3IoKSkgXAogICAgICAgICBkZXNjcmlw dG9yLnNldEFjY2Vzc29yRGVzY3JpcHRvcihzbG90LmdldHRlclNldHRlcigpLCBzbG90LmF0dHJp YnV0ZXMoKSk7IFwKICAgICBlbHNlIFwKICAgICAgICAgZGVzY3JpcHRvci5zZXREZXNjcmlwdG9y KHNsb3QuZ2V0VmFsdWUoZXhlYywgcHJvcGVydHlOYW1lKSwgc2xvdC5hdHRyaWJ1dGVzKCkpOyBc CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaAko cmV2aXNpb24gMTU0MzEzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVy dHlTbG90LmgJKHdvcmtpbmcgY29weSkKQEAgLTY5LDEwICs2OSwxMCBAQCBwdWJsaWM6CiAKICAg ICBib29sIGlzQ2FjaGVhYmxlKCkgY29uc3QgeyByZXR1cm4gbV9vZmZzZXQgIT0gaW52YWxpZE9m ZnNldDsgfQogICAgIGJvb2wgaXNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fcHJvcGVydHlUeXBl ID09IFR5cGVWYWx1ZTsgfQotICAgIGJvb2wgaXNHZXR0ZXIoKSBjb25zdCB7IHJldHVybiBtX3By b3BlcnR5VHlwZSA9PSBUeXBlR2V0dGVyOyB9CisgICAgYm9vbCBpc0FjY2Vzc29yKCkgY29uc3Qg eyByZXR1cm4gbV9wcm9wZXJ0eVR5cGUgPT0gVHlwZUdldHRlcjsgfQogICAgIGJvb2wgaXNDdXN0 b20oKSBjb25zdCB7IHJldHVybiBtX3Byb3BlcnR5VHlwZSA9PSBUeXBlQ3VzdG9tOyB9CiAgICAg Ym9vbCBpc0NhY2hlYWJsZVZhbHVlKCkgY29uc3QgeyByZXR1cm4gaXNDYWNoZWFibGUoKSAmJiBp c1ZhbHVlKCk7IH0KLSAgICBib29sIGlzQ2FjaGVhYmxlR2V0dGVyKCkgY29uc3QgeyByZXR1cm4g aXNDYWNoZWFibGUoKSAmJiBpc0dldHRlcigpOyB9CisgICAgYm9vbCBpc0NhY2hlYWJsZUdldHRl cigpIGNvbnN0IHsgcmV0dXJuIGlzQ2FjaGVhYmxlKCkgJiYgaXNBY2Nlc3NvcigpOyB9CiAgICAg Ym9vbCBpc0NhY2hlYWJsZUN1c3RvbSgpIGNvbnN0IHsgcmV0dXJuIGlzQ2FjaGVhYmxlKCkgJiYg aXNDdXN0b20oKTsgfQogCiAgICAgdW5zaWduZWQgYXR0cmlidXRlcygpIGNvbnN0IHsgcmV0dXJu IG1fYXR0cmlidXRlczsgfQpAQCAtODUsNyArODUsNyBAQCBwdWJsaWM6CiAKICAgICBHZXR0ZXJT ZXR0ZXIqIGdldHRlclNldHRlcigpIGNvbnN0CiAgICAgewotICAgICAgICBBU1NFUlQoaXNHZXR0 ZXIoKSk7CisgICAgICAgIEFTU0VSVChpc0FjY2Vzc29yKCkpOwogICAgICAgICByZXR1cm4gbV9k YXRhLmdldHRlci5nZXR0ZXJTZXR0ZXI7CiAgICAgfQogCg==