120060 2013-08-20 02:40:44 -0700 [Qt][WK2] Doesn't build without Plugin-process 2013-08-20 03:43:30 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abecsi cmarcelo commit-queue jturcotte kbalazs menard oldest_to_newest 918987 0 allan.jensen 2013-08-20 02:40:44 -0700 In Qt we enable netscape-plugin-api on Mac and Windows for WebKit1, but do not enable plugin-process since we do not support plugins on mac and win in WebKit2. This configuration currently does not build. 918989 1 209176 allan.jensen 2013-08-20 02:43:06 -0700 Created attachment 209176 Patch 918994 2 209178 allan.jensen 2013-08-20 03:14:23 -0700 Created attachment 209178 Patch 918997 3 209178 jturcotte 2013-08-20 03:19:44 -0700 Comment on attachment 209178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209178&action=review > Source/WebKit2/Target.pri:18 > +enable?(netscape_plugin_api):enable?(plugin_architecture_unsupported) { enable?(plugin_architecture_unsupported) doesn't read quite well, but well, a hack is a hack. r=me 919000 4 allan.jensen 2013-08-20 03:43:30 -0700 Committed r154321: <http://trac.webkit.org/changeset/154321> 209176 2013-08-20 02:43:06 -0700 2013-08-20 03:14:19 -0700 Patch bug-120060-20130820114305.patch text/plain 1334 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWJhZTc5MTA3NzhlZWE1 NmJhMDcyODVjODk4YWQxMjA5OTY1YWY3MS4uNjk4NmRjMDhhMGIyYjVlZWVmNjFhNDhhZDk5MDg4 MmJhY2U3NTAzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTIwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF1bV0syXSBEb2Vzbid0IGJ1aWxkIHdpdGhvdXQgUGx1Z2luLXByb2Nlc3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDA2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgbmV0c2NhcGUgcGx1 Z2luIGFwaSBpbiBXZWJLaXQyIHdoZW4gcGx1Z2luIHByb2Nlc3MgaXMgbm90IGVuYWJsZWQuCisK KyAgICAgICAgKiBUYXJnZXQucHJpOgorCiAyMDEzLTA4LTE4ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTE5OTg5PiBNYWtl IHVzZSBvZiBOb2RlOjpvd25lckRvY3VtZW50IGEgY29tcGlsZSB0aW1lIGVycm9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9UYXJnZXQucHJpIGIvU291cmNlL1dlYktpdDIvVGFyZ2V0LnBy aQppbmRleCBlMTUzOGI3OGM3MWYxNDcyODQxOWNiNTM3YThhMTczYzYyMTk0NzBlLi5kZmZmZmMw Zjk4YmFkNWQ2NThkNjdmODNmMWM4Njk5MjYwODU5NGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9UYXJnZXQucHJpCisrKyBiL1NvdXJjZS9XZWJLaXQyL1RhcmdldC5wcmkKQEAgLTE1LDYg KzE1LDEyIEBAIENPTkZJRyArPSBzdGF0aWNsaWIKIAogUkVTT1VSQ0VTICs9ICQkUFdEL1dlYktp dDIucXJjCiAKKyFlbmFibGU/KHBsdWdpbl9wcm9jZXNzKTplbmFibGU/KG5ldHNjYXBlX3BsdWdp bl9hcGkpIHsKKyAgICAjIE5TQVBJIGluIFdlYktpdDIgcmVxdWlyZXMgUGx1Z2luUHJvY2VzcywK KyAgICAjIGJ1dCBpdCBtYXkgaGF2ZSBiZWVuIGVuYWJsZWQgZm9yIFdlYktpdDEuCisgICAgV0VC S0lUX0NPTkZJRyAtPSBuZXRzY2FwZV9wbHVnaW5fYXBpCit9CisKIEhFQURFUlMgKz0gXAogICAg IFBsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnREZWNvZGVyLmggXAogICAgIFBsYXRmb3JtL0NvcmVJ UEMvQXJndW1lbnRFbmNvZGVyLmggXAo= 209178 2013-08-20 03:14:23 -0700 2013-08-20 03:19:43 -0700 Patch bug-120060-20130820121422.patch text/plain 1401 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWJhZTc5MTA3NzhlZWE1 NmJhMDcyODVjODk4YWQxMjA5OTY1YWY3MS4uYzA4NGRlMWM1MjBjYzU0ZmFkMzViNzMxN2FjMGZk ZmNiYTE1ZTEwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTIwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF1bV0syXSBEb2Vzbid0IGJ1aWxkIHdpdGhvdXQgUGx1Z2luLXByb2Nlc3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDA2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgbmV0c2NhcGUgcGx1 Z2luIGFwaSBpbiBXZWJLaXQyIHdoZW4gdGhlIHBsdWdpbiBhcmNoaXRlY3R1cmUgaXMgdW5zdXBw b3J0ZWQgZm9yIFdlYktpdDIuCisKKyAgICAgICAgKiBUYXJnZXQucHJpOgorCiAyMDEzLTA4LTE4 ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTE5OTg5PiBNYWtlIHVzZSBvZiBOb2RlOjpvd25lckRvY3VtZW50IGEgY29tcGls ZSB0aW1lIGVycm9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9UYXJnZXQucHJpIGIvU291 cmNlL1dlYktpdDIvVGFyZ2V0LnByaQppbmRleCBlMTUzOGI3OGM3MWYxNDcyODQxOWNiNTM3YThh MTczYzYyMTk0NzBlLi43YmFjMzgzZjJmNGVkZTNhMWM5YzQzMWVkOTY2ZTRjNzFhYmU0NTJiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9UYXJnZXQucHJpCisrKyBiL1NvdXJjZS9XZWJLaXQy L1RhcmdldC5wcmkKQEAgLTE1LDYgKzE1LDEyIEBAIENPTkZJRyArPSBzdGF0aWNsaWIKIAogUkVT T1VSQ0VTICs9ICQkUFdEL1dlYktpdDIucXJjCiAKK2VuYWJsZT8obmV0c2NhcGVfcGx1Z2luX2Fw aSk6ZW5hYmxlPyhwbHVnaW5fYXJjaGl0ZWN0dXJlX3Vuc3VwcG9ydGVkKSB7CisgICAgIyBOZXRz Y2FwZSBwbHVnaW5zIGFyZSBub3Qgc3VwcG9ydGVkIGZvciB0aGlzIGFyY2hpdGVjdHVyZSBvbiBX ZWJLaXQyLAorICAgICMgYnV0IHRoZXkgbWF5IGhhdmUgYmVlbiBlbmFibGVkIGZvciBXZWJLaXQx LgorICAgIFdFQktJVF9DT05GSUcgLT0gbmV0c2NhcGVfcGx1Z2luX2FwaQorfQorCiBIRUFERVJT ICs9IFwKICAgICBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RGVjb2Rlci5oIFwKICAgICBQbGF0 Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5oIFwK