12005 2006-12-27 14:20:42 -0800 REGRESSION(r17256-17272): Multiple history entries created 2007-04-09 17:22:50 -0700 1 1 1 Unclassified WebKit History 420+ Mac OS X 10.4 RESOLVED FIXED http://cbs4boston.com/ HasReduction, InRadar, Regression P1 Normal --- 1 dacarson webkit-unassigned beidson mjs mrowe oldest_to_newest 39375 0 dacarson 2006-12-27 14:20:42 -0800 When I load CBS4Boston web site, three history entries are created. The history items are the original page, and two entitled 'Click here to find out more!' Loading the same site in shipping Safari and FF, only one history entry is created. Marked it as regression as this is not a problem in shipping safari. 34590 1 mrowe 2007-01-16 19:19:22 -0800 <rdar://problem/4928650> 34594 2 beidson 2007-01-16 19:30:39 -0800 Theres been alot of loader and history work done lately... any chance you can regress this using the nightlys? 34597 3 dev+webkit 2007-01-16 19:35:39 -0800 This is still happening with r18892 34548 4 beidson 2007-01-16 20:30:12 -0800 Regress using the nightlys, meaning going back through the nightlys and seeing where the problem first appears 32690 5 mrowe 2007-01-24 20:22:21 -0800 The additional history entries come from the titles advertisements that are displayed in iframes. 32684 6 mrowe 2007-01-24 20:33:26 -0800 This regression would appear to be introduced between r17256 and r17282, but it's hard to narrow it down further as the URL in question crashes the nightly builds in that range. 32681 7 12659 mrowe 2007-01-24 21:20:38 -0800 Created attachment 12659 Reduction The ad-related JS on the page creates an iframe via document.write, then straight away sets its src property. It appears that setting the src property to the same value is triggering a fresh load which creates a history entry. 25309 8 mjs 2007-02-07 05:40:53 -0800 *** Bug 12650 has been marked as a duplicate of this bug. *** 25310 9 mjs 2007-02-07 05:42:27 -0800 From duplicate: <rdar://problem/4921797> 19510 10 darin 2007-03-11 10:35:51 -0700 (In reply to comment #7) > The ad-related JS on the page creates an iframe via document.write, then > straight away sets its src property. It appears that setting the src property > to the same value is triggering a fresh load which creates a history entry. Setting the src property is always supposed to cause a reload. But that was buggy in older version of WebKit. It didn't trigger a load if the URL was the same. It's possible that we need to trigger a load yet somehow know not to put things in the back/forward list in this case. 15772 11 beidson 2007-04-03 17:56:37 -0700 Using the reduction, I regressed this further with the nightlies to the 17256-17272 range 15774 12 beidson 2007-04-03 18:49:52 -0700 This broke in http://trac.webkit.org/projects/webkit/changeset/17267 Geoff's seemingly simplistic change that was attempting to clean up loading code, but there's something subtle it tweaked re: user gesture versus non-user gesture here that I need to figure out. 15261 13 beidson 2007-04-09 17:22:50 -0700 The reduction Mark posted way key - it was well understood and a fix was committed in r20813! Yay! 12659 2007-01-24 21:20:38 -0800 2007-01-24 21:20:38 -0800 Reduction webkit-bug-12005-reduction.html text/html 298 mrowe PGh0bWw+CjxoZWFkPgogICAgPHRpdGxlPnVudGl0bGVkPC90aXRsZT4KPC9oZWFkPgo8Ym9keT4K ICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgICAgICBkb2N1bWVudC53cml0 ZSgnPGlmcmFtZSBpZD0iZnJhbWUiIHNyYz0iaHR0cDovL3JlZGRpdC5jb20vIiB3aWR0aD0iNTAw IiBoZWlnaHQ9IjUwMCI+PC9pZnJhbWU+Jyk7CiAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2ZyYW1lJykuc3JjID0gImh0dHA6Ly9yZWRkaXQuY29tLyI7CiAgICA8L3NjcmlwdD4KPC9i b2R5Pgo8L2h0bWw+Cg==