120020 2013-08-19 12:29:55 -0700 Change Set 154207 causes wrong register to be used for 32 bit tests 2013-08-19 14:25:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin oldest_to_newest 918736 0 msaboff 2013-08-19 12:29:55 -0700 The change to branchTest32(ResultCondition, RegisterID, TrustedImm32) in change set 154207 breaks the testing of registers esp, ebp, esi and edi. Due to the encoding of registers for 32bit addressing, registers numbered 4-7 (esp, ebp, esi and edi) become the upper half of registers 0-3 (ah, ch, dh and bh respectively). Therefore a call to branchTestPtr(Zero, GPRInfo::edi, TrustedImm32(7)) while emit a testb $7, %bh instruction. For 64 bit addressing, a REX prefix is used to assure the right lower 8 bits or a register are used. 918761 1 209115 msaboff 2013-08-19 13:28:58 -0700 Created attachment 209115 Patch Limit the prior optimization to registers eax, ecx, edx and ebx per intel documentation. 918794 2 msaboff 2013-08-19 14:25:34 -0700 Committed r154298: <http://trac.webkit.org/changeset/154298> 209115 2013-08-19 13:28:58 -0700 2013-08-19 13:44:11 -0700 Patch 120020.patch text/plain 1751 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MjkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTA4LTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAwMjAgQ2hhbmdl IFNldCAxNTQyMDcgY2F1c2VzIHdyb25nIHJlZ2lzdGVyIHRvIGJlIHVzZWQgZm9yIDMyIGJpdCB0 ZXN0cworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo YW5nZSBicmFuc2hUZXN0MzIgdG8gb25seSB1c2UgdGhlIGJ5dGUgZm9yIDggYml0IHRlc3Qgb24g dGhlIGxvd2VyIDQgcmVnaXN0ZXJzLgorICAgICAgICBSZWdpc3RlcnMgNCB0aHJvdWdoIDcgYXMg Ynl0ZSByZWdpc2VycyBhcmUgYWgsIGNoLCBkaCBhbmQgYmggaW5zdGVhZCBvZiBzcCwgYnAsIHNp IGFuZCBkaS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5o OgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6YnJhbmNoVGVzdDMyKToK KyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChKU0M6 OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmZpbGxTcGVjdWxhdGVDZWxsKToKKwogMjAxMy0wOC0xNiAg T2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwczovL3dlYmtp dC5vcmcvYi8xMTk4NjA+IENyYXNoIGR1cmluZyBleGNlcHRpb24gdW53aW5kaW5nCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt Ymxlclg4NkNvbW1vbi5oCShyZXZpc2lvbiAxNTQyODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgJKHdvcmtpbmcgY29weSkKQEAg LTExNDAsNyArMTE0MCw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIGlmIChtYXNrLm1fdmFs dWUgPT0gLTEpCiAgICAgICAgICAgICBtX2Fzc2VtYmxlci50ZXN0bF9ycihyZWcsIHJlZyk7Ci0g ICAgICAgIGVsc2UgaWYgKCEobWFzay5tX3ZhbHVlICYgfjB4ZmYpKQorICAgICAgICBlbHNlIGlm ICghKG1hc2subV92YWx1ZSAmIH4weGZmKSAmJiByZWcgPCBYODZSZWdpc3RlcnM6OmVzcCkgLy8g VXNpbmcgZXNwIGFuZCBncmVhdGVyIGFzIGEgYnl0ZSByZWdpc3RlciB5aWVsZHMgdGhlIHVwcGVy IGhhbGYgb2YgdGhlIDE2IGJpdCByZWdpc3RlcnMgYXgsIGN4LCBkeCBhbmQgYngsIGUuZy4gZXNw LCByZWdpc3RlciA0LCBpcyBhY3R1YWxseSBhaC4KICAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRl c3RiX2k4cihtYXNrLm1fdmFsdWUsIHJlZyk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIG1f YXNzZW1ibGVyLnRlc3RsX2kzMnIobWFzay5tX3ZhbHVlLCByZWcpOwo=