120012 2013-08-19 10:01:48 -0700 100% cpu usage for "transition: opacity" animation 2013-08-29 04:10:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified CLOSED FIXED http://www.webkit.org/blog-files/leaves/ P2 Normal --- 1 luciano.wolf luciano.wolf cmarcelo commit-queue dino hugo.lima jb.seo jturcotte luiz noam sergio simon.fraser zeno oldest_to_newest 918664 0 209095 luciano.wolf 2013-08-19 10:01:48 -0700 Created attachment 209095 Proposed fix - WIP - doesn't include ChangeLog yet. While running leaves demo, the CPU tops at 100% for WebProcess. Even simple examples like LayoutTests/compositing/repaint/opacity-between-absolute.html does the same. Doing some research I've found that CoordinatedLayerTreeHost::scheduleAnimation() does set a timer for animation and right after that it schedules again the same timer with 0. This behavior could be avoided if we call scheduleLayerFlush() before m_layerFlushTimer.startOneShot(m_coordinator->nextAnimationServiceTime()). I've detected this issue on NIX port, but I wasn't able to compile Qt, GTK or EFL. 919265 1 jb.seo 2013-08-20 15:39:55 -0700 It also detected and resolved by your idea with Qt port. 921625 2 luciano.wolf 2013-08-27 12:23:08 -0700 So, is this patch useful? Should I updated it with ChangeLog info and ask for review? 921632 3 noam 2013-08-27 12:59:55 -0700 (In reply to comment #2) > So, is this patch useful? Should I updated it with ChangeLog info and ask for review? Yes please! 921645 4 209793 luciano.wolf 2013-08-27 13:44:59 -0700 Created attachment 209793 Patch 921694 5 jb.seo 2013-08-27 15:13:59 -0700 I added a reivew as a comment. (Because, I don't have the auth.) Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:399 > scheduleLayerFlush(); I think, scheduleLayerFlush() at this moment is meaningless. How about erase that and insert below? if(!m_layerFlushSchedulingEnabled) return; 921696 6 209793 commit-queue 2013-08-27 15:22:11 -0700 Comment on attachment 209793 Patch Clearing flags on attachment: 209793 Committed r154711: <http://trac.webkit.org/changeset/154711> 921697 7 commit-queue 2013-08-27 15:22:13 -0700 All reviewed patches have been landed. Closing bug. 922396 8 luciano.wolf 2013-08-29 04:10:42 -0700 (In reply to comment #5) > I added a reivew as a comment. (Because, I don't have the auth.) > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:399 > > scheduleLayerFlush(); > > I think, scheduleLayerFlush() at this moment is meaningless. > How about erase that and insert below? > > if(!m_layerFlushSchedulingEnabled) > return; Sorry, I missed your comment among commit messages :) I'll test and provide an updated patch. Thanks for your suggestion. 209095 2013-08-19 10:01:48 -0700 2013-08-27 13:44:53 -0700 Proposed fix - WIP - doesn't include ChangeLog yet. proposed-patch.diff text/plain 656 luciano.wolf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm8KaW5kZXggNDcxMjQxYy4uNmQ3YzljMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRy ZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRp bmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC0zOTcsOCArMzk3 LDggQEAgdm9pZCBDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OnNjaGVkdWxlQW5pbWF0aW9uKCkK ICAgICBpZiAobV9sYXllckZsdXNoVGltZXIuaXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgbV9sYXllckZsdXNoVGltZXIuc3RhcnRPbmVTaG90KG1fY29vcmRpbmF0b3ItPm5leHRB bmltYXRpb25TZXJ2aWNlVGltZSgpKTsKICAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKKyAgICBt X2xheWVyRmx1c2hUaW1lci5zdGFydE9uZVNob3QobV9jb29yZGluYXRvci0+bmV4dEFuaW1hdGlv blNlcnZpY2VUaW1lKCkpOwogfQogI2VuZGlmCgo= 209793 2013-08-27 13:44:59 -0700 2013-08-27 15:22:10 -0700 Patch bug-120012-20130827174459.patch text/plain 1716 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmI1NzQyYzVmYWNiNDM2 ZDY4YTYzZjk0ZDk3NjM5YjJlMjRkNTdjNC4uMGVkNjFjZmE4NDZhMDY1NDQ3ODdlMmMyODQ4ZDZm ZDllYzkzOTdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTI3ICBMdWNp YW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICAxMDAlIGNw dSB1c2FnZSBmb3IgInRyYW5zaXRpb246IG9wYWNpdHkiIGFuaW1hdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMDEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2NoZWR1bGUgYW5pbWF0aW9uIHRp bWVyIGFmdGVyIHNjaGVkdWxpbmcgYSBsYXllciBmbHVzaC4gVGhpcyB3YXkgaXQKKyAgICAgICAg d29uJ3Qgb3ZlcndyaXRlIGFuaW1hdGlvbiB0aW1lciB3aXRoICIwIiwgdGh1cyBhdm9pZGluZyAx MDAlIGNwdSB1c2FnZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6c2NoZWR1bGVBbmltYXRpb24pOgorCiAyMDEzLTA4 LTI3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dL Ml1bU291cF0gQWRkIFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OndlYkZyYW1lTG9hZGVyQ2xp ZW50KCkgYWZ0ZXIgcjE1NDQ5MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggM2Y5OWM4NzlmNDA4OTYyOTI2ZGE0 MDNmY2YxNTdjYmU1ZDMxZTVmZS4uMTRlZTkzNjIzMTc0MDQ5YTE4NmZhNDRkZjhhZGVmMDYxZDll Njg3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRl ZExheWVyVHJlZUhvc3QuY3BwCkBAIC0zOTYsOCArMzk2LDggQEAgdm9pZCBDb29yZGluYXRlZExh eWVyVHJlZUhvc3Q6OnNjaGVkdWxlQW5pbWF0aW9uKCkKICAgICBpZiAobV9sYXllckZsdXNoVGlt ZXIuaXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9sYXllckZsdXNoVGltZXIu c3RhcnRPbmVTaG90KG1fY29vcmRpbmF0b3ItPm5leHRBbmltYXRpb25TZXJ2aWNlVGltZSgpKTsK ICAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKKyAgICBtX2xheWVyRmx1c2hUaW1lci5zdGFydE9u ZVNob3QobV9jb29yZGluYXRvci0+bmV4dEFuaW1hdGlvblNlcnZpY2VUaW1lKCkpOwogfQogI2Vu ZGlmCiAK