11998 2006-12-27 08:15:10 -0800 Incorrect serialization of quotation marks in XML attributes. 2006-12-30 00:54:10 -0800 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED http://www.yvon-thoraval.com/Canvas/menu.html P2 Major --- 1 yt.dev ap ap oldest_to_newest 39482 0 yt.dev 2006-12-27 08:15:10 -0800 seems to be due to this XPath syntax : <a> <xsl:attribute name="href"> <xsl:value-of select="concat('javascript:setPage(&quot;',link,'&quot;);')"/> </xsl:attribute> <xsl:value-of select="label"/> </a> notice exactly same syntax works within Firefox 2 and Opera 9.1 39446 1 12068 ap 2006-12-27 11:40:25 -0800 Created attachment 12068 test case The problem is that XSLTProcessor re-parses the stylesheet (evil!), while serializer handles quotation marks incorrectly. Here is a workaround: <xsl:value-of select="concat('javascript:setPage(%22',link,'%22);')"/> See also: bug 11947. 39013 2 12110 ap 2006-12-29 11:22:30 -0800 Created attachment 12110 proposed fix 38965 3 12110 mitz 2006-12-29 15:32:38 -0800 Comment on attachment 12110 proposed fix + document.getElementById("result").textContent += ": " + (new XMLSerializer()).serializeToString(document.getElementsByTagName('div')[1]); Doesn't work so well with the initial text in result (I guess originally it was just FAIL) The patch looks very straightforward, so assuming it doesn't affect any existing tests, r=me. 38936 4 ap 2006-12-30 00:54:10 -0800 Committed revision 18484. (In reply to comment #3) > Doesn't work so well with the initial text in result (I guess originally it was > just FAIL) Oops, indeed. Fixed. 12068 2006-12-27 11:40:25 -0800 2006-12-27 11:40:25 -0800 test case serialize-quot.xhtml application/xhtml+xml 328 ap PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgo8aGVhZD4KPHRpdGxl Lz4KPHNjcmlwdD4KZnVuY3Rpb24gdGVzdCgpIHsKICBhbGVydCgiU2VlIGhvdyB0aGUgYXR0cmli dXRlIHZhbHVlIGlzIHNlcmlhbGl6ZWQ6IFxuIiArIAogICAgICAgICAgKG5ldyBYTUxTZXJpYWxp emVyKCkpLnNlcmlhbGl6ZVRvU3RyaW5nKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0RGl2 IikpKTsKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgo8ZGl2IGlk PSJ0ZXN0RGl2IiBhdHRyPSImcXVvdDsiLz4KPC9ib2R5Pgo8L2h0bWw+Cg== 12110 2006-12-29 11:22:30 -0800 2006-12-29 15:32:38 -0800 proposed fix 11998r1_patch.txt text/plain 5789 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4NDc1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMTItMjkgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExOTk4CisgICAgICAgIEluY29ycmVjdCBzZXJpYWxpemF0aW9uIG9mIHF1b3RhdGlvbiBt YXJrcyBpbiBYTUwgYXR0cmlidXRlcy4KKworICAgICAgICAqIGZhc3QvZG9tL3NlcmlhbGl6ZS1h dHRyaWJ1dGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9zZXJpYWxp emUtYXR0cmlidXRlLnhodG1sOiBBZGRlZC4KKwogMjAwNi0xMi0yOSAgRXJpYyBTZWlkZWwgIDxl cmljQGVzZWlkZWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IG9sbGllai4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZG9tL3NlcmlhbGl6ZS1hdHRyaWJ1dGUtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3NlcmlhbGl6ZS1hdHRyaWJ1dGUtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vc2VyaWFsaXplLWF0 dHJpYnV0ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGVzdCBm b3IgYnVnIDExOTk4OiBJbmNvcnJlY3Qgc2VyaWFsaXphdGlvbiBvZiBxdW90YXRpb24gbWFya3Mg aW4gWE1MIGF0dHJpYnV0ZXMuCisKK1NVQ0NFU1MKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5 b3V0VGVzdHMvZmFzdC9kb20vc2VyaWFsaXplLWF0dHJpYnV0ZS1leHBlY3RlZC50eHQKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFpbgpOYW1lOiBzdm46ZW9sLXN0 eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vc2VyaWFsaXplLWF0 dHJpYnV0ZS54aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9zZXJpYWxp emUtYXR0cmlidXRlLnhodG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v c2VyaWFsaXplLWF0dHJpYnV0ZS54aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMyBAQAor PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgorPGhlYWQ+Cis8dGl0 bGUvPgorPHNjcmlwdD4KKzwhW0NEQVRBWworZnVuY3Rpb24gdGVzdCgpIHsKKworICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKworICB0cnkgeworICAgIHNlcmlhbGl6ZWQgPSAobmV3IFhNTFNlcmlhbGl6ZXIo KSkuc2VyaWFsaXplVG9TdHJpbmcoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3REaXZcIicm PD4iKSk7CisgICAgaWYgKHNlcmlhbGl6ZWQgPT0gIjxkaXYgeG1sbnM9XCJodHRwOi8vd3d3Lncz Lm9yZy8xOTk5L3hodG1sXCIgaWQ9XCJ0ZXN0RGl2JnF1b3Q7JyZhbXA7Jmx0OyZndDtcIi8+IiB8 fAorICAgICAgICBzZXJpYWxpemVkID09ICI8ZGl2IHhtbG5zPVwiaHR0cDovL3d3dy53My5vcmcv MTk5OS94aHRtbFwiIGlkPVwidGVzdERpdiZxdW90OycmYW1wOyZsdDsmZ3Q7XCI+PC9kaXY+IikK KyAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS50ZXh0Q29udGVudCA9ICJT VUNDRVNTIjsKKyAgICBlbHNlCisgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0 IikudGV4dENvbnRlbnQgKz0gIjogIiArIChuZXcgWE1MU2VyaWFsaXplcigpKS5zZXJpYWxpemVU b1N0cmluZyhkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnZGl2JylbMV0pOworICB9IGNh dGNoIChleCkgeworICAgIGFsZXJ0KGV4KTsKKyAgfQorfQorXV0+Cis8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpOyI+Cis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk5OCI+YnVnIDExOTk4PC9hPjoKK0lu Y29ycmVjdCBzZXJpYWxpemF0aW9uIG9mIHF1b3RhdGlvbiBtYXJrcyBpbiBYTUwgYXR0cmlidXRl cy48L3A+Cis8ZGl2IGlkPSJyZXN1bHQiPkZBSUw6IGNhbm5vdCBmaW5kIGFuIGVsZW1lbnQuPC9k aXY+CisKKzwhLS0gQ3VycmVudGx5LCBXZWJLaXQgZG9lc24ndCBzZXJpYWxpemUgdGhlIG5hbWVz cGFjZSB1bmxlc3MgaXQncyBleHBsaWNpdGx5IHNwZWNpZmllZCwgYnVnIDUyNjIgLS0+Cis8ZGl2 IHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiBpZD0idGVzdERpdiYjMzQ7JiMz OTsmIzM4OyYjNjA7JiM2MjsiLz4KKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMg b246IExheW91dFRlc3RzL2Zhc3QvZG9tL3NlcmlhbGl6ZS1hdHRyaWJ1dGUueGh0bWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC94bWwKCkluZGV4OiBXZWJDb3JlL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0NzUp CisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisy MDA2LTEyLTI5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk5OAorICAgICAgICBJbmNvcnJlY3Qgc2VyaWFsaXph dGlvbiBvZiBxdW90YXRpb24gbWFya3MgaW4gWE1MIGF0dHJpYnV0ZXMuCisKKyAgICAgICAgVGVz dDogZmFzdC9kb20vc2VyaWFsaXplLWF0dHJpYnV0ZS54aHRtbAorCisgICAgICAgICogZWRpdGlu Zy9tYXJrdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZXNjYXBlVGV4dEZvck1hcmt1cCk6IEFk ZGVkIGFuIGlzQXR0cmlidXRlVmFsdWUgcGFyYW1ldGVyLCBhcyB0aGUgcXVvdGF0aW9uIG1hcmsK KyAgICAgICAgb25seSBuZWVkcyB0byBiZSBlbmNvZGVkIGluIGF0dHJpYnV0ZSB2YWx1ZXMuCisg ICAgICAgIChXZWJDb3JlOjpzdGFydE1hcmt1cCk6IFBhc3MgYXBwcm9wcmlhdGUgaXNBdHRyaWJ1 dGVWYWx1ZSB0byBlc2NhcGVUZXh0Rm9yTWFya3VwKCkuCisKIDIwMDYtMTItMjkgIEVyaWMgU2Vp ZGVsICA8ZXJpY0Blc2VpZGVsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBhcC4KSW5kZXg6 IFdlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGlu Zy9tYXJrdXAuY3BwCShyZXZpc2lvbiAxODQ3NCkKKysrIFdlYkNvcmUvZWRpdGluZy9tYXJrdXAu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSw3ICs2MSw3IEBAIHVzaW5nIG5hbWVzcGFjZSBIVE1M TmFtZXM7CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRTZWxmQ2xvc2UoY29uc3QgTm9kZSAq bm9kZSk7CiAKLXN0YXRpYyBEZXByZWNhdGVkU3RyaW5nIGVzY2FwZVRleHRGb3JNYXJrdXAoY29u c3QgRGVwcmVjYXRlZFN0cmluZyAmaW4pCitzdGF0aWMgRGVwcmVjYXRlZFN0cmluZyBlc2NhcGVU ZXh0Rm9yTWFya3VwKGNvbnN0IERlcHJlY2F0ZWRTdHJpbmcgJmluLCBib29sIGlzQXR0cmlidXRl VmFsdWUpCiB7CiAgICAgRGVwcmVjYXRlZFN0cmluZyBzID0gIiI7CiAKQEAgLTc3LDYgKzc3LDEy IEBAIHN0YXRpYyBEZXByZWNhdGVkU3RyaW5nIGVzY2FwZVRleHRGb3JNYXIKICAgICAgICAgICAg IGNhc2UgJz4nOgogICAgICAgICAgICAgICAgIHMgKz0gIiZndDsiOwogICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgY2FzZSAnIic6CisgICAgICAgICAgICAgICAgaWYgKGlzQXR0 cmlidXRlVmFsdWUpIHsKKyAgICAgICAgICAgICAgICAgICAgcyArPSAiJnF1b3Q7IjsKKyAgICAg ICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg IC8vIGZhbGwgdGhyb3VnaAogICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICBz ICs9IGluW2ldOwogICAgICAgICB9CkBAIC0xNjMsNyArMTY5LDcgQEAgc3RhdGljIERlcHJlY2F0 ZWRTdHJpbmcgc3RhcnRNYXJrdXAoY29ucwogICAgICAgICAgICAgfQogICAgICAgICAgICAgYm9v bCB1c2VSZW5kZXJlZFRleHQgPSBhbm5vdGF0ZSAmJiAhZW5jbG9zaW5nTm9kZVdpdGhUYWcoY29u c3RfY2FzdDxOb2RlKj4obm9kZSksIHNlbGVjdFRhZyk7CiAgICAgICAgICAgICAKLSAgICAgICAg ICAgIERlcHJlY2F0ZWRTdHJpbmcgbWFya3VwID0gdXNlUmVuZGVyZWRUZXh0ID8gZXNjYXBlVGV4 dEZvck1hcmt1cChyZW5kZXJlZFRleHQobm9kZSwgcmFuZ2UpKSA6IGVzY2FwZVRleHRGb3JNYXJr dXAoc3RyaW5nVmFsdWVGb3JSYW5nZShub2RlLCByYW5nZSkuZGVwcmVjYXRlZFN0cmluZygpKTsg ICAgICAgICAgICAKKyAgICAgICAgICAgIERlcHJlY2F0ZWRTdHJpbmcgbWFya3VwID0gdXNlUmVu ZGVyZWRUZXh0ID8gZXNjYXBlVGV4dEZvck1hcmt1cChyZW5kZXJlZFRleHQobm9kZSwgcmFuZ2Up LCBmYWxzZSkgOiBlc2NhcGVUZXh0Rm9yTWFya3VwKHN0cmluZ1ZhbHVlRm9yUmFuZ2Uobm9kZSwg cmFuZ2UpLmRlcHJlY2F0ZWRTdHJpbmcoKSwgZmFsc2UpOwogICAgICAgICAgICAgaWYgKGRlZmF1 bHRTdHlsZSkgewogICAgICAgICAgICAgICAgIE5vZGUgKmVsZW1lbnQgPSBub2RlLT5wYXJlbnRO b2RlKCk7CiAgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQpIHsKQEAgLTIzNyw3ICsyNDMsNyBA QCBzdGF0aWMgRGVwcmVjYXRlZFN0cmluZyBzdGFydE1hcmt1cChjb25zCiAgICAgICAgICAgICAg ICAgICAgIG1hcmt1cCArPSAiICIgKyBhdHRyLT5uYW1lKCkubG9jYWxOYW1lKCkuZGVwcmVjYXRl ZFN0cmluZygpOwogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgbWFy a3VwICs9ICIgIiArIGF0dHItPm5hbWUoKS50b1N0cmluZygpLmRlcHJlY2F0ZWRTdHJpbmcoKTsK LSAgICAgICAgICAgICAgICBtYXJrdXAgKz0gIj1cIiIgKyBlc2NhcGVUZXh0Rm9yTWFya3VwKHZh bHVlLmRlcHJlY2F0ZWRTdHJpbmcoKSkgKyAiXCIiOworICAgICAgICAgICAgICAgIG1hcmt1cCAr PSAiPVwiIiArIGVzY2FwZVRleHRGb3JNYXJrdXAodmFsdWUuZGVwcmVjYXRlZFN0cmluZygpLCB0 cnVlKSArICJcIiI7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGlm IChhZGRpdGlvbmFsU3R5bGUubGVuZ3RoKCkgPiAwKQo=