119948 2013-08-17 08:21:42 -0700 Change drag-specific clipboard writing in DragController to go straight to Pasteboard, not forward through Clipboard 2013-08-20 09:48:48 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 115980 1 darin darin commit-queue esprehn+autocc kangil.han oldest_to_newest 918298 0 darin 2013-08-17 08:21:42 -0700 Change drag-specific clipboard writing in DragController to go straight to Pasteboard, not forward through Clipboar 918299 1 208997 darin 2013-08-17 08:23:41 -0700 Created attachment 208997 Patch 918300 2 208997 kling 2013-08-17 08:31:03 -0700 Comment on attachment 208997 Patch LGTM 918301 3 darin 2013-08-17 08:31:44 -0700 Committed r154231: <http://trac.webkit.org/changeset/154231> 208997 2013-08-17 08:23:41 -0700 2013-08-17 08:31:03 -0700 Patch bug-119948-20130817082340.patch text/plain 5440 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTMwMTJkMjE3OTIyZDQw ZTQ1ZDFmMjVlZDliNDYwZTY1NzNhZWZkNy4uOGExYTY0ZDdiN2E0YTU3YmI2YzUwNDZjYjdiZDA3 ZTZkYjFkNWZhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTA4LTE3ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTE5OTQ4PiBDaGFuZ2UgZHJhZy1zcGVjaWZpYyBjbGlwYm9hcmQgd3JpdGluZyBpbiBEcmFn Q29udHJvbGxlciB0byBnbyBzdHJhaWdodCB0byBQYXN0ZWJvYXJkLCBub3QgZm9yd2FyZCB0aHJv dWdoIENsaXBib2FyZAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZG9tL0NsaXBib2FyZC5jcHA6IFJlbW92ZWQgd3JpdGVSYW5nZSwgd3JpdGVQbGFp blRleHQsIGFuZCB3cml0ZVVSTCBmdW5jdGlvbnMuCisgICAgICAgIEFsbCB0aHJlZSBhcmUganVz dCB1bm5lZWRlZCBmb3J3YXJkaW5nIHRvIHBhc3RlYm9hcmQuCisgICAgICAgICogZG9tL0NsaXBi b2FyZC5oOiBEaXR0by4KKworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZyk6IE1vdmUgdGhlIGxvZ2lj IGluIGhlcmUuIExhdGVyIHdlIG1pZ2h0CisgICAgICAgIHdhbnQgdG8gc3RyYWlnaHRlbiB0aGlz IG91dCBhIGJpdCwgcGVyaGFwcyB1c2luZyBmdW5jdGlvbnMgaW4gRWRpdG9yLCBidXQgaXQncwor ICAgICAgICBub3QgbXVjaCBjb2RlIHNvIGZpbmUgdG8ganVzdCBoYXZlIGl0IGhlcmUgZm9yIG5v dy4KKworMjAxMy0wOC0xNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzExOTk0Nz4gUmVtb3ZlIExFR0FDWV9TVFlMRV9BQlNU UkFDVF9DTElQQk9BUkRfQ0xBU1MKIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5n LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAppbmRleCAzNzA1YWRmYjNhODI1MWRhM2JkNjMwMDcy NmE2NTdhZmJjNGU2MDVmLi45NDU5OGRmNDYzYTcwMGZhMWUwZmQwNDU0ZDQxZDg4NjJiMGU5YmVj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcApAQCAtMzY2LDI5ICszNjYsNiBAQCB2b2lkIERy YWdJbWFnZUxvYWRlcjo6aW1hZ2VDaGFuZ2VkKENhY2hlZEltYWdlKiwgY29uc3QgSW50UmVjdCop CiAgICAgbV9jbGlwYm9hcmQtPnVwZGF0ZURyYWdJbWFnZSgpOwogfQogCi12b2lkIENsaXBib2Fy ZDo6d3JpdGVSYW5nZShSYW5nZSogcmFuZ2UsIEZyYW1lKiBmcmFtZSkKLXsKLSAgICBBU1NFUlQo cmFuZ2UpOwotICAgIEFTU0VSVChmcmFtZSk7Ci0gICAgLy8gRklYTUU6IFRoaXMgaXMgYSBkZXNp Z24gbWlzdGFrZSwgYSBsYXllcmluZyB2aW9sYXRpb24gdGhhdCBzaG91bGQgYmUgZml4ZWQuCi0g ICAgLy8gVGhlIGNvZGUgdG8gd3JpdGUgdGhlIHJhbmdlIHRvIGEgcGFzdGVib2FyZCBzaG91bGQg YmUgYW4gRWRpdG9yIGZ1bmN0aW9uIHRoYXQgdGFrZXMgYSBwYXN0ZWJvYXJkIGFyZ3VtZW50Lgot ICAgIC8vIEZJWE1FOiBUaGUgZnJhbWUgYXJndW1lbnQgc2VlbXMgcmVkdW5kYW50LCBzaW5jZSBh IFJhbmdlIGlzIGluIGEgcGFydGljdWxhciBkb2N1bWVudCwgd2hpY2ggaGFzIGEgY29ycmVzcG9u ZGluZyBmcmFtZS4KLSAgICBtX3Bhc3RlYm9hcmQtPndyaXRlU2VsZWN0aW9uKHJhbmdlLCBmcmFt ZS0+ZWRpdG9yKCkuc21hcnRJbnNlcnREZWxldGVFbmFibGVkKCkgJiYgZnJhbWUtPnNlbGVjdGlv bigpLT5ncmFudWxhcml0eSgpID09IFdvcmRHcmFudWxhcml0eSwgZnJhbWUsIEluY2x1ZGVJbWFn ZUFsdFRleHRGb3JDbGlwYm9hcmQpOwotfQotCi12b2lkIENsaXBib2FyZDo6d3JpdGVQbGFpblRl eHQoY29uc3QgU3RyaW5nJiB0ZXh0KQotewotICAgIG1fcGFzdGVib2FyZC0+d3JpdGVQbGFpblRl eHQodGV4dCwgUGFzdGVib2FyZDo6Q2Fubm90U21hcnRSZXBsYWNlKTsKLX0KLQotdm9pZCBDbGlw Ym9hcmQ6OndyaXRlVVJMKGNvbnN0IEtVUkwmIHVybCwgY29uc3QgU3RyaW5nJiB0aXRsZSwgRnJh bWUqIGZyYW1lKQotewotICAgIEFTU0VSVChmcmFtZSk7Ci0gICAgLy8gRklYTUU6IFRoaXMgaXMg YSBkZXNpZ24gbWlzdGFrZSwgYSBsYXllcmluZyB2aW9sYXRpb24gdGhhdCBzaG91bGQgYmUgZml4 ZWQuCi0gICAgLy8gVGhlIHBhc3RlYm9hcmQgd3JpdGVVUkwgZnVuY3Rpb24gc2hvdWxkIG5vdCB0 YWtlIGEgZnJhbWUgYXJndW1lbnQsIG5vciBkb2VzIHRoaXMgZnVuY3Rpb24gbmVlZCBhIGZyYW1l LgotICAgIG1fcGFzdGVib2FyZC0+d3JpdGVVUkwodXJsLCB0aXRsZSwgZnJhbWUpOwotfQotCiAj ZW5kaWYgLy8gRU5BQkxFKERSQUdfU1VQUE9SVCkKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5oIGIvU291cmNlL1dlYkNv cmUvZG9tL0NsaXBib2FyZC5oCmluZGV4IDE5NWFkNjhhMmRlZmM3NTE2NzNiN2YzYjczNTdlNzdm YjlmMDcwYzIuLmVkMWE0MGE5YTY2YmYxZjVmYmZiMWQxMTIzNTBlZjYwYjgyODJhMDggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vQ2xpcGJvYXJkLmgKQEAgLTc5LDkgKzc5LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICBOb2RlKiBkcmFnSW1hZ2VFbGVtZW50KCkgY29uc3QgeyByZXR1cm4gbV9kcmFnSW1h Z2VFbGVtZW50LmdldCgpOyB9CiAgICAgICAgIAogICAgICAgICBEcmFnSW1hZ2VSZWYgY3JlYXRl RHJhZ0ltYWdlKEludFBvaW50JiBkcmFnTG9jYXRpb24pIGNvbnN0OwotICAgICAgICB2b2lkIHdy aXRlVVJMKGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmLCBGcmFtZSopOwotICAgICAgICB2b2lk IHdyaXRlUmFuZ2UoUmFuZ2UqLCBGcmFtZSopOwotICAgICAgICB2b2lkIHdyaXRlUGxhaW5UZXh0 KGNvbnN0IFN0cmluZyYpOwogCiAgICAgICAgIGJvb2wgaGFzRGF0YSgpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCmluZGV4IDliODIzZDQ0ZTI5NzQ3NjUwMGQ2MWUwODdj NzFiZDE1ODYzNjI5ZDYuLmNhZjVkZWZmOGYzMWJlZmQ5MmY0NDZkMDY4MWQyMzVhN2ViYTgxMzAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBAIC02MSw2ICs2MSw3IEBA CiAjaW5jbHVkZSAiSW1hZ2VPcmllbnRhdGlvbi5oIgogI2luY2x1ZGUgIk1vdmVTZWxlY3Rpb25D b21tYW5kLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIlBhc3RlYm9hcmQuaCIKICNp bmNsdWRlICJQbGF0Zm9ybUtleWJvYXJkRXZlbnQuaCIKICNpbmNsdWRlICJQbHVnaW5Eb2N1bWVu dC5oIgogI2luY2x1ZGUgIlBsdWdpblZpZXdCYXNlLmgiCkBAIC03OTIsOSArNzkzLDExIEBAIGJv b2wgRHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZyhGcmFtZSogc3JjLCBjb25zdCBEcmFnU3RhdGUm IHN0YXRlLCBEcmFnT3BlcmF0aW9uCiAgICAgICAgICAgICBzcmMtPmVkaXRvcigpLndpbGxXcml0 ZVNlbGVjdGlvblRvUGFzdGVib2FyZChzZWxlY3Rpb25SYW5nZS5nZXQoKSk7CiAKICAgICAgICAg ICAgIGlmIChlbmNsb3NpbmdUZXh0Rm9ybUNvbnRyb2woc3JjLT5zZWxlY3Rpb24oKS0+c3RhcnQo KSkpCi0gICAgICAgICAgICAgICAgY2xpcGJvYXJkLT53cml0ZVBsYWluVGV4dChzcmMtPmVkaXRv cigpLnNlbGVjdGVkVGV4dEZvckNsaXBib2FyZCgpKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAg ICAgICAgICAgICBjbGlwYm9hcmQtPndyaXRlUmFuZ2Uoc2VsZWN0aW9uUmFuZ2UuZ2V0KCksIHNy Yyk7CisgICAgICAgICAgICAgICAgY2xpcGJvYXJkLT5wYXN0ZWJvYXJkKCkud3JpdGVQbGFpblRl eHQoc3JjLT5lZGl0b3IoKS5zZWxlY3RlZFRleHRGb3JDbGlwYm9hcmQoKSwgUGFzdGVib2FyZDo6 Q2Fubm90U21hcnRSZXBsYWNlKTsKKyAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAg IC8vIEZJWE1FOiBDb3VsZCB0aGlzIGluc3RlYWQgYmUgYSBoZWxwZXIgZnVuY3Rpb24gaW4gRWRp dG9yPworICAgICAgICAgICAgICAgIGNsaXBib2FyZC0+cGFzdGVib2FyZCgpLndyaXRlU2VsZWN0 aW9uKHNlbGVjdGlvblJhbmdlLmdldCgpLCBzcmMtPmVkaXRvcigpLnNtYXJ0SW5zZXJ0RGVsZXRl RW5hYmxlZCgpICYmIHNyYy0+c2VsZWN0aW9uKCktPmdyYW51bGFyaXR5KCkgPT0gV29yZEdyYW51 bGFyaXR5LCBzcmMsIEluY2x1ZGVJbWFnZUFsdFRleHRGb3JDbGlwYm9hcmQpOworICAgICAgICAg ICAgfQogCiAgICAgICAgICAgICBzcmMtPmVkaXRvcigpLmRpZFdyaXRlU2VsZWN0aW9uVG9QYXN0 ZWJvYXJkKCk7CiAgICAgICAgIH0KQEAgLTgzMCw3ICs4MzMsNyBAQCBib29sIERyYWdDb250cm9s bGVyOjpzdGFydERyYWcoRnJhbWUqIHNyYywgY29uc3QgRHJhZ1N0YXRlJiBzdGF0ZSwgRHJhZ09w ZXJhdGlvbgogICAgICAgICBpZiAoIWNsaXBib2FyZC0+aGFzRGF0YSgpKQogICAgICAgICAgICAg Ly8gU2ltcGxpZnkgd2hpdGVzcGFjZSBzbyB0aGUgdGl0bGUgcHV0IG9uIHRoZSBjbGlwYm9hcmQg cmVzZW1ibGVzIHdoYXQgdGhlIHVzZXIgc2VlcwogICAgICAgICAgICAgLy8gb24gdGhlIHdlYiBw YWdlLiBUaGlzIGluY2x1ZGVzIHJlcGxhY2luZyBuZXdsaW5lcyB3aXRoIHNwYWNlcy4KLSAgICAg ICAgICAgIGNsaXBib2FyZC0+d3JpdGVVUkwobGlua1VSTCwgaGl0VGVzdFJlc3VsdC50ZXh0Q29u dGVudCgpLnNpbXBsaWZ5V2hpdGVTcGFjZSgpLCBzcmMpOworICAgICAgICAgICAgY2xpcGJvYXJk LT5wYXN0ZWJvYXJkKCkud3JpdGVVUkwobGlua1VSTCwgaGl0VGVzdFJlc3VsdC50ZXh0Q29udGVu dCgpLnNpbXBsaWZ5V2hpdGVTcGFjZSgpLCBzcmMpOwogCiAgICAgICAgIGlmIChzcmMtPnNlbGVj dGlvbigpLT5pc0NhcmV0KCkgJiYgc3JjLT5zZWxlY3Rpb24oKS0+aXNDb250ZW50RWRpdGFibGUo KSkgewogICAgICAgICAgICAgLy8gYSB1c2VyIGNhbiBpbml0aWF0ZSBhIGRyYWcgb24gYSBsaW5r IHdpdGhvdXQgaGF2aW5nIGFueSB0ZXh0Cg==