119915 2013-08-16 14:52:48 -0700 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get() 2013-08-19 14:53:27 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 1 rniwa ap aestes ap beidson commit-queue darin oldest_to_newest 918128 0 rniwa 2013-08-16 14:52:48 -0700 stderr: ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get() /Volumes/Data/webkit4/Source/WebCore/loader/FrameLoader.cpp(3233) : void WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad() 1 0x1067f9090 WTFCrash 2 0x107c5c563 WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad() 3 0x107a1a629 WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) 4 0x1076d28cd WebCore::CachedResource::checkNotify() 5 0x1076d2a6c WebCore::CachedResource::error(WebCore::CachedResource::Status) 6 0x108c97f67 WebCore::SubresourceLoader::didFail(WebCore::ResourceError const&) 7 0x108ac8355 WebCore::ResourceLoader::didFail(WebCore::ResourceHandle*, WebCore::ResourceError const&) 8 0x108ea2855 -[WebCoreResourceHandleAsDelegate connection:didFailWithError:] 9 0x7fff8e213d88 __65-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:]_block_invoke_0 10 0x7fff8e213ccc -[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:] 11 0x7fff8e38aef4 -[NSURLConnectionInternal _withErrorForConnection:] 12 0x7fff922e78d5 ___delegate_didFail_block_invoke_0 13 0x7fff9228854a ___withDelegateAsync_block_invoke_0 14 0x7fff92318f3a __block_global_1 15 0x7fff87b47154 CFArrayApplyFunction 16 0x7fff922792b4 RunloopBlockContext::perform() 17 0x7fff9227918b MultiplexerSource::perform() 18 0x7fff87b28b31 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 19 0x7fff87b28455 __CFRunLoopDoSources0 20 0x7fff87b4b7f5 __CFRunLoopRun 21 0x7fff87b4b0e2 CFRunLoopRunSpecific 22 0x7fff8f8faeb4 RunCurrentEventLoopInMode 23 0x7fff8f8fac52 ReceiveNextEventCommon 24 0x7fff8f8faae3 BlockUntilNextEventMatchingListInMode 25 0x7fff8a2dc533 _DPSNextEvent 26 0x7fff8a2dbdf2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 27 0x7fff8a2d31a3 -[NSApplication run] 28 0x108af63d2 WebCore::RunLoop::run() 29 0x104ec7d8a int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebContentProcessMainDelegate>(int, char**) 30 0x104ec79db WebContentProcessMain 31 0x104bb6d18 WebKit::BootstrapMain(int, char**) 918129 1 rniwa 2013-08-16 14:53:11 -0700 Tools/Scripts/run-webkit-tests --debug http/tests/navigation/post-frames-goback1.html -2 918130 2 rniwa 2013-08-16 14:55:22 -0700 Committed r154206: <http://trac.webkit.org/changeset/154206> 918145 3 ap 2013-08-16 16:56:36 -0700 I have this mostly done. NetworkProcess wasn't managing cache model correctly, so it ended up with no CFNetwork cache. 918660 4 ap 2013-08-19 09:37:57 -0700 Well, and WebProcess too. 918753 5 209112 ap 2013-08-19 13:08:59 -0700 Created attachment 209112 proposed fix Decided to do a simpler fix. There are two aspects to dynamically changing cache model: - Real clients should just set it upfront, changing it after some processes are created is a poorly defined operation. WKContextSetCacheModel currently fails to update cache model in Networking process, and it fails to accurately update cache sizes in WebProcess, especially when running in a non-default session. - There are three regression tests that attempt to change cache model at runtime, and this is broken for multiple reasons, most notably because this is done in injected bundle, and doesn't update Networking process. Neither appears important enough to address at the moment. Eventually, we should probably change cache model API to explicitly take a storage session (ditto for cookie accept policy). 918768 6 209112 rniwa 2013-08-19 13:46:57 -0700 Comment on attachment 209112 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=209112&action=review > Tools/ChangeLog:11 > + the easiest way to get this going to to initialize it to correct value upfront. typo: to to. 918792 7 ap 2013-08-19 14:20:47 -0700 This assertion failure could also happen in any process that had cache disabled on purpose, or even when cache was enabled, but couldn't hold the item. Tracking that with bug 120028. 918793 8 209124 ap 2013-08-19 14:22:21 -0700 Created attachment 209124 patch for landing 918810 9 209124 commit-queue 2013-08-19 14:53:24 -0700 Comment on attachment 209124 patch for landing Clearing flags on attachment: 209124 Committed r154301: <http://trac.webkit.org/changeset/154301> 918811 10 commit-queue 2013-08-19 14:53:27 -0700 All reviewed patches have been landed. Closing bug. 209112 2013-08-19 13:08:59 -0700 2013-08-19 14:22:21 -0700 proposed fix FixTheTest.txt text/plain 2835 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NDI5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEzLTA4LTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk5 MTUKKyAgICAgICAgUkVHUkVTU0lPTihyMTU0MTQ0KTogQVNTRVJUSU9OIEZBSUxFRDogbV9oaXN0 b3J5LT5wcm92aXNpb25hbEl0ZW0oKSA9PSBtX3JlcXVlc3RlZEhpc3RvcnlJdGVtLmdldCgpCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGlzc3Vl IHdhcyB0aGF0IHdlIGVuZGVkIHVwIGhhdmluZyBubyBDRk5ldHdvcmsgY2FjaGUgaW4gdGhlIHRl c3Rpbmcgc2Vzc2lvbiBkdWUKKyAgICAgICAgdG8gYW4gaW5jb3JyZWN0IGNhY2hlIG1vZGVsLiBU aGVyZSBpcyBhIG51bWJlciBvZiB0aGluZ3Mgbm90IGltcGxlbWVudGVkIHdoZW4gaXQKKyAgICAg ICAgY29tZXMgdG8gZHluYW1pY2FsbHkgY2hhbmdpbmcgY2FjaGUgbW9kZWwgYXMgYXR0ZW1wdGVk IGJ5IFdlYktpdFRlc3RSdW5uZXIsIGJ1dAorICAgICAgICB0aGUgZWFzaWVzdCB3YXkgdG8gZ2V0 IHRoaXMgZ29pbmcgdG8gdG8gaW5pdGlhbGl6ZSBpdCB0byBjb3JyZWN0IHZhbHVlIHVwZnJvbnQu CisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDogKFdUUjo6 VGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemUpOgorCiAyMDEzLTA4LTE5ICBBbGxhbiBTYW5kZmVs ZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04o cjE1NDI3NSk6IHdlYmtpdHB5IHRlc3RzIGZhaWxpbmcKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxNTQxODgpCisrKyBUb29scy9XZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc2LDYg KzM3Niw3IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemUoaW50IGFyZ2MKICAgICB9 CiAKICAgICBXS0NvbnRleHRVc2VUZXN0aW5nTmV0d29ya1Nlc3Npb24obV9jb250ZXh0LmdldCgp KTsKKyAgICBXS0NvbnRleHRTZXRDYWNoZU1vZGVsKG1fY29udGV4dC5nZXQoKSwga1dLQ2FjaGVN b2RlbERvY3VtZW50QnJvd3Nlcik7CiAKICAgICBwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCk7 CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDI5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA4LTE5ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTk5MTUKKyAgICAgICAgUkVHUkVTU0lPTihyMTU0MTQ0KTogQVNT RVJUSU9OIEZBSUxFRDogbV9oaXN0b3J5LT5wcm92aXNpb25hbEl0ZW0oKSA9PSBtX3JlcXVlc3Rl ZEhpc3RvcnlJdGVtLmdldCgpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcHBp bmcgdGhlIGZhaWxpbmcgdGVzdC4KKwogMjAxMy0wOC0xNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMTk4NjA+IENyYXNo IGR1cmluZyBleGNlcHRpb24gdW53aW5kaW5nCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNTQyOTEpCisrKyBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAg LTMzNSw5ICszMzUsNiBAQCB3ZWJraXQub3JnL2IvMTE4OTI1IFsgRGVidWcgXSBzdmcvcmVwYWlu CiAjIE9ubHkgZmFpbGluZyBvbiBXSzEKIHdlYmtpdC5vcmcvYi8xMDQxMDQgZmFzdC9vdmVyZmxv dy9zY3JvbGxiYXItY2xpY2stcmV0YWlucy1mb2N1cy5odG1sIFsgUGFzcyBdCiAKLXdlYmtpdC5v cmcvYi8xMTk5MTUgWyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZnJhbWVz LWdvYmFjazEuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzExOTkxNSBbIERlYnVnIF0g aHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZnJhbWVzLWdvYmFjazEuaHRtbCBbIENyYXNoIF0K LQogIyMjIEVORCBPRiAoMSkgQ2xhc3NpZmllZCBmYWlsdXJlcyB3aXRoIGJ1ZyByZXBvcnRzCiAj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAK 209124 2013-08-19 14:22:21 -0700 2013-08-19 14:53:24 -0700 patch for landing FixTheTest.txt text/plain 2829 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NDI5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEzLTA4LTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk5 MTUKKyAgICAgICAgUkVHUkVTU0lPTihyMTU0MTQ0KTogQVNTRVJUSU9OIEZBSUxFRDogbV9oaXN0 b3J5LT5wcm92aXNpb25hbEl0ZW0oKSA9PSBtX3JlcXVlc3RlZEhpc3RvcnlJdGVtLmdldCgpCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgVGhlIGlzc3VlIHdh cyB0aGF0IHdlIGVuZGVkIHVwIGhhdmluZyBubyBDRk5ldHdvcmsgY2FjaGUgaW4gdGhlIHRlc3Rp bmcgc2Vzc2lvbiBkdWUKKyAgICAgICAgdG8gYW4gaW5jb3JyZWN0IGNhY2hlIG1vZGVsLiBUaGVy ZSBpcyBhIG51bWJlciBvZiB0aGluZ3Mgbm90IGltcGxlbWVudGVkIHdoZW4gaXQKKyAgICAgICAg Y29tZXMgdG8gZHluYW1pY2FsbHkgY2hhbmdpbmcgY2FjaGUgbW9kZWwgYXMgYXR0ZW1wdGVkIGJ5 IFdlYktpdFRlc3RSdW5uZXIsIGJ1dAorICAgICAgICB0aGUgZWFzaWVzdCB3YXkgdG8gZ2V0IHRo aXMgZ29pbmcgaXMgdG8gaW5pdGlhbGl6ZSBpdCB0byBjb3JyZWN0IHZhbHVlIHVwZnJvbnQuCisK KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDogKFdUUjo6VGVz dENvbnRyb2xsZXI6OmluaXRpYWxpemUpOgorCiAyMDEzLTA4LTE5ICBBbGxhbiBTYW5kZmVsZCBK ZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE1 NDI3NSk6IHdlYmtpdHB5IHRlc3RzIGZhaWxpbmcKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxNTQxODgpCisrKyBUb29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc2LDYgKzM3 Niw3IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemUoaW50IGFyZ2MKICAgICB9CiAK ICAgICBXS0NvbnRleHRVc2VUZXN0aW5nTmV0d29ya1Nlc3Npb24obV9jb250ZXh0LmdldCgpKTsK KyAgICBXS0NvbnRleHRTZXRDYWNoZU1vZGVsKG1fY29udGV4dC5nZXQoKSwga1dLQ2FjaGVNb2Rl bERvY3VtZW50QnJvd3Nlcik7CiAKICAgICBwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCk7CiAK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NDI5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA4LTE5ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTk5MTUKKyAgICAgICAgUkVHUkVTU0lPTihyMTU0MTQ0KTogQVNTRVJU SU9OIEZBSUxFRDogbV9oaXN0b3J5LT5wcm92aXNpb25hbEl0ZW0oKSA9PSBtX3JlcXVlc3RlZEhp c3RvcnlJdGVtLmdldCgpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcHBpbmcgdGhl IGZhaWxpbmcgdGVzdC4KKwogMjAxMy0wOC0xNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMTk4NjA+IENyYXNoIGR1cmlu ZyBleGNlcHRpb24gdW53aW5kaW5nCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sy L1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNTQyOTEpCisrKyBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTMzNSw5 ICszMzUsNiBAQCB3ZWJraXQub3JnL2IvMTE4OTI1IFsgRGVidWcgXSBzdmcvcmVwYWluCiAjIE9u bHkgZmFpbGluZyBvbiBXSzEKIHdlYmtpdC5vcmcvYi8xMDQxMDQgZmFzdC9vdmVyZmxvdy9zY3Jv bGxiYXItY2xpY2stcmV0YWlucy1mb2N1cy5odG1sIFsgUGFzcyBdCiAKLXdlYmtpdC5vcmcvYi8x MTk5MTUgWyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZnJhbWVzLWdvYmFj azEuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzExOTkxNSBbIERlYnVnIF0gaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZnJhbWVzLWdvYmFjazEuaHRtbCBbIENyYXNoIF0KLQogIyMj IEVORCBPRiAoMSkgQ2xhc3NpZmllZCBmYWlsdXJlcyB3aXRoIGJ1ZyByZXBvcnRzCiAjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAK