119913 2013-08-16 14:14:43 -0700 Baseline JIT gives erroneous error message that an object is not a constructor though it expects a function 2013-08-16 14:40:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam chris_curtis fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 918111 0 mark.lam 2013-08-16 14:14:43 -0700 Some layout test fails with text diffs because the baseline JIT is throwing errors with the wrong message: Expected message: "… is not a function …" Actual message: "… is not a constructor …" These failures shows up if I do a test run on a build with the LLINT disabled to force the baseline JIT to be used. The failing tests are: fast/js/exception-thrown-from-new.html fast/regex/cross-frame-callable.html http/tests/security/document-all.html http/tests/security/xss-DENIED-window-index-assign.html inspector/console/console-exception-stack-traces.html plugins/npruntime/object-from-destroyed-plugin-in-subframe.html plugins/npruntime/object-from-destroyed-plugin.html plugins/npruntime/plugin-scriptable-object-invoke-default.html sputnik/Conformance/13_Function_Definition/S13_A17_T2.html sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1.html sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A3.html Patch for fix coming soon. 918114 1 208959 mark.lam 2013-08-16 14:24:24 -0700 Created attachment 208959 the patch. 918123 2 mark.lam 2013-08-16 14:40:37 -0700 Thanks for the review. Landed in r154204: <http://trac.webkit.org/r154204>. 208959 2013-08-16 14:24:24 -0700 2013-08-16 14:36:02 -0700 the patch. bug-119913.patch text/plain 1524 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MjAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTA4LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTkxMz4gQmFzZWxpbmUg SklUIGdpdmVzIGVycm9uZW91cworICAgICAgICBlcnJvciBtZXNzYWdlIHRoYXQgYW4gb2JqZWN0 IGlzIG5vdCBhIGNvbnN0cnVjdG9yIHRob3VnaCBpdCBleHBlY3RzIGEgZnVuY3Rpb24KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9KSVRTdHVi cy5jcHA6CisgICAgICAgIChKU0M6OkRFRklORV9TVFVCX0ZVTkNUSU9OKToKKwogMjAxMy0wOC0x NiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIE9iamVjdCBwcm9w ZXJ0aWVzIGFkZGVkIHVzaW5nIGRvdCBzeW50YXggKG8uZiA9IC4uLikgZnJvbSBjb2RlIHRoYXQg aXNuJ3QgaW4gZXZhbCBzaG91bGQgYmUgbGVzcyBsaWtlbHkgdG8gY2F1c2UgYW4gb2JqZWN0IHRv IGJlY29tZSBhIGRpY3Rpb25hcnkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU U3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1 YnMuY3BwCShyZXZpc2lvbiAxNTQxODcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VFN0dWJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQwOCw3ICsxNDA4LDcgQEAgREVGSU5FX1NU VUJfRlVOQ1RJT04oRW5jb2RlZEpTVmFsdWUsIG9wXwogICAgIEFTU0VSVChjYWxsVHlwZSAhPSBD YWxsVHlwZUpTKTsKICAgICBpZiAoY2FsbFR5cGUgIT0gQ2FsbFR5cGVIb3N0KSB7CiAgICAgICAg IEFTU0VSVChjYWxsVHlwZSA9PSBDYWxsVHlwZU5vbmUpOwotICAgICAgICBFcnJvcldpdGhFeGVj QW5kQ2FsbGVlRnVuY3RvciBmdW5jdG9yID0gRXJyb3JXaXRoRXhlY0FuZENhbGxlZUZ1bmN0b3Io Y3JlYXRlTm90QUNvbnN0cnVjdG9yRXJyb3IsIGNhbGxlZSk7CisgICAgICAgIEVycm9yV2l0aEV4 ZWNBbmRDYWxsZWVGdW5jdG9yIGZ1bmN0b3IgPSBFcnJvcldpdGhFeGVjQW5kQ2FsbGVlRnVuY3Rv cihjcmVhdGVOb3RBRnVuY3Rpb25FcnJvciwgY2FsbGVlKTsKICAgICAgICAgcmV0dXJuIHRocm93 RXhjZXB0aW9uRnJvbU9wQ2FsbDxFbmNvZGVkSlNWYWx1ZT4oc3RhY2tGcmFtZSwgY2FsbEZyYW1l LCBTVFVCX1JFVFVSTl9BRERSRVNTLCBmdW5jdG9yKTsKICAgICB9CiAK