119884 2013-08-16 02:26:24 -0700 [GTK] fixing localizedString method name 2013-08-16 04:49:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 danilo.eu webkit-unassigned commit-queue oldest_to_newest 917859 0 danilo.eu 2013-08-16 02:26:24 -0700 [GTK] fixing localizedString method name 917860 1 208896 danilo.eu 2013-08-16 02:26:47 -0700 Created attachment 208896 Patch 917861 2 danilo.eu 2013-08-16 02:27:35 -0700 The method name defined in LocalizedStringsGtk.cpp doesn't not match the one declared in LocalizedStrings.h 917863 3 commit-queue 2013-08-16 02:28:14 -0700 Attachment 208896 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 917864 4 208897 danilo.eu 2013-08-16 02:29:32 -0700 Created attachment 208897 Patch 917914 5 208897 commit-queue 2013-08-16 04:49:47 -0700 Comment on attachment 208897 Patch Clearing flags on attachment: 208897 Committed r154175: <http://trac.webkit.org/changeset/154175> 917915 6 commit-queue 2013-08-16 04:49:49 -0700 All reviewed patches have been landed. Closing bug. 208896 2013-08-16 02:26:47 -0700 2013-08-16 02:29:24 -0700 Patch bug-119884-20130816122645.patch text/plain 1456 danilo.eu U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZkYjhkNDBkYjU4NjJj OWZkZWM5MWQ5OTAwYzhmZWQ0ZDk2YmRmZi4uNWQ4MzExZDkxMDdjOTcwZTIzZGY1ZDNiZTcyNjhi MjJiZDY2NjJhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTE2ICBEYW5p bG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgIDxkYW5pbG8uY2VzYXJAY29sbGFib3JhLmNvLnVrPgor CisgICAgICAgIFtHVEtdIGZpeGluZyBsb2NhbGl6ZWRTdHJpbmcgbWV0aG9kIG5hbWUKKyAgICAg ICAgPE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKT4KKworICAgICAgICBUaGUgbWV0aG9kIG5hbWUg ZGVmaW5lZCBpbiBMb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcCBkb2Vzbid0IG5vdCBtYXRjaAorICAg ICAgICB0aGUgb25lIHVzZWQgaW4gTG9jYWxpemVkU3RyaW5ncy5oCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvTG9jYWxpemVk U3RyaW5nc0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0ZXh0VHJhY2tPZmZNZW51SXRlbVRl eHQpOgorCiAyMDEzLTA4LTEzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgTm9kZTo6YXR0YWNoKCkgYW5kIENvbnRhaW5lck5vZGU6OmF0dGFjaCgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5n c0d0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0 ay5jcHAKaW5kZXggZWNkYmNkNTQ0NmIxMWQ5ODM5MjI0MjA4OTJlMmYxMzAxZmUxNmEyMy4uOTQ5 N2NhMjIwMmY3ZjhkOWU4N2ZjNmYxYjFiZWFkOWMxNjU4MzY0ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcApAQCAtNzkzLDcg Kzc5Myw3IEBAIFN0cmluZyB0ZXh0VHJhY2tTdWJ0aXRsZXNUZXh0KCkKICAgICByZXR1cm4gU3Ry aW5nOjpmcm9tVVRGOChDXygiU3VidGl0bGVzIiwgIk1lbnUgc2VjdGlvbiBoZWFkaW5nIGZvciBz dWJ0aXRsZXMiKSk7CiB9CiAKLVN0cmluZyB0ZXh0VHJhY2tPZmZUZXh0KCkKK1N0cmluZyB0ZXh0 VHJhY2tPZmZNZW51SXRlbVRleHQoKQogewogICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KENf KCJPZmYiLCAiTWVudSBpdGVtIGxhYmVsIGZvciB0aGUgdHJhY2sgdGhhdCByZXByZXNlbnRzIGRp c2FibGluZyBjbG9zZWQgY2FwdGlvbnMiKSk7CiB9Cg== 208897 2013-08-16 02:29:32 -0700 2013-08-16 04:49:47 -0700 Patch bug-119884-20130816122931.patch text/plain 1476 danilo.eu U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZkYjhkNDBkYjU4NjJj OWZkZWM5MWQ5OTAwYzhmZWQ0ZDk2YmRmZi4uMTJhZTIwNjQ0MjlhZjI2OGU2Njc0ZDQ4M2IzNjE5 YjJlNjBmZjdiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTE2ICBEYW5p bG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgIDxkYW5pbG8uY2VzYXJAY29sbGFib3JhLmNvLnVrPgor CisgICAgICAgIFtHVEtdIGZpeGluZyBsb2NhbGl6ZWRTdHJpbmcgbWV0aG9kIG5hbWUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTg4NAorCisgICAg ICAgIFRoZSBtZXRob2QgbmFtZSBkZWZpbmVkIGluIExvY2FsaXplZFN0cmluZ3NHdGsuY3BwIGRv ZXNuJ3Qgbm90IG1hdGNoCisgICAgICAgIHRoZSBvbmUgdXNlZCBpbiBMb2NhbGl6ZWRTdHJpbmdz LmgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRl eHRUcmFja09mZk1lbnVJdGVtVGV4dCk6CisKIDIwMTMtMDgtMTMgIEFudHRpIEtvaXZpc3RvICA8 YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBOb2RlOjphdHRhY2goKSBhbmQgQ29u dGFpbmVyTm9kZTo6YXR0YWNoKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcAppbmRleCBlY2RiY2Q1NDQ2YjExZDk4MzkyMjQyMDg5 MmUyZjEzMDFmZTE2YTIzLi45NDk3Y2EyMjAyZjdmOGQ5ZTg3ZmM2ZjFiMWJlYWQ5YzE2NTgzNjRm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5n c0d0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmlu Z3NHdGsuY3BwCkBAIC03OTMsNyArNzkzLDcgQEAgU3RyaW5nIHRleHRUcmFja1N1YnRpdGxlc1Rl eHQoKQogICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KENfKCJTdWJ0aXRsZXMiLCAiTWVudSBz ZWN0aW9uIGhlYWRpbmcgZm9yIHN1YnRpdGxlcyIpKTsKIH0KIAotU3RyaW5nIHRleHRUcmFja09m ZlRleHQoKQorU3RyaW5nIHRleHRUcmFja09mZk1lbnVJdGVtVGV4dCgpCiB7CiAgICAgcmV0dXJu IFN0cmluZzo6ZnJvbVVURjgoQ18oIk9mZiIsICJNZW51IGl0ZW0gbGFiZWwgZm9yIHRoZSB0cmFj ayB0aGF0IHJlcHJlc2VudHMgZGlzYWJsaW5nIGNsb3NlZCBjYXB0aW9ucyIpKTsKIH0K