119878 2013-08-15 23:49:00 -0700 Text Selection on flex and grid box items does not work as expected 2023-04-20 20:38:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pravind ahmad.saleem792 ahmad.saleem792 bdakin commit-queue dino esprehn+autocc glenn hyatt joepeck kondapallykalyan leviw mitz ntim rniwa simon.fraser sudarshan.cp webkit-bug-importer oldest_to_newest 917827 0 208884 pravind 2013-08-15 23:49:00 -0700 Created attachment 208884 TestCase Consider a Flex box having 2 or more children with text(div or span) and the children are laid out horizontally (flex-direction: row). When the content of the 1st child is selected the selction background width excompasses the entire body's width rather than being restricted to the boundries of the flex child. 917828 1 208885 pravind 2013-08-16 00:05:49 -0700 Created attachment 208885 Patch 917837 2 208885 koivisto 2013-08-16 00:38:39 -0700 Comment on attachment 208885 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208885&action=review > Source/WebCore/rendering/RenderBlock.cpp:3513 > + if (parent() && parent()->isFlexibleBox()) > + return true; Looks suspicious. This function tests the current element not the parent everywhere else. Hyatt should probably take a look. 921157 3 208885 buildbot 2013-08-26 14:18:15 -0700 Comment on attachment 208885 Patch Attachment 208885 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1590037 1196170 4 208885 beidson 2016-05-24 22:02:33 -0700 Comment on attachment 208885 Patch Assuming that patches for review since 2013 are stale, r- 1899195 5 ahmad.saleem792 2022-09-17 07:25:15 -0700 https://github.com/WebKit/WebKit/pull/4441 1899297 6 ews-feeder 2022-09-17 20:43:47 -0700 Committed 254602@main (48936aafec37): <https://commits.webkit.org/254602@main> Reviewed commits have been landed. Closing PR #4441 and removing active labels. 1899298 7 webkit-bug-importer 2022-09-17 20:44:17 -0700 <rdar://problem/100080307> 1899303 8 ahmad.saleem792 2022-09-17 23:46:31 -0700 *** Bug 200251 has been marked as a duplicate of this bug. *** 1936671 9 ahmad.saleem792 2023-02-24 15:04:16 -0800 *** Bug 128966 has been marked as a duplicate of this bug. *** 1950241 10 ahmad.saleem792 2023-04-20 20:38:29 -0700 *** Bug 241074 has been marked as a duplicate of this bug. *** 208884 2013-08-15 23:49:00 -0700 2013-08-15 23:49:00 -0700 TestCase flexBox.html text/html 767 pravind PGh0bWw+DQo8c3R5bGU+DQouZmxleHkgew0KICAgIGRpc3BsYXk6IC13ZWJraXQtZmxleDsNCiAg ICBkaXNwbGF5OiAtbW96LWZsZXg7DQogICAgZGlzcGxheTpmbGV4Ow0KICAgIGZsZXgtZmxvdzog cm93Ow0KICAgIC8vLXdlYmtpdC1mbGV4LWRpcmVjdGlvbjogY29sdW1uOw0KICAgIC8vLW1vei1m bGV4LWRpcmVjdGlvbjogY29sdW1uOw0KICAgIC8vZmxleC1kaXJlY3Rpb246IGNvbHVtbjsNCn0N Ci5mbGV4eSA+IHNwYW4gew0KICAgIGhlaWdodDogNTBweDsNCiAgICB3aWR0aDogNDBweDsNCiAg ICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7DQogICAgLy8td2Via2l0LXdyaXRpbmctbW9kZTogdmVy dGljYWwtcmw7DQogICAgLW1vei13cml0aW5nLW1vZGU6IHZlcnRpY2FsLXJsOw0KICAgIC8vd3Jp dGluZy1tb2RlOiB2ZXJ0aWNhbC1ybDsNCn0NCjwvc3R5bGU+DQo8Ym9keT4NCjxkaXYgY2xhc3M9 ImZsZXh5Ij4NCiAgICAgPHNwYW4gaWQ9InRlc3QiPkhlbGxvIEhlbGxvIEhlbGxvIDwvc3Bhbj4N CiAgICA8c3Bhbj5Xb3JsZCBXb3JsZCBXb3JsZCA8L3NwYW4+DQo8L2Rpdj4NCjxzY3JpcHQ+DQp2 YXIgc2VsID0gd2luZG93LmdldFNlbGVjdGlvbigpOw0Kc2VsLmNvbGxhcHNlKGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCd0ZXN0JyksIDApOw0Kc2VsLm1vZGlmeSgnZXh0ZW5kJywgJ2ZvcndhcmQn ICwgJ2xpbmUnKTsNCnNlbC5tb2RpZnkoJ2V4dGVuZCcsICdmb3J3YXJkJyAsICdsaW5lJyk7DQo8 L3NjcmlwdD4NCjwvYm9keT4NCjwvaHRtbD4= 208885 2013-08-16 00:05:49 -0700 2016-05-24 22:02:33 -0700 Patch bug-119878-20130816122437.patch text/plain 4193 pravind U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2EwNDM1YzdjZGY1MjBj N2I1NjY4NDdmOGFjNzRlYzQzYTU5MTQ2Ni4uMjUwMmYxMTdlYjE1ODE0ZWZkOTc0YTgwZTUwZmM1 ZmE4ZTBlOWQyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA4LTE1ICBQcmF2 aW4gRCAgPHByYXZpbmRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzExOTg3OD4gVGV4dCBTZWxlY3Rpb24gb24gZmxleCBib3ggaXRlbXMgZG9lcyBub3Qgd29y ayBhcyBleHBlY3RlZAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gdGhlIHRleHQgaW4gYSBmbGV4IGNoaWxkIGlzIHNlbGVjdGVkIHRoZSBzZWxl Y3Rpb24gcm9vdCB0aGF0IGlzIHVzZWQgdG8gZ2V0IHRoZSBib3VuZHJ5IGxpbWl0cyBmb3IgZHJh d2luZworICAgICAgICB0aGUgc2VsZWN0aW9uIGJhY2tncm91bmQgaXMgd3JvbmcuIFRoZSBwYXJl bnQgYmxvY2sgaXMgc2VsZWN0ZWQgYXMgc2VsZWN0aW9uIHJvb3QgYmFzZWQgb24gY2VydGFpbiBj b25kaXRpb25zLCBleGFtcGxlIGlmIHRoZSAKKyAgICAgICAgdGhlIGNoaWxkcmVuIGFyZSBpbmxp bmUtYmxvY2ssIGV0Yy4gT3RoZXJ3aXNlIHRoZSBib2R5IGlzIHNlbGVjdGVkIGFzIHRoZSBzZWxl Y3Rpb24gcm9vdC4gSG93ZXZlciBpZiB0aGUgY2hpbGRyZW4gYXJlIHBhcnQgb2YKKyAgICAgICAg ZmxleCBib3gsIHRoZSBjaGlsZCBzaG91bGQgYmUgc2VsZWN0ZWQgYXMgc2VsZWN0aW9uIHJvb3Qu CisKKyAgICAgICAgVGVzdDogZWRpdGluZy9zZWxlY3Rpb24vdGV4dC1zZWxlY3Rpb24taW4tZmxl eGJveC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmlzU2VsZWN0aW9uUm9vdCk6CisgICAgICAgICBBZGRl ZCBhIGNvbmRpdGlvbiB0byBzZWxlY3Rpb24gZmxleCBjaGlsZCBhcyBzZWxlY3Rpb24gcm9vdC4K KwogMjAxMy0wOC0xNCAgSmlud29vIEplb25nICA8ancwMC5qZW9uZ0BzYW1zdW5nLmNvbT4KIAog ICAgICAgICBGRUNvbXBvbmVudFRyYW5zZmVyIGNvdWxkIGJlIGZhc3Rlci4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDRhN2I5MmVlNDJhZWZkZTBiY2VmMjI0 NzkyNmIxNDJkYTdhMzkzN2MuLjJiMTFkZjhlNjc2ZmY4MmNlNjc5ZGRkYTBiYTU4MmE3NTRmM2M5 ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtMzUwOCw2 ICszNTA4LDkgQEAgYm9vbCBSZW5kZXJCbG9jazo6aXNTZWxlY3Rpb25Sb290KCkgY29uc3QKICAg ICAgICAgaWYgKHN0YXJ0RWxlbWVudCAmJiBzdGFydEVsZW1lbnQtPnJvb3RFZGl0YWJsZUVsZW1l bnQoKSA9PSBub2RlKCkpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CisKKyAgICBp ZiAocGFyZW50KCkgJiYgcGFyZW50KCktPmlzRmxleGlibGVCb3goKSkKKyAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgCiAgICAgcmV0dXJuIGZhbHNlOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDA5ZDAxMjQ4ODVmMmMw OTUwMmIyNzBmOGVmOGRhMGRlYWZmNzkwOTQuLjJhYzkwMDVmYWIwMzc2YWIwOTJhNDYyNmJkM2E3 ODk2N2U1OGQ0ZGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wOC0xNSAgUHJhdmluIEQg IDxwcmF2aW5kQHNhbXN1bmcuY29tPgorCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x MTk4Nzg+IFRleHQgU2VsZWN0aW9uIG9uIGZsZXggYm94IGl0ZW1zIGRvZXMgbm90IHdvcmsgYXMg ZXhwZWN0ZWQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGVkaXRpbmcvc2VsZWN0aW9uL3RleHQtc2VsZWN0aW9uLWluLWZsZXhib3gtZXhwZWN0ZWQu aHRtbDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vdGV4dC1zZWxlY3Rpb24t aW4tZmxleGJveC5odG1sOiBBZGRlZC4KKwogMjAxMy0wOC0xMyAgR3l1eW91bmcgS2ltICA8Z3l1 eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFRoZSBsZW5ndGggb2Ygc2NoZW1lIGlz IGF0IGxlYXN0IGZpdmUgY2hhcmFjdGVycyBldmVuIHdoZW4gdGhlIHNjaGVtZSBoYXMgJ3dlYisn IHByZWZpeApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vdGV4dC1z ZWxlY3Rpb24taW4tZmxleGJveC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vdGV4dC1zZWxlY3Rpb24taW4tZmxleGJveC1leHBlY3RlZC5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjU1MzVlMTZhODcyZmMxMTMyMWUzNWJjMmM1YzNmZjQ4NDkzYjcyNjcKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi90ZXh0LXNlbGVjdGlvbi1pbi1m bGV4Ym94LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyMyBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxzdHlsZT4KK3NwYW4geworICAgIGhlaWdodDogNTBweDsKKyAgICB3aWR0aDogNTBw eDsKKyAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CisgICAgcGFkZGluZzowcHg7CisgICAgbWFy Z2luOjVweDsKKyAgICBib3JkZXI6MHB4OworfQorPC9zdHlsZT4KKzxib2R5PgorPGRpdj4KKyAg ICA8c3BhbiBpZD0idGVzdCI+SGVsbG9vIFdvcmxkIEhlbGxvbyBXb3JsZDwvc3Bhbj4KKyAgICA8 c3BhbiA+SGVsbG9vIFdvcmxkIEhlbGxvbyBXb3JsZDwvc3Bhbj4KKzwvZGl2PgorPHNjcmlwdD4K K3ZhciBzZWxPYmplY3QgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CitzZWxPYmplY3Quc2VsZWN0 QWxsQ2hpbGRyZW4oZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKSk7Cis8L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0 aW9uL3RleHQtc2VsZWN0aW9uLWluLWZsZXhib3guaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL3RleHQtc2VsZWN0aW9uLWluLWZsZXhib3guaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41Njg2 ZjgyOWRkN2YyZTlhZGE3MTU5YjljYjNkMjYwMDBjYTU4ZGM1Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vdGV4dC1zZWxlY3Rpb24taW4tZmxleGJveC5o dG1sCkBAIC0wLDAgKzEsMjcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c3R5bGU+Cisu ZmxleEJveCB7CisgICAgZGlzcGxheTogLXdlYmtpdC1mbGV4OworICAgIGRpc3BsYXk6IC1tb3ot ZmxleDsKKyAgICBkaXNwbGF5OiBmbGV4OworICAgIGZsZXgtZmxvdzogcm93OworfQorCitzcGFu IHsKKyAgICBoZWlnaHQ6IDUwcHg7CisgICAgd2lkdGg6IDUwcHg7CisgICAgbWFyZ2luOjVweDsK K30KKzwvc3R5bGU+Cis8Ym9keT4KKzxkaXYgY2xhc3M9ImZsZXhCb3giPgorICAgIDxzcGFuIGlk PSJ0ZXN0Ij5IZWxsb28gV29ybGQgSGVsbG9vIFdvcmxkPC9zcGFuPgorICAgIDxzcGFuIHN0eWxl PSJtYXJnaW4tbGVmdDo5cHg7Ij5IZWxsb28gV29ybGQgSGVsbG9vIFdvcmxkPC9zcGFuPgorPC9k aXY+Cis8c2NyaXB0PgordmFyIHNlbE9iamVjdCA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKK3Nl bE9iamVjdC5zZWxlY3RBbGxDaGlsZHJlbihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcp KTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=