119876 2013-08-15 18:17:33 -0700 [JSC] x86: improve code generation for xxxTest32 2013-08-16 16:34:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough oliver oldest_to_newest 917793 0 benjamin 2013-08-15 18:17:33 -0700 [JSC] x86: improve code generation for xxxTest32 917795 1 208875 benjamin 2013-08-15 18:20:06 -0700 Created attachment 208875 Patch 917813 2 208875 ggaren 2013-08-15 21:07:01 -0700 Comment on attachment 208875 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208875&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + When the input is a register, we can use testb if we are only intersted Should be: interested. 918140 3 benjamin 2013-08-16 16:34:00 -0700 Committed r154207: <http://trac.webkit.org/changeset/154207> 208875 2013-08-15 18:20:06 -0700 2013-08-15 21:07:00 -0700 Patch bug-119876-20130815182006.patch text/plain 4009 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MmRmODNkMDY0YjRkYzc0NzhjNGU4ODIzMDVlYWQxYjI5MmI4YTcyLi5hY2MyN2E5N2E2N2I1N2Y1 NGRlYTVkZjhmNzk0ZTY1NWFhNzczZjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMy0wOC0xNSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10geDg2OiBpbXByb3ZlIGNvZGUgZ2VuZXJhdGlvbiBmb3Ig eHh4VGVzdDMyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTk4NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUcnkgdG8gdXNlIHRlc3RiIHdoZW5ldmVyIHBvc3NpYmxlIHdoZW4gdGVzdGluZyBmb3IgYW4g aW1tZWRpYXRlIHZhbHVlLgorCisgICAgICAgIFdoZW4gdGhlIGlucHV0IGlzIGFuIGFkZHJlc3Mg YW5kIGFuIG9mZnNldCwgd2UgY2FuIHR3ZWFrIHRoZSBtYXNrCisgICAgICAgIGFuZCBvZmZzZXQg dG8gYmUgYWJsZSB0byBnZW5lcmF0ZSB0ZXN0YiBmb3IgYW55IGJ5dGUgb2YgdGhlIG1hc2suCisK KyAgICAgICAgV2hlbiB0aGUgaW5wdXQgaXMgYSByZWdpc3Rlciwgd2UgY2FuIHVzZSB0ZXN0YiBp ZiB3ZSBhcmUgb25seSBpbnRlcnN0ZWQKKyAgICAgICAgaW4gdGVzdGluZyB0aGUgbG93IGJpdHMu CisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaDoKKyAgICAg ICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246OmJyYW5jaFRlc3QzMik6CisgICAgICAg IChKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjp0ZXN0MzIpOgorICAgICAgICAoSlNDOjpN YWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6Z2VuZXJhdGVUZXN0MzIpOgorCiAyMDEzLTA4LTA3ICBN YXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgMzItYml0 IGNvZGUgZ2VuIGZvciBUeXBlT2YgZG9lc24ndCBwcm9wZXJseSB1cGRhdGUgdGhlIEFic3RyYWN0 SW50ZXJwcmV0ZXIgc3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAppbmRleCBkYmU4MjUzODc2YTMyYmY1 ZmFkMjg5NTY5YWI3OTJjZjMyNTAwZTU0Li5iM2NjOTc2ZDA4MmVkNWMzZDU2YjdjZGUzZGJiMDlk MDMwNDkzMDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCkBAIC0xMTMyLDkgKzExMzIsMTAgQEAgcHVi bGljOgogCiAgICAgSnVtcCBicmFuY2hUZXN0MzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQsIFJlZ2lz dGVySUQgcmVnLCBUcnVzdGVkSW1tMzIgbWFzayA9IFRydXN0ZWRJbW0zMigtMSkpCiAgICAgewot ICAgICAgICAvLyBpZiB3ZSBhcmUgb25seSBpbnRlcmVzdGVkIGluIHRoZSBsb3cgc2V2ZW4gYml0 cywgdGhpcyBjYW4gYmUgdGVzdGVkIHdpdGggYSB0ZXN0YgogICAgICAgICBpZiAobWFzay5tX3Zh bHVlID09IC0xKQogICAgICAgICAgICAgbV9hc3NlbWJsZXIudGVzdGxfcnIocmVnLCByZWcpOwor ICAgICAgICBlbHNlIGlmICghKG1hc2subV92YWx1ZSAmIH4weGZmKSkKKyAgICAgICAgICAgIG1f YXNzZW1ibGVyLnRlc3RiX2k4cihtYXNrLm1fdmFsdWUsIHJlZyk7CiAgICAgICAgIGVsc2UKICAg ICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RsX2kzMnIobWFzay5tX3ZhbHVlLCByZWcpOwogICAg ICAgICByZXR1cm4gSnVtcChtX2Fzc2VtYmxlci5qQ0MoeDg2Q29uZGl0aW9uKGNvbmQpKSk7CkBA IC0xMTQyLDEwICsxMTQzLDcgQEAgcHVibGljOgogCiAgICAgSnVtcCBicmFuY2hUZXN0MzIoUmVz dWx0Q29uZGl0aW9uIGNvbmQsIEFkZHJlc3MgYWRkcmVzcywgVHJ1c3RlZEltbTMyIG1hc2sgPSBU cnVzdGVkSW1tMzIoLTEpKQogICAgIHsKLSAgICAgICAgaWYgKG1hc2subV92YWx1ZSA9PSAtMSkK LSAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNtcGxfaW0oMCwgYWRkcmVzcy5vZmZzZXQsIGFkZHJl c3MuYmFzZSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RsX2kz Mm0obWFzay5tX3ZhbHVlLCBhZGRyZXNzLm9mZnNldCwgYWRkcmVzcy5iYXNlKTsKKyAgICAgICAg Z2VuZXJhdGVUZXN0MzIoYWRkcmVzcywgbWFzayk7CiAgICAgICAgIHJldHVybiBKdW1wKG1fYXNz ZW1ibGVyLmpDQyh4ODZDb25kaXRpb24oY29uZCkpKTsKICAgICB9CiAKQEAgLTE0MTMsMTAgKzE0 MTEsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHRlc3QzMihSZXN1bHRDb25kaXRpb24gY29uZCwg QWRkcmVzcyBhZGRyZXNzLCBUcnVzdGVkSW1tMzIgbWFzaywgUmVnaXN0ZXJJRCBkZXN0KQogICAg IHsKLSAgICAgICAgaWYgKG1hc2subV92YWx1ZSA9PSAtMSkKLSAgICAgICAgICAgIG1fYXNzZW1i bGVyLmNtcGxfaW0oMCwgYWRkcmVzcy5vZmZzZXQsIGFkZHJlc3MuYmFzZSk7Ci0gICAgICAgIGVs c2UKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RsX2kzMm0obWFzay5tX3ZhbHVlLCBhZGRy ZXNzLm9mZnNldCwgYWRkcmVzcy5iYXNlKTsKKyAgICAgICAgZ2VuZXJhdGVUZXN0MzIoYWRkcmVz cywgbWFzayk7CiAgICAgICAgIHNldDMyKHg4NkNvbmRpdGlvbihjb25kKSwgZGVzdCk7CiAgICAg fQogCkBAIC0xNDk4LDYgKzE0OTMsMjIgQEAgcHJpdmF0ZToKICAgICAvLyB4ODZfNjQsIGFuZCBj bGllbnRzICYgc3ViY2xhc3NlcyBvZiBNYWNyb0Fzc2VtYmxlciBzaG91bGQgYmUgdXNpbmcgJ3N1 cHBvcnRzRmxvYXRpbmdQb2ludCgpJy4KICAgICBmcmllbmQgY2xhc3MgTWFjcm9Bc3NlbWJsZXJY ODY7CiAKKyAgICBBTFdBWVNfSU5MSU5FIHZvaWQgZ2VuZXJhdGVUZXN0MzIoQWRkcmVzcyBhZGRy ZXNzLCBUcnVzdGVkSW1tMzIgbWFzayA9IFRydXN0ZWRJbW0zMigtMSkpCisgICAgeworICAgICAg ICBpZiAobWFzay5tX3ZhbHVlID09IC0xKQorICAgICAgICAgICAgbV9hc3NlbWJsZXIuY21wbF9p bSgwLCBhZGRyZXNzLm9mZnNldCwgYWRkcmVzcy5iYXNlKTsKKyAgICAgICAgZWxzZSBpZiAoISht YXNrLm1fdmFsdWUgJiB+MHhmZikpCisgICAgICAgICAgICBtX2Fzc2VtYmxlci50ZXN0Yl9pbSht YXNrLm1fdmFsdWUsIGFkZHJlc3Mub2Zmc2V0LCBhZGRyZXNzLmJhc2UpOworICAgICAgICBlbHNl IGlmICghKG1hc2subV92YWx1ZSAmIH4weGZmMDApKQorICAgICAgICAgICAgbV9hc3NlbWJsZXIu dGVzdGJfaW0obWFzay5tX3ZhbHVlID4+IDgsIGFkZHJlc3Mub2Zmc2V0ICsgMSwgYWRkcmVzcy5i YXNlKTsKKyAgICAgICAgZWxzZSBpZiAoIShtYXNrLm1fdmFsdWUgJiB+MHhmZjAwMDApKQorICAg ICAgICAgICAgbV9hc3NlbWJsZXIudGVzdGJfaW0obWFzay5tX3ZhbHVlID4+IDE2LCBhZGRyZXNz Lm9mZnNldCArIDIsIGFkZHJlc3MuYmFzZSk7CisgICAgICAgIGVsc2UgaWYgKCEobWFzay5tX3Zh bHVlICYgfjB4ZmYwMDAwMDApKQorICAgICAgICAgICAgbV9hc3NlbWJsZXIudGVzdGJfaW0obWFz ay5tX3ZhbHVlID4+IDI0LCBhZGRyZXNzLm9mZnNldCArIDMsIGFkZHJlc3MuYmFzZSk7CisgICAg ICAgIGVsc2UKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RsX2kzMm0obWFzay5tX3ZhbHVl LCBhZGRyZXNzLm9mZnNldCwgYWRkcmVzcy5iYXNlKTsKKyAgICB9CisKICNpZiBDUFUoWDg2KQog I2lmIE9TKE1BQ19PU19YKQogCg==