119861 2013-08-15 13:43:54 -0700 Fix !ENABLE(INSPECTOR) builds after r154116 2013-08-15 13:58:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 119435 1 zarvai webkit-unassigned simon.fraser thorton oldest_to_newest 917673 0 zarvai 2013-08-15 13:43:54 -0700 Variable 'page' is unused on !ENABLE(INSPECTOR) builds after r154116: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/page/FrameView.cpp: In member function 'void WebCore::FrameView::sendResizeEventIfNeeded()': /ramdisk/qt-linux-release-minimal/build/Source/WebCore/page/FrameView.cpp:2836:11: error: unused variable 'page' [-Werror=unused-variable] cc1plus: all warnings being treated as errors Fix is on the way. 917677 1 208848 zarvai 2013-08-15 13:46:53 -0700 Created attachment 208848 buildfix 917683 2 zarvai 2013-08-15 13:57:49 -0700 Ups, its already fixed in http://trac.webkit.org/changeset/154128. 208848 2013-08-15 13:46:53 -0700 2013-08-15 13:58:33 -0700 buildfix inspfix.patch text/plain 1683 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYzY1Y2IzLi4wMWEwNmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDgtMTUgIFpvbHRhbiBBcnZhaSAgPHphcnZhaUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzExOTg2MT4gRml4ICFFTkFCTEUoSU5TUEVD VE9SKSBidWlsZHMgYWZ0ZXIgcjE1NDExNi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBNb3ZpbmcgZGVmaW5pdGlvbiBpbnNpZGUgdGhlIGd1YXJkZWQg YXJlYSB0byBmaXg6CisgICAgICAgIFVudXNlZCB2YXJpYWJsZSAncGFnZScgWy1XZXJyb3I9dW51 c2VkLXZhcmlhYmxlXQorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVWaWV3OjpzZW5kUmVzaXplRXZlbnRJZk5lZWRlZCk6CisKIDIwMTMtMDgt MTUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMTE5ODI0PiBBWDogV0tWaWV3IGRvZXMgbm90IGJlY29tZSBmaXJz dCByZXNwb25kZXIgd2hlbiB0aGUgdm9pY2VvdmVyIGN1cnNvciBsYW5kcyBvbiBpdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGY3YTkwNjAuLmFlYjJmYjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAKQEAgLTI4MzMsNyArMjgzMyw2IEBAIHZvaWQgRnJhbWVWaWV3OjpzZW5k UmVzaXplRXZlbnRJZk5lZWRlZCgpCiAgICAgaWYgKCFyZW5kZXJWaWV3IHx8IHJlbmRlclZpZXct PnByaW50aW5nKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIFBhZ2UqIHBhZ2UgPSBtX2ZyYW1l LT5wYWdlKCk7CiAgICAgSW50U2l6ZSBjdXJyZW50U2l6ZTsKICAgICBpZiAodXNlRml4ZWRMYXlv dXQoKSAmJiAhZml4ZWRMYXlvdXRTaXplKCkuaXNFbXB0eSgpICYmIGRlbGVnYXRlc1Njcm9sbGlu ZygpKQogICAgICAgICBjdXJyZW50U2l6ZSA9IGZpeGVkTGF5b3V0U2l6ZSgpOwpAQCAtMjg2MCw2 ICsyODU5LDggQEAgdm9pZCBGcmFtZVZpZXc6OnNlbmRSZXNpemVFdmVudElmTmVlZGVkKCkKICAg ICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZW5xdWV1ZVdpbmRvd0V2ZW50KHJlc2l6ZUV2ZW50 LnJlbGVhc2UoKSk7CiAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQorICAgIFBhZ2UqIHBhZ2UgPSBt X2ZyYW1lLT5wYWdlKCk7CisKICAgICBpZiAoSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpoYXNG cm9udGVuZHMoKSAmJiBpc01haW5GcmFtZSkgewogICAgICAgICBpZiAoSW5zcGVjdG9yQ2xpZW50 KiBpbnNwZWN0b3JDbGllbnQgPSBwYWdlID8gcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5p bnNwZWN0b3JDbGllbnQoKSA6IDApCiAgICAgICAgICAgICBpbnNwZWN0b3JDbGllbnQtPmRpZFJl c2l6ZU1haW5GcmFtZShtX2ZyYW1lLmdldCgpKTsK