119847 2013-08-15 09:55:04 -0700 [Windows] Incorrect DLL Linkage for JavaScriptCore ArrayBuffer and ArrayBufferView 2013-08-15 12:29:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham mark.lam oliver webkit-bug-importer oldest_to_newest 917545 0 bfulgham 2013-08-15 09:55:04 -0700 I noticed the following warnings in my build output: 7>..\runtime\ArrayBuffer.cpp(37): warning C4273: 'JSC::ArrayBuffer::transfer' : inconsistent dll linkage 7> c:\projects\webkit\opensource\source\javascriptcore\runtime\ArrayBuffer.h(109) : see previous definition of 'transfer' 7>..\runtime\ArrayBufferView.cpp(34): warning C4273: 'JSC::ArrayBufferView::ArrayBufferView' : inconsistent dll linkage 7> c:\projects\webkit\opensource\source\javascriptcore\runtime\ArrayBufferView.h(78) : see previous definition of '{ctor}' 7>..\runtime\ArrayBufferView.cpp(46): warning C4273: 'JSC::ArrayBufferView::~ArrayBufferView' : inconsistent dll linkage 7> c:\projects\webkit\opensource\source\javascriptcore\runtime\ArrayBufferView.h(75) : see previous definition of '{dtor}' 7>..\runtime\ArrayBufferView.cpp(52): warning C4273: 'JSC::ArrayBufferView::neuter' : inconsistent dll linkage 7> c:\projects\webkit\opensource\source\javascriptcore\runtime\ArrayBufferView.h(122) : see previous definition of 'neuter' These are caused by the use of a WTF export macro when building JSC: From JavaScriptCore/runtime/ArrayBuffer.h: WTF_EXPORT_PRIVATE bool transfer(ArrayBufferContents&, Vector<RefPtr<ArrayBufferView> >& neuteredViews); From JavaScriptCore/runtime/ArrayBufferView.h: WTF_EXPORT_PRIVATE virtual ~ArrayBufferView(); WTF_EXPORT_PRIVATE ArrayBufferView(PassRefPtr<ArrayBuffer>, unsigned byteOffset); WTF_EXPORT_PRIVATE virtual void neuter(); Unless you have WTF_IS_LINKED_IN_SAME_BINARY defined (which is only true when building the WTF.dll), WTF_EXPORT_PRIVATE is mapped to __declspec(dllimport). This means the linker will try to find these definitions in an external library. This should result in a compile failure, but I guess Visual Studio sees the definition in the implementation file and uses it. 917547 1 webkit-bug-importer 2013-08-15 09:58:29 -0700 <rdar://problem/14747056> 917549 2 208817 bfulgham 2013-08-15 10:01:21 -0700 Created attachment 208817 Patch 917551 3 208817 mark.lam 2013-08-15 10:03:50 -0700 Comment on attachment 208817 Patch LGTM, but need someone else to r+. 917635 4 bfulgham 2013-08-15 12:29:08 -0700 Committed r154119: <http://trac.webkit.org/changeset/154119> 208817 2013-08-15 10:01:21 -0700 2013-08-15 10:04:22 -0700 Patch bug-119847-20130815100105.patch text/plain 2445 bfulgham SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MTA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTA4LTE1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5kb3dzXSBJbmNvcnJlY3QgRExMIExpbmthZ2UgZm9yIEpTQyBBcnJheUJ1ZmZlciBh bmQgQXJyYXlCdWZmZXJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTk4NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHJ1bnRpbWUvQXJyYXlCdWZmZXIuaDogU3dpdGNoIGZyb20gV1RGX0VYUE9S VF9QUklWQVRFIHRvIEpTX0VYUE9SVF9QUklWQVRFCisgICAgICAgICogcnVudGltZS9BcnJheUJ1 ZmZlclZpZXcuaDogRGl0dG8uCisKIDIwMTMtMDgtMTUgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAg PGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTQ4NzkwKSBN YWRlIDcgdGVzdHMgZmFpbCBvbiB4ODYgMzJiaXQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5QnVmZmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQXJyYXlCdWZmZXIuaAkocmV2aXNpb24gMTU0MTAyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlCdWZmZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTA2 LDcgKzEwNiw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGFkZFZpZXcoQXJyYXlCdWZmZXJWaWV3Kik7 CiAgICAgdm9pZCByZW1vdmVWaWV3KEFycmF5QnVmZmVyVmlldyopOwogCi0gICAgV1RGX0VYUE9S VF9QUklWQVRFIGJvb2wgdHJhbnNmZXIoQXJyYXlCdWZmZXJDb250ZW50cyYsIFZlY3RvcjxSZWZQ dHI8QXJyYXlCdWZmZXJWaWV3PiA+JiBuZXV0ZXJlZFZpZXdzKTsKKyAgICBKU19FWFBPUlRfUFJJ VkFURSBib29sIHRyYW5zZmVyKEFycmF5QnVmZmVyQ29udGVudHMmLCBWZWN0b3I8UmVmUHRyPEFy cmF5QnVmZmVyVmlldz4gPiYgbmV1dGVyZWRWaWV3cyk7CiAgICAgYm9vbCBpc05ldXRlcmVkKCkg eyByZXR1cm4gIW1fY29udGVudHMubV9kYXRhOyB9CiAKICAgICB+QXJyYXlCdWZmZXIoKSB7IH0K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5QnVmZmVyVmlldy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5QnVmZmVyVmll dy5oCShyZXZpc2lvbiAxNTQxMDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9B cnJheUJ1ZmZlclZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAtNzIsMTAgKzcyLDEwIEBAIHB1Ymxp YzoKICAgICB2b2lkIHNldE5ldXRlcmFibGUoYm9vbCBmbGFnKSB7IG1faXNOZXV0ZXJhYmxlID0g ZmxhZzsgfQogICAgIGJvb2wgaXNOZXV0ZXJhYmxlKCkgY29uc3QgeyByZXR1cm4gbV9pc05ldXRl cmFibGU7IH0KIAotICAgIFdURl9FWFBPUlRfUFJJVkFURSB2aXJ0dWFsIH5BcnJheUJ1ZmZlclZp ZXcoKTsKKyAgICBKU19FWFBPUlRfUFJJVkFURSB2aXJ0dWFsIH5BcnJheUJ1ZmZlclZpZXcoKTsK IAogcHJvdGVjdGVkOgotICAgIFdURl9FWFBPUlRfUFJJVkFURSBBcnJheUJ1ZmZlclZpZXcoUGFz c1JlZlB0cjxBcnJheUJ1ZmZlcj4sIHVuc2lnbmVkIGJ5dGVPZmZzZXQpOworICAgIEpTX0VYUE9S VF9QUklWQVRFIEFycmF5QnVmZmVyVmlldyhQYXNzUmVmUHRyPEFycmF5QnVmZmVyPiwgdW5zaWdu ZWQgYnl0ZU9mZnNldCk7CiAKICAgICBpbmxpbmUgYm9vbCBzZXRJbXBsKEFycmF5QnVmZmVyVmll dyosIHVuc2lnbmVkIGJ5dGVPZmZzZXQpOwogCkBAIC0xMTksNyArMTE5LDcgQEAgcHJvdGVjdGVk OgogICAgICAgICAqbnVtRWxlbWVudHMgPSBzdGQ6Om1pbihyZW1haW5pbmdFbGVtZW50cywgKm51 bUVsZW1lbnRzKTsKICAgICB9CiAKLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdmlydHVhbCB2b2lk IG5ldXRlcigpOworICAgIEpTX0VYUE9SVF9QUklWQVRFIHZpcnR1YWwgdm9pZCBuZXV0ZXIoKTsK IAogICAgIC8vIFRoaXMgaXMgdGhlIGFkZHJlc3Mgb2YgdGhlIEFycmF5QnVmZmVyJ3Mgc3RvcmFn ZSwgcGx1cyB0aGUgYnl0ZSBvZmZzZXQuCiAgICAgdm9pZCogbV9iYXNlQWRkcmVzczsK