119835 2013-08-15 05:10:00 -0700 Disable maybe-uninitialized warning with GCC 4.8 2013-08-21 02:23:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen benjamin cmarcelo commit-queue oldest_to_newest 917476 0 allan.jensen 2013-08-15 05:10:00 -0700 GCC 4.8 emits a maybe-uninitialized warning for UnlinkedCodeBlock.cpp:249. It seems to be a mistake from GCC, but we might as well fix it to shut it up. 917477 1 208802 allan.jensen 2013-08-15 05:12:03 -0700 Created attachment 208802 Patch 917761 2 208802 andersca 2013-08-15 16:24:32 -0700 Comment on attachment 208802 Patch I hate the “may be uninitialized” warning; it uses the GCC optimizer and can thus give different results based on the optimization level. I suggest you turn this warning off instead. 919001 3 209179 allan.jensen 2013-08-20 03:47:15 -0700 Created attachment 209179 Patch Disable the warning instead. 919043 4 209179 andersca 2013-08-20 07:39:30 -0700 Comment on attachment 209179 Patch Looks good, but please retitle the bug as well. 919370 5 allan.jensen 2013-08-21 02:23:06 -0700 Committed r154381: <http://trac.webkit.org/changeset/154381> 208802 2013-08-15 05:12:03 -0700 2013-08-20 03:47:11 -0700 Patch bug-119835-20130815141202.patch text/plain 1539 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx Y2Y2OWVkY2I0MDI0MzRiMDY4ZWFiZTJhNzE4NDRmYTJmMWZkMGQzLi5iMzdmODllNjExYzBlYzEz MDRhMDY2ZDllZTAxZjNiOTA5YWEzNTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxMy0wOC0xNSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVu c2VuQGRpZ2lhLmNvbT4KIAorICAgICAgICBGaXggbWF5YmUtdW5pbml0aWFsaXplZCB3YXJuaW5n IHdpdGggR0NDIDQuOAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE5ODM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5pdGlhbGl6ZSBsaW5lIHZhcmlhYmxlIHRvIG1ha2UgR0NDIHN0b3AgY29tcGxhaW5p bmcuCisKKyAgICAgICAgKiBieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHA6CisgICAgICAg IChKU0M6OlVubGlua2VkQ29kZUJsb2NrOjpsaW5lTnVtYmVyRm9yQnl0ZWNvZGVPZmZzZXQpOgor CisyMDEzLTA4LTE1ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEu Y29tPgorCiAgICAgICAgIFJFR1JFU1NJT04ocjE0ODc5MCkgTWFkZSA3IHRlc3RzIGZhaWwgb24g eDg2IDMyYml0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTQ5MTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1Vu bGlua2VkQ29kZUJsb2NrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Vbmxp bmtlZENvZGVCbG9jay5jcHAKaW5kZXggMjA3MDlhNTdhOGMzOTBhMTY1NTNmYzM0MDIwOWZhYjFj MjcxZjFjMy4uZGVmYTQ3ZjA2MWNhMWNmOGU1NjAzNDdlZDRiODM0YTkyZDcyMjAwOSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2su Y3BwCkBAIC0yNDMsNyArMjQzLDcgQEAgaW50IFVubGlua2VkQ29kZUJsb2NrOjpsaW5lTnVtYmVy Rm9yQnl0ZWNvZGVPZmZzZXQodW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQpCiAgICAgaW50IGRpdm90 OwogICAgIGludCBzdGFydE9mZnNldDsKICAgICBpbnQgZW5kT2Zmc2V0OwotICAgIHVuc2lnbmVk IGxpbmU7CisgICAgdW5zaWduZWQgbGluZSA9IDA7CiAgICAgdW5zaWduZWQgY29sdW1uOwogICAg IGV4cHJlc3Npb25SYW5nZUZvckJ5dGVjb2RlT2Zmc2V0KGJ5dGVjb2RlT2Zmc2V0LCBkaXZvdCwg c3RhcnRPZmZzZXQsIGVuZE9mZnNldCwgbGluZSwgY29sdW1uKTsKICAgICByZXR1cm4gbGluZTsK 209179 2013-08-20 03:47:15 -0700 2013-08-20 07:39:30 -0700 Patch bug-119835-20130820124714.patch text/plain 1187 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQwMzE2NjNmMzdlNzQ3NzVmYWYzOWYx NTM1MzZkNmVjN2ZmNzFiMmMuLjYwNjQ3NDhkNTk0N2Y2OWI1ZjA4MGYyNzMxZDg5OTI1MjFhNGU4 NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDgtMjAgIEFsbGFuIFNhbmRmZWxkIEplbnNl biAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAgICAgICAgRml4IG1heWJlLXVuaW5pdGlh bGl6ZWQgd2FybmluZyB3aXRoIEdDQyA0LjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExOTgzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERpc2FibGUgdGhlIG1heWJlLXVuaW5pdGlhbGl6ZWQgd2Fybmlu Zy4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5oOgorCiAyMDEzLTA4LTE5ICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x MjAwNDk+IERlbGV0ZSBjb2RlIGZvciBTbm93IExlb3BhcmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL0NvbXBpbGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCmluZGV4IGFhMDcy YjBiNzExYjJkNzdlYzI0YmNiOWRiYTMzOWM4NTFiOTYwYmEuLjc5ZjU5NmQ2NDljMmQzMzA0MGZh NTk3ZmRkZGNhMjFmNmRhYzVhYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVy LmgKKysrIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaApAQCAtMTM1LDYgKzEzNSw3IEBACiAj aWYgQ09NUElMRVIoR0NDKSAmJiAhQ09NUElMRVIoQ0xBTkcpCiAjaWYgR0NDX1ZFUlNJT05fQVRf TEVBU1QoNCwgOCwgMCkKICNwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVd1bnVzZWQt bG9jYWwtdHlwZWRlZnMiCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWF5YmUt dW5pbml0aWFsaXplZCIKICNlbmRpZgogI2lmIGRlZmluZWQoX19TVERDX1ZFUlNJT05fXykgJiYg X19TVERDX1ZFUlNJT05fXyA+PSAyMDExMTJMCiAvKiBDMTEgc3VwcG9ydCAqLwo=