119821 2013-08-14 15:41:32 -0700 AX: platform/mac/accessibility/role-subrole-roledescription.html is failing 2013-08-15 17:44:42 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro ap cdumez commit-queue dmazzoni jdiggs mario rniwa samuel_white webkit-bug-importer oldest_to_newest 917309 0 cfleizach 2013-08-14 15:41:32 -0700 After https://bugs.webkit.org/show_bug.cgi?id=119706 landed this test started to fail 917311 1 webkit-bug-importer 2013-08-14 15:41:53 -0700 <rdar://problem/14740959> 917556 2 ap 2013-08-15 10:22:38 -0700 Who is going to look into this? Looks like this is still making bots red. 917579 3 samuel_white 2013-08-15 11:18:50 -0700 I'm investigating this now with help from Chris. 917717 4 samuel_white 2013-08-15 14:49:31 -0700 accessibilityController.accessibleElementById is returning an AccessibilityUIElement object in every case. This means that if you do say: accessibilityController.accessibleElementById('fdsafdsafdsa') you will get an object back (a junk object, but still an object). So our test: axElement = accessibilityController.accessibleElementById(el.id); if (axElement) { Is invalid because it will always pass. So in the math case we were getting back a junk element from accessibleElementById and comparing that axElements role (which returned nothing) to element.getAttribute('data-role') (which was set to nothing) so we passed. So the fix for this issue is to simply update our layout test. I'll poke around the other accessibility layout tests and file a bug if any others have invalid axElement condition checks like above. 917747 5 208865 samuel_white 2013-08-15 15:32:53 -0700 Created attachment 208865 Updated layout test. This updates our layout test to account for id working correctly on the math element. 917759 6 208865 commit-queue 2013-08-15 16:18:03 -0700 Comment on attachment 208865 Updated layout test. Clearing flags on attachment: 208865 Committed r154148: <http://trac.webkit.org/changeset/154148> 917760 7 commit-queue 2013-08-15 16:18:07 -0700 All reviewed patches have been landed. Closing bug. 917766 8 cfleizach 2013-08-15 16:27:38 -0700 *** Bug 119873 has been marked as a duplicate of this bug. *** 917785 9 ap 2013-08-15 17:44:42 -0700 Thank you for tackling this! 208865 2013-08-15 15:32:53 -0700 2013-08-15 16:18:03 -0700 Updated layout test. role-subrole-roledescription.patch text/plain 2303 samuel_white ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNjJmYmQ1Li5kNmQzNDI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDgt MTUgIFNhbSBXaGl0ZSAgPHNhbXVlbF93aGl0ZUBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHBs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3JvbGUtc3Vicm9sZS1yb2xlZGVzY3JpcHRpb24uaHRt bCBpcyBmYWlsaW5nCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMTk4MjE+CisKKyAg ICAgICAgVXBkYXRpbmcgb3VyIGxheW91dCB0ZXN0IG5vdyB0aGF0IGFjY2Vzc2libGVFbGVtZW50 QnlJZCBpcyBhYmxlCisgICAgICAgIHRvIGZldGNoIHRoZSBtYXRoIGVsZW1lbnQgY29ycmVjdGx5 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9sZS1zdWJyb2xlLXJvbGVkZXNjcmlwdGlvbi1leHBl Y3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9sZS1zdWJy b2xlLXJvbGVkZXNjcmlwdGlvbi5odG1sOgorCiAyMDEzLTA4LTE1ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGEgdGVzdCB0aGF0IHRpbWVzIG91dC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3JvbGUt c3Vicm9sZS1yb2xlZGVzY3JpcHRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9sZS1zdWJyb2xlLXJvbGVkZXNjcmlwdGlvbi1leHBlY3Rl ZC50eHQKaW5kZXggMzY0ZDJhMy4uNmE3MDllZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9sZS1zdWJyb2xlLXJvbGVkZXNjcmlwdGlvbi1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9s ZS1zdWJyb2xlLXJvbGVkZXNjcmlwdGlvbi1leHBlY3RlZC50eHQKQEAgLTMyNSw5ICszMjUsOSBA QCBQQVNTOiBtYXJrCiAgICAgICBBWFJvbGVEZXNjcmlwdGlvbjogCiAgICAgICAKIFBBU1M6IG1h dGgKLSAgICAgIEFYUm9sZTogCi0gICAgICBBWFN1YnJvbGU6IAotICAgICAgQVhSb2xlRGVzY3Jp cHRpb246IAorICAgICAgQVhSb2xlOiBBWEdyb3VwCisgICAgICBBWFN1YnJvbGU6IEFYRG9jdW1l bnRNYXRoCisgICAgICBBWFJvbGVEZXNjcmlwdGlvbjogbWF0aAogICAgICAgCiBQQVNTOiBtZXRl cgogICAgICAgQVhSb2xlOiBBWFByb2dyZXNzSW5kaWNhdG9yCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9yb2xlLXN1YnJvbGUtcm9sZWRlc2NyaXB0 aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9yb2xlLXN1 YnJvbGUtcm9sZWRlc2NyaXB0aW9uLmh0bWwKaW5kZXggMDdlODhiYy4uYzhjMTZlMCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcm9sZS1zdWJyb2xl LXJvbGVkZXNjcmlwdGlvbi5odG1sCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L3JvbGUtc3Vicm9sZS1yb2xlZGVzY3JpcHRpb24uaHRtbApAQCAtOTAsNyArOTAs NyBAQAogPCEtLSBza2lwcGVkIDxsaW5rPiAtLT4KIDwhLS0gc2tpcHBlZCA8bWFwPiAtLT4KIDwh LS0gaHR0cDovL3dlYmtpdC5vcmcvYi8xMDkwMTggLS0+PG1hcmsgZGF0YS1yb2xlPSIiIGRhdGEt c3Vicm9sZT0iIiBkYXRhLXJvbGVkZXNjcmlwdGlvbj0iIiBjbGFzcz0iZXgiPlg8L21hcms+Ci08 bWF0aCBkYXRhLXJvbGU9IiIgZGF0YS1zdWJyb2xlPSIiIGRhdGEtcm9sZWRlc2NyaXB0aW9uPSIi IGNsYXNzPSJleCI+WDwvbWF0aD4KKzxtYXRoIGRhdGEtcm9sZT0iQVhHcm91cCIgZGF0YS1zdWJy b2xlPSJBWERvY3VtZW50TWF0aCIgZGF0YS1yb2xlZGVzY3JpcHRpb249Im1hdGgiIGNsYXNzPSJl eCI+WDwvbWF0aD4KIDwhLS0gc2tpcHBlZCA8bWVudT4gLS0+CiA8IS0tIHNraXBwZWQgPG1ldGE+ IC0tPgogPG1ldGVyIGRhdGEtcm9sZT0iQVhQcm9ncmVzc0luZGljYXRvciIgZGF0YS1zdWJyb2xl PSIiIGRhdGEtcm9sZWRlc2NyaXB0aW9uPSJwcm9ncmVzcyBpbmRpY2F0b3IiIGNsYXNzPSJleCIg dmFsdWU9IjAuNzUiPlg8L21ldGVyPgo=