<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>119818</bug_id>
          
          <creation_ts>2013-08-14 15:00:20 -0700</creation_ts>
          <short_desc>[Windows] Test fails in DRT, succeeds in WinLauncher</short_desc>
          <delta_ts>2013-08-16 08:26:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>917298</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-14 15:00:20 -0700</bug_when>
    <thetext>For some reason, the test &quot;compositing/tiling/empty-to-tiled.html&quot; crashes when run via DumpRenderTree, but works correctly inside WinLauncher.

The crash happens because we encounter a CACFLayer in the PlatformCALayer::adoptSublayers call that does not have an PlatformCALayerWinInternal object attached to its UserData node. We dereference this null pointer and crash.

The crashing callstack looks like this:

&gt;	WebKit.dll!WTF::VectorBufferBase&lt;WebCore::StyleRule *&gt;::buffer()  Line 50 + 0xa bytes	C++
 	WebKit.dll!WebCore::PlatformCALayer::platformLayer()  Line 180	C++
 	WebKit.dll!WebCore::PlatformCALayerWinInternal::setSublayers(const WTF::Vector&lt;WTF::RefPtr&lt;WebCore::PlatformCALayer&gt;,0,WTF::CrashOnOverflow&gt; &amp; list)  Line 205 + 0x1a bytes	C++
 	WebKit.dll!WebCore::PlatformCALayer::setSublayers(const WTF::Vector&lt;WTF::RefPtr&lt;WebCore::PlatformCALayer&gt;,0,WTF::CrashOnOverflow&gt; &amp; list)  Line 264	C++
 	WebKit.dll!WebCore::PlatformCALayer::adoptSublayers(WebCore::PlatformCALayer * source)  Line 316	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::swapFromOrToTiledLayer(bool useTiledLayer)  Line 2706	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers(WebCore::GraphicsLayerCA::CommitState &amp; commitState, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, const WebCore::FloatRect &amp; oldVisibleRect)  Line 1145	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1064	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::flushCompositingState(const WebCore::FloatRect &amp; clipRect)  Line 893	C++
 	WebKit.dll!WebCore::RenderLayerCompositor::flushPendingLayerChanges(bool isFlushRoot)  Line 399	C++
 	WebKit.dll!WebCore::FrameView::flushCompositingStateForThisFrame(WebCore::Frame * rootFrameForFlush)  Line 938	C++
 	WebKit.dll!WebCore::FrameView::flushCompositingStateIncludingSubframes()  Line 1038 + 0x17 bytes	C++
 	WebKit.dll!WebView::flushPendingGraphicsLayerChanges()  Line 6736	C++
 	WebKit.dll!WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow()  Line 296	C++
 	WebKit.dll!WebView::paint(HDC__ * dc, long options)  Line 1066	C++
 	WebKit.dll!WebView::WebViewWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam)  Line 2189	C++
 	user32.dll!_InternalCallWinProc@20()  + 0x23 bytes	
 	user32.dll!_UserCallWinProcCheckWow@36()  + 0xbd bytes	
 	user32.dll!_CallWindowProcAorW@24()  + 0x5d bytes	
 	user32.dll!_CallWindowProcW@20()  + 0x1c bytes	
 	comctl32.dll!_CallOriginalWndProc@24()  + 0x1a bytes	
 	comctl32.dll!CallNextSubclassProc()  + 0x92 bytes	
 	comctl32.dll!TTSubclassProc()  + 0x97 bytes	
 	comctl32.dll!CallNextSubclassProc()  + 0x92 bytes	
 	comctl32.dll!MasterSubclassProc()  + 0xa4 bytes	
 	user32.dll!_InternalCallWinProc@20()  + 0x23 bytes	
 	user32.dll!_UserCallWinProcCheckWow@36()  + 0x18d9 bytes	
 	user32.dll!_SendMessageWorker@24()  + 0x47b9 bytes	
 	user32.dll!_SendMessageW@16()  + 0x52 bytes	
 	DumpRenderTree.dll!dump()  Line 749	C++
 	DumpRenderTree.dll!FrameLoadDelegate::locationChangeDone(IWebError * __formal, IWebFrame * frame)  Line 254	C++
 	DumpRenderTree.dll!FrameLoadDelegate::didFinishLoadForFrame(IWebView * webView, IWebFrame * frame)  Line 264	C++
 	WebKit.dll!WebFrameLoaderClient::dispatchDidFinishLoad()  Line 413	C++
 	WebKit.dll!WebCore::FrameLoader::checkLoadCompleteForThisFrame()  Line 2197	C++
 	WebKit.dll!WebCore::FrameLoader::checkLoadComplete()  Line 2363 + 0x24 bytes	C++
 	WebKit.dll!WebCore::DocumentLoader::finishedLoading(double finishTime)  Line 411	C++
 	WebKit.dll!WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource * resource)  Line 345	C++
 	WebKit.dll!WebCore::CachedResource::checkNotify()  Line 369 + 0x11 bytes	C++
 	WebKit.dll!WebCore::CachedResource::finishLoading(WebCore::ResourceBuffer * __formal)  Line 386	C++
 	WebKit.dll!WebCore::CachedRawResource::finishLoading(WebCore::ResourceBuffer * data)  Line 95	C++
 	WebKit.dll!WebCore::SubresourceLoader::didFinishLoading(double finishTime)  Line 284	C++
 	WebKit.dll!WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle * __formal, double finishTime)  Line 489	C++
 	WebKit.dll!WebCore::didFinishLoading(_CFURLConnection * conn, const void * clientInfo)  Line 263	C++
 	CFNetwork.dll!URLConnectionClient::_clientDidFinishLoading(URLConnectionClient::ClientConnectionEventQueue * preQ)  Line 1739 + 0x13 bytes	C++
 	CFNetwork.dll!URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo&lt;enum XClientEvent,XClientEventParams&gt; * e, long count)  Line 2256	C++
 	CFNetwork.dll!XConnectionEventQueue&lt;enum XClientEvent,XClientEventParams&gt;::processAllEvents()  Line 231	C++
 	CFNetwork.dll!URLConnectionClient::processEvents()  Line 362	C++
 	CFNetwork.dll!URLConnectionWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam)  Line 109	C++
 	user32.dll!_InternalCallWinProc@20()  + 0x23 bytes	
 	user32.dll!_UserCallWinProcCheckWow@36()  + 0xbd bytes	
 	user32.dll!_DispatchMessageWorker@8()  + 0xf8 bytes	
 	user32.dll!_DispatchMessageW@4()  + 0x10 bytes	
 	DumpRenderTree.dll!runTest(const std::basic_string&lt;char,std::char_traits&lt;char&gt;,std::allocator&lt;char&gt; &gt; &amp; inputLine)  Line 1134	C++
 	DumpRenderTree.dll!dllLauncherEntryPoint(int argc, const char * * argv)  Line 1425 + 0x23 bytes	C++
 	DumpRenderTree.exe!main(int argc, const char * * argv)  Line 202 + 0xe bytes	C++
 	DumpRenderTree.exe!__tmainCRTStartup()  Line 555 + 0x17 bytes	C
 	kernel32.dll!@BaseThreadInitThunk@12()  + 0xe bytes	
 	ntdll.dll!___RtlUserThreadStart@8()  + 0x27 bytes	
 	ntdll.dll!__RtlUserThreadStart@8()  + 0x1b bytes	

The same break position (in WinLauncher) is hit from a different starting point. In WinLauncher we are in the midst of a flush operation from the parent layers.

&gt;	WebKit.dll!WebCore::GraphicsLayerCA::swapFromOrToTiledLayer(bool useTiledLayer)  Line 2696	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers(WebCore::GraphicsLayerCA::CommitState &amp; commitState, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, const WebCore::FloatRect &amp; oldVisibleRect)  Line 1145	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1064	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::recursiveCommitChanges(const WebCore::GraphicsLayerCA::CommitState &amp; commitState, const WebCore::TransformState &amp; state, float pageScaleFactor, const WebCore::FloatPoint &amp; positionRelativeToBase, bool affectedByPageScale)  Line 1080	C++
 	WebKit.dll!WebCore::GraphicsLayerCA::flushCompositingState(const WebCore::FloatRect &amp; clipRect)  Line 893	C++
 	WebKit.dll!WebCore::RenderLayerCompositor::flushPendingLayerChanges(bool isFlushRoot)  Line 399	C++
 	WebKit.dll!WebCore::FrameView::flushCompositingStateForThisFrame(WebCore::Frame * rootFrameForFlush)  Line 938	C++
 	WebKit.dll!WebCore::FrameView::flushCompositingStateIncludingSubframes()  Line 1038 + 0x17 bytes	C++
 	WebKit.dll!WebView::flushPendingGraphicsLayerChanges()  Line 6736	C++
 	WebKit.dll!WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow()  Line 296	C++
 	WebKit.dll!WebCore::LayerChangesFlusher::hookFired(int code, unsigned int wParam, long lParam)  Line 93 + 0x1e bytes	C++
 	WebKit.dll!WebCore::LayerChangesFlusher::hookCallback(int code, unsigned int wParam, long lParam)  Line 78 + 0x18 bytes	C++
 	user32.dll!_DispatchHookW@16()  + 0x36 bytes	
 	user32.dll!_CallHookWithSEH@16()  + 0x25 bytes	
 	user32.dll!___fnHkINLPMSG@4()  + 0x51 bytes	
 	ntdll.dll!_KiUserCallbackDispatcher@12()  + 0x2e bytes	
 	user32.dll!_PeekMessageW@20()  + 0x11f bytes	
 	CoreFoundation.dll!__CFRunLoopRun(__CFRunLoop * rl, __CFRunLoopMode * rlm, double seconds, unsigned char stopAfterHandle, __CFRunLoopMode * previousMode)  Line 42286 + 0xf bytes	C++
 	CoreFoundation.dll!CFRunLoopRunSpecific(__CFRunLoop * rl, const __CFString * modeName, double seconds, unsigned char returnAfterSourceHandled)  Line 42413 + 0x12 bytes	C++
 	CoreFoundation.dll!CFRunLoopRun()  Line 42440 + 0x1d bytes	C++
 	WinLauncher.dll!dllLauncherEntryPoint(HINSTANCE__ * __formal, HINSTANCE__ * __formal, HINSTANCE__ * __formal, int nCmdShow)  Line 475	C++
 	WinLauncher.exe!004012ca() 	
 	[Frames below may be incorrect and/or missing, no symbols loaded for WinLauncher.exe]	
 	ntdll.dll!_RtlpHeapAddListEntry@24()  + 0xc16 bytes	
 	ntdll.dll!@RtlpFreeHeap@16()  + 0x20c bytes	

I have two initial thoughts:

1. DRT is not properly setting up the run environment. Perhaps not using a CFRunLoop to handle Windows messages means that certain dispatch operations are not occurring, which we rely on to sync/flush our CALayers?
2. Maybe we have a bug in our CACFLayer setup code that is allowing a layer to be created with no &quot;intern&quot; member.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917790</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-15 18:06:01 -0700</bug_when>
    <thetext>This happens when the large blank rectangle in the test is changed to something with a border. This causes us to switch from a plain layer with a color background to a tiled layer.

When the switch from flat to tiled layers is made, the old &quot;background color&quot; layer is destroyed. However, a pointer to this destroyed layer is left in the parent containing layer.

Later, when we switch to using a tiling layer, we attempt to grab the sublayers of the &quot;flat&quot; layer we are replacing.  Unfortunately, the sole sublayer is a dangling pointer to our &quot;destroyed&quot; &quot;background color&quot; layer.  When we attempt to dereference this NULL pointer we get a crash.

The solution proposed in this bug is to remove the layer from its superlayer during the destruction process.

We could also add null-pointer checking in the PlatformCALayerWinInternall::getSublayers method, but removing the sublayer prevents the corrupt entry from being present.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917791</commentid>
    <comment_count>2</comment_count>
      <attachid>208874</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-15 18:11:37 -0700</bug_when>
    <thetext>Created attachment 208874
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917792</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2013-08-15 18:12:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/14753069&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917794</commentid>
    <comment_count>4</comment_count>
      <attachid>208874</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2013-08-15 18:17:47 -0700</bug_when>
    <thetext>Comment on attachment 208874
Patch

You should re-enable tests at the same time!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917814</commentid>
    <comment_count>5</comment_count>
      <attachid>208879</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-15 21:14:32 -0700</bug_when>
    <thetext>Created attachment 208879
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917815</commentid>
    <comment_count>6</comment_count>
      <attachid>208879</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-15 21:15:06 -0700</bug_when>
    <thetext>Comment on attachment 208879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208879&amp;action=review

&gt; Tools/ChangeLog:16
&gt; +

Sigh.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917816</commentid>
    <comment_count>7</comment_count>
      <attachid>208880</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-15 21:18:30 -0700</bug_when>
    <thetext>Created attachment 208880
Reactivate compositing/tiling/empty-to-tiled.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>917961</commentid>
    <comment_count>8</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-08-16 08:26:28 -0700</bug_when>
    <thetext>Committed r154180: &lt;http://trac.webkit.org/changeset/154180&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>208874</attachid>
            <date>2013-08-15 18:11:37 -0700</date>
            <delta_ts>2013-08-15 21:14:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-119818-20130815181120.patch</filename>
            <type>text/plain</type>
            <size>1505</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDE1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTE1ICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dzXSBQcmV2ZW50
IGRhbmdsaW5nIENBQ0ZMYXllciB3aGVuIHN3aXRjaGluZyB0by9mcm9tIFRpbGVkIGJhY2tpbmcu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk4MTgK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVk
IGJ5IGV4aXN0aW5nOiBjb21wb3NpdGluZy90aWxpbmcvZW1wdHktdG8tdGlsZWQuaHRtbAorCisg
ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5jcHA6
CisgICAgICAgIChQbGF0Zm9ybUNBTGF5ZXI6On5QbGF0Zm9ybUNBTGF5ZXIpOiBSZW1vdmUgZGVs
ZXRlZCBsYXllciBmcm9tIGl0cworICAgICAgICBwYXJlbnQgbGF5ZXIgCisKIDIwMTMtMDgtMTUg
IEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBTaGFwZXNd
IEFkZCBzdXBwb3J0IGZvciBzaGFwZS1vdXRzaWRlIGltYWdlIHZhbHVlcwpJbmRleDogU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1Bs
YXRmb3JtQ0FMYXllcldpbi5jcHAJKHJldmlzaW9uIDE1NDE1MikKKysrIFNvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9QbGF0Zm9ybUNBTGF5ZXJXaW4uY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC0xMzgsNiArMTM4LDEyIEBAIFBsYXRmb3JtQ0FMYXllcjo6flBsYXRmb3JtQ0FM
YXllcigpCiAgICAgUGxhdGZvcm1DQUxheWVyV2luSW50ZXJuYWwqIGxheWVySW50ZXJuID0gaW50
ZXJuKHRoaXMpOwogICAgIENBQ0ZMYXllclNldFVzZXJEYXRhKG1fbGF5ZXIuZ2V0KCksIDApOwog
CisgICAgLy8gQ2xlYXIgdGhlIG93bmVyLCB3aGljaCBhbHNvIGNsZWFycyBpdCBpbiB0aGUgZGVs
ZWdhdGUgdG8gcHJldmVudCBhdHRlbXB0cyAKKyAgICAvLyB0byB1c2UgdGhlIEdyYXBoaWNzTGF5
ZXJDQSBhZnRlciBpdCBoYXMgYmVlbiBkZXN0cm95ZWQuCisgICAgc2V0T3duZXIoMCk7CisKKyAg
ICBDQUNGTGF5ZXJSZW1vdmVGcm9tU3VwZXJsYXllcihtX2xheWVyLmdldCgpKTsKKwogICAgIGRl
bGV0ZSBsYXllckludGVybjsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>208879</attachid>
            <date>2013-08-15 21:14:32 -0700</date>
            <delta_ts>2013-08-15 21:18:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-119818-20130815211413.patch</filename>
            <type>text/plain</type>
            <size>3683</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDE2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTE1ICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dzXSBQcmV2ZW50
IGRhbmdsaW5nIENBQ0ZMYXllciB3aGVuIHN3aXRjaGluZyB0by9mcm9tIFRpbGVkIGJhY2tpbmcu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk4MTgK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVk
IGJ5IGV4aXN0aW5nOiBjb21wb3NpdGluZy90aWxpbmcvZW1wdHktdG8tdGlsZWQuaHRtbAorCisg
ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5jcHA6
CisgICAgICAgIChQbGF0Zm9ybUNBTGF5ZXI6On5QbGF0Zm9ybUNBTGF5ZXIpOiBSZW1vdmUgZGVs
ZXRlZCBsYXllciBmcm9tIGl0cworICAgICAgICBwYXJlbnQgbGF5ZXIgCisKIDIwMTMtMDgtMTMg
IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEdldCBpT1Mg
cG9ydCBvZmYgbGVnYWN5IGNsaXBib2FyZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5jcHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5j
cHAJKHJldmlzaW9uIDE1NDE2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L2NhL3dpbi9QbGF0Zm9ybUNBTGF5ZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsNiAr
MTM4LDEyIEBAIFBsYXRmb3JtQ0FMYXllcjo6flBsYXRmb3JtQ0FMYXllcigpCiAgICAgUGxhdGZv
cm1DQUxheWVyV2luSW50ZXJuYWwqIGxheWVySW50ZXJuID0gaW50ZXJuKHRoaXMpOwogICAgIENB
Q0ZMYXllclNldFVzZXJEYXRhKG1fbGF5ZXIuZ2V0KCksIDApOwogCisgICAgLy8gQ2xlYXIgdGhl
IG93bmVyLCB3aGljaCBhbHNvIGNsZWFycyBpdCBpbiB0aGUgZGVsZWdhdGUgdG8gcHJldmVudCBh
dHRlbXB0cyAKKyAgICAvLyB0byB1c2UgdGhlIEdyYXBoaWNzTGF5ZXJDQSBhZnRlciBpdCBoYXMg
YmVlbiBkZXN0cm95ZWQuCisgICAgc2V0T3duZXIoMCk7CisKKyAgICBDQUNGTGF5ZXJSZW1vdmVG
cm9tU3VwZXJsYXllcihtX2xheWVyLmdldCgpKTsKKwogICAgIGRlbGV0ZSBsYXllckludGVybjsK
IH0KIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxv
ZwkocmV2aXNpb24gMTU0MTYzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTkgQEAKKzIwMTMtMDgtMTQgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBs
ZS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIERSVCBpcyBub3QgdXNpbmcgdGhlIHNhbWUgcHJl
ZmVyZW5jZXMgYXMgdGhlIE1hYyBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTExOTgyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNw
cDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlV25kUHJvYyk6IFRlcm1pbmF0ZSB0aGUgQ0ZSdW5M
b29wIG9uIGV4aXQuCisgICAgICAgIChyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKTog
VXBkYXRlIHRvIG1hdGNoIGN1cnJlbnQgc2V0CisgICAgICAgIG9mIHByZWZlcmVuY2VzIG9uIE1h
Yy4KKyAgICAgICAgKHJ1blRlc3QpOiBQcm9jZXNzIFdpbmRvd3MgbWVzc2FnZSBxdWV1ZSB1c2lu
ZyBDRlJ1bkxvb3AgdG8gYWxsb3cKKyAgICAgICAgZGlzcGF0Y2ggcm91dGluZXMgdG8gcnVuIHBy
b3Blcmx5LgorICAgICAgICAoZGxsTGF1bmNoZXJFbnRyeVBvaW50KTogV3JhcCBDRy1zcGVjaWZp
YyBzZXR1cCBjb2RlIGluIGEgbWFjcm8KKyAgICAgICAgdG8gcHJldmVudCBwcm9ibGVtcyBvbiBX
aW5DYWlybyBwb3J0LgorCiAyMDEzLTA4LTE1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw
bGUuY29tPgogCiAgICAgICAgIFtXSzJdIE5ldHdvcmtQcm9jZXNzIHNob3VsZCB1c2UgYSB0ZW1w
b3Jhcnkgc3RvcmFnZSBzZXNzaW9uIGZvciB0ZXN0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTQxNjMp
CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBA
QAorMjAxMy0wOC0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KKworICAg
ICAgICBbV2luZG93c10gRW5hYmxlIHByZXZpb3VzbHktZmFpbGluZyBjb21wb3NpdGluZy90aWxp
bmcvZW1wdHktdG8tdGlsZWQuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTE5ODE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9uczogUmUtZW5hYmxl
IGVtcHR5LXRvLXRpbGVkLmh0bWwKKwogMjAxMy0wOC0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn
aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luZG93c10gVW5yZXZpZXdlZCBnYXJkZW5pbmcu
IENvcnJlY3Qgc29tZSB0ZXN0IGV4cGVjdGF0aW9ucyB0aGF0IG5vdyBwYXNzLgpJbmRleDogTGF5
b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5
b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE1NDE2MykK
KysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNv
cHkpCkBAIC0yODEzLDUgKzI4MTMsMyBAQCBzdmcvZG9tL3N2Z3BhdGgtb3V0LW9mLWJvdW5kcy1n
ZXRQYXRoU2VnCiBmYXN0L2pzL2dsb2JhbC1jb25zdHJ1Y3RvcnMtYXR0cmlidXRlcy1kZWRpY2F0
ZWQtd29ya2VyLmh0bWwgWyBGYWlsdXJlIF0KIGZhc3QvdGV4dC9zcGxpdC10ZXh0LWNyYXNoLnho
dG1sIFsgRmFpbHVyZSBdCiBmYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1uZXN0ZWQtY3Jh
c2guaHRtbCBbIEZhaWx1cmUgXQotCi13ZWJraXQub3JnL2IvMTE5ODE4IGNvbXBvc2l0aW5nL3Rp
bGluZy9lbXB0eS10by10aWxlZC5odG1sIFsgQ3Jhc2ggXQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>208880</attachid>
            <date>2013-08-15 21:18:30 -0700</date>
            <delta_ts>2013-08-15 23:22:24 -0700</delta_ts>
            <desc>Reactivate compositing/tiling/empty-to-tiled.html</desc>
            <filename>bug-119818-20130815211812.patch</filename>
            <type>text/plain</type>
            <size>2688</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDE2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTE1ICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dzXSBQcmV2ZW50
IGRhbmdsaW5nIENBQ0ZMYXllciB3aGVuIHN3aXRjaGluZyB0by9mcm9tIFRpbGVkIGJhY2tpbmcu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk4MTgK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVk
IGJ5IGV4aXN0aW5nOiBjb21wb3NpdGluZy90aWxpbmcvZW1wdHktdG8tdGlsZWQuaHRtbAorCisg
ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5jcHA6
CisgICAgICAgIChQbGF0Zm9ybUNBTGF5ZXI6On5QbGF0Zm9ybUNBTGF5ZXIpOiBSZW1vdmUgZGVs
ZXRlZCBsYXllciBmcm9tIGl0cworICAgICAgICBwYXJlbnQgbGF5ZXIgCisKIDIwMTMtMDgtMTMg
IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEdldCBpT1Mg
cG9ydCBvZmYgbGVnYWN5IGNsaXBib2FyZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5jcHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbi5j
cHAJKHJldmlzaW9uIDE1NDE2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L2NhL3dpbi9QbGF0Zm9ybUNBTGF5ZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsNiAr
MTM4LDEyIEBAIFBsYXRmb3JtQ0FMYXllcjo6flBsYXRmb3JtQ0FMYXllcigpCiAgICAgUGxhdGZv
cm1DQUxheWVyV2luSW50ZXJuYWwqIGxheWVySW50ZXJuID0gaW50ZXJuKHRoaXMpOwogICAgIENB
Q0ZMYXllclNldFVzZXJEYXRhKG1fbGF5ZXIuZ2V0KCksIDApOwogCisgICAgLy8gQ2xlYXIgdGhl
IG93bmVyLCB3aGljaCBhbHNvIGNsZWFycyBpdCBpbiB0aGUgZGVsZWdhdGUgdG8gcHJldmVudCBh
dHRlbXB0cyAKKyAgICAvLyB0byB1c2UgdGhlIEdyYXBoaWNzTGF5ZXJDQSBhZnRlciBpdCBoYXMg
YmVlbiBkZXN0cm95ZWQuCisgICAgc2V0T3duZXIoMCk7CisKKyAgICBDQUNGTGF5ZXJSZW1vdmVG
cm9tU3VwZXJsYXllcihtX2xheWVyLmdldCgpKTsKKwogICAgIGRlbGV0ZSBsYXllckludGVybjsK
IH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl
c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MTYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDgtMTUgIEJyZW50IEZ1bGdo
YW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIEVuYWJsZSBwcmV2
aW91c2x5LWZhaWxpbmcgY29tcG9zaXRpbmcvdGlsaW5nL2VtcHR5LXRvLXRpbGVkLmh0bWwKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTgxOAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v
d2luL1Rlc3RFeHBlY3RhdGlvbnM6IFJlLWVuYWJsZSBlbXB0eS10by10aWxlZC5odG1sCisKIDIw
MTMtMDgtMTUgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAg
W1dpbmRvd3NdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBDb3JyZWN0IHNvbWUgdGVzdCBleHBlY3Rh
dGlvbnMgdGhhdCBub3cgcGFzcy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0
RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0
RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNTQxNjMpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93
aW4vVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjgxMyw1ICsyODEzLDMgQEAg
c3ZnL2RvbS9zdmdwYXRoLW91dC1vZi1ib3VuZHMtZ2V0UGF0aFNlZwogZmFzdC9qcy9nbG9iYWwt
Y29uc3RydWN0b3JzLWF0dHJpYnV0ZXMtZGVkaWNhdGVkLXdvcmtlci5odG1sIFsgRmFpbHVyZSBd
CiBmYXN0L3RleHQvc3BsaXQtdGV4dC1jcmFzaC54aHRtbCBbIEZhaWx1cmUgXQogZmFzdC9mcmFt
ZXMvc2VhbWxlc3Mvc2VhbWxlc3MtbmVzdGVkLWNyYXNoLmh0bWwgWyBGYWlsdXJlIF0KLQotd2Vi
a2l0Lm9yZy9iLzExOTgxOCBjb21wb3NpdGluZy90aWxpbmcvZW1wdHktdG8tdGlsZWQuaHRtbCBb
IENyYXNoIF0K
</data>
<flag name="review"
          id="230840"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>