119808 2013-08-14 11:35:39 -0700 FloatingObject m_paginationStrut should be LayoutUnit 2014-02-07 10:33:06 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 917207 0 bjonesbe 2013-08-14 11:35:39 -0700 It is a vertical offset, and it will be much clearer if the type is correct. 977203 1 223293 bjonesbe 2014-02-05 19:51:42 -0800 Created attachment 223293 Patch 977758 2 223293 kling 2014-02-07 01:42:23 -0800 Comment on attachment 223293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review r=me > Source/WebCore/ChangeLog:13 > + Also, stop copying the originatingLine in FloatingObject::unsafeClone > + because that allows a FloatingObject to point to a line for a renderer > + that it doesn't belong to. I would do this in a separate change. 977873 3 bjonesbe 2014-02-07 10:19:15 -0800 (In reply to comment #2) > (From update of attachment 223293 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review > > r=me > > > Source/WebCore/ChangeLog:13 > > + Also, stop copying the originatingLine in FloatingObject::unsafeClone > > + because that allows a FloatingObject to point to a line for a renderer > > + that it doesn't belong to. > > I would do this in a separate change. Thanks! I'll pull that out into a different patch. 977877 4 223465 bjonesbe 2014-02-07 10:20:13 -0800 Created attachment 223465 Patch for landing 977887 5 223465 commit-queue 2014-02-07 10:33:04 -0800 Comment on attachment 223465 Patch for landing Clearing flags on attachment: 223465 Committed r163631: <http://trac.webkit.org/changeset/163631> 977888 6 commit-queue 2014-02-07 10:33:06 -0800 All reviewed patches have been landed. Closing bug. 223293 2014-02-05 19:51:42 -0800 2014-02-07 10:20:11 -0800 Patch bug-119808-20140205194824.patch text/plain 4087 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQ0OGYyYzFhNGFhNDUy YmFhNjE0MTg2ZjM3M2ViNGZiZmYwMWE0Yi4uZjcxNmZlMmRlYmEzNzA1Yjk5MjkwMzIyYzczYjJm NzEwYTZkOGYwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTAyLTA1ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIEZsb2F0aW5nT2JqZWN0 IG1fcGFnaW5hdGlvblN0cnV0IHNob3VsZCBiZSBMYXlvdXRVbml0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk4MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBwYWdpbmF0aW9uU3RydXQg aW4gRmxvYXRpbmdPYmplY3QgaGF2ZSB0aGUgc2FtZSB0eXBlIGFzIGFsbAorICAgICAgICBvZiB0 aGUgb3RoZXIgcGFnaW5hdGlvblN0cnV0cyBpbiB0aGUgY29kZS4KKworICAgICAgICBBbHNvLCBz dG9wIGNvcHlpbmcgdGhlIG9yaWdpbmF0aW5nTGluZSBpbiBGbG9hdGluZ09iamVjdDo6dW5zYWZl Q2xvbmUKKyAgICAgICAgYmVjYXVzZSB0aGF0IGFsbG93cyBhIEZsb2F0aW5nT2JqZWN0IHRvIHBv aW50IHRvIGEgbGluZSBmb3IgYSByZW5kZXJlcgorICAgICAgICB0aGF0IGl0IGRvZXNuJ3QgYmVs b25nIHRvLgorCisgICAgICAgICogcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGbG9hdGluZ09iamVjdDo6dW5zYWZlQ2xvbmUpOgorICAgICAgICAqIHJl bmRlcmluZy9GbG9hdGluZ09iamVjdHMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0aW5nT2Jq ZWN0OjpwYWdpbmF0aW9uU3RydXQpOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRpbmdPYmplY3Q6 OnNldFBhZ2luYXRpb25TdHJ1dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGlu ZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OnBvc2l0aW9u TmV3RmxvYXRPbkxpbmUpOgorCiAyMDE0LTAyLTA1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHRoZSAhRU5BQkxFKFBBR0VfVklTSUJJTElUWV9B UEkpIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdP YmplY3RzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3Bw CmluZGV4IDc3ZjYyNjliYWVmMWJmNTY2ZWJhZTAxZTYxMTEzZGJiZmI3ODFjNjQuLjFiN2RhYTgy ODY1ZGRlNGU1ZDBmMWRiMmRhNzcxYTMxY2ZjNzNkYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwCkBAIC05Myw3ICs5Myw2IEBAIHN0ZDo6dW5pcXVl X3B0cjxGbG9hdGluZ09iamVjdD4gRmxvYXRpbmdPYmplY3Q6OnVuc2FmZUNsb25lKCkgY29uc3QK IHsKICAgICAvLyBGSVhNRTogVXNlIG1ha2VfdW5pcXVlIGhlcmUsIG9uY2Ugd2UgY2FuIGdldCBp dCB0byBjb21waWxlIG9uIGFsbCBwbGF0Zm9ybXMgd2Ugc3VwcG9ydC4KICAgICBzdGQ6OnVuaXF1 ZV9wdHI8RmxvYXRpbmdPYmplY3Q+IGNsb25lT2JqZWN0KG5ldyBGbG9hdGluZ09iamVjdChyZW5k ZXJlcigpLCB0eXBlKCksIG1fZnJhbWVSZWN0LCBtX3Nob3VsZFBhaW50LCBtX2lzRGVzY2VuZGFu dCkpOwotICAgIGNsb25lT2JqZWN0LT5tX29yaWdpbmF0aW5nTGluZSA9IG1fb3JpZ2luYXRpbmdM aW5lOwogICAgIGNsb25lT2JqZWN0LT5tX3BhZ2luYXRpb25TdHJ1dCA9IG1fcGFnaW5hdGlvblN0 cnV0OwogICAgIGNsb25lT2JqZWN0LT5tX2lzUGxhY2VkID0gbV9pc1BsYWNlZDsKICAgICByZXR1 cm4gY2xvbmVPYmplY3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxv YXRpbmdPYmplY3RzLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3Rz LmgKaW5kZXggODUxOTIzNzc5MmFiMTQ4YjZmN2I3ZjA3OTczZDIzNmE0MGMyZTdlZS4uNzIyMmU5 N2E0MGE3MDAwZTNjOTFhZmI4NDdkNDI1ZjFkZTRhZjVhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9GbG9hdGluZ09iamVjdHMuaApAQCAtNjcsOCArNjcsOCBAQCBwdWJsaWM6CiAgICAg Y29uc3QgTGF5b3V0UmVjdCYgZnJhbWVSZWN0KCkgY29uc3QgeyBBU1NFUlQoaXNQbGFjZWQoKSk7 IHJldHVybiBtX2ZyYW1lUmVjdDsgfQogICAgIHZvaWQgc2V0RnJhbWVSZWN0KGNvbnN0IExheW91 dFJlY3QmIGZyYW1lUmVjdCkgeyBBU1NFUlQoIWlzSW5QbGFjZWRUcmVlKCkpOyBtX2ZyYW1lUmVj dCA9IGZyYW1lUmVjdDsgfQogCi0gICAgaW50IHBhZ2luYXRpb25TdHJ1dCgpIGNvbnN0IHsgcmV0 dXJuIG1fcGFnaW5hdGlvblN0cnV0OyB9Ci0gICAgdm9pZCBzZXRQYWdpbmF0aW9uU3RydXQoaW50 IHN0cnV0KSB7IG1fcGFnaW5hdGlvblN0cnV0ID0gc3RydXQ7IH0KKyAgICBMYXlvdXRVbml0IHBh Z2luYXRpb25TdHJ1dCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnaW5hdGlvblN0cnV0OyB9CisgICAg dm9pZCBzZXRQYWdpbmF0aW9uU3RydXQoTGF5b3V0VW5pdCBzdHJ1dCkgeyBtX3BhZ2luYXRpb25T dHJ1dCA9IHN0cnV0OyB9CiAKICNpZm5kZWYgTkRFQlVHCiAgICAgYm9vbCBpc0luUGxhY2VkVHJl ZSgpIGNvbnN0IHsgcmV0dXJuIG1faXNJblBsYWNlZFRyZWU7IH0KQEAgLTg4LDcgKzg4LDcgQEAg cHJpdmF0ZToKICAgICBSZW5kZXJCb3gmIG1fcmVuZGVyZXI7CiAgICAgUm9vdElubGluZUJveCog bV9vcmlnaW5hdGluZ0xpbmU7CiAgICAgTGF5b3V0UmVjdCBtX2ZyYW1lUmVjdDsKLSAgICBpbnQg bV9wYWdpbmF0aW9uU3RydXQ7IC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBhIExheW91dFVuaXQs IHNpbmNlIGl0J3MgYSB2ZXJ0aWNhbCBvZmZzZXQuCisgICAgTGF5b3V0VW5pdCBtX3BhZ2luYXRp b25TdHJ1dDsKIAogICAgIHVuc2lnbmVkIG1fdHlwZSA6IDI7IC8vIFR5cGUgKGxlZnQgb3Igcmln aHQgYWxpZ25lZCkKICAgICB1bnNpZ25lZCBtX3Nob3VsZFBhaW50IDogMTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKaW5kZXggNDNj ZjFjZDAzZWUwNDkyMDhjMzk5Zjk5NmIyMTFjNGJjYjA5ZDUyYS4uMzUzN2M2YjBmYTBlNzY1MmNj NjU4MGQ5OWQ5N2U4MjVmZGE0NjVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTIxMTYsNyArMjExNiw3IEBAIGJvb2wg UmVuZGVyQmxvY2tGbG93Ojpwb3NpdGlvbk5ld0Zsb2F0T25MaW5lKEZsb2F0aW5nT2JqZWN0KiBu ZXdGbG9hdCwgRmxvYXRpbmdPCiAgICAgQVNTRVJUKGZsb2F0aW5nT2JqZWN0U2V0Lmxhc3QoKS5n ZXQoKSA9PSBuZXdGbG9hdCk7CiAKICAgICBMYXlvdXRVbml0IGZsb2F0TG9naWNhbFRvcCA9IGxv Z2ljYWxUb3BGb3JGbG9hdChuZXdGbG9hdCk7Ci0gICAgaW50IHBhZ2luYXRpb25TdHJ1dCA9IG5l d0Zsb2F0LT5wYWdpbmF0aW9uU3RydXQoKTsKKyAgICBMYXlvdXRVbml0IHBhZ2luYXRpb25TdHJ1 dCA9IG5ld0Zsb2F0LT5wYWdpbmF0aW9uU3RydXQoKTsKIAogICAgIGlmIChmbG9hdExvZ2ljYWxU b3AgLSBwYWdpbmF0aW9uU3RydXQgIT0gbG9naWNhbEhlaWdodCgpICsgbGluZUluZm8uZmxvYXRQ YWdpbmF0aW9uU3RydXQoKSkKICAgICAgICAgcmV0dXJuIHRydWU7Cg== 223465 2014-02-07 10:20:13 -0800 2014-02-07 10:33:04 -0800 Patch for landing bug-119808-20140207101630.patch text/plain 3001 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThmYjI4Y2U2OTllODcy ZGU1OWNkNzY4ZTU2ZDIxZmIyMDA1MmY3Zi4uZjY0MDYyZDAwZDcwYzAzNmY0MjBiOWJhMGU5ZjFi MmE5MmM2MzQ5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAyLTA1ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIEZsb2F0aW5nT2JqZWN0 IG1fcGFnaW5hdGlvblN0cnV0IHNob3VsZCBiZSBMYXlvdXRVbml0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk4MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAgICAgIE1ha2UgdGhlIHBhZ2luYXRpb25TdHJ1dCBp biBGbG9hdGluZ09iamVjdCBoYXZlIHRoZSBzYW1lIHR5cGUgYXMgYWxsCisgICAgICAgIG9mIHRo ZSBvdGhlciBwYWdpbmF0aW9uU3RydXRzIGluIHRoZSBjb2RlLgorCisgICAgICAgICogcmVuZGVy aW5nL0Zsb2F0aW5nT2JqZWN0cy5oOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRpbmdPYmplY3Q6 OnBhZ2luYXRpb25TdHJ1dCk6CisgICAgICAgIChXZWJDb3JlOjpGbG9hdGluZ09iamVjdDo6c2V0 UGFnaW5hdGlvblN0cnV0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6cG9zaXRpb25OZXdG bG9hdE9uTGluZSk6CisKIDIwMTQtMDItMDcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIENUVEU6IERvY3VtZW50VGhyZWFkYWJsZUxvYWRlciBhbHdheXMgaGFz IGEgRG9jdW1lbnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRp bmdPYmplY3RzLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3RzLmgK aW5kZXggODUxOTIzNzc5MmFiMTQ4YjZmN2I3ZjA3OTczZDIzNmE0MGMyZTdlZS4uNzIyMmU5N2E0 MGE3MDAwZTNjOTFhZmI4NDdkNDI1ZjFkZTRhZjVhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9GbG9hdGluZ09iamVjdHMuaApAQCAtNjcsOCArNjcsOCBAQCBwdWJsaWM6CiAgICAgY29u c3QgTGF5b3V0UmVjdCYgZnJhbWVSZWN0KCkgY29uc3QgeyBBU1NFUlQoaXNQbGFjZWQoKSk7IHJl dHVybiBtX2ZyYW1lUmVjdDsgfQogICAgIHZvaWQgc2V0RnJhbWVSZWN0KGNvbnN0IExheW91dFJl Y3QmIGZyYW1lUmVjdCkgeyBBU1NFUlQoIWlzSW5QbGFjZWRUcmVlKCkpOyBtX2ZyYW1lUmVjdCA9 IGZyYW1lUmVjdDsgfQogCi0gICAgaW50IHBhZ2luYXRpb25TdHJ1dCgpIGNvbnN0IHsgcmV0dXJu IG1fcGFnaW5hdGlvblN0cnV0OyB9Ci0gICAgdm9pZCBzZXRQYWdpbmF0aW9uU3RydXQoaW50IHN0 cnV0KSB7IG1fcGFnaW5hdGlvblN0cnV0ID0gc3RydXQ7IH0KKyAgICBMYXlvdXRVbml0IHBhZ2lu YXRpb25TdHJ1dCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnaW5hdGlvblN0cnV0OyB9CisgICAgdm9p ZCBzZXRQYWdpbmF0aW9uU3RydXQoTGF5b3V0VW5pdCBzdHJ1dCkgeyBtX3BhZ2luYXRpb25TdHJ1 dCA9IHN0cnV0OyB9CiAKICNpZm5kZWYgTkRFQlVHCiAgICAgYm9vbCBpc0luUGxhY2VkVHJlZSgp IGNvbnN0IHsgcmV0dXJuIG1faXNJblBsYWNlZFRyZWU7IH0KQEAgLTg4LDcgKzg4LDcgQEAgcHJp dmF0ZToKICAgICBSZW5kZXJCb3gmIG1fcmVuZGVyZXI7CiAgICAgUm9vdElubGluZUJveCogbV9v cmlnaW5hdGluZ0xpbmU7CiAgICAgTGF5b3V0UmVjdCBtX2ZyYW1lUmVjdDsKLSAgICBpbnQgbV9w YWdpbmF0aW9uU3RydXQ7IC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBhIExheW91dFVuaXQsIHNp bmNlIGl0J3MgYSB2ZXJ0aWNhbCBvZmZzZXQuCisgICAgTGF5b3V0VW5pdCBtX3BhZ2luYXRpb25T dHJ1dDsKIAogICAgIHVuc2lnbmVkIG1fdHlwZSA6IDI7IC8vIFR5cGUgKGxlZnQgb3IgcmlnaHQg YWxpZ25lZCkKICAgICB1bnNpZ25lZCBtX3Nob3VsZFBhaW50IDogMTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKaW5kZXggNDNjZjFj ZDAzZWUwNDkyMDhjMzk5Zjk5NmIyMTFjNGJjYjA5ZDUyYS4uMzUzN2M2YjBmYTBlNzY1MmNjNjU4 MGQ5OWQ5N2U4MjVmZGE0NjVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTIxMTYsNyArMjExNiw3IEBAIGJvb2wgUmVu ZGVyQmxvY2tGbG93Ojpwb3NpdGlvbk5ld0Zsb2F0T25MaW5lKEZsb2F0aW5nT2JqZWN0KiBuZXdG bG9hdCwgRmxvYXRpbmdPCiAgICAgQVNTRVJUKGZsb2F0aW5nT2JqZWN0U2V0Lmxhc3QoKS5nZXQo KSA9PSBuZXdGbG9hdCk7CiAKICAgICBMYXlvdXRVbml0IGZsb2F0TG9naWNhbFRvcCA9IGxvZ2lj YWxUb3BGb3JGbG9hdChuZXdGbG9hdCk7Ci0gICAgaW50IHBhZ2luYXRpb25TdHJ1dCA9IG5ld0Zs b2F0LT5wYWdpbmF0aW9uU3RydXQoKTsKKyAgICBMYXlvdXRVbml0IHBhZ2luYXRpb25TdHJ1dCA9 IG5ld0Zsb2F0LT5wYWdpbmF0aW9uU3RydXQoKTsKIAogICAgIGlmIChmbG9hdExvZ2ljYWxUb3Ag LSBwYWdpbmF0aW9uU3RydXQgIT0gbG9naWNhbEhlaWdodCgpICsgbGluZUluZm8uZmxvYXRQYWdp bmF0aW9uU3RydXQoKSkKICAgICAgICAgcmV0dXJuIHRydWU7Cg==