119798 2013-08-14 07:42:48 -0700 ANGLE doesn't build with bison 3.0 2013-08-15 10:58:36 -0700 1 1 1 Unclassified WebKit ANGLE 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abrhm achristensen commit-queue dino hugo.lima kondapallykalyan rakuco vestbo zan zherczeg oldest_to_newest 917113 0 allan.jensen 2013-08-14 07:42:48 -0700 When using bison 3.0 we have problems building ANGLE. I believe the easiest solution is to stop generating our own files and use those pregenerated in WebKit. 917114 1 allan.jensen 2013-08-14 07:44:33 -0700 Qt bug tracked as https://bugreports.qt-project.org/browse/QTBUG-32913 917115 2 208725 allan.jensen 2013-08-14 08:04:07 -0700 Created attachment 208725 Patch 917130 3 208731 allan.jensen 2013-08-14 08:43:29 -0700 Created attachment 208731 Patch Just fix the parser file to be compatible with bison 3 917470 4 rakuco 2013-08-15 04:27:43 -0700 For the record, carewolf has also submitted this upstream: <https://code.google.com/p/angleproject/issues/detail?id=462>. 917555 5 achristensen 2013-08-15 10:20:21 -0700 Looks good to me. I tried this on Mac, and it works with Bison 2.3. This is suggested as a patch upstream at https://code.google.com/p/angleproject/issues/detail?id=462 so hopefully we'll merge this change in with a future ANGLE update anyway. 917563 6 achristensen 2013-08-15 10:37:12 -0700 By the way, this would change the generated files a little, but there are no functional changes and we're trying to remove them from the repository anyways, so don't worry about that. 917573 7 208731 commit-queue 2013-08-15 10:58:34 -0700 Comment on attachment 208731 Patch Clearing flags on attachment: 208731 Committed r154109: <http://trac.webkit.org/changeset/154109> 917574 8 commit-queue 2013-08-15 10:58:36 -0700 All reviewed patches have been landed. Closing bug. 208725 2013-08-14 08:04:07 -0700 2013-08-14 08:43:25 -0700 Patch bug-119798-20130814170406.patch text/plain 2502 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMzdlZjdmNzk0YWExNWZkY2M5OTliMmM0ZTMzZmE4M2Q4OTFjZTBhOC4uMWUxMzc2MjVhNjc1 NDZkZGJmMDllY2MxM2I0NWY2YjJjMjc1YzMyZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTE0ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh bGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtRdF0gQU5HTEUgZG9lc24ndCBidWls ZCB3aXRoIGJpc29uIDMuMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE5Nzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG8gbm90IGdlbmVyYXRlIG91ciBvd24gZ2xzbGFuZyBwYXJzZXIgYW5kIGxleGVy LgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJpOgorICAgICAgICAqIFRhcmdldC5wcmk6 CisKIDIwMTMtMDgtMDkgIFpvbHRhbiBBcnZhaSAgPHphcnZhaUBpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgW1F0XSBCdWlkZml4IGFmdGVyIHIxNTM2NjQuIEFkZGluZyBBTkdMRV9XRUJLSVRf V0lOIGRlZmluaXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9EZXJp dmVkU291cmNlcy5wcmkgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9EZXJpdmVkU291cmNlcy5w cmkKaW5kZXggOGY5NTBlODJjMWMxODZhMzQ3ZTVhZGIxMGJlNzE2YTM5OGFmY2RiOS4uNmI3YmU5 ZDM5ZTRlOTAzMjYxYmUzNTgxMGIxZDBiMzlhNTQzNjM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvRGVyaXZlZFNvdXJjZXMucHJpCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL0Rlcml2ZWRTb3VyY2VzLnByaQpAQCAtMTIsNyArMTIsNiBAQCBzYW5pdGl6ZWRGaWxl ID0gJCR0b1Nhbml0aXplZFBhdGgoJCRfRklMRV8pCiBlcXVhbHMoc2FuaXRpemVkRmlsZSwgJCR0 b1Nhbml0aXplZFBhdGgoJCRfUFJPX0ZJTEVfKSk6VEVNUExBVEUgPSBkZXJpdmVkCiAKIEFOR0xF X0ZMRVhfU09VUkNFUyA9IFwKLSAgICAkJFBXRC9zcmMvY29tcGlsZXIvZ2xzbGFuZy5sIFwKICAg ICAkJFBXRC9zcmMvY29tcGlsZXIvcHJlcHJvY2Vzc29yL1Rva2VuaXplci5sCiAKIGFuZ2xlZmxl eC5vdXRwdXQgPSAke1FNQUtFX0ZJTEVfQkFTRX1fbGV4LmNwcApAQCAtMjEsNyArMjAsNiBAQCBh bmdsZWZsZXguY29tbWFuZHMgPSAkJEZMRVggLS1ub2xpbmUgLS1ub3VuaXN0ZCAtLW91dGZpbGU9 JHtRTUFLRV9GSUxFX09VVH0gJHtRTQogR0VORVJBVE9SUyArPSBhbmdsZWZsZXgKIAogQU5HTEVf QklTT05fU09VUkNFUyA9IFwKLSAgICAkJFBXRC9zcmMvY29tcGlsZXIvZ2xzbGFuZy55IFwKICAg ICAkJFBXRC9zcmMvY29tcGlsZXIvcHJlcHJvY2Vzc29yL0V4cHJlc3Npb25QYXJzZXIueQogCiBh bmdsZWJpc29uX2RlY2wub3V0cHV0ID0gJHtRTUFLRV9GSUxFX0JBU0V9X3RhYi5oCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9UYXJnZXQucHJpIGIvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvVGFyZ2V0LnByaQppbmRleCA4YmMxNzIzY2IxN2NlZGI1NzAzMWNmYjQzOTZkOTMw YzVkMmVhOTI5Li4zMWFjM2VkNWU4OTFhZTBlYzhkNDRkNWYzZTg3ODQxYjAwZDMyY2M5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9UYXJnZXQucHJpCisrKyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL1RhcmdldC5wcmkKQEAgLTMyLDYgKzMyLDcgQEAgSEVBREVSUyArPSBc CiAgICAgc3JjL2NvbXBpbGVyL0V4dGVuc2lvbkJlaGF2aW9yLmggXAogICAgIHNyYy9jb21waWxl ci9Gb3JMb29wVW5yb2xsLmggXAogICAgIHNyYy9jb21waWxlci9nbHNsYW5nLmggXAorICAgIHNy Yy9jb21waWxlci9nbHNsYW5nX3RhYi5oIFwKICAgICBzcmMvY29tcGlsZXIvSGFzaE5hbWVzLmgg XAogICAgIHNyYy9jb21waWxlci9JbmZvU2luay5oIFwKICAgICBzcmMvY29tcGlsZXIvSW5pdGlh bGl6ZURsbC5oIFwKQEAgLTk4LDYgKzk5LDggQEAgU09VUkNFUyArPSBcCiAgICAgc3JjL2NvbXBp bGVyL0RpYWdub3N0aWNzLmNwcCBcCiAgICAgc3JjL2NvbXBpbGVyL0RpcmVjdGl2ZUhhbmRsZXIu Y3BwIFwKICAgICBzcmMvY29tcGlsZXIvRm9yTG9vcFVucm9sbC5jcHAgXAorICAgIHNyYy9jb21w aWxlci9nbHNsYW5nX2xleC5jcHAgXAorICAgIHNyYy9jb21waWxlci9nbHNsYW5nX3RhYi5jcHAg XAogICAgIHNyYy9jb21waWxlci9JbmZvU2luay5jcHAgXAogICAgIHNyYy9jb21waWxlci9Jbml0 aWFsaXplLmNwcCBcCiAgICAgc3JjL2NvbXBpbGVyL0luaXRpYWxpemVEbGwuY3BwIFwK 208731 2013-08-14 08:43:29 -0700 2013-08-15 10:58:33 -0700 Patch bug-119798-20130814174328.patch text/plain 1893 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMzdlZjdmNzk0YWExNWZkY2M5OTliMmM0ZTMzZmE4M2Q4OTFjZTBhOC4uNGUyMjMyNzA2MDI0 ZjA5YjljOGJkZTc2ZDk3MGEyYzg4NTc3MjE5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTE0ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh bGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIEFOR0xFIGRvZXNuJ3QgYnVpbGQgd2l0 aCBiaXNvbiAzLjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExOTc5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2UgZ2xzbGFuZy55IGNvbXBhdGlibGUgd2l0aCBiaXNvbiAzLjAsIGJ5IHVzaW5nICVs ZXgtcGFyYW0KKyAgICAgICAgdG8gc2V0IFlZTEVYX1BBUkFNIGFuZCBnZXR0aW5nIHJpZCBvZiB1 c2VsZXNzIFlZSUQgbWFjcm8uCisKKyAgICAgICAgKiBzcmMvY29tcGlsZXIvZ2xzbGFuZy55Ogor CiAyMDEzLTA4LTA5ICBab2x0YW4gQXJ2YWkgIDx6YXJ2YWlAaW5mLnUtc3plZ2VkLmh1PgogCiAg ICAgICAgIFtRdF0gQnVpZGZpeCBhZnRlciByMTUzNjY0LiBBZGRpbmcgQU5HTEVfV0VCS0lUX1dJ TiBkZWZpbml0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2Nv bXBpbGVyL2dsc2xhbmcueSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9n bHNsYW5nLnkKaW5kZXggMWYxNWQwN2Q2MWRkOTUwNTEyYzc1OWQ5NzUwYTk3MDBjMTIyNGQzNS4u NGY4OTRiMzgyYWNmMWQ3YmIxNjFiN2JhYTg1NTI3YjNhOGU1YzVjMSAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL2dsc2xhbmcueQorKysgYi9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZ2xzbGFuZy55CkBAIC00Nyw2ICs0Nyw3IEBA IFdISUNIIEdFTkVSQVRFUyBUSEUgR0xTTCBFUyBQQVJTRVIgKGdsc2xhbmdfdGFiLmNwcCBBTkQg Z2xzbGFuZ190YWIuaCkuCiAlcHVyZS1wYXJzZXIKICVwYXJzZS1wYXJhbSB7VFBhcnNlQ29udGV4 dCogY29udGV4dH0KICVsb2NhdGlvbnMKKyVsZXgtcGFyYW0ge1lZTEVYX1BBUkFNfQogCiAldW5p b24gewogI2RlZmluZSBZWUxUWVBFIFRTb3VyY2VMb2MKQEAgLTg2LDcgKzg3LDcgQEAgc3RhdGlj IHZvaWQgeXllcnJvcihZWUxUWVBFKiB5eWxsb2MsIFRQYXJzZUNvbnRleHQqIGNvbnRleHQsIGNv bnN0IGNoYXIqIHJlYXNvbikKIAogI2RlZmluZSBZWUxMT0NfREVGQVVMVChDdXJyZW50LCBSaHMs IE4pICAgICAgICAgICAgICAgICAgICAgIFwKICAgZG8geyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICBpZiAoWVlJRChOKSkgeyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgaWYgKE4pIHsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICAg KEN1cnJlbnQpLmZpcnN0X2ZpbGUgPSBZWVJIU0xPQyhSaHMsIDEpLmZpcnN0X2ZpbGU7ICBcCiAg ICAgICAgIChDdXJyZW50KS5maXJzdF9saW5lID0gWVlSSFNMT0MoUmhzLCAxKS5maXJzdF9saW5l OyAgXAogICAgICAgICAoQ3VycmVudCkubGFzdF9maWxlID0gWVlSSFNMT0MoUmhzLCBOKS5sYXN0 X2ZpbGU7ICAgIFwK